Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-05-02 Thread Fiona Ebner
Am 02.05.23 um 12:35 schrieb Juan Quintela: > Fiona Ebner wrote: >> Am 02.05.23 um 12:03 schrieb Fiona Ebner: >>> Am 28.04.23 um 18:54 schrieb Juan Quintela: Kevin Wolf wrote: > Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: >> Kevin Wolf wrote: I am perhaps a bit in

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-05-02 Thread Juan Quintela
Fiona Ebner wrote: > Am 02.05.23 um 12:03 schrieb Fiona Ebner: >> Am 28.04.23 um 18:54 schrieb Juan Quintela: >>> Kevin Wolf wrote: Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: > Kevin Wolf wrote: >>> I am perhaps a bit ingenuous here, but it is there a way to convince

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-05-02 Thread Juan Quintela
Fiona Ebner wrote: > Am 28.04.23 um 18:54 schrieb Juan Quintela: >> Kevin Wolf wrote: >>> Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: Kevin Wolf wrote: >> I am perhaps a bit ingenuous here, but it is there a way to convince >> qemu that snapshot_save_job_bh *HAS* to run on

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-05-02 Thread Fiona Ebner
Am 02.05.23 um 12:03 schrieb Fiona Ebner: > Am 28.04.23 um 18:54 schrieb Juan Quintela: >> Kevin Wolf wrote: >>> Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: Kevin Wolf wrote: >> I am perhaps a bit ingenuous here, but it is there a way to convince >> qemu that snapshot_save_

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-05-02 Thread Fiona Ebner
Am 28.04.23 um 18:54 schrieb Juan Quintela: > Kevin Wolf wrote: >> Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: >>> Kevin Wolf wrote: > I am perhaps a bit ingenuous here, but it is there a way to convince > qemu that snapshot_save_job_bh *HAS* to run on the main thread?

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Juan Quintela
Kevin Wolf wrote: > Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: >> Kevin Wolf wrote: >> >> I am perhaps a bit ingenuous here, but it is there a way to convince >> >> qemu that snapshot_save_job_bh *HAS* to run on the main thread? >> > >> > I believe we're talking about a technicality he

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Kevin Wolf
Am 28.04.2023 um 10:38 hat Juan Quintela geschrieben: > Kevin Wolf wrote: > >> I am perhaps a bit ingenuous here, but it is there a way to convince > >> qemu that snapshot_save_job_bh *HAS* to run on the main thread? > > > > I believe we're talking about a technicality here. I asked another more >

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Juan Quintela
Kevin Wolf wrote: >> >> I am perhaps a bit ingenuous here, but it is there a way to convince >> qemu that snapshot_save_job_bh *HAS* to run on the main thread? > > I believe we're talking about a technicality here. I asked another more > fundamental question that nobody has answered yet: > > Why

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Kevin Wolf
Am 28.04.2023 um 09:47 hat Juan Quintela geschrieben: > Fiona Ebner wrote: > > Am 27.04.23 um 16:36 schrieb Juan Quintela: > >> Fiona Ebner wrote: > >>> Am 27.04.23 um 13:03 schrieb Kevin Wolf: > Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: > > Am 20.04.23 um 08:55 schrieb Paolo B

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Fiona Ebner
Am 27.04.23 um 16:56 schrieb Peter Xu: > On Thu, Apr 27, 2023 at 04:36:14PM +0200, Juan Quintela wrote: >> Fiona Ebner wrote: >>> Am 27.04.23 um 13:03 schrieb Kevin Wolf: Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: > Am 20.04.23 um 08:55 schrieb Paolo Bonzini: >> >> Hi >> >>> Our

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Juan Quintela
Fiona Ebner wrote: > Am 27.04.23 um 16:36 schrieb Juan Quintela: >> Fiona Ebner wrote: >>> Am 27.04.23 um 13:03 schrieb Kevin Wolf: Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: > Am 20.04.23 um 08:55 schrieb Paolo Bonzini: >> >> Hi >> >>> Our function is a custom variant of savi

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-28 Thread Fiona Ebner
Am 27.04.23 um 16:36 schrieb Juan Quintela: > Fiona Ebner wrote: >> Am 27.04.23 um 13:03 schrieb Kevin Wolf: >>> Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: Am 20.04.23 um 08:55 schrieb Paolo Bonzini: > > Hi > >> Our function is a custom variant of saving a snapshot and uses >> qemu

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-27 Thread Peter Xu
On Thu, Apr 27, 2023 at 04:36:14PM +0200, Juan Quintela wrote: > Fiona Ebner wrote: > > Am 27.04.23 um 13:03 schrieb Kevin Wolf: > >> Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: > >>> Am 20.04.23 um 08:55 schrieb Paolo Bonzini: > > Hi > > > Our function is a custom variant of saving a sn

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-27 Thread Juan Quintela
Fiona Ebner wrote: > Am 27.04.23 um 13:03 schrieb Kevin Wolf: >> Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: >>> Am 20.04.23 um 08:55 schrieb Paolo Bonzini: Hi > Our function is a custom variant of saving a snapshot and uses > qemu_savevm_state_setup(), which is why the qemu_mutex_unlock

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-27 Thread Fiona Ebner
Am 27.04.23 um 13:03 schrieb Kevin Wolf: > Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: >> Am 20.04.23 um 08:55 schrieb Paolo Bonzini: >>> >>> >>> Il gio 20 apr 2023, 08:11 Markus Armbruster >> > ha scritto: >>> >>> So, splicing in a bottom half unmoored monitor

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-27 Thread Kevin Wolf
Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben: > Am 20.04.23 um 08:55 schrieb Paolo Bonzini: > > > > > > Il gio 20 apr 2023, 08:11 Markus Armbruster > > ha scritto: > > > > So, splicing in a bottom half unmoored monitor commands from the main > > loop.  We

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-26 Thread Fiona Ebner
Am 20.04.23 um 08:55 schrieb Paolo Bonzini: > > > Il gio 20 apr 2023, 08:11 Markus Armbruster > ha scritto: > > So, splicing in a bottom half unmoored monitor commands from the main > loop.  We weren't aware of that, as our commit messages show. > > I gues

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-19 Thread Paolo Bonzini
Il gio 20 apr 2023, 08:11 Markus Armbruster ha scritto: > So, splicing in a bottom half unmoored monitor commands from the main > loop. We weren't aware of that, as our commit messages show. > > I guess the commands themselves don't care; all they need is the BQL. > > However, did we unwittingly

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-19 Thread Markus Armbruster
Fiona Ebner writes: > Hi, > while debugging a completely different issue, I was surprised to see > do_qmp_dispatch_bh being run in a vCPU thread. I was under the > impression that QMP functions are supposed to be executed in the main > thread. Is that wrong? > > I managed to reproduced the scenar

Re: QMP (without OOB) function running in thread different from the main thread as part of aio_poll

2023-04-19 Thread Paolo Bonzini
Il mer 19 apr 2023, 16:11 Fiona Ebner ha scritto: Hi, while debugging a completely different issue, I was surprised to see do_qmp_dispatch_bh being run in a vCPU thread. I was under the impression that QMP functions are supposed to be executed in the main thread. Is that wrong While monitor co