[Qemu-block] RFC iscsi: set FUA and DPO if !bs-enable_write_cache

2015-04-14 Thread Peter Lieven
Hi, Ronnie came up with an idea to reduce latency if !bs-enable_write_cache for an iSCSI device. If !bs-enable_write_cache Qemu sends a flush after every single write. What could be done is the following: if (!bs-enable_write_cache) set FUA (force unit access) and DPO (disable page out)

[Qemu-block] [PATCH] block/iscsi: do not forget to logout from target

2015-04-14 Thread Peter Lieven
We actually were always impolitely dropping the connection and not cleanly logging out. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ab20e4d..0b6d3dd 100644 ---

Re: [Qemu-block] RFC iscsi: set FUA and DPO if !bs-enable_write_cache

2015-04-14 Thread Stefan Hajnoczi
On Tue, Apr 14, 2015 at 7:49 AM, Peter Lieven p...@kamp.de wrote: Ronnie came up with an idea to reduce latency if !bs-enable_write_cache for an iSCSI device. If !bs-enable_write_cache Qemu sends a flush after every single write. What could be done is the following: if

Re: [Qemu-block] RFC iscsi: set FUA and DPO if !bs-enable_write_cache

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 08:49, Peter Lieven wrote: Hi, Ronnie came up with an idea to reduce latency if !bs-enable_write_cache for an iSCSI device. If !bs-enable_write_cache Qemu sends a flush after every single write. What could be done is the following: if (!bs-enable_write_cache) set FUA

Re: [Qemu-block] RFC iscsi: set FUA and DPO if !bs-enable_write_cache

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 11:04, Stefan Hajnoczi wrote: Do other commands besides writes rely on iscsi_co_flush()? Paolo: I checked NBD and noticed there is an inconsistency there. nbd_co_writev_1() uses FUA when bs-enable_write_cache == true but it also sends flushes. Does that mean it's doing

Re: [Qemu-block] RFC iscsi: set FUA and DPO if !bs-enable_write_cache

2015-04-14 Thread Peter Lieven
Am 14.04.2015 um 11:04 schrieb Stefan Hajnoczi: On Tue, Apr 14, 2015 at 7:49 AM, Peter Lieven p...@kamp.de wrote: Ronnie came up with an idea to reduce latency if !bs-enable_write_cache for an iSCSI device. If !bs-enable_write_cache Qemu sends a flush after every single write. What could be