Re: [Qemu-block] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

On 11/25/2015 12:39 AM, Fam Zheng wrote: > The "flags" bit mask is expanded to two booleans, "data" and "zero"; > "bs" is replaced with "filename" string. > > Signed-off-by: Fam Zheng > --- > qapi/block-core.json | 28 > qemu-img.c | 48

Re: [Qemu-block] [PATCH v7 13/24] virtio-scsi: Catch BDS-BB removal/insertion

Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > Make use of the BDS-BB removal and insertion notifiers to remove or set > up, respectively, virtio-scsi's op blockers. > > Signed-off-by: Max Reitz > @@ -797,6 +830,29 @@ static void virtio_scsi_hotunplug(HotplugHandler >

Re: [Qemu-block] [PATCH v7 12/24] virtio-blk: Functions for op blocker management

On 25.11.2015 16:57, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Put the code for setting up and removing op blockers into an own >> function, respectively. Then, we can invoke those functions whenever a >> BDS is removed from an virtio-blk BB or inserted into it. >>

Re: [Qemu-block] [Qemu-devel] [PULL 0/6] Block patches for 2.5.0-rc2

On 25 November 2015 at 14:10, Kevin Wolf wrote: > The following changes since commit 1aae36df4b8ed884c6ef6995e70c67fad79b49df: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2015-11-25' > into staging (2015-11-25 11:38:03 +) > > are available in the

Re: [Qemu-block] [PATCH v7 12/24] virtio-blk: Functions for op blocker management

Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > Put the code for setting up and removing op blockers into an own > function, respectively. Then, we can invoke those functions whenever a > BDS is removed from an virtio-blk BB or inserted into it. > > Signed-off-by: Max Reitz

Re: [Qemu-block] [PATCH v7 12/24] virtio-blk: Functions for op blocker management

Am 25.11.2015 um 17:03 hat Max Reitz geschrieben: > On 25.11.2015 16:57, Kevin Wolf wrote: > > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > >> Put the code for setting up and removing op blockers into an own > >> function, respectively. Then, we can invoke those functions whenever a > >>

Re: [Qemu-block] [PATCH v2 14/14] iotests: Add "qemu-img map" test for VMDK extents

On 11/25/2015 12:39 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/059 | 10 ++ > tests/qemu-iotests/059.out | 38 ++ > 2 files changed, 48 insertions(+) Reviewed-by: Eric Blake --

Re: [Qemu-block] [PATCH v2 13/14] qemu-img: Use QAPI visitor to generate JSON

On 11/25/2015 12:39 AM, Fam Zheng wrote: > A visible improvement is that "filename" is now included in the output > if it's valid. > > Signed-off-by: Fam Zheng > --- > qemu-img.c | 39 --- > tests/qemu-iotests/122.out | 96 >

Re: [Qemu-block] [PATCH 0/2] import nvme fix

On Wed, Nov 25, 2015 at 10:28:42AM +0100, Kevin Wolf wrote: > Am 18.11.2015 um 19:53 hat Christoph Hellwig geschrieben: > > First one fixes Identify to behave as mandated by the spec, and the > > second bumps the PCI revision so that guest drivers can detect > > the fixed version of the device so

Re: [Qemu-block] [PATCH v7 for-2.6 00/24] block: Rework bdrv_close_all()

Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, > which can lead to data corruption (see the iotest added in the final > patch of this series) and is most certainly very ugly. > > This series reworks bdrv_close_all() to

Re: [Qemu-block] [PATCH v2 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status

On 11/25/2015 12:39 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/qed.c | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

Re: [Qemu-block] [PATCH v7 13/24] virtio-scsi: Catch BDS-BB removal/insertion

On 25.11.2015 17:03, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Make use of the BDS-BB removal and insertion notifiers to remove or set >> up, respectively, virtio-scsi's op blockers. >> >> Signed-off-by: Max Reitz > >> @@ -797,6 +830,29 @@ static

Re: [Qemu-block] [PATCH v2 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status

On 11/25/2015 12:39 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/parallels.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake > > diff --git a/block/parallels.c b/block/parallels.c > index d1146f1..6552f32 100644 > ---

[Qemu-block] [PATCH v8] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

Re: [Qemu-block] [Qemu-devel] [PATCH v8] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On 11/25/2015 05:24 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message is displayed showing the user how to unmount a > volume. > >

[Qemu-block] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

Re: [Qemu-block] [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On 11/25/2015 09:10 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message is displayed showing the user how to unmount a > volume. > >

[Qemu-block] QEMU being able to use audio cdroms

Is there any platform where a guest in QEMU can play an audio cd? If not, is this a feature that you would allow into QEMU?

Re: [Qemu-block] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

On Wed, 11/25 08:36, Eric Blake wrote: > On 11/25/2015 12:39 AM, Fam Zheng wrote: > > The "flags" bit mask is expanded to two booleans, "data" and "zero"; > > "bs" is replaced with "filename" string. > > > > Signed-off-by: Fam Zheng > > --- > > qapi/block-core.json | 28

[Qemu-block] [PATCH v3 08/15] sheepdog: Assign bs to file in sd_co_get_block_status

Signed-off-by: Fam Zheng --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0f6789e..d5e7ff8 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2740,6 +2740,9 @@ sd_co_get_block_status(BlockDriverState *bs,

[Qemu-block] [PATCH v3 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status

Signed-off-by: Fam Zheng --- block/vpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 912f5d0..412ff41 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -588,6 +588,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(BlockDriverState

[Qemu-block] [PATCH v3 03/15] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status

Signed-off-by: Fam Zheng --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 836888c..7634c42 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1302,6 +1302,7 @@ static int64_t coroutine_fn

[Qemu-block] [PATCH v3 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 2d1e230..8c7f1b3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -625,6 +625,9 @@ out: if

Re: [Qemu-block] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct

On 11/25/2015 10:05 PM, Fam Zheng wrote: > The "flags" bit mask is expanded to two booleans, "data" and "zero"; > "bs" is replaced with "filename" string. > > Refactor the merge conditions in img_map() into entry_mergable(). s/mergable/mergeable/ here and in the patch body > > Signed-off-by:

Re: [Qemu-block] [PATCH v2 08/14] sheepdog: Assign bs to file in sd_co_get_block_status

On 11/25/2015 12:39 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/sheepdog.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Eric Blake > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index 0f6789e..d5e7ff8 100644 > ---

Re: [Qemu-block] [PATCH v2 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

On 11/25/2015 12:39 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/vdi.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake > > diff --git a/block/vdi.c b/block/vdi.c > index 2199fd3..6b1a57b 100644 > --- a/block/vdi.c > +++

Re: [Qemu-block] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions

On 11/25/2015 12:39 AM, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is referring to. It's value should be ignored unless s/It's/Its/ (remember, "It's" is valid only if "It is" also works in the same place) > BDRV_BLOCK_OFFSET_VALID in

[Qemu-block] [PATCH v3 11/15] vmdk: Return extent's file in bdrv_get_block_status

Signed-off-by: Fam Zheng --- block/vmdk.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f5a56fd..b60a5af 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1265,6 +1265,7 @@ static int64_t coroutine_fn

[Qemu-block] [PATCH v3 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/qed.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qed.c b/block/qed.c index a6bbd8b..03af9c1 100644 --- a/block/qed.c +++ b/block/qed.c @@ -692,6 +692,7 @@ typedef struct {

[Qemu-block] [PATCH v3 15/15] iotests: Add "qemu-img map" test for VMDK extents

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 10 ++ tests/qemu-iotests/059.out | 38 ++ 2 files changed, 48 insertions(+) diff --git a/tests/qemu-iotests/059

Re: [Qemu-block] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions

On Wed, 11/25 22:03, Eric Blake wrote: > On 11/25/2015 12:39 AM, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is referring to. It's value should be ignored unless > > s/It's/Its/ (remember, "It's" is valid only if "It is" also works in

Re: [Qemu-block] [PATCH v3 0/4] Bitmap clean-up patches for 2.6

On Wed, 11/25 09:57, Vladimir Sementsov-Ogievskiy wrote: > Hmm, stop. Very bad thing (sorry, that I didn't realize it before): > > This breaks my dirty bitmap migration series with its meta bitmaps. > Meta bitmap is an additional HBitmap in BdrvDirtyBitmap, which > tracks dirtiness of this

Re: [Qemu-block] [PATCH v7 12/24] virtio-blk: Functions for op blocker management

On Wed, Nov 25, 2015 at 05:26:02PM +0100, Max Reitz wrote: > On 25.11.2015 17:18, Kevin Wolf wrote: > > Am 25.11.2015 um 17:03 hat Max Reitz geschrieben: > >> On 25.11.2015 16:57, Kevin Wolf wrote: > >>> Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > >>> This makes me wonder: What do we even

Re: [Qemu-block] [PATCH 0/2] import nvme fix

Am 18.11.2015 um 19:53 hat Christoph Hellwig geschrieben: > First one fixes Identify to behave as mandated by the spec, and the > second bumps the PCI revision so that guest drivers can detect > the fixed version of the device so that only the old version has > to be blacklisted. Keith, this

Re: [Qemu-block] [PATCH for-2.5] xen_disk: Remove ioreq.postsync

On Wed, 25 Nov 2015, Alberto Garcia wrote: > This code has been dead for three years (since commit 7e7b7cba1). > > Signed-off-by: Alberto Garcia Reviewed-by: Stefano Stabellini Kevin, I'll send it out together with another fix today. >

Re: [Qemu-block] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

On 25/11/2015 08:39, Fam Zheng wrote: > */ > -if (next && > -(next->flags & (BDRV_BLOCK_DATA|BDRV_BLOCK_ZERO)) != > BDRV_BLOCK_DATA) { > -next->flags &= ~BDRV_BLOCK_DATA; > -next->flags |= BDRV_BLOCK_ZERO; > +if (next && !next->data)

Re: [Qemu-block] [PATCH v2 8/8] block: Remove bdrv_states

Am 10.11.2015 um 04:27 hat Max Reitz geschrieben: > Every entry in this list should be a root BDS and as such either be > anchored to a BlockBackend or be owned by the monitor. > > Signed-off-by: Max Reitz > --- > block.c | 30 +-

[Qemu-block] [PULL 4/6] raw-posix.c: Make GetBSDPath() handle caching options

From: Programmingkid Add support for caching options that can be specified from the command line. The CD-ROM raw char device bypasses the host page cache and therefore has alignment requirements. Alignment probing is necessary so only use the raw char device if

[Qemu-block] [PULL 3/6] nand: fix flash erase when oob is in memory

From: Ricard Wanderlof For the "main area on file, oob in memory" case, fix the shifts so that we erase the correct number of pages. Signed-off-by: Ricard Wanderlöf Signed-off-by: Kevin Wolf --- hw/block/nand.c | 2 +- 1 file

[Qemu-block] [PULL 2/6] test-aio: Fix event notifier cleanup

One test case closed an event notifier (event_notifier_cleanup()) without first disabling it (set_event_notifier(..., NULL)). This resulted in a leftover handle 0 that was added to each subsequent WaitForMultipleObjects() call, causing the function to fail (invalid handle). Signed-off-by: Kevin

[Qemu-block] [PULL 1/6] tests/Makefile: Add more dependencies for test-timed-average

'make check' failed to compile the test case for mingw because of undefined references. Pull in a few more dependencies so that it builds. Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi ---

[Qemu-block] [PULL 0/6] Block patches for 2.5.0-rc2

The following changes since commit 1aae36df4b8ed884c6ef6995e70c67fad79b49df: Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2015-11-25' into staging (2015-11-25 11:38:03 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[Qemu-block] [PULL 5/6] block/qapi: Plug memory leak on query-block error path

From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qapi.c | 8 +++- 1 file

[Qemu-block] [PULL 6/6] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

From: Fam Zheng Otherwise, a window flashes on my desktop (built with SDL). Add this as other cases have it. Signed-off-by: Fam Zheng Message-id: 1448245930-15031-1-git-send-email-f...@redhat.com Signed-off-by: Max Reitz ---

Re: [Qemu-block] [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On 11/25/2015 09:23 PM, Eric Blake wrote: >> +static kern_return_t FindEjectableOpticalMedia(io_iterator_t *mediaIterator, >> +char >> *mediaType) > > Unusual indentation; more typical is: > > | static kern_return_t

Re: [Qemu-block] [PATCH v2 10/14] vpc: Assign bs->file->bs to file in vpc_co_get_block_status

On 11/25/2015 12:39 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/vpc.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake > > diff --git a/block/vpc.c b/block/vpc.c > index 912f5d0..412ff41 100644 > --- a/block/vpc.c > +++

[Qemu-block] [PATCH v3 01/15] block: Add "file" output parameter to block status query functions

The added parameter can be used to return the BDS pointer which the valid offset is referring to. It's value should be ignored unless BDRV_BLOCK_OFFSET_VALID in ret is set. Until block drivers fill in the right value, let's clear it explicitly right before calling .bdrv_get_block_status.

[Qemu-block] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block

v3: Add Eric's rev-by in patches 6, 7, 13, 14. 12: New, split out from the previous 13. 12->13: Refactor "entry_mergable" from imp_map(). Don't mess the merge conditions. [Paolo] Address Eric's comments: - Check has_foo before using foo. - Remove blank line

[Qemu-block] [PATCH v3 02/15] qcow: Assign bs->file->bs to file in qcow_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow.c b/block/qcow.c index 558f443..b59383f 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -509,6 +509,7 @@ static int64_t

[Qemu-block] [PATCH v3 04/15] raw: Assign bs to file in raw_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/raw-posix.c | 1 + block/raw_bsd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 2cd7d68..9988aa4 100644 --- a/block/raw-posix.c +++

[Qemu-block] [PATCH v3 14/15] qemu-img: Use QAPI visitor to generate JSON

A visible improvement is that "filename" is now included in the output if it's valid. Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- qemu-img.c | 34 ++-- tests/qemu-iotests/122.out | 96

Re: [Qemu-block] [PATCH v2 13/14] qemu-img: Use QAPI visitor to generate JSON

On Wed, 11/25 08:42, Eric Blake wrote: > On 11/25/2015 12:39 AM, Fam Zheng wrote: > > A visible improvement is that "filename" is now included in the output > > if it's valid. > > > > Signed-off-by: Fam Zheng > > --- > > qemu-img.c | 39 --- > >

[Qemu-block] [PATCH v3 12/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status

Now all drivers should return a correct "file", we can make use of it, even with the recursion into backing chain above. Signed-off-by: Fam Zheng --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 7954242..a7fa794

[Qemu-block] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct

The "flags" bit mask is expanded to two booleans, "data" and "zero"; "bs" is replaced with "filename" string. Refactor the merge conditions in img_map() into entry_mergable(). Signed-off-by: Fam Zheng --- qapi/block-core.json | 27 qemu-img.c |

[Qemu-block] [PATCH v3 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

Signed-off-by: Fam Zheng --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 2199fd3..6b1a57b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -550,6 +550,7 @@ static int64_t coroutine_fn vdi_co_get_block_status(BlockDriverState *bs,

Re: [Qemu-block] [PATCH v3 12/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status

On 11/25/2015 10:05 PM, Fam Zheng wrote: > Now all drivers should return a correct "file", we can make use of it, > even with the recursion into backing chain above. > > Signed-off-by: Fam Zheng > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)