Re: [Qemu-block] [PATCH 3/3] iotests: Test format probes

On 07/11/2016 03:50 PM, Colin Lord wrote: > Adds a new iotest for testing that the format probing functions work as > expected. This is done by booting up a vm with a disk image without > specifying the image format. Then the format is checked using a call to > query-block. > > For any format

Re: [Qemu-block] [Qemu-devel] [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface

On 06/03/2016 12:32 AM, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should be > hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying > HBitmapIter. > > A small difference in the interface is, before, an HBitmapIter is

Re: [Qemu-block] [RFC PATCH 0/7] BlockBackends, nodes and guest devices

Am 12.07.2016 um 02:13 hat John Snow geschrieben: > No oxford comma in the subject? :) It's already hard enough to keep the German comma rules straight and avoid confusing the pre-reform rules with the post-reform ones. I don't think I should bother with the comma rules of a language where even

[Qemu-block] [PATCH 1/1] mirror: double performance of the bulk stage if the disc is full

From: Vladimir Sementsov-Ogievskiy Mirror can do up to 16 in-flight requests, but actually on full copy (the whole source disk is non-zero) in-flight is always 1. This happens as the request is not limited in size: the data occupies maximum available capacity of s->buf.

Re: [Qemu-block] [PATCH v2 0/7] drive-mirror improvements

On Thu, 07/07 12:35, Denis V. Lunev wrote: > This patchset contains patches dealing with known-to-be-zero areas in drive > mirror from [PATCH 0/9] major rework of drive-mirror patchset. Looks pretty good overall despite the minor comments. Reviewed-by: Fam Zheng > > Changes

[Qemu-block] [PATCH v2] aio-posix: remove useless parameter

Parameter **errp of aio_context_setup() is useless, remove it and clean up the related code. Signed-off-by: Cao jin --- aio-posix.c | 3 ++- async.c | 8 ++-- include/block/aio.h | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-) diff

Re: [Qemu-block] [Qemu-devel] [PATCH] aio-posix: fill error message that is missed

On Tue, 07/12 09:41, Eric Blake wrote: > On 07/12/2016 05:34 AM, Cao jin wrote: > > The current judegement of caller is meaningless, make it useful. > > Is this something you can trigger? If so, what command line? If not, > how did you find it? > > Spelled 'judgment', not 'judegement'; but

Re: [Qemu-block] [Qemu-devel] [PATCH] aio-posix: fill error message that is missed

On 07/12/2016 11:41 PM, Eric Blake wrote: On 07/12/2016 05:34 AM, Cao jin wrote: The current judegement of caller is meaningless, make it useful. Is this something you can trigger? If so, what command line? If not, how did you find it? No, I didn't find it by "trigger" it. I just a very

Re: [Qemu-block] [PATCH v2] aio-posix: remove useless parameter

On Wed, 07/13 10:26, Cao jin wrote: > Parameter **errp of aio_context_setup() is useless, remove it > and clean up the related code. > > Signed-off-by: Cao jin > --- > aio-posix.c | 3 ++- > async.c | 8 ++-- > include/block/aio.h | 2 +- > 3

Re: [Qemu-block] [Qemu-devel] [PATCH] aio-posix: fill error message that is missed

On 07/13/2016 09:33 AM, Fam Zheng wrote: On Tue, 07/12 09:41, Eric Blake wrote: On 07/12/2016 05:34 AM, Cao jin wrote: The current judegement of caller is meaningless, make it useful. Is this something you can trigger? If so, what command line? If not, how did you find it? Spelled

Re: [Qemu-block] [PATCH 1/1] mirror: double performance of the bulk stage if the disc is full

On 12/07/2016 11:36, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited in size:

Re: [Qemu-block] [PATCH v21 00/10] Block replication for continuous checkpoints

Hi all block maintainers, ping... @kevin & jeff, do you have time to review these patchsets? Thanks -Wang WeiWei 在 2016年07月06日 01:45, Changlong Xie 写道: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed

[Qemu-block] [PATCH] aio-posix: fill error message that is missed

The current judegement of caller is meaningless, make it useful. Signed-off-by: Cao jin --- aio-posix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/aio-posix.c b/aio-posix.c index 6006122..8b0deb7 100644 --- a/aio-posix.c +++ b/aio-posix.c @@ -18,6 +18,7 @@

Re: [Qemu-block] [PATCH 1/1] mirror: double performance of the bulk stage if the disc is full

Am 12.07.2016 um 11:36 hat Denis V. Lunev geschrieben: > From: Vladimir Sementsov-Ogievskiy > > Mirror can do up to 16 in-flight requests, but actually on full copy > (the whole source disk is non-zero) in-flight is always 1. This happens > as the request is not limited

Re: [Qemu-block] [Qemu-devel] [PATCH] build: Work around SIZE_MAX bug in OSX headers

On 07/12/2016 09:21 AM, Eric Blake wrote: > C99 requires SIZE_MAX to be declared with the same type as the > integral promotion of size_t, but OSX mistakenly defines it as > an unsigned long long expression even though size_t is only > unsigned long. Rather than futzing around with whether size_t

[Qemu-block] [PATCH] build: Work around SIZE_MAX bug in OSX headers

C99 requires SIZE_MAX to be declared with the same type as the integral promotion of size_t, but OSX mistakenly defines it as an unsigned long long expression even though size_t is only unsigned long. Rather than futzing around with whether size_t is 32- or 64-bits wide, let the compiler get the

Re: [Qemu-block] [PATCH v2 7/7] mirror: improve performance of mirroring of empty disk

On 07/11/2016 11:57 PM, Fam Zheng wrote: > On Mon, 07/11 15:53, John Snow wrote: >> >> >> On 07/07/2016 05:35 AM, Denis V. Lunev wrote: >>> We should not take into account zero blocks for delay calculations. >>> They are not read and thus IO throttling is not required. In the >>> other case VM

Re: [Qemu-block] [Qemu-devel] [PATCH] aio-posix: fill error message that is missed

On 07/12/2016 05:34 AM, Cao jin wrote: > The current judegement of caller is meaningless, make it useful. Is this something you can trigger? If so, what command line? If not, how did you find it? Spelled 'judgment', not 'judegement'; but rather than just fixing the typo, it might read better

[Qemu-block] [PATCH] qcow2: do not allocate extra memory

There are no needs to allocate more than one cluster, as we set avail_out for deflate to one cluster. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! Please, can anybody say me what I'm missing? I've looked through deflate documentation at

Re: [Qemu-block] [RFC PATCH 0/7] BlockBackends, nodes and guest devices

On 07/12/2016 04:14 AM, Kevin Wolf wrote: > Am 12.07.2016 um 02:13 hat John Snow geschrieben: >> No oxford comma in the subject? :) > > It's already hard enough to keep the German comma rules straight and > avoid confusing the pre-reform rules with the post-reform ones. I don't > think I should

Re: [Qemu-block] [PATCH] qcow2: do not allocate extra memory

On 07/12/2016 11:43 AM, Vladimir Sementsov-Ogievskiy wrote: > There are no needs to allocate more than one cluster, as we set > avail_out for deflate to one cluster. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Hi all! > > Please, can anybody say me what

Re: [Qemu-block] [PATCH] qcow2: do not allocate extra memory

On 07/12/2016 01:43 PM, Vladimir Sementsov-Ogievskiy wrote: > There are no needs to allocate more than one cluster, as we set > avail_out for deflate to one cluster. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Hi all! > > Please, can anybody say me

Re: [Qemu-block] [Qemu-devel] [PATCH] build: Work around SIZE_MAX bug in OSX headers

On 07/12/2016 01:35 PM, Peter Maydell wrote: > I tested this patch with a compile on OSX, and it does compile > without warnings or errors. (NB: haven't tested that it > fixes the warning that was being complained about in the > other patchset.) Ultimately, the combination of this patch plus the

Re: [Qemu-block] [PATCH] qcow2: do not allocate extra memory

On 07/12/2016 01:11 PM, Vladimir Sementsov-Ogievskiy wrote: > On 12.07.2016 21:43, Eric Blake wrote: >> On 07/12/2016 11:43 AM, Vladimir Sementsov-Ogievskiy wrote: >>> There are no needs to allocate more than one cluster, as we set >>> avail_out for deflate to one cluster. >>> >>> ... >>>

Re: [Qemu-block] [PATCH 1/3] iotests: Add dmg format option

On 07/11/2016 03:50 PM, Colin Lord wrote: > Adds option to test the dmg format. > > Signed-off-by: Colin Lord > --- > tests/qemu-iotests/common | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common > index

Re: [Qemu-block] [PATCH] qcow2: do not allocate extra memory

On 12.07.2016 21:43, Eric Blake wrote: On 07/12/2016 11:43 AM, Vladimir Sementsov-Ogievskiy wrote: There are no needs to allocate more than one cluster, as we set avail_out for deflate to one cluster. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! Please,

Re: [Qemu-block] [Qemu-devel] [PATCH] build: Work around SIZE_MAX bug in OSX headers

On 12 July 2016 at 19:23, Eric Blake wrote: > This violates POSIX, which requires that: > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stdint.h.html#tag_13_48 > "Each instance of these macros shall be replaced by a constant > expression suitable for use in #if