Re: [Qemu-block] [Qemu-devel] [PATCH v5 1/9] util: Add UUID API

On Fri, 08/12 07:24, Richard Henderson wrote: > On 08/12/2016 05:52 AM, Fam Zheng wrote: > >+/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */ > >+ > >+typedef struct { > >+union { > >+unsigned char data[16]; > >+struct { > >+/* Generated in BE endian, can

Re: [Qemu-block] [PATCH v5 1/9] util: Add UUID API

On 08/12/2016 05:52 AM, Fam Zheng wrote: +/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */ + +typedef struct { +union { +unsigned char data[16]; +struct { +/* Generated in BE endian, can be swapped with qemu_uuid_bswap. */ Nit: BE endian is redundant.

Re: [Qemu-block] [Qemu-devel] [PATCH] linux-aio: Handle io_submit() failure gracefully

On 08/09/2016 01:20 PM, Kevin Wolf wrote: > It is generally not expected that io_submit() fails other than with > -EAGAIN, but corner cases like SELinux refusing I/O when permissions are > revoked are still possible. In this case, we shouldn't abort, but just > return an I/O error for the request.

Re: [Qemu-block] [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

On 08/11/2016 09:29 PM, Fam Zheng wrote: > On Thu, 08/11 12:03, Colin Lord wrote: >> On 08/10/2016 11:23 PM, Fam Zheng wrote: >>> On Wed, 08/10 21:06, Max Reitz wrote: On 10.08.2016 21:04, Colin Lord wrote: > On 08/10/2016 02:37 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord

Re: [Qemu-block] [PATCH] test-coroutine: Fix coroutine pool corruption

Am 10.08.2016 um 13:17 hat Kevin Wolf geschrieben: > The test case overwrites the Coroutine object with 0xff as a way to > assert that the coroutine isn't used any more. However, this means that > the coroutine pool now contains a corrupted object and later test cases > may get this corrupted

[Qemu-block] [PATCH v8 4/4] blockdev: Modularize nfs block driver

Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-block] [PATCH v8 0/4] Dynamic module loading for block drivers

On 12.08.2016 15:27, Colin Lord wrote: > v8: > - Add note to commit message about dmg not being modularized > > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) > > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra

Re: [Qemu-block] [PATCH v7 1/4] blockdev: prepare iSCSI block driver for dynamic loading

On Mon, Aug 08, 2016 at 02:07:17PM -0400, Colin Lord wrote: > This commit moves the initialization of the QemuOptsList qemu_iscsi_opts > struct out of block/iscsi.c in order to allow the iscsi module to be > dynamically loaded. > > Signed-off-by: Colin Lord > Reviewed-by: Fam

[Qemu-block] [PATCH for-2.7? 2/5] block/nbd: Use QemuOpts for runtime options

Using QemuOpts will prevent qemu from crashing if the input options have not been validated (which is the case when they are specified on the command line or in a json: filename) and some have the wrong type. Signed-off-by: Max Reitz --- block/nbd.c | 74

[Qemu-block] [PATCH for-2.7? 3/5] block/blkdebug: Store config filename

Store the configuration file's filename so it can later be used in bdrv_refresh_filename() without having to directly access the options QDict which may contain a value of a non-string type. Signed-off-by: Max Reitz --- block/blkdebug.c | 17 - 1 file changed,

[Qemu-block] [PATCH for-2.7? 4/5] block/nbd: Store runtime option values

Store the runtime option values in the BDRVNBDState so they can later be used in nbd_refresh_filename() without having to directly access the options QDict which may contain values of non-string types. Signed-off-by: Max Reitz --- block/nbd.c | 105

Re: [Qemu-block] [PATCH 0/2] coroutine: Assertions and debugging aids

On Thu, Aug 11, 2016 at 06:22:20PM +0200, Kevin Wolf wrote: > A while ago we were debugging a hang where coroutines were waiting for a mutex > to be unlocked, but we couldn't find out who held the lock. This series adds > some information to Coroutine and CoMutex that both allows to add a few >

[Qemu-block] [PATCH for-2.7? 5/5] iotests: Test case for wrong runtime option types

Signed-off-by: Max Reitz --- tests/qemu-iotests/162 | 96 ++ tests/qemu-iotests/162.out | 17 tests/qemu-iotests/group | 1 + 3 files changed, 114 insertions(+) create mode 100755 tests/qemu-iotests/162 create mode

[Qemu-block] [PATCH for-2.7? 1/5] block/ssh: Use QemuOpts for runtime options

Using QemuOpts will prevent qemu from crashing if the input options have not been validated (which is the case when they are specified on the command line or in a json: filename) and some have the wrong type. Signed-off-by: Max Reitz --- block/ssh.c | 77

[Qemu-block] [PATCH v8 2/4] blockdev: Add dynamic generation of module_block.h

From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí

[Qemu-block] [PATCH v8 3/4] blockdev: Add dynamic module loading for block drivers

From: Marc Mari Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. In addition,

[Qemu-block] [PATCH v8 0/4] Dynamic module loading for block drivers

v8: - Add note to commit message about dmg not being modularized v7: - Add ifdef around qemu_iscsi_opts in vl.c (first patch) v6: - Fix bug so that users can specify a modularized driver on the cli without qemu exiting - Remove extra lines from Makefile - Add patch to modularize NFS v5: - No

Re: [Qemu-block] [PATCH v7 0/4] Dynamic module loading for block drivers

On 08.08.2016 20:07, Colin Lord wrote: > One more minor revision from v6, no big changes. > > v7: > - Add ifdef around qemu_iscsi_opts in vl.c (first patch) > > v6: > - Fix bug so that users can specify a modularized driver on the cli > without qemu exiting > - Remove extra lines from Makefile