Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/1] blockdev: acquire aio_context for bitmap add/remove

2019-02-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190213195501.7790-1-js...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-14 Thread Andrey Shinkevich
On 12/02/2019 14:35, Alberto Garcia wrote: > On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: The problem is in the concept of "base" node. The code written in manner that base is not changed during block job. However, job don't own base and there is no

Re: [Qemu-block] [PATCH 01/13] block: Allow freezing BdrvChild links

2019-02-14 Thread Alberto Garcia
On Tue 12 Feb 2019 03:47:47 PM CET, Kevin Wolf wrote: > Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: >> @@ -3861,6 +3923,10 @@ int bdrv_drop_intermediate(BlockDriverState *top, >> BlockDriverState *base, >> goto exit; >> } >> >> +if (bdrv_is_backing_chain_frozen(top,

Re: [Qemu-block] [PATCH 01/13] block: Allow freezing BdrvChild links

2019-02-14 Thread Kevin Wolf
Am 14.02.2019 um 15:13 hat Alberto Garcia geschrieben: > On Tue 12 Feb 2019 03:47:47 PM CET, Kevin Wolf wrote: > > Am 17.01.2019 um 16:33 hat Alberto Garcia geschrieben: > >> @@ -3861,6 +3923,10 @@ int bdrv_drop_intermediate(BlockDriverState *top, > >> BlockDriverState *base, > >> goto

Re: [Qemu-block] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job

2019-02-14 Thread Kevin Wolf
Am 14.02.2019 um 16:21 hat Alberto Garcia geschrieben: > On Tue 12 Feb 2019 03:54:15 PM CET, Kevin Wolf wrote: > >> @@ -336,6 +340,10 @@ void commit_start(const char *job_id, > >> BlockDriverState *bs, > >> } > >> } > >> > >> +if (bdrv_freeze_backing_chain(commit_top_bs, base,

Re: [Qemu-block] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job

2019-02-14 Thread Alberto Garcia
On Tue 12 Feb 2019 03:54:15 PM CET, Kevin Wolf wrote: >> @@ -336,6 +340,10 @@ void commit_start(const char *job_id, BlockDriverState >> *bs, >> } >> } >> >> +if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) { >> +goto fail; >> +} > > Don't error paths

Re: [Qemu-block] [PULL 0/1] Block patches

2019-02-14 Thread Peter Maydell
On Thu, 14 Feb 2019 at 04:33, Stefan Hajnoczi wrote: > > The following changes since commit 0b5e750bea635b167eb03d86c3d9a09bbd43bc06: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-02-12 10:53:37 +) > > are available in the Git repository