[PULL 2/2] trace: avoid "is" with a literal Python 3.8 warnings

2019-10-14 Thread Stefan Hajnoczi
The following statement produces a SyntaxWarning with Python 3.8: if len(format) is 0: scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Did you mean "=="? Use the conventional len(x) == 0 syntax instead. Reported-by: Daniel P. Berrangé Reviewed-by: Daniel P. Berrangé

[PULL 0/2] Tracing patches

2019-10-14 Thread Stefan Hajnoczi
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git

[PULL 1/1] test-bdrv-drain: fix iothread_join() hang

2019-10-14 Thread Stefan Hajnoczi
tests/test-bdrv-drain can hang in tests/iothread.c:iothread_run(): while (!atomic_read(>stopping)) { aio_poll(iothread->ctx, true); } The iothread_join() function works as follows: void iothread_join(IOThread *iothread) { iothread->stopping = true;

[PULL 0/1] Block patches

2019-10-14 Thread Stefan Hajnoczi
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request

Re: [PATCH v3 07/16] qcow2: Write v3-compliant snapshot list on upgrade

2019-10-14 Thread Max Reitz
On 11.10.19 18:23, Eric Blake wrote: > On 10/11/19 10:28 AM, Max Reitz wrote: >> qcow2 v3 requires every snapshot table entry to have two extra data >> fields: The 64-bit VM state size, and the virtual disk size.  Both are >> optional for v2 images, so they may not be present. >> >>

Re: [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191014081545.29694-1-be...@igalia.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [RFC v5 000/126] error: auto propagated local_err

2019-10-14 Thread Vladimir Sementsov-Ogievskiy
11.10.2019 20:02, Eric Blake wrote: > On 10/11/19 11:03 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> At the request of Markus: full version of errp propagation. Let's look >> at it. Cover as much as possible, except inserting macro invocation >> where it's not necessary. >> >> It's

Re: [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

2019-10-14 Thread Vladimir Sementsov-Ogievskiy
11.10.2019 20:12, Eric Blake wrote: > On 10/11/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> > >>   scripts/coccinelle/auto-propagated-errp.cocci | 118 ++ >>   1 file changed, 118 insertions(+) >>   create mode 100644

[PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread Alberto Garcia
The BDRV_REQ_NO_FALLBACK flag means that an operation should only be performed if it can be offloaded or otherwise performed efficiently. However a misaligned write request requires a RMW so we should return an error and let the caller decide how to proceed. This hits an assertion since commit

<    1   2