[PATCH RESEND 13/13] contrib/rdmacm-mux: Remove superfluous semicolon

Fixes: a5d2f6f8773 Signed-off-by: Philippe Mathieu-Daudé --- Cc: Shamir Rabinovitch --- contrib/rdmacm-mux/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c index de53048f06..bd82abbad3 100644 ---

[PATCH RESEND 12/13] tests/qtest/libqos/qgraph: Remove superfluous semicolons

Fixes: fc281c80202 Signed-off-by: Philippe Mathieu-Daudé --- Cc: Emanuele Giuseppe Esposito --- tests/qtest/libqos/qgraph.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/libqos/qgraph.c b/tests/qtest/libqos/qgraph.c index 7a7ae2a19e..ca01de0743 100644 ---

Re: [PATCH RESEND 06/13] hw/m68k/next-cube: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 956a78118bf > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 07/13] hw/scsi/esp: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 74d71ea16bc > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v4 13/19] iotests: Use complete_and_wait() in 155

This way, we get to see errors during the completion phase. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/155 | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/qemu-iotests/155 b/tests/qemu-iotests/155 index

Re: [PATCH 00/13] trivial: Detect and remove superfluous semicolons in C code

On 2/18/20 10:37 AM, Philippe Mathieu-Daudé wrote: Luc noticed a superfluous trailing semicolon: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html Prevent that by modifying checkpatch.pl and clean the codebase. Philippe Mathieu-Daudé (13): scripts/checkpatch.pl: Detect

Re: [PATCH RESEND 06/13] hw/m68k/next-cube: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 956a78118bf > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > hw/m68k/next-cube.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c

Re: [PATCH RESEND 08/13] hw/vfio/display: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 8b818e059bf > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > Cc: Gerd Hoffmann > --- > hw/vfio/display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/display.c

Re: [PATCH RESEND 03/13] block: Remove superfluous semicolons

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 132ada80c4a > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > block.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 9c810534d6..9db0b973fe

[RFC qemu 3/6] mirror: add check for bitmap-mode without bitmap

as one without the other does not make much sense with the current set of modes. Signed-off-by: Fabian Grünbichler --- blockdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/blockdev.c b/blockdev.c index 8f7b7ba5eb..23df9f76ba 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3868,6

[RFC qemu 0/6] mirror: implement incremental and bitmap modes

picking up on John's in-progress patch series from last summer, this is a stab at rebasing and adding test cases for the low-hanging fruits: - bitmap mirror mode with always/on-success/never bitmap sync mode - incremental mirror mode as sugar for bitmap + on-success Fabian Grünbichler (4):

[RFC qemu 2/6] drive-mirror: add support for conditional and always bitmap sync modes

From: John Snow Teach mirror two new tricks for using bitmaps: Always: no matter what, we synchronize the copy_bitmap back to the sync_bitmap. In effect, this allows us resume a failed mirror at a later date. Conditional: On success only, we sync the bitmap. This is akin to incremental backup

[RFC qemu 4/6] mirror: switch to bdrv_dirty_bitmap_merge_internal

since sync_bitmap is busy at the point of merging, and we checked access beforehand. Signed-off-by: Fabian Grünbichler --- block/mirror.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 40d174a625..d6aca2874e 100644 ---

[PATCH v4 00/19] block: Fix check_to_replace_node()

Branch: https://github.com/XanClic/qemu.git fix-can-replace-v4 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-can-replace-v4 v1: https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01027.html v2: https://lists.nongnu.org/archive/html/qemu-block/2019-11/msg00370.html v3:

Re: [PATCH RESEND 09/13] migration/multifd: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: d32ca5ad798 > Signed-off-by: Philippe Mathieu-Daudé I forgot, queued on migration branch.

[PATCH v4 05/19] quorum: Fix child permissions

Quorum cannot share WRITE or RESIZE on its children. Presumably, it only does so because as a filter, it seemed intuitively correct to point its .bdrv_child_perm to bdrv_filter_default_perm(). However, it is not really a filter, and bdrv_filter_default_perm() does not work for it, so we have to

[PATCH v4 19/19] iotests: Check that @replaces can replace filters

Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 46 ++ tests/qemu-iotests/041.out | 4 ++-- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041

Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes

Patchew URL: https://patchew.org/QEMU/20200218100740.2228521-1-f.gruenbich...@proxmox.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC qemu 0/6] mirror: implement incremental and bitmap modes Message-id:

[PATCH v4 17/19] iotests: Use self.image_len in TestRepairQuorum

041's TestRepairQuorum has its own image_len, no need to refer to TestSingleDrive. (This patch allows commenting out TestSingleDrive to speed up 041 during test testing.) Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 2 +- 1 file changed, 1

[PATCH 00/13] trivial: Detect and remove superfluous semicolons in C code

Luc noticed a superfluous trailing semicolon: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html Prevent that by modifying checkpatch.pl and clean the codebase. Philippe Mathieu-Daudé (13): scripts/checkpatch.pl: Detect superfluous semicolon in C code audio/alsaaudio: Remove

[PATCH 01/13] scripts/checkpatch.pl: Detect superfluous semicolon in C code

Display error when a commit contains superfluous semicolon: $ git show 6663a0a3376 | scripts/checkpatch.pl -q - ERROR: superfluous trailing semicolon #276: FILE: block/io_uring.c:186: +ret = -ENOSPC;; total: 1 errors, 1 warnings, 485 lines checked Reported-by: Luc

[PATCH 01/13] scripts/checkpatch.pl: Detect superfluous semicolon in C code

Display error when a commit contains superfluous semicolon: $ git show 6663a0a3376 | scripts/checkpatch.pl -q - ERROR: superfluous trailing semicolon #276: FILE: block/io_uring.c:186: +ret = -ENOSPC;; total: 1 errors, 1 warnings, 485 lines checked Reported-by: Luc

Re: [PATCH RESEND 02/13] audio/alsaaudio: Remove superfluous semicolons

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 286a5d201e4 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > Cc: "Kővágó, Zoltán" > --- > audio/alsaaudio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH RESEND 12/13] tests/qtest/libqos/qgraph: Remove superfluous semicolons

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: fc281c80202 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > Cc: Emanuele Giuseppe Esposito > --- > tests/qtest/libqos/qgraph.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [PATCH RESEND 13/13] contrib/rdmacm-mux: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: a5d2f6f8773 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > Cc: Shamir Rabinovitch > --- > contrib/rdmacm-mux/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[RFC qemu 6/6] mirror: move some checks to QMP

and assert the passing conditions in block/mirror.c. while incremental mode was never available for drive-mirror, it makes the interface more uniform w.r.t. backup block jobs. Signed-off-by: Fabian Grünbichler --- block/mirror.c | 28 +++ blockdev.c | 29

[RFC qemu 5/6] iotests: add test for bitmap mirror

heavily based on/practically forked off iotest 257 for bitmap backups, but: - no writes to filter node 'mirror-top' between completion and finalization, as those seem to deadlock? - no inclusion of not-yet-available full/top sync modes in combination with bitmaps - extra set of reference/test

Re: [PATCH RESEND 11/13] target/i386/whpx: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 812d49f2a3e > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 10/13] ui/input-barrier: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 6105683da35 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 12/13] tests/qtest/libqos/qgraph: Remove superfluous semicolons

Philippe Mathieu-Daudé wrote: > Fixes: fc281c80202 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v4 16/19] iotests: Resolve TODOs in 041

Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 7b2cf5c2f8..084da6baf3 100755 --- a/tests/qemu-iotests/041 +++

[PATCH v4 15/19] iotests/041: Drop superfluous shutdowns

All tearDowns in 041 shutdown the VM. Thus, test cases do not need to do it themselves (unless they need the VM to be down for some post-operation check). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 11 --- 1 file changed, 11

[PATCH v4 18/19] iotests: Add tests for invalid Quorum @replaces

Add two tests to see that you cannot replace a Quorum child with the mirror job while the child is in use by a different parent. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 70 +-

[PATCH 00/13] trivial: Detect and remove superfluous semicolons in C code

Luc noticed a superfluous trailing semicolon: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html Prevent that by modifying checkpatch.pl and clean the codebase. Philippe Mathieu-Daudé (13): scripts/checkpatch.pl: Detect superfluous semicolon in C code audio/alsaaudio: Remove

[PATCH RESEND 09/13] migration/multifd: Remove superfluous semicolon

Fixes: d32ca5ad798 Signed-off-by: Philippe Mathieu-Daudé --- migration/multifd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c index b3e8ae9bcc..cfaba1369e 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -305,7 +305,7

Re: [PATCH v2 01/22] migration/block-dirty-bitmap: fix dirty_bitmap_mig_before_vm_start

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: No reason to use _locked version of bdrv_enable_dirty_bitmap, as we don't lock this mutex before. Moreover, the adjacent bdrv_dirty_bitmap_enable_successor do lock the mutex. Fixes: 58f72b965e9e1q Cc: qemu-sta...@nongnu.org # v3.0

[PATCH RESEND 01/13] scripts/checkpatch.pl: Detect superfluous semicolon in C code

Display error when a commit contains superfluous semicolon: $ git show 6663a0a3376 | scripts/checkpatch.pl -q - ERROR: superfluous trailing semicolon #276: FILE: block/io_uring.c:186: +ret = -ENOSPC;; total: 1 errors, 1 warnings, 485 lines checked Reported-by: Luc

[PATCH RESEND 11/13] target/i386/whpx: Remove superfluous semicolon

Fixes: 812d49f2a3e Signed-off-by: Philippe Mathieu-Daudé --- Cc: Justin Terry (VM) --- target/i386/whpx-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 3ed2aa1892..35601b8176 100644 --- a/target/i386/whpx-all.c +++

[PATCH RESEND 10/13] ui/input-barrier: Remove superfluous semicolon

Fixes: 6105683da35 Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier --- ui/input-barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/input-barrier.c b/ui/input-barrier.c index fe35049b83..527c75e130 100644 --- a/ui/input-barrier.c +++

[PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Luc noticed a superfluous trailing semicolon: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html Prevent that by modifying checkpatch.pl and clean the codebase. Philippe Mathieu-Daudé (13): scripts/checkpatch.pl: Detect superfluous semicolon in C code audio/alsaaudio: Remove

[PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Fixes: 6663a0a3376 Signed-off-by: Philippe Mathieu-Daudé --- Cc: Stefano Garzarella --- block/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/io_uring.c b/block/io_uring.c index 56892fd1ab..a3142ca989 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@

[PATCH RESEND 03/13] block: Remove superfluous semicolons

Fixes: 132ada80c4a Signed-off-by: Philippe Mathieu-Daudé --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 9c810534d6..9db0b973fe 100644 --- a/block.c +++ b/block.c @@ -2435,13 +2435,13 @@ BdrvChild

[PATCH RESEND 06/13] hw/m68k/next-cube: Remove superfluous semicolon

Fixes: 956a78118bf Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/next-cube.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index e5343348d0..350c6fec78 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -734,7 +734,7

[PATCH RESEND 05/13] hw/arm/xlnx-versal: Remove superfluous semicolon

Fixes: 6f16da53ffe Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-versal-virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c index 462493c467..0d2e3bdda1 100644 --- a/hw/arm/xlnx-versal-virt.c +++

[PATCH RESEND 07/13] hw/scsi/esp: Remove superfluous semicolon

Fixes: 74d71ea16bc Signed-off-by: Philippe Mathieu-Daudé --- Cc: Dr. David Alan Gilbert Cc: Mark Cave-Ayland Cc: Laurent Vivier Cc: Paolo Bonzini --- hw/scsi/esp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index f8fc30cccb..405f8b7cbc

Re: [PATCH RESEND 05/13] hw/arm/xlnx-versal: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 6f16da53ffe > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > hw/arm/xlnx-versal-virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xlnx-versal-virt.c

Re: [PATCH RESEND 10/13] ui/input-barrier: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 6105683da35 > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Laurent Vivier Reviewed-by: Dr. David Alan Gilbert > --- > ui/input-barrier.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 6663a0a3376 > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Stefano Garzarella Reviewed-by: Dr. David Alan Gilbert > --- > block/io_uring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH RESEND 09/13] migration/multifd: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: d32ca5ad798 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > migration/multifd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/multifd.c b/migration/multifd.c

[RFC qemu 1/6] drive-mirror: add support for sync=bitmap mode=never

From: John Snow This patch adds support for the "BITMAP" sync mode to drive-mirror and blockdev-mirror. It adds support only for the BitmapSyncMode "never," because it's the simplest mode. This mode simply uses a user-provided bitmap as an initial copy manifest, and then does not clear any bits

Re: [PATCH RESEND 13/13] contrib/rdmacm-mux: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: a5d2f6f8773 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 01/13] scripts/checkpatch.pl: Detect superfluous semicolon in C code

Philippe Mathieu-Daudé wrote: > Display error when a commit contains superfluous semicolon: > > $ git show 6663a0a3376 | scripts/checkpatch.pl -q - > ERROR: superfluous trailing semicolon > #276: FILE: block/io_uring.c:186: > +ret = -ENOSPC;; > total: 1 errors, 1

Re: [PATCH RESEND 02/13] audio/alsaaudio: Remove superfluous semicolons

Philippe Mathieu-Daudé wrote: > Fixes: 286a5d201e4 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v4 01/19] blockdev: Allow external snapshots everywhere

There is no good reason why we would allow external snapshots only on the first non-filter node in a chain. Parent BDSs should not care whether their child is replaced by a snapshot. (If they do care, they should announce that via freezing the chain, which is checked in bdrv_append() through

[PATCH v4 07/19] blkverify: Implement .bdrv_recurse_can_replace()

Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/blkverify.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/blkverify.c b/block/blkverify.c index 304b0a1368..0add3ab483 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -282,6

[PATCH v4 10/19] block: Remove bdrv_recurse_is_first_non_filter()

It no longer has any users. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block.c | 33 - block/blkverify.c | 15 --- block/copy-on-read.c | 9 - block/filter-compress.c | 9

[PATCH v4 09/19] block: Use bdrv_recurse_can_replace()

Let check_to_replace_node() use the more specialized bdrv_recurse_can_replace() instead of bdrv_recurse_is_first_non_filter(), which is too restrictive (or, in the case of quorum, sometimes not restrictive enough). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block.c

[PATCH v4 14/19] iotests: Add VM.assert_block_path()

Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 59 +++ 1 file changed, 59 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 0473e824ed..8815052eb5 100644 --- a/tests/qemu-iotests/iotests.py +++

[PATCH v4 12/19] quorum: Stop marking it as a filter

Quorum is not a filter, for example because it cannot guarantee which of its children will serve the next request. Thus, any of its children may differ from the data visible to quorum's parents. We have other filters with multiple children, but they differ in this aspect: - blkverify quits the

Re: [PATCH 00/13] trivial: Detect and remove superfluous semicolons in C code

On 2/18/20 10:32 AM, Philippe Mathieu-Daudé wrote: Luc noticed a superfluous trailing semicolon: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html Prevent that by modifying checkpatch.pl and clean the codebase. Philippe Mathieu-Daudé (13): scripts/checkpatch.pl: Detect

[PATCH RESEND 02/13] audio/alsaaudio: Remove superfluous semicolons

Fixes: 286a5d201e4 Signed-off-by: Philippe Mathieu-Daudé --- Cc: "Kővágó, Zoltán" --- audio/alsaaudio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index a23a5a0b60..a8e62542f9 100644 --- a/audio/alsaaudio.c +++

Re: [PATCH RESEND 01/13] scripts/checkpatch.pl: Detect superfluous semicolon in C code

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Display error when a commit contains superfluous semicolon: > > $ git show 6663a0a3376 | scripts/checkpatch.pl -q - > ERROR: superfluous trailing semicolon > #276: FILE: block/io_uring.c:186: > +ret = -ENOSPC;; >

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Am 18.02.2020 um 10:43 hat Philippe Mathieu-Daudé geschrieben: > Fixes: 6663a0a3376 > Signed-off-by: Philippe Mathieu-Daudé Thanks, applied patches 3 and 4 to the block branch. Kevin

[PATCH RESEND 08/13] hw/vfio/display: Remove superfluous semicolon

Fixes: 8b818e059bf Signed-off-by: Philippe Mathieu-Daudé --- Cc: Gerd Hoffmann --- hw/vfio/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index a5a608c5b2..f4977c66e1 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @@

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

On Tue, Feb 18, 2020 at 10:43:53AM +0100, Philippe Mathieu-Daudé wrote: > Fixes: 6663a0a3376 > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Stefano Garzarella > --- > block/io_uring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefano Garzarella Thanks, Stefano

Re: [PATCH RESEND 08/13] hw/vfio/display: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 8b818e059bf > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v4 04/19] iotests: Let 041 use -blockdev for quorum children

Using -drive with default options means that a virtio-blk drive will be created that has write access to the to-be quorum children. Quorum should have exclusive write access to them, so we should use -blockdev instead. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy ---

[PATCH v4 02/19] blockdev: Allow resizing everywhere

Block nodes that do not allow resizing should not share BLK_PERM_RESIZE. It does not matter whether they are the first non-filter in their chain or not. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- blockdev.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH v2 03/22] migration/block-dirty-bitmap: rename dirty_bitmap_mig_cleanup

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Rename dirty_bitmap_mig_cleanup to dirty_bitmap_do_save_cleanup, to stress that it is on save part. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block-dirty-bitmap.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH RESEND 07/13] hw/scsi/esp: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 74d71ea16bc > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > Cc: Dr. David Alan Gilbert > Cc: Mark Cave-Ayland > Cc: Laurent Vivier > Cc: Paolo Bonzini > --- > hw/scsi/esp.c | 2 +- > 1 file

Re: [PATCH RESEND 11/13] target/i386/whpx: Remove superfluous semicolon

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Fixes: 812d49f2a3e > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > Cc: Justin Terry (VM) > --- > target/i386/whpx-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH RESEND 03/13] block: Remove superfluous semicolons

Philippe Mathieu-Daudé wrote: > Fixes: 132ada80c4a > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 05/13] hw/arm/xlnx-versal: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 6f16da53ffe > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: 6663a0a3376 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH RESEND 09/13] migration/multifd: Remove superfluous semicolon

Philippe Mathieu-Daudé wrote: > Fixes: d32ca5ad798 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v4 11/19] mirror: Double-check immediately before replacing

There is no guarantee that we can still replace the node we want to replace at the end of the mirror job. Double-check by calling bdrv_recurse_can_replace(). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 14 +- 1 file changed, 13

[PATCH v4 08/19] quorum: Implement .bdrv_recurse_can_replace()

Signed-off-by: Max Reitz --- block/quorum.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 17b439056f..3ece6e4382 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -813,6 +813,59 @@ static bool

[PATCH v4 03/19] block: Drop bdrv_is_first_non_filter()

It is unused now. (And it was ugly because it needed to explore all BDS chains from the top.) Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block.c | 26 -- include/block/block.h | 1 - 2 files changed, 27 deletions(-) diff

[PATCH v4 06/19] block: Add bdrv_recurse_can_replace()

After a couple of follow-up patches, this function will replace bdrv_recurse_is_first_non_filter() in check_to_replace_node(). bdrv_recurse_is_first_non_filter() is both not sufficiently specific for check_to_replace_node() (it allows cases that should not be allowed, like replacing child nodes

[PATCH] migration/block: rename BLOCK_SIZE macro

Both and define BLOCK_SIZE macros. Avoiding using that name in block/migration.c. I noticed this when including (Linux io_uring) from "block/aio.h" and compilation failed. Although patches adding that include haven't been sent yet, it makes sense to rename the macro now in case someone else

Re: [PATCH v3] configure: Avoid compiling system tools on user build by default

Le 17/02/2020 à 14:33, Philippe Mathieu-Daudé a écrit : > User-mode does not need the system tools. Do not build them by > default if the user specifies --disable-system. > > This disables building the following binaries on a user-only build: > > - elf2dmp > - qemu-edid > - qemu-ga > - qemu-img

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

On 2/18/20 2:02 PM, Andrey Shinkevich wrote: qemu-iotests:$ ./check -qcow2 PASSED (except always failed 261 and 272) Have you reported those failures on the threads that introduced those tests? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization:

Re: [PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

On 18/02/2020 18:04, Paolo Bonzini wrote: > On 18/02/20 10:43, Philippe Mathieu-Daudé wrote: >> Luc noticed a superfluous trailing semicolon: >> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html >> >> Prevent that by modifying checkpatch.pl and clean the codebase. >> >> Philippe

Re: [PATCH v2 09/22] migration/block-dirty-bitmap: relax error handling in incoming part

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy recovering) because of dirty-bitmaps migration failure. Instead we should just lose unfinished bitmaps. Still we have to report io stream violation

Re: [PATCH v2 10/22] migration/block-dirty-bitmap: cancel migration on shutdown

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: If target is turned of prior to postcopy finished, target crashes because busy bitmaps are found at shutdown. Canceling incoming migration helps, as it removes all unfinished (and therefore busy) bitmaps. Similarly on source we crash

Re: [PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Le 18/02/2020 à 18:04, Paolo Bonzini a écrit : > On 18/02/20 10:43, Philippe Mathieu-Daudé wrote: >> Luc noticed a superfluous trailing semicolon: >> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html >> >> Prevent that by modifying checkpatch.pl and clean the codebase. >> >>

Re: [PATCH 3/3] hw/block/pflash_cfi02: Remove unneeded variable assignment

Le 15/02/2020 à 17:15, Philippe Mathieu-Daudé a écrit : > Fix warning reported by Clang static code analyzer: > > CC hw/block/pflash_cfi02.o > hw/block/pflash_cfi02.c:311:5: warning: Value stored to 'ret' is never read > ret = -1; > ^ ~~ > > Reported-by: Clang Static

Re: [PATCH v2 00/22] Fix error handling during bitmap postcopy

qemu-iotests:$ ./check -qcow2 PASSED (except always failed 261 and 272) Andrey On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: Original idea of bitmaps postcopy migration is that bitmaps are non critical data, and their loss is not serious problem. So, using postcopy method on any

Re: [PATCH 2/3] hw/display/qxl: Remove unneeded variable assignment

Le 15/02/2020 à 17:15, Philippe Mathieu-Daudé a écrit : > Fix warning reported by Clang static code analyzer: > > hw/display/qxl.c:1634:14: warning: Value stored to 'orig_io_port' during > its initialization is never read > uint32_t orig_io_port = io_port; >^~~~

Re: Cross-project NBD extension proposal: NBD_INFO_INIT_STATE

On 2/17/20 9:13 AM, Max Reitz wrote: Hi, It’s my understanding that without some is_zero infrastructure for QEMU, it’s impossible to implement this flag in qemu’s NBD server. You're right that we may need some more infrastructure before being able to decide when to report this bit in all

Re: [PATCH v2 04/22] migration/block-dirty-bitmap: move mutex init to dirty_bitmap_mig_init

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: No reasons to keep two public init functions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/migration.h | 1 - migration/block-dirty-bitmap.c | 6 +- migration/migration.c | 2 -- 3 files changed, 1

[PATCH v3 18/33] block: Add bdrv_default_perms()

This callback can be used by BDSs that use child_of_bds with the appropriate BdrvChildRole for their children. Also, make bdrv_format_default_perms() use it for child_of_bds children (just a temporary solution until we can drop bdrv_format_default_perms() altogether). Signed-off-by: Max Reitz

[PATCH v3 31/33] block: Drop child_file

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block.c | 30 +- include/block/block_int.h | 1 - tests/test-bdrv-drain.c | 8 +++- 3 files changed, 4 insertions(+), 35 deletions(-) diff --git a/block.c b/block.c index

[PATCH v3 27/33] tests: Use child_of_bds instead of child_file

Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/test-bdrv-drain.c | 29 + tests/test-bdrv-graph-mod.c | 6 -- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c index

Re: [PATCH v4 18/19] iotests: Add tests for invalid Quorum @replaces

On 18.02.20 13:38, Kevin Wolf wrote: > Am 18.02.2020 um 11:34 hat Max Reitz geschrieben: >> Add two tests to see that you cannot replace a Quorum child with the >> mirror job while the child is in use by a different parent. >> >> Signed-off-by: Max Reitz >> Reviewed-by: Vladimir

Re: [PATCH v2 06/22] migration/block-dirty-bitmap: rename finish_lock to just lock

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote: finish_lock is bad name, as lock used not only on process end. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block-dirty-bitmap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 3/3] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command

Hi Cédric, On [2020 Feb 04] Tue 08:45:11, Cédric Le Goater wrote: > On 2/3/20 7:09 PM, Guenter Roeck wrote: > > The Linux kernel recently started using FAST_READ_4 commands. > > This results in flash read failures. At the same time, the m25p80 > > emulation is seen to read 8 more bytes than

Re: [PATCH v4 18/19] iotests: Add tests for invalid Quorum @replaces

Am 18.02.2020 um 11:34 hat Max Reitz geschrieben: > Add two tests to see that you cannot replace a Quorum child with the > mirror job while the child is in use by a different parent. > > Signed-off-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/041 |

[PATCH v3 06/33] block: Pass BdrvChildRole to .inherit_options()

For now, all callers (effectively) pass 0 and no callee evaluates thie value. Later patches will change both. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block.c | 40 +++ block/block-backend.c | 3 ++- block/vvfat.c

[PATCH v3 08/33] block: Rename bdrv_inherited_options()

The other two .inherit_options implementations specify exactly for what case they are used in their name, so do it for this one as well. (The actual intention behind this patch is to follow it up with a generic bdrv_inherited_options() that works for all three cases.) Signed-off-by: Max Reitz

  1   2   >