Re: [PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-08-07 Thread Vladimir Sementsov-Ogievskiy
06.08.2020 22:35, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary to_json() ... that returns a json-dumpable object with desired fields and their values. Extend it in subclass

Re: [PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-08-07 Thread Vladimir Sementsov-Ogievskiy
07.08.2020 11:03, Andrey Shinkevich wrote: On 07.08.2020 09:30, Vladimir Sementsov-Ogievskiy wrote: 06.08.2020 22:35, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary to_json() ...

Re: [PATCH v13 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-08-07 Thread Andrey Shinkevich
On 07.08.2020 09:30, Vladimir Sementsov-Ogievskiy wrote: 06.08.2020 22:35, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary to_json() ... that returns a json-dumpable object New

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

2020-08-07 Thread Ying Fang
On 8/6/2020 5:13 PM, Kevin Wolf wrote: Am 05.08.2020 um 04:38 hat Ying Fang geschrieben: From: fangying When qemu or qemu-nbd process uses a qcow2 image and configured with 'cache = none', it will write to the qcow2 image with a cache to cache L2 tables, however the process will not use L2

Re: [PATCH v3 2/3] async: always set ctx->notified in aio_notify()

2020-08-07 Thread Stefan Hajnoczi
On Thu, Aug 06, 2020 at 03:45:33PM +0200, Paolo Bonzini wrote: > On 06/08/20 15:18, Stefan Hajnoczi wrote: > > +atomic_set(>notified, false); > > + > > +/* > > + * Write ctx->notified before reading e.g. bh->flags. Pairs with > > smp_mb in > > + * aio_notify. > > + */ > > +

[PATCH] Simple & stupid coroutine-aware monitor_cur()

2020-08-07 Thread Markus Armbruster
This is just a sketch. It's incomplete, needs comments and a real commit message. Support for "[PATCH v6 09/12] hmp: Add support for coroutine command handlers" is missing. Marked FIXME. As is, it goes on top of Kevin's series. It is meant to be squashed into PATCH 06, except for the FIXME,

Ways to do per-coroutine properties (was: [PATCH v6 06/12] monitor: Make current monitor a per-coroutine property)

2020-08-07 Thread Markus Armbruster
I called for a discussion of design alternatives, because I dislike the one I got. Here we go. = Context: the "current monitor" = Output of HMP commands needs to go to the HMP monitor executing the command. Trivial in HMP command handlers: the handler function takes a monitor argument. Not so

[PATCH] Coroutine-aware monitor_cur() with coroutine-specific data

2020-08-07 Thread Markus Armbruster
This is just a sketch. It needs comments and a real commit message. As is, it goes on top of Kevin's series. It is meant to be squashed into PATCH 06. Signed-off-by: Markus Armbruster --- include/qemu/coroutine.h | 4 include/qemu/coroutine_int.h | 2 ++ monitor/monitor.c

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-07 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 17:59, Max Reitz wrote: On 10.07.20 19:41, Andrey Shinkevich wrote: On 10.07.2020 18:24, Max Reitz wrote: On 09.07.20 16:52, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the

Re: [PATCH v7 03/47] block: bdrv_cow_child() for bdrv_has_zero_init()

2020-08-07 Thread Vladimir Sementsov-Ogievskiy
25.06.2020 18:21, Max Reitz wrote: bdrv_has_zero_init() and the related bdrv_unallocated_blocks_are_zero() should use bdrv_cow_child() if they want to check whether the given BDS has a COW backing file. Signed-off-by: Max Reitz --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2] block/vhdx: Support vhdx image only with 512 bytes logical sector size

2020-08-07 Thread Swapnil Ingle
block/vhdx uses qemu block layer where sector size is always 512 bytes. This may have issues with 4K logical sector sized vhdx image. For e.g qemu-img convert on such images fails with following assert: $qemu-img convert -f vhdx -O raw 4KTest1.vhdx test.raw qemu-img: util/iov.c:388: qiov_slice:

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

2020-08-07 Thread Kevin Wolf
Am 07.08.2020 um 09:42 hat Ying Fang geschrieben: > > > On 8/6/2020 5:13 PM, Kevin Wolf wrote: > > Am 05.08.2020 um 04:38 hat Ying Fang geschrieben: > > > From: fangying > > > > > > When qemu or qemu-nbd process uses a qcow2 image and configured with > > > 'cache = none', it will write to the

Re: [PATCH v7 01/47] block: Add child access functions

2020-08-07 Thread Vladimir Sementsov-Ogievskiy
28.07.2020 19:09, Christophe de Dinechin wrote: On 2020-07-13 at 11:06 CEST, Vladimir Sementsov-Ogievskiy wrote... 25.06.2020 18:21, Max Reitz wrote: There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Since the introduction of filters and

Re: [PATCH v2] block/vhdx: Support vhdx image only with 512 bytes logical sector size

2020-08-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1596794594-44531-1-git-send-email-swapnil.in...@nutanix.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. ===

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-07 Thread John Snow
On 8/5/20 4:41 PM, Peter Maydell wrote: On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: The struct had a single field (IDEDevice dev), and is only used in the QOM type declarations and property lists. We can simply use the IDEDevice struct directly instead. Signed-off-by: Eduardo