[PULL v2 2/7] meson: move vhost_user_blk_server to meson.build

2020-11-17 Thread Michael S. Tsirkin
From: Stefan Hajnoczi The --enable/disable-vhost-user-blk-server options were implemented in ./configure. There has been confusion about them and part of the problem is that the shell syntax used for setting the default value is not easy to read. Move the option over to meson where the

Re: [PATCH for-5.2 00/10] block/export: vhost-user-blk server tests and input validation

2020-11-17 Thread Michael S. Tsirkin
On Wed, Nov 11, 2020 at 12:43:21PM +, Stefan Hajnoczi wrote: > The vhost-user-blk server test was already in Michael Tsirkin's recent vhost > pull request, but was dropped because it exposed vhost-user regressions > (b7c1bd9d7848 and the Based-on tag below). Now that the vhost-user regressions

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

2020-11-17 Thread Philippe Mathieu-Daudé
On 10/26/20 2:40 AM, Bin Meng wrote: > Hi Philippe, > > On Mon, Oct 26, 2020 at 2:56 AM Philippe Mathieu-Daudé > wrote: >> >> On 10/25/20 4:23 PM, Bin Meng wrote: >>> From: Bin Meng >>> >>> Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 >>> bytes, hence the READ_BL_LEN

[PATCH] curl: remove compatibility code

2020-11-17 Thread Paolo Bonzini
cURL 7.16.0 was released in October 2006. Just remove code that is in all likelihood not being used anywhere. Signed-off-by: Paolo Bonzini --- block/curl.c | 28 1 file changed, 28 deletions(-) diff --git a/block/curl.c b/block/curl.c index 4f907c47be..b77bfe12e7

Re: [PATCH v2 4/7] qapi: Use QAPI_LIST_PREPEND() where possible

2020-11-17 Thread Stefan Hajnoczi
On Thu, Nov 12, 2020 at 07:13:37PM -0600, Eric Blake wrote: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded until

[PULL 6/7] iotests/081: Filter image format after testdir

2020-11-17 Thread Kevin Wolf
From: Max Reitz Otherwise, this breaks whenever the test directory contains the image format (e.g. "/tmp/test-raw-file" is filtered to "/tmp/test-IMGFMT-file" instead of "TEST_DIR"). Signed-off-by: Max Reitz Message-Id: <20201113211718.261671-3-mre...@redhat.com> Signed-off-by: Kevin Wolf ---

Re: [PATCH] curl: remove compatibility code

2020-11-17 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 01:40:56PM +0100, Paolo Bonzini wrote: > On 17/11/20 12:46, Daniel P. Berrangé wrote: > > On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote: > > > cURL 7.16.0 was released in October 2006. Just remove code that is > > > in all likelihood not being used

Re: [PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted

2020-11-17 Thread Kevin Wolf
Am 13.11.2020 um 22:17 hat Max Reitz geschrieben: > Hi, > > While reviewing Berto’s block-status/write-zeroes series for quorum, I > wondered how quorum’s permission code handles rewrite-corrupted. It > turns out it doesn’t, and so qemu with a read-only rewrite-corrupted > quorum node simply

Re: [PATCH v2 4/7] qapi: Use QAPI_LIST_PREPEND() where possible

2020-11-17 Thread Markus Armbruster
Eric Blake writes: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded until later patches. "now-public" suggests a

[PULL 0/1] SD/MMC patches for 2020-11-17

2020-11-17 Thread Philippe Mathieu-Daudé
-20201117 for you to fetch changes up to 575094b786e999e5fbd04c0456f518a5ebefab5b: hw/sd: Fix 2 GiB card CSD register values (2020-11-17 11:45:13 +0100) SD/MMC patches - Correctly handle 2 GB SCSD Memory Cards (Bin Meng) CI jobs

[PULL 1/1] hw/sd: Fix 2 GiB card CSD register values

2020-11-17 Thread Philippe Mathieu-Daudé
From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for the NetBSD 9.0 test of the Orange Pi PC that has an expanded SD card image of 2 GiB size.

Re: [PATCH] curl: remove compatibility code

2020-11-17 Thread Daniel P . Berrangé
On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote: > cURL 7.16.0 was released in October 2006. Just remove code that is > in all likelihood not being used anywhere. Rather than assuming that, we should be picking our minimum version and enforcing that in configure/meson. Currently,

[PULL 7/7] iotests/081: Test rewrite-corrupted without WRITE

2020-11-17 Thread Kevin Wolf
From: Max Reitz Test what happens when a rewrite-corrupted quorum node performs such a rewrite, while there is no parent that has taken the WRITE permission. Signed-off-by: Max Reitz Message-Id: <20201113211718.261671-4-mre...@redhat.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/081

[PULL 3/7] file-posix: allow -EBUSY errors during write zeros on raw block devices

2020-11-17 Thread Kevin Wolf
From: Maxim Levitsky On Linux, fallocate(fd, FALLOC_FL_PUNCH_HOLE) when it is used on a block device, without O_DIRECT can return -EBUSY if it races with another write to the same page. Since this is rare and discard is not a critical operation, ignore this error Signed-off-by: Maxim Levitsky

[PULL 4/7] io_uring: do not use pointer after free

2020-11-17 Thread Kevin Wolf
From: Paolo Bonzini Even though only the pointer value is only printed, it is untidy and Coverity complains. Cc: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Message-Id: <20201113154102.1460459-1-pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Kevin Wolf ---

[PULL 0/7] Patches for 5.2.0-rc2

2020-11-17 Thread Kevin Wolf
The following changes since commit bce36c6c5436c0c2679b42c6de54de5393dfcf59: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2020-11-16 22:29:51 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you

[PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted

2020-11-17 Thread Kevin Wolf
From: Max Reitz Using rewrite-corrupted means quorum may issue writes to its children just from receiving read requests from its parents. Thus, it must take the WRITE permission when rewrite-corrupted is used. Signed-off-by: Max Reitz Message-Id: <20201113211718.261671-2-mre...@redhat.com>

[PULL 1/7] char-stdio: Fix QMP default for 'signal'

2020-11-17 Thread Kevin Wolf
Commit 02c4bdf1 tried to make signal=on the default for stdio chardevs except for '-serial mon:stdio', but it forgot about QMP and accidentally switched the QMP default from true (except for -nographic) to false (always). The documentation was kept unchanged and still describes the opposite of the

[PULL 2/7] iotests: Replace deprecated ConfigParser.readfp()

2020-11-17 Thread Kevin Wolf
iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning changes the output: nbd-fault-injector.py:230: DeprecationWarning: This method will be removed in future versions. Use 'parser.read_file()' instead. In fact, readfp() has already been deprecated in Python 3.2 and

Re: [PATCH] curl: remove compatibility code

2020-11-17 Thread Paolo Bonzini
On 17/11/20 12:46, Daniel P. Berrangé wrote: On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote: cURL 7.16.0 was released in October 2006. Just remove code that is in all likelihood not being used anywhere. Rather than assuming that, we should be picking our minimum version and

Re: [PATCH v5 3/4] hw/block/m25p80: Check SPI mode before running some Numonyx commands

2020-11-17 Thread Francisco Iglesias
On Mon, Nov 16, 2020 at 03:11:03PM -0800, Joe Komlodi wrote: > Some Numonyx flash commands cannot be executed in DIO and QIO mode, such as > trying to do DPP or DOR when in QIO mode. > > Signed-off-by: Joe Komlodi Reviewed-by: Francisco Iglesias > --- > hw/block/m25p80.c | 114 >

Re: [PULL 0/7] Patches for 5.2.0-rc2

2020-11-17 Thread Peter Maydell
On Tue, 17 Nov 2020 at 12:16, Kevin Wolf wrote: > > The following changes since commit bce36c6c5436c0c2679b42c6de54de5393dfcf59: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2020-11-16 22:29:51 +) > > are available in the Git repository at: >

Re: [PULL 0/1] SD/MMC patches for 2020-11-17

2020-11-17 Thread Peter Maydell
> > are available in the Git repository at: > > https://gitlab.com/philmd/qemu.git tags/sdmmc-20201117 > > for you to fetch changes up to 575094b786e999e5fbd04c0456f518a5ebefab5b: > > hw/sd: Fix 2 GiB card CSD

question about bdrv_replace_node

2020-11-17 Thread Vladimir Sementsov-Ogievskiy
Hi! bdrv_replace_node_common() keeps old node parents in a list and call bdrv_replace_child_noperm() in a loop.. But bdrv_replace_child_noperm() may do aio_poll, which may trigger any graph change, up to freeing child which we keep in a loop. Actually I've reach something similar with a lot

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-17 Thread Keith Busch
On Thu, Nov 12, 2020 at 08:36:39PM +0100, Klaus Jensen wrote: > On Nov 5 11:53, Dmitry Fomichev wrote: > > @@ -133,6 +300,12 @@ static Property nvme_ns_props[] = { > > DEFINE_BLOCK_PROPERTIES(NvmeNamespace, blkconf), > > DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0), > >