Re: [PATCH v6 03/11] target/arm: Restrict ARMv4 cpus to TCG accel

2021-03-04 Thread Philippe Mathieu-Daudé
On 3/4/21 12:55 PM, Claudio Fontana wrote: > Hi, > > I am trying to take these patches, > in the hope that they help with some of the test issues I am having with the > kvm-only build, > > but they fail with: > > target/arm/Kconfig: does not exist in index > > so I guess I need the

Re: [PATCH V4 0/8] hw/block/nvme: support namespace attachment

2021-03-04 Thread Keith Busch
On Tue, Mar 02, 2021 at 10:26:09PM +0900, Minwoo Im wrote: > Hello, > > This series supports namespace attachment: attach and detach. This is > the fourth version of series with replacing changed namespace list to > bitmap to indicate changed namespace IDs. > > Please review. Looks good to me.

Re: [PATCH v2 2/2] memory: Drop "qemu:" prefix from QOM memory region type names

2021-03-04 Thread Alistair Francis
On Thu, Mar 4, 2021 at 9:03 AM Markus Armbruster wrote: > > Almost all QOM type names consist only of letters, digits, '-', '_', > and '.'. Just two contain ':': "qemu:memory-region" and > "qemu:iommu-memory-region". Neither can be plugged with -object. > Rename them to "memory-region" and

Re: [RESEND][BUG FIX HELP] QEMU main thread endlessly hangs in __ppoll()

2021-03-04 Thread John Snow
On 2/28/21 9:39 PM, Like Xu wrote: Hi Genius, I am a user of QEMU v4.2.0 and stuck in an interesting bug, which may still exist in the mainline. Thanks in advance to heroes who can take a look and share understanding. Do you have a test case that reproduces on 5.2? It'd be nice to know if

Re: [PATCH] hw/sd/sdhci: Report error when guest access protected registers

2021-03-04 Thread John Snow
On 2/18/21 12:56 PM, Philippe Mathieu-Daudé wrote: The SDHC_SYSAD and SDHC_BLKSIZE can not be accessed while a transaction is in progress, see 'SD Host Controller Simplified Specification' 1.5) SD Command Generation The Host Driver should not read the SDMA System Address, Block Size

Re: [PATCH] hw/sd/sdhci: Report error when guest access protected registers

2021-03-04 Thread Bin Meng
On Fri, Feb 19, 2021 at 1:56 AM Philippe Mathieu-Daudé wrote: > > The SDHC_SYSAD and SDHC_BLKSIZE can not be accessed while a > transaction is in progress, see 'SD Host Controller Simplified > Specification' > > 1.5) SD Command Generation > > The Host Driver should not read the SDMA System

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Markus Armbruster
Peter Krempa writes: > On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus

Re: [PATCH v2 6/8] simplebench/bench-backup: support qcow2 source files

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add support for qcow2 source. New option says to use test-source.qcow2 instead of test-source. Of course, test-source.qcow2 should be precreated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 5

Re: [PATCH v2 1/8] simplebench: bench_one(): add slow_limit argument

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: Sometimes one of cells in a testing table runs too slow. And we really don't want to wait so long. Limit number of runs in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 29

Re: [PATCH v2 2/8] simplebench: bench_one(): support count=1

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: statistics.stdev raises if sequence length is less than two. Support that case by hand. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 4/8] simplebench/bench-backup: add target-cache argument

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: Allow benchmark with different kinds of target cache. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 33 -- scripts/simplebench/bench_block_job.py | 10 +--- 2 files

Re: [PATCH v2 5/8] simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: We should not report success if there is an error in final event. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench_block_job.py | 4 1 file changed, 4 insertions(+) diff --git

Re: [RESEND][BUG FIX HELP] QEMU main thread endlessly hangs in __ppoll()

2021-03-04 Thread Like Xu
Hi John, Thanks for your comment. On 2021/3/5 7:53, John Snow wrote: On 2/28/21 9:39 PM, Like Xu wrote: Hi Genius, I am a user of QEMU v4.2.0 and stuck in an interesting bug, which may still exist in the mainline. Thanks in advance to heroes who can take a look and share understanding.

Re: [PATCH v2 7/8] simplebench/bench-backup: add --count and --no-initial-run

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add arguments to set number of test runs per table cell and to disable initial run that is not counted in results. It's convenient to set --count 1 --no-initial-run to fast run test onece, and to set --count to some large enough number for

[PATCH v2 3/3] blockdev: Drop deprecated bogus -drive interface type

2021-03-04 Thread Markus Armbruster
Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate -drive with bogus interface type" (v5.1.0). Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst | 7 -- docs/system/removed-features.rst | 7 ++ include/sysemu/blockdev.h| 1 - blockdev.c

[PATCH v2 0/3] Drop deprecated floppy config & bogus -drive if=T

2021-03-04 Thread Markus Armbruster
v2: * Rebased, straightforward conflict with commit f5d33dd51f "hw/block/fdc: Remove the check_media_rate property" resolved * PATCH 2: Commit message fixed [Kevin] Markus Armbruster (3): fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives() into

[PATCH v2 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-03-04 Thread Markus Armbruster
The previous commit rendered the name fdctrl_connect_drives() somewhat misleading. Get rid of it by inlining the (now pretty simple) function into its only caller. Signed-off-by: Markus Armbruster --- hw/block/fdc.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-)

Re: [PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Denis V. Lunev
On 3/4/21 12:51 PM, Vladimir Sementsov-Ogievskiy wrote: > Add new parallels-ext.c and myself as co-maintainer. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9b2aa18e1f..92ba1fce5e

[PATCH v2 0/8] simplebench improvements

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here are some improvements to simplebench lib, to support my "qcow2: compressed write cache" series. v1 was inside "[PATCH 0/7] qcow2: compressed write cache" <20210129165030.640169-1-vsement...@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07795.html

[PATCH v2 3/8] simplebench/bench-backup: add --compressed option

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Allow bench compressed backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 55 ++ scripts/simplebench/bench_block_job.py | 23 +++ 2 files changed, 62 insertions(+), 16 deletions(-) diff --git

[PATCH v2 2/8] simplebench: bench_one(): support count=1

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
statistics.stdev raises if sequence length is less than two. Support that case by hand. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/simplebench/simplebench.py

[PATCH v2 6/8] simplebench/bench-backup: support qcow2 source files

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Add support for qcow2 source. New option says to use test-source.qcow2 instead of test-source. Of course, test-source.qcow2 should be precreated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 5 + scripts/simplebench/bench_block_job.py | 7 ++-

[PATCH v2 8/8] simplebench/bench_block_job: drop caches before test run

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
It probably may improve reliability of results when testing in cached mode. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench_block_job.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/simplebench/bench_block_job.py

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Wed, Mar 03, 2021 at 10:26:12PM +0100, Peter Lieven wrote: Am 03.03.21 um 19:47 schrieb Jason Dillaman: On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella wrote: Hi Jason, as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD writing data is very slow compared to a raw

[PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Markus Armbruster
Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate configuring floppies with -global isa-fdc" (v5.1.0). Signed-off-by: Markus Armbruster --- docs/system/deprecated.rst | 26 -- docs/system/removed-features.rst | 26 ++ hw/block/fdc.c | 54 +--

[PATCH v2 4/8] simplebench/bench-backup: add target-cache argument

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Allow benchmark with different kinds of target cache. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-backup.py| 33 -- scripts/simplebench/bench_block_job.py | 10 +--- 2 files changed, 33 insertions(+), 10 deletions(-) diff --git

Re: [PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Denis V. Lunev
On 3/4/21 12:58 PM, Vladimir Sementsov-Ogievskiy wrote: > 04.03.2021 12:51, Vladimir Sementsov-Ogievskiy wrote: >> Add new parallels-ext.c and myself as co-maintainer. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   MAINTAINERS | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff

[PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Add new parallels-ext.c and myself as co-maintainer. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..92ba1fce5e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3117,9 +3117,11 @@ F:

[PATCH v2 1/8] simplebench: bench_one(): add slow_limit argument

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Sometimes one of cells in a testing table runs too slow. And we really don't want to wait so long. Limit number of runs in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 29 + 1 file changed, 25 insertions(+), 4

[PATCH v2 5/8] simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
We should not report success if there is an error in final event. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench_block_job.py | 4 1 file changed, 4 insertions(+) diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py index

[PATCH] MAINTAINERS: add Vladimir as co-maintainer of NBD

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- I have good knowledge of the subsystem and I'm an author of large part of it :) MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 92ba1fce5e..58994bfafc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: > Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate > configuring floppies with -global isa-fdc" (v5.1.0). > > Signed-off-by: Markus Armbruster > --- > docs/system/deprecated.rst | 26 -- >

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella wrote: Hi Jason, as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD writing data is very slow compared to a raw file. Comparing raw vs QCOW2 image creation

Re: [PATCH v2 7/6] MAINTAINERS: update parallels block driver

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
04.03.2021 12:51, Vladimir Sementsov-Ogievskiy wrote: Add new parallels-ext.c and myself as co-maintainer. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..92ba1fce5e 100644 ---

[PATCH v2 7/8] simplebench/bench-backup: add --count and --no-initial-run

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Add arguments to set number of test runs per table cell and to disable initial run that is not counted in results. It's convenient to set --count 1 --no-initial-run to fast run test onece, and to set --count to some large enough number for good precision of the results. Signed-off-by: Vladimir

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 09:55:40AM +0100, Stefano Garzarella wrote: > On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: > > On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella > > wrote: > > > > > > Hi Jason, > > > as reported in this BZ [1], when qemu-img creates a QCOW2 image on

[PATCH v2 9/8] MAINTAINERS: update Benchmark util: add git tree

2021-03-04 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b2aa18e1f..642c1c8a46 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2484,6 +2484,7 @@ Benchmark util M: Vladimir Sementsov-Ogievskiy S: Maintained

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Thu, Mar 04, 2021 at 10:25:33AM +, Daniel P. Berrangé wrote: On Thu, Mar 04, 2021 at 09:55:40AM +0100, Stefano Garzarella wrote: On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: > On Wed, Mar 3, 2021 at 12:41 PM Stefano Garzarella wrote: > > > > Hi Jason, > > as reported

Re: [PATCH 0/9] hw/arm/virt: Improve CPU help and fix testing under KVM

2021-03-04 Thread Claudio Fontana
On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote: > Yet again bugfixes and cleanup patches noticed while > rebasing my "Support disabling TCG on ARM (part 2)" series. > > Sending them independently as they aren't directly dependent > of it so don't have to be delayed by other unanswered

Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG

2021-03-04 Thread Peter Maydell
On Fri, 5 Feb 2021 at 14:44, Philippe Mathieu-Daudé wrote: > > Support for ARMv7 has been dropped in commit 82bf7ae84ce > ("target/arm: Remove KVM support for 32-bit Arm hosts"). > Restrict the 32-bit CPUs to --enable-tcg builds. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c |

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Kevin Wolf
Am 03.03.2021 um 18:40 hat Stefano Garzarella geschrieben: > Hi Jason, > as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD > writing data is very slow compared to a raw file. > > Comparing raw vs QCOW2 image creation with RBD I found that we use a > different object size, for

Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG

2021-03-04 Thread Claudio Fontana
Hi Peter, what do you think of the following patch? We messaged yesterday about cortex-a15 being the default cpu for virt, this patch would need also changing the default CPU for virt under KVM I would think. Or, we could change the virt default cpu to "max"? Thanks, Claudio On 2/5/21

Re: [PATCH v6 03/11] target/arm: Restrict ARMv4 cpus to TCG accel

2021-03-04 Thread Claudio Fontana
Hi, I am trying to take these patches, in the hope that they help with some of the test issues I am having with the kvm-only build, but they fail with: target/arm/Kconfig: does not exist in index so I guess I need the "target/arm/Kconfig" series right, how can I find that one? Thanks,

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 12:12:51PM +0100, Stefano Garzarella wrote: > On Thu, Mar 04, 2021 at 10:25:33AM +, Daniel P. Berrangé wrote: > > On Thu, Mar 04, 2021 at 09:55:40AM +0100, Stefano Garzarella wrote: > > > On Wed, Mar 03, 2021 at 01:47:06PM -0500, Jason Dillaman wrote: > > > > On Wed,

Re: [PATCH] nbd: server: Report holes for raw images

2021-03-04 Thread Kevin Wolf
Am 25.02.2021 um 19:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.02.2021 19:58, Eric Blake wrote: > > On 2/19/21 10:42 AM, Eric Blake wrote: > > > > > > To me, data=false looks compatible with NBD_STATE_HOLE. From user point > > > > of view, getting same results from qemu-nbd and

Re: [PATCH v2 2/6] parallels.txt: fix bitmap L1 table description

2021-03-04 Thread Kevin Wolf
Am 24.02.2021 um 11:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > Actually L1 table entry offset is in 512 bytes sectors. Fix the spec. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > docs/interop/parallels.txt | 27 +++ > 1 file changed, 15 insertions(+),

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: >> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate >> configuring floppies with -global isa-fdc" (v5.1.0). >> >> Signed-off-by: Markus Armbruster >> --- >> docs/system/deprecated.rst

Re: [PATCH v2 3/6] block/parallels: BDRVParallelsState: add cluster_size field

2021-03-04 Thread Kevin Wolf
Am 04.03.2021 um 15:57 hat Denis V. Lunev geschrieben: > On 3/4/21 5:24 PM, Kevin Wolf wrote: > > Am 24.02.2021 um 11:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> We are going to use it in more places, calculating > >> "s->tracks << BDRV_SECTOR_BITS" doesn't look good. > >> > >>

[PATCH v2 2/2] memory: Drop "qemu:" prefix from QOM memory region type names

2021-03-04 Thread Markus Armbruster
Almost all QOM type names consist only of letters, digits, '-', '_', and '.'. Just two contain ':': "qemu:memory-region" and "qemu:iommu-memory-region". Neither can be plugged with -object. Rename them to "memory-region" and "iommu-memory-region". Signed-off-by: Markus Armbruster ---

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: > >> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate > >> configuring floppies with -global isa-fdc" (v5.1.0). >

Re: [PATCH] MAINTAINERS: add Vladimir as co-maintainer of NBD

2021-03-04 Thread Eric Blake
On 3/4/21 4:35 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > I have good knowledge of the subsystem and I'm an author of large part > of it :) Reviewed-by: Eric Blake I'll include this in my next NBD pull request > > MAINTAINERS | 2 ++ >

[PATCH v2 1/2] hw: Replace anti-social QOM type names

2021-03-04 Thread Markus Armbruster
Several QOM type names contain ',': ARM,bitband-memory etraxfs,pic etraxfs,serial etraxfs,timer fsl,imx25 fsl,imx31 fsl,imx6 fsl,imx6ul fsl,imx7 grlib,ahbpnp grlib,apbpnp grlib,apbuart grlib,gptimer grlib,irqmp qemu,register SUNW,bpp

Re: [PATCH v2 3/6] block/parallels: BDRVParallelsState: add cluster_size field

2021-03-04 Thread Denis V. Lunev
On 3/4/21 5:24 PM, Kevin Wolf wrote: > Am 24.02.2021 um 11:47 hat Vladimir Sementsov-Ogievskiy geschrieben: >> We are going to use it in more places, calculating >> "s->tracks << BDRV_SECTOR_BITS" doesn't look good. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> @@ -771,6 +770,7 @@ static

[PATCH v2 0/2] QOM type names and QAPI

2021-03-04 Thread Markus Armbruster
Based-on: <20210304100059.157158-1-arm...@redhat.com> Note: to apply it on master instead, replace one more "SUNW,fdtwo" by "sun-fdtwo" in hw/block/fdc.c. QAPI has naming rules. docs/devel/qapi-code-gen.txt: === Naming rules and reserved names === All names must begin with a letter,

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Thu, Mar 04, 2021 at 01:05:02PM +0100, Kevin Wolf wrote: Am 03.03.2021 um 18:40 hat Stefano Garzarella geschrieben: Hi Jason, as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD writing data is very slow compared to a raw file. Comparing raw vs QCOW2 image creation with

Re: [PATCH v2 3/6] block/parallels: BDRVParallelsState: add cluster_size field

2021-03-04 Thread Kevin Wolf
Am 24.02.2021 um 11:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > We are going to use it in more places, calculating > "s->tracks << BDRV_SECTOR_BITS" doesn't look good. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > @@ -771,6 +770,7 @@ static int parallels_open(BlockDriverState *bs,

Re: [PATCH v2 0/6] parallels: load bitmap extension

2021-03-04 Thread Kevin Wolf
Am 24.02.2021 um 11:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > We need to load bitmaps from parallels image in our product. > So here is a feature. Thanks, applied to the block branch. I changed some sentences in patch 2 as suggested in my reply to it. Please let me know if

Re: [PATCH v2 0/2] QOM type names and QAPI

2021-03-04 Thread Paolo Bonzini
On 04/03/21 15:02, Markus Armbruster wrote: [*] Paolo's "[PATCH 04/25] keyval: accept escaped commas in implied option" provides for comma-quoting. I'm ignoring it here for brevity. I assure you it doesn't weaken my argument. I even agree about that, for what it's worth. Acked-by: Paolo

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Kevin Wolf
Am 04.03.2021 um 15:08 hat Stefano Garzarella geschrieben: > On Thu, Mar 04, 2021 at 01:05:02PM +0100, Kevin Wolf wrote: > > Am 03.03.2021 um 18:40 hat Stefano Garzarella geschrieben: > > > Hi Jason, > > > as reported in this BZ [1], when qemu-img creates a QCOW2 image on RBD > > > writing data is

Re: Potential regression in 'qemu-img convert' to LVM

2021-03-04 Thread Stefan Reiter
On 07/01/2021 21:03, Nir Soffer wrote: On Tue, Sep 15, 2020 at 2:51 PM Stefan Reiter wrote: On 9/15/20 11:08 AM, Nir Soffer wrote: On Mon, Sep 14, 2020 at 3:25 PM Stefan Reiter wrote: Hi list, following command fails since 5.1 (tested on kernel 5.4.60): # qemu-img convert -p -f raw -O

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Peter Krempa
On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: > >> >> Drop the

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 05:52:50PM +0100, Peter Krempa wrote: > On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote: > > >> Daniel P. Berrangé writes: > > >> > > >> > On Thu,

Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration

2021-03-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote: >> >> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate >> >> configuring

Re: QEMU RBD is slow with QCOW2 images

2021-03-04 Thread Stefano Garzarella
On Thu, Mar 04, 2021 at 03:59:17PM +0100, Kevin Wolf wrote: Am 04.03.2021 um 15:08 hat Stefano Garzarella geschrieben: On Thu, Mar 04, 2021 at 01:05:02PM +0100, Kevin Wolf wrote: > Am 03.03.2021 um 18:40 hat Stefano Garzarella geschrieben: > > Hi Jason, > > as reported in this BZ [1], when

Re: [PATCH v2 8/8] simplebench/bench_block_job: drop caches before test run

2021-03-04 Thread John Snow
On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: It probably may improve reliability of results when testing in cached mode. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench_block_job.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v2 1/2] hw: Replace anti-social QOM type names

2021-03-04 Thread Mark Cave-Ayland
On 04/03/2021 14:02, Markus Armbruster wrote: Several QOM type names contain ',': ARM,bitband-memory etraxfs,pic etraxfs,serial etraxfs,timer fsl,imx25 fsl,imx31 fsl,imx6 fsl,imx6ul fsl,imx7 grlib,ahbpnp grlib,apbpnp grlib,apbuart