On 25/06/2015 20:07, Programmingkid wrote:
I honestly think it is in the right place. The function find_image_format()
is doing just that - trying to find the format. The image part of the
function's name
does bother me. But we could ignore it. Since we know it is a real cdrom
drive,
it
On Thu, Jun 25, 2015 at 12:49:31PM +0200, Markus Armbruster wrote:
Peter Maydell peter.mayd...@linaro.org writes:
On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
This patchset attempts to improve the warning and error
Ping?
Paolo
On 28/05/2015 16:17, Paolo Bonzini wrote:
bdrv_close already does that, and in fact hmp_drive_del would need
another drain after the flush (which bdrv_close does). So remove
the duplication.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
blockdev.c | 3 ---
1 file
On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote:
upcoming libnfs versions will support logging debug messages. Add
support for it in qemu through an URL parameter.
Signed-off-by: Peter Lieven p...@kamp.de
---
block/nfs.c | 4
1 file changed, 4 insertions(+)
diff --git
Peter Maydell peter.mayd...@linaro.org writes:
On 25 June 2015 at 10:26, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
This patchset attempts to improve the warning and error messages for
bad user command lines that attempt to connect a drive up to
Kevin, can you queue this patch for 2.4?
Paolo
On 29/05/2015 12:53, Fam Zheng wrote:
There callers work on a single BlockDriverState subtree, where using
bdrv_drain() is more accurate.
Signed-off-by: Fam Zheng f...@redhat.com
---
block.c | 6 +++---
block/snapshot.c | 2 +-
On Wed, Jun 24, 2015 at 07:14:34PM +0200, Alberto Garcia wrote:
Ping...
https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01929.html
Kevin is on vacation, I am merging QEMU 2.4 bug fixes for the areas he
maintains.
This series is not a bug fix. Kevin will review it when he's back.
Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi:
On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote:
upcoming libnfs versions will support logging debug messages. Add
support for it in qemu through an URL parameter.
Signed-off-by: Peter Lieven p...@kamp.de
---
block/nfs.c | 4
Reclaim the dirty bitmap if an incremental backup block job is
cancelled. The ret variable may be 0 when the job is cancelled so it's
not enough to check ret 0.
Reviewed-by: John Snow js...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
On Wed, Jun 24, 2015 at 11:08:43AM +, Li, Liang Z wrote:
Right now, we don't have an interface to detect that cases and
got back to the iterative stage.
How about go back to the iterative stage when detect that the
pending_size is larger Than max_size, like this:
On Thu, 06/25 09:02, Fam Zheng wrote:
On Wed, 06/24 19:01, Paolo Bonzini wrote:
On 24/06/2015 11:08, Fam Zheng wrote:
Stefan,
The only controversial patches are the qmp/drive-mirror ones (1-3), while
patches 4-8 are still useful on their own: they fix the mentioned crash
On Tue, Jun 16, 2015 at 01:45:07PM +0200, Peter Lieven wrote:
libiscsi starting with 1.15 will properly support timeout of iscsi
commands. The default will remain no timeout, but this can
be changed via cmdline parameters, e.g.:
qemu -iscsi timeout=30 -drive file=iscsi://...
If a timeout
On Tue, Jun 23, 2015 at 02:26:51PM -0400, Programmingkid wrote:
On Jun 23, 2015, at 2:06 PM, John Snow wrote:
On 06/23/2015 01:56 PM, Programmingkid wrote:
Fix real cdrom detection so that a real cdrom can actually be used.
signed-off-by: John Arbuckle programmingk...@gmail.com
Am 25.06.2015 um 23:08 schrieb Paolo Bonzini:
On 16/06/2015 13:45, Peter Lieven wrote:
libiscsi starting with 1.15 will properly support timeout of iscsi
commands. The default will remain no timeout, but this can
be changed via cmdline parameters, e.g.:
qemu -iscsi timeout=30 -drive
On Jun 25, 2015, at 11:14 AM, Programmingkid wrote:
On Jun 25, 2015, at 2:53 AM, Markus Armbruster wrote:
Programmingkid programmingk...@gmail.com writes:
On Jun 23, 2015, at 2:06 PM, John Snow wrote:
On 06/23/2015 01:56 PM, Programmingkid wrote:
Fix real cdrom detection so that
On Jun 25, 2015, at 11:32 AM, Programmingkid wrote:
On Jun 25, 2015, at 11:14 AM, Programmingkid wrote:
On Jun 25, 2015, at 2:53 AM, Markus Armbruster wrote:
Programmingkid programmingk...@gmail.com writes:
On Jun 23, 2015, at 2:06 PM, John Snow wrote:
On 06/23/2015 01:56
On Wed, Jun 24, 2015 at 03:54:27PM -0400, Jeff Cody wrote:
@@ -269,7 +270,9 @@ static int vpc_open(BlockDriverState *bs, QDict *options,
int flags,
goto fail;
}
-s-pagetable = qemu_try_blockalign(bs-file, s-max_table_entries *
4);
+pagetable_size =
On 25/06/2015 17:32, Programmingkid wrote:
I think we are going to have to agree to disagree. I have never
used the /dev/sr(0 | 1) devices and don't see how they would be
effected by this patch. Are you trying to say the /dev/sr(0 | 1)
devices *should* be handled by this patch?
Thinking
On 25/06/2015 17:48, Paolo Bonzini wrote:
On 25/06/2015 17:32, Programmingkid wrote:
I think we are going to have to agree to disagree. I have never
used the /dev/sr(0 | 1) devices and don't see how they would be
effected by this patch. Are you trying to say the /dev/sr(0 | 1)
devices
On 25/06/2015 18:16, Paolo Bonzini wrote:
On 25/06/2015 18:12, Laurent Vivier wrote:
On 25/06/2015 17:48, Paolo Bonzini wrote:
On 25/06/2015 17:32, Programmingkid wrote:
I think we are going to have to agree to disagree. I have never
used the /dev/sr(0 | 1) devices and don't see how
On Thu, Jun 04, 2015 at 08:20:34PM -0400, John Snow wrote:
If we wish to make differential backups a feature that's easy to access,
it might be pertinent to rename the dirty-bitmap mode to incremental
to make it clear what /type/ of backup the dirty-bitmap is helping us
perform.
This is an
On 25/06/2015 18:12, Laurent Vivier wrote:
On 25/06/2015 17:48, Paolo Bonzini wrote:
On 25/06/2015 17:32, Programmingkid wrote:
I think we are going to have to agree to disagree. I have never
used the /dev/sr(0 | 1) devices and don't see how they would be
effected by this patch. Are
On Thu, Jun 25, 2015 at 12:30:56PM -0400, John Snow wrote:
On 06/25/2015 08:53 AM, Stefan Hajnoczi wrote:
Reclaim the dirty bitmap if an incremental backup block job is
cancelled. The ret variable may be 0 when the job is cancelled so it's
not enough to check ret 0.
Reviewed-by:
On 06/25/2015 08:53 AM, Stefan Hajnoczi wrote:
Reclaim the dirty bitmap if an incremental backup block job is
cancelled. The ret variable may be 0 when the job is cancelled so it's
not enough to check ret 0.
Reviewed-by: John Snow js...@redhat.com
Reviewed-by: Max Reitz
On Jun 25, 2015, at 11:48 AM, Paolo Bonzini wrote:
On 25/06/2015 17:32, Programmingkid wrote:
I think we are going to have to agree to disagree. I have never
used the /dev/sr(0 | 1) devices and don't see how they would be
effected by this patch. Are you trying to say the /dev/sr(0 | 1)
On 25/06/2015 19:56, Programmingkid wrote:
In fact, programmingkid, you should fix it in hdev_open() where
there is already a #if __APPLE__ .
Nice to hear from you again Laurent. The only way a solution in
hdev_open() would work is if it could prevent find_image_format()
from executing.
On Jun 25, 2015, at 12:12 PM, Laurent Vivier wrote:
On 25/06/2015 17:48, Paolo Bonzini wrote:
On 25/06/2015 17:32, Programmingkid wrote:
I think we are going to have to agree to disagree. I have never
used the /dev/sr(0 | 1) devices and don't see how they would be
effected by this
On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote:
Nice to hear from you again Laurent. The only way a solution in
hdev_open() would work is if it could prevent find_image_format()
from executing. Otherwise find_image_format() would just quit QEMU
with an error.
The
Am 23.06.2015 um 01:03 schrieb ronnie sahlberg:
LGTM
It is good to finally have timeouts that work in libiscsi, and a consumer that
can use and benefit from it.
Paolo, Kevin, Stefan, do you think this is sth for 2.4?
Peter
Programmingkid programmingk...@gmail.com writes:
On Jun 23, 2015, at 2:06 PM, John Snow wrote:
On 06/23/2015 01:56 PM, Programmingkid wrote:
Fix real cdrom detection so that a real cdrom can actually be used.
signed-off-by: John Arbuckle programmingk...@gmail.com
Peter Maydell peter.mayd...@linaro.org writes:
This patchset attempts to improve the warning and error messages for
bad user command lines that attempt to connect a drive up to two
devices. The motivation here is patch #4, which changes the default
interface for the virt board to virtio. That
On 25 June 2015 at 08:40, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
Now we have virtio-pci, we can make the virt board's default block
device type be IF_VIRTIO. This allows users to use simplified
command lines that don't have to explicitly
Peter Maydell peter.mayd...@linaro.org writes:
On 25 June 2015 at 08:40, Markus Armbruster arm...@redhat.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
Now we have virtio-pci, we can make the virt board's default block
device type be IF_VIRTIO. This allows users to use simplified
33 matches
Mail list logo
