Re: [Qemu-block] [PATCH v2 02/11] aio: Save type to AioHandler

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:05PM +0800, Fam Zheng wrote: So it can be used by aio_poll later. Signed-off-by: Fam Zheng f...@redhat.com --- aio-posix.c | 2 ++ aio-win32.c | 3 +++ 2 files changed, 5 insertions(+) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-block] [PATCH v2 01/11] aio: Introduce type in aio_set_fd_handler and aio_set_event_notifier

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:04PM +0800, Fam Zheng wrote: The parameter is added but not used. The callers are converted with following coccinelle semantic patch: @@ expression E1, E2, E3, E4, E5; @@ ( -aio_set_event_notifier(E1, E2, E3)

Re: [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as protocol

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote: diff --git a/include/block/aio.h b/include/block/aio.h index bd1d44b..d02ddfa 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx); bool aio_dispatch(AioContext *ctx);

Re: [Qemu-block] [PATCH v2 04/11] nbd: Mark fd handlers client type as nbd server

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:07PM +0800, Fam Zheng wrote: So we could distinguish it from protocol to avoid handling in nested aio polls. Signed-off-by: Fam Zheng f...@redhat.com --- include/block/aio.h | 1 + nbd.c | 4 ++-- 2 files changed, 3 insertions(+), 2

Re: [Qemu-block] [PATCH v2 05/11] aio: Mark ctx-notifier's client type as context

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:08PM +0800, Fam Zheng wrote: It is important to include this for any blocking poll, on the other hand it is also OK to exclude it otherwise. Signed-off-by: Fam Zheng f...@redhat.com --- async.c | 4 ++-- include/block/aio.h | 1 + 2 files

Re: [Qemu-block] [PATCH v2 06/11] dataplane: Mark host notifiers' client type as dataplane

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:09PM +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- hw/block/dataplane/virtio-blk.c | 4 ++-- hw/scsi/virtio-scsi-dataplane.c | 16 include/block/aio.h | 1 + 3 files changed, 11 insertions(+), 10

Re: [Qemu-block] [Qemu-devel] [PATCH v2 07/11] aio-posix: introduce aio_{disable, enable}_clients

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:10PM +0800, Fam Zheng wrote: +void aio_disable_enable_clients(AioContext *ctx, int clients_mask, +bool is_disable) +{ +AioHandler *node; +aio_context_acquire(ctx); + +QLIST_FOREACH(node, ctx-aio_handlers, node) { +

Re: [Qemu-block] [PATCH v2 09/11] block: Introduce bdrv_aio_poll

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:12PM +0800, Fam Zheng wrote: This call is introduced simply as a wrapper of aio_poll, but it makes it is easy to change the polled client types. Signed-off-by: Fam Zheng f...@redhat.com --- block/io.c| 8 include/block/aio.h | 2 +-

Re: [Qemu-block] [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-08-27 Thread Eric Blake
On 08/27/2015 09:17 AM, Peter Maydell wrote: I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+ doesn't have sparse file support, and Windows

Re: [Qemu-block] coroutine pool memory usage

2015-08-27 Thread Peter Lieven
Am 27.08.2015 um 17:23 schrieb Paolo Bonzini: i was debugging increased memory footprint of qemu over the past time and found that the coroutine pool heap usage can grow up to 70MB by just booting an Ubuntu Live CD. And those 70MB are never freed. Is this expected? Wouldn't it make sense to

Re: [Qemu-block] coroutine pool memory usage

2015-08-27 Thread Paolo Bonzini
i was debugging increased memory footprint of qemu over the past time and found that the coroutine pool heap usage can grow up to 70MB by just booting an Ubuntu Live CD. And those 70MB are never freed. Is this expected? Wouldn't it make sense to asynchronically throw some coroutines (or at

[Qemu-block] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-08-27 Thread Peter Maydell
I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+ doesn't have sparse file support, and Windows probably doesn't either. Worse, if the test fails an

Re: [Qemu-block] [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-08-27 Thread John Snow
On 08/27/2015 11:29 AM, Eric Blake wrote: On 08/27/2015 09:17 AM, Peter Maydell wrote: I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+

Re: [Qemu-block] [PATCH 3/5] block: Drop drv parameter from bdrv_open_inherit()

2015-08-27 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:50 PM CEST, Max Reitz wrote: Now that this parameter is effectively unused, we can drop it and just pass NULL to bdrv_fill_options(). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Alberto Garcia be...@igalia.com Berto

Re: [Qemu-block] [PATCH 1/5] block: Always pass NULL as drv for bdrv_open()

2015-08-27 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:48 PM CEST, Max Reitz mre...@redhat.com wrote: Change all callers of bdrv_open() to pass the driver name in the options QDict instead of passing its BlockDriver pointer. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Alberto Garcia be...@igalia.com Berto

Re: [Qemu-block] [PATCH 2/5] block: Drop drv parameter from bdrv_open()

2015-08-27 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:49 PM CEST, Max Reitz wrote: Now that this parameter is effectively unused, we can drop it and just pass NULL on to bdrv_open_inherit(). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Alberto Garcia be...@igalia.com Berto

Re: [Qemu-block] [PATCH 4/5] block: Drop drv parameter from bdrv_fill_options()

2015-08-27 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:51 PM CEST, Max Reitz wrote: Now that this parameter is effectively unused, we can drop it and change the function accordingly. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Alberto Garcia be...@igalia.com Berto

Re: [Qemu-block] [PATCH 5/5] block: Drop bdrv_find_whitelisted_format()

2015-08-27 Thread Alberto Garcia
On Wed 26 Aug 2015 07:47:52 PM CEST, Max Reitz wrote: It is unused by now, so we can drop it. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Alberto Garcia be...@igalia.com Berto

[Qemu-block] [PATCH V3] block/nfs: cache allocated filesize for read-only files

2015-08-27 Thread Peter Lieven
If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed-off-by: Peter

[Qemu-block] coroutine pool memory usage

2015-08-27 Thread Peter Lieven
Hi, i was debugging increased memory footprint of qemu over the past time and found that the coroutine pool heap usage can grow up to 70MB by just booting an Ubuntu Live CD. And those 70MB are never freed. Is this expected? Wouldn't it make sense to asynchronically throw some coroutines (or