Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

On Wed, Dec 02, 2015 at 01:37:08PM +, Daniel P. Berrange wrote: > On Wed, Dec 02, 2015 at 01:56:30PM +0100, Wouter Verhelst wrote: > > Hi Daniel, > > > > Something occurred to me earlier today: > > > > On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > > > As is, if the

[Qemu-block] [PULL 0/2] Block patches for 2.5.0-rc3

The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into staging (2015-12-02 10:16:53 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-block] [PATCH v7 14/24] nbd: Switch from close to eject notifier

On 01.12.2015 14:16, Kevin Wolf wrote: > Am 30.11.2015 um 18:22 hat Max Reitz geschrieben: >> On 30.11.2015 16:36, Kevin Wolf wrote: >>> Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: The NBD code uses the BDS close notifier to determine when a medium is ejected. However, now it

Re: [Qemu-block] [PULL 0/1] Block patches for 2.5

On 2 December 2015 at 14:27, Jeff Cody wrote: > The following changes since commit 680617ed43a2811318ac2df63e686f6b7bc22f55: > > Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20151130' into > staging (2015-11-30 15:35:20 +) > > are available in the git

Re: [Qemu-block] [PATCH v2 18/21] blkdebug: Enable reopen

On Mon 23 Nov 2015 04:59:57 PM CET, Kevin Wolf wrote: > Just reopening the children (as block.c does now) is enough. > > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

[Qemu-block] [PULL v2 1/1] mirror: Quiesce source during "mirror_exit"

From: Fam Zheng With dataplane, the ioeventfd events could be dispatched after mirror_run releases the dirty bitmap, but before mirror_exit actually does the device switch, because the iothread will still be running, and it will cause silent data loss. Fix this by adding a

Re: [Qemu-block] [PATCH] mirror: Quiesce source during "mirror_exit"

On Mon, Nov 23, 2015 at 10:28:04AM +0800, Fam Zheng wrote: > With dataplane, the ioeventfd events could be dispatched after > mirror_run releases the dirty bitmap, but before mirror_exit actually > does the device switch, because the iothread will still be running, and > it will cause silent data

Re: [Qemu-block] [PULL 0/1] Block patches for 2.5

On Wed, Dec 02, 2015 at 03:40:42PM +, Peter Maydell wrote: > On 2 December 2015 at 14:27, Jeff Cody wrote: > > The following changes since commit 680617ed43a2811318ac2df63e686f6b7bc22f55: > > > > Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20151130' into > >

[Qemu-block] [PULL 0/1] Block patches for 2.5

The following changes since commit 680617ed43a2811318ac2df63e686f6b7bc22f55: Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20151130' into staging (2015-11-30 15:35:20 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

[Qemu-block] [PULL v2 0/1] Block patches for 2.5

The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into staging (2015-12-02 10:16:53 +) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git

[Qemu-block] [PULL 2/2] blkdebug: silence warning under qtest

From: "Michael S. Tsirkin" make check always outputs warnings, this is not nice. Disable blkdebug warnings under qtest. Signed-off-by: Michael S. Tsirkin Message-id: 1448883874-17933-1-git-send-email-...@redhat.com Signed-off-by: Max Reitz

[Qemu-block] [PULL 1/2] qcow2: Fix potential qemu-img check crash on 32 bit hosts

This crash was caught with qemu-iotests test case 138. Commit b6d36de already fixed a few 32 bit truncation bugs that could cause qemu-img check to allocate too little memory and consequently it would segfault. On 32 bit hosts, there is one more place that needs to be fixed because size_t was

Re: [Qemu-block] [PATCH 7/8] block: Make bdrv_open() return a BDS

On 01.12.2015 15:44, Alberto Garcia wrote: > On Tue 10 Nov 2015 04:44:22 AM CET, Max Reitz wrote: >> @@ -1398,32 +1397,21 @@ static int bdrv_open_inherit(BlockDriverState **pbs, >> const char *filename, >> bool options_non_empty = options ? qdict_size(options) : false; >>

Re: [Qemu-block] [Qemu-devel] [PULL 0/2] Block patches for 2.5.0-rc3

On 2 December 2015 at 16:20, Kevin Wolf wrote: > The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into > staging (2015-12-02 10:16:53 +) > > are available in the git

Re: [Qemu-block] [PULL v2 0/1] Block patches for 2.5

On 2 December 2015 at 15:47, Jeff Cody wrote: > The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into > staging (2015-12-02 10:16:53 +) > > are available in the git

Re: [Qemu-block] [PATCH 3/8] block: Let bdrv_open_inherit() return the snapshot

On 01.12.2015 15:35, Alberto Garcia wrote: > On Tue 10 Nov 2015 04:44:18 AM CET, Max Reitz wrote: >> -int bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, Error **errp) >> +static BlockDriverState *bdrv_append_temp_snapshot(BlockDriverState *bs, >> +

Re: [Qemu-block] [PATCH 0/3] block: Fix assertion failure with before write notifier again

On Tue, Dec 01, 2015 at 05:36:27PM +0800, Fam Zheng wrote: > This is basically a supplementary fix of 06c3916b. > > On 512 disks, the crash only happens when copy-on-read is enabled, which is > covered by the previou fix. But on 4k disks the write request that triggers > the notifier itself may

Re: [Qemu-block] [PATCH 12/15] nbd: implement TLS support in the protocol negotiation

On Sat, Nov 28, 2015 at 11:28:55AM +0100, Wouter Verhelst wrote: > Minor nitpick: > > On Fri, Nov 27, 2015 at 12:20:50PM +, Daniel P. Berrange wrote: > [...] > > @@ -563,6 +659,14 @@ static int nbd_receive_options(NBDClient *client) > > case NBD_OPT_EXPORT_NAME: > >

Re: [Qemu-block] [PATCH for-2.6 0/3] iotests: 124: Don't reopen qcow2 file

Am 02.12.2015 um 00:16 hat John Snow geschrieben: > Kevin caught me being Naughty, and because I don't want Santa to be > mad at me, I have corrected my ways. > > Split iotest 124 into two classes so that the iotest that requires > a blkdebug filter from the get-go can forego the standard setUp >

Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

On Wed, Dec 02, 2015 at 01:56:30PM +0100, Wouter Verhelst wrote: > Hi Daniel, > > Something occurred to me earlier today: > > On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > > As is, if the client connects to a TLS enabled NBD server and then > > immediately sends

Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

Hi Daniel, Something occurred to me earlier today: On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > As is, if the client connects to a TLS enabled NBD server and then > immediately sends NBD_OPT_EXPORT_NAME, it is not possible for us > to send back NBD_REP_ERR_TLS_REQD as

Re: [Qemu-block] [PATCH v2 07/21] block: Pass driver-specific options to .bdrv_refresh_filename()

On Mon 23 Nov 2015 04:59:46 PM CET, Kevin Wolf wrote: > In order to decide whether a blkdebug: filename can be produced or a > json: one is necessary, blkdebug checked whether bs->options had more > options than just "config", "x-image" or "image" (the latter including > nested