>
> Subject: [PATCH] nvme: generate OpenFirmware device path in the "bootorder"
> fw_cfg file
>
> Background on QEMU boot indices
> ---
>
> Normally, the "bootindex" property is configured for bootable devices
> with:
>
> DEVICE_instance_init()
> device_add_boot
On Tue, 01/26 18:54, John Snow wrote:
> It will no longer be sufficient to rely on the opaque parameter
> containing a BDS, and there's no way to reliably include a
> self-reference to the job we're creating, so always pass the Job
> object forward to any callbacks.
>
> Signed-off-by: John Snow
>
On Tue, 01/26 18:54, John Snow wrote:
> Instead of relying on peeking at bs->job, we want to explicitly get
> a reference to the job that was involved in this notifier callback.
>
> Pack the Notifier inside of the BackupBlockJob so we can use
> container_of to get a reference back to the BackupBlo
On Tue, 01/26 17:57, John Snow wrote:
> Can we implement a function that, in the event of a disaster, compares
> the current state of the drive with the last known good incremental and
> populates a bitmap based on the difference?
>
> Actually, we probably really want this feature around regardles
Pick up an extra reference in mirror_start_job to allow callers
of mirror_start and commit_active_start to get a reference to
the job they have created. Phase out callers from fishing the job
out of bs->job -- use the return value instead.
Callers of mirror_start_job and commit_active_start are no
It will no longer be sufficient to rely on the opaque parameter
containing a BDS, and there's no way to reliably include a
self-reference to the job we're creating, so always pass the Job
object forward to any callbacks.
Signed-off-by: John Snow
---
block/backup.c| 2 +-
block/commi
backup_start picks up a reference to return the job it created to a
caller. callers are updated to put down the reference when they are
finished.
This is particularly interesting for transactions where backup jobs
pick up an implicit reference to the job. Previously, we check to
see if the job sti
stream_start now picks up a reference for its return value, a copy of
the job started. callers are responsible for putting it down when they
are done with it.
This removes a minor reference to bs->job in qmp_block_stream, for
a simple tracing function.
Reviewed-by: Kevin Wolf
Signed-off-by: John
Instead of relying on peeking at bs->job, we want to explicitly get
a reference to the job that was involved in this notifier callback.
Pack the Notifier inside of the BackupBlockJob so we can use
container_of to get a reference back to the BackupBlockJob object.
This cuts out one more case where
This is a small collection of patches to reduce our use of the bs->job
pointer where possible. There are still more usages in the code, but
this cuts down on a few.
The goal is to eventually eliminate all of them and allow multiple block
jobs to run concurrently, but design on what that will look
Background on QEMU boot indices
---
Normally, the "bootindex" property is configured for bootable devices
with:
DEVICE_instance_init()
device_add_bootindex_property(..., "bootindex", ...)
object_property_add(..., device_get_bootindex,
On 01/26/2016 03:45 AM, Vladimir Sementsov-Ogievskiy wrote:
> On 03.06.2015 01:17, John Snow wrote:
>>
>> On 05/28/2015 04:56 PM, Denis V. Lunev wrote:
>>> On 28/05/15 23:09, John Snow wrote:
On 05/26/2015 10:51 AM, Denis V. Lunev wrote:
> On 26/05/15 17:48, Denis V. Lunev wrote:
>>
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 63 ++
1 file changed, 46 insertions(+), 17 deletions(-)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index e45a7f4..ba77bea 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -627,6 +62
All functions relative to DMA (DMA_*() functions) are stubs on sparc platform.
Disable the DMA in the floppy controller, instead of calling these stubs.
Signed-off-by: Hervé Poussineau
---
hw/block/fdc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index
Ping
(I know I could just send a PR, but in this case I'd like someone to
look over it. I've gone over pretty terrible detail to convince myself
this won't break anything IDE-wise, so if it looks sane block-wise, I'd
be satisfied with an ACK.)
On 01/19/2016 12:39 PM, John Snow wrote:
> The ATAPI
On 01/26/2016 03:38 AM, Fam Zheng wrote:
> If the driver owns some dirty bitmaps, this assertion will fail.
>
> The correct place to release them is in bdrv_close, so move the
> assertion one line down.
>
> Signed-off-by: Fam Zheng
> ---
> block.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 d
On 01/26/2016 03:38 AM, Fam Zheng wrote:
> So that driver can write the dirty bits into persistent dirty bitmaps in
> the write callback.
>
> Signed-off-by: Fam Zheng
> ---
> block/io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
>
> diff --git a/block
On 01/26/2016 03:38 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
> ---
> docs/specs/qbm.md | 118
> ++
> 1 file changed, 118 insertions(+)
> create mode 100644 docs/specs/qbm.md
>
> diff --git a/docs/specs/qbm.md b/docs/specs/qbm.md
> new
On 01/20/2016 01:11 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
Looks OK at 10,000 feet.
Acked-by: John Snow
> ---
> tests/test-hbitmap.c | 139
> +++
> 1 file changed, 139 insertions(+)
>
> diff --git a/tests/test-hbitmap.c b/tests/test
On 01/20/2016 01:11 AM, Fam Zheng wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Several functions to provide necessary access to BdrvDirtyBitmap for
> block-migration.c
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> [Add the "finish" parameters. - Fam]
> Signed-off-by: Fam Zheng
> ---
>
On 01/20/2016 01:11 AM, Fam Zheng wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> Functions to serialize / deserialize(restore) HBitmap. HBitmap should be
> saved to linear sequence of bits independently of endianness and bitmap
> array element (unsigned long) size. Therefore Little Endian is c
On 20.01.2016 09:11, Fam Zheng wrote:
HBitmap is an implementation detail of block dirty bitmap that should be hidden
from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying
HBitmapIter.
A small difference in the interface is, before, an HBitmapIter is initialized
in place, now
On Mon, Jan 04, 2016 at 01:50:40PM +0800, Wen Congyang wrote:
> On 12/23/2015 05:47 PM, Stefan Hajnoczi wrote:
> > On Wed, Dec 02, 2015 at 01:37:25PM +0800, Wen Congyang wrote:
> >> +/*
> >> + * Only write to active disk if the sectors have
> >> + * already been allocated in active disk
On Mon, Jan 04, 2016 at 02:03:16PM +0800, Wen Congyang wrote:
> On 12/23/2015 05:26 PM, Stefan Hajnoczi wrote:
> > On Wed, Dec 02, 2015 at 01:31:46PM +0800, Wen Congyang wrote:
> >> +== Failure Handling ==
> >> +There are 6 internal errors when block replication is running:
> >> +1. I/O error on pr
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-io.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
di
When declaring the 'struct option' array, use the standard
constants no_argument/required_argument, instead of magic
values 0 and 1.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 47 ---
1 file changed, 24 insertions(+), 2
Allow creation of user creatable object types with qemu-io
via a new --object command line arg. This will be used to supply
passwords and/or encryption keys to the various block driver
backends via the recently added 'secret' object type.
# printf letmein > mypasswd.txt
# qemu-io --object secret
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(
Currently qemu-img allows an image filename to be passed on the
command line, but unless using the JSON format, it does not have
a way to set any options except the format eg
qemu-img info https://127.0.0.1/images/centos7.iso
This adds a --image-opts arg that indicates that the positional
file
Currently qemu-nbd allows an image filename to be passed on the
command line, but unless using the JSON format, it does not have
a way to set any options except the format eg
qemu-nbd https://127.0.0.1/images/centos7.iso
qemu-nbd /home/berrange/demo.qcow2
This adds a --image-opts arg that i
Currently qemu-io allows an image filename to be passed on the
command line, but unless using the JSON format, it does not have
a way to set any options except the format eg
qemu-io https://127.0.0.1/images/centos7.iso
qemu-io /home/berrange/demo.qcow2
This adds a --image-opts arg that indicate
Allow creation of user creatable object types with qemu-img
via a new --object command line arg. This will be used to supply
passwords and/or encryption keys to the various block driver
backends via the recently added 'secret' object type.
# printf letmein > mypasswd.txt
# qemu-img info --object
The QMP monitor code has two helper methods object_add
and qmp_object_del that are called from several places
in the code (QMP, HMP and main emulator startup).
The HMP and main emulator startup code also share
further logic that extracts the qom-type & id
values from a qdict.
We soon need to use
This series of patches expands the syntax of the qemu-img,
qemu-nbd and qemu-io commands to make them more flexible.
v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html
v2: https://lists.gnu.org/archi
Allow creation of user creatable object types with qemu-nbd
via a new --object command line arg. This will be used to supply
passwords and/or encryption keys to the various block driver
backends via the recently added 'secret' object type.
# printf letmein > mypasswd.txt
# qemu-nbd --object secr
On 21/01/2016 17:37, Daniel P. Berrange wrote:
> This is an update of the series previously posted:
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg06126.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg01580.html
> v3: https://lists.gnu.org/archive/html
For now it merely invokes block-dirty-bitmap-{add,set-persistent}.
Verification of the bitmap data and user data to be added in the future.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/141 | 62 ++
tests/qemu-iotests/141.out | 5
tests/qem
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/004 | 2 +-
tests/qemu-iotests/017 | 2 +-
tests/qemu-iotests/018 | 2 +-
tests/qemu-iotests/019 | 2 +-
tests/qemu-iotests/020 | 2 +-
tests/qemu-iotests/024 | 2 +-
tests/qemu-iotests/025 | 2 +-
tests/qemu-iotests/027 | 2 +-
tests/qemu-iotests/0
The output of "qemu-img map" will be slightly different for qbm because
the data image paths are not $TEST_IMG, but the pattern is predicatable
enough so we can just filter it out.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/095 | 2 +-
tests/qemu-iotests/097 | 4 +++-
2 files changed, 4 ins
Signed-off-by: Fam Zheng
---
blockdev.c | 20
qapi/block-core.json | 22 ++
qmp-commands.hx | 31 +++
3 files changed, 73 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 08236f2..a9d6617 100644
--- a/blo
Signed-off-by: Fam Zheng
---
qapi/block-core.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 52689ed..97dc0cd 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1599,7 +1599,7 @@
{ 'enum': 'BlockdevDriver'
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/140 | 80 +
tests/qemu-iotests/140.out | 145 +
tests/qemu-iotests/common | 6 ++
tests/qemu-iotests/group | 1 +
4 files changed, 232 insertions(+)
create mode 100755
Persistent dirty bitmaps are special because they're tightly associated
with, or even belonging to the driver, swapping them doesn't make much
sense. Because this has nothing to do with backward compatibility, it's
okay to just let them stay with the old BDS.
Signed-off-by: Fam Zheng
---
block.c
Though a number of test cases dosn't apply because of cluster size and
blkdebug limitation, mirroring qbm can be covered by all other cases.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/041 | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iote
Signed-off-by: Fam Zheng
---
block/Makefile.objs |1 +
block/qbm.c | 1315 +++
2 files changed, 1316 insertions(+)
create mode 100644 block/qbm.c
diff --git a/block/Makefile.objs b/block/Makefile.objs
index cdd8655..ba7 100644
---
When omitted it defaults to false with unchanged behavior.
When set to true, the created dirty bitmap is made persistent if supported, it
requires support from the active image format. Otherwise an error is returned.
Signed-off-by: Fam Zheng
---
blockdev.c | 8 +++-
qapi/block-cor
By implementing bdrv_dirty_bitmap_set_persistent, a driver can support
the persistent dirty bitmap feature.
Once a dirty bitmap is made persistent, the driver is responsible for saving
the dirty bitmap when appropriate, for example before close; if a persistent
bitmap is removed or made non-persis
Signed-off-by: Fam Zheng
---
docs/specs/qbm.md | 118 ++
1 file changed, 118 insertions(+)
create mode 100644 docs/specs/qbm.md
diff --git a/docs/specs/qbm.md b/docs/specs/qbm.md
new file mode 100644
index 000..b91910b
--- /dev/null
+++ b/
Signed-off-by: Fam Zheng
---
block/io.c| 2 +-
include/block/block.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index b964e7e..15e461f 100644
--- a/block/io.c
+++ b/block/io.c
@@ -425,7 +425,7 @@ void bdrv_round_to_clusters(BlockDriv
With the return value decoupled from VMDK, it can be reused by other block
code.
Signed-off-by: Fam Zheng
---
block.c | 40
block/vmdk.c | 40
include/block/block.h | 2 ++
3 files changed,
So that driver can write the dirty bits into persistent dirty bitmaps in
the write callback.
Signed-off-by: Fam Zheng
---
block/io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 343ff1f..b964e7e 100644
--- a/block/io.c
+++ b/block/io.c
@@
If the driver owns some dirty bitmaps, this assertion will fail.
The correct place to release them is in bdrv_close, so move the
assertion one line down.
Signed-off-by: Fam Zheng
---
block.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index afb71c0..f
Hi all,
This series introduces a simple format to enable support of persistence of
block dirty bitmaps. Block dirty bitmap is the tool to achieve incremental
backup, and persistence of block dirty bitmap makes incrememtal backup possible
across VM shutdowns, where existing in-memory dirty bitmaps
Am 25.01.2016 um 19:41 hat Max Reitz geschrieben:
> An error during negotiation, e.g. by the client trying to open an export
> that does not exist, should not lead to a crash of the server process.
>
> The middle six patches of this series are taken from my series
> "block: Rework bdrv_close_all()
On 26/01/2016 10:32, Kevin Wolf wrote:
> Am 25.01.2016 um 19:41 hat Max Reitz geschrieben:
>> > Use client_close() if an error in nbd_co_client_start() occurs instead
>> > of manually inlining parts of it. This fixes an assertion error on the
>> > server side if nbd_negotiate() fails.
>> >
>> >
Am 25.01.2016 um 19:41 hat Max Reitz geschrieben:
> Use client_close() if an error in nbd_co_client_start() occurs instead
> of manually inlining parts of it. This fixes an assertion error on the
> server side if nbd_negotiate() fails.
>
> Signed-off-by: Max Reitz
Paolo, if you can Ack this one,
Am 26.01.2016 um 08:09 hat Markus Armbruster geschrieben:
> Max Reitz writes:
>
> > Image formats used in test 118 need to support image creation.
> >
> > Reported-by: Markus Armbruster
> > Signed-off-by: Max Reitz
> > ---
> > tests/qemu-iotests/118 | 4 +++-
> > 1 file changed, 3 insertions(+
Am 26.01.2016 um 04:16 hat Fam Zheng geschrieben:
> On Mon, 01/25 12:16, Kevin Wolf wrote:
> > Am 25.01.2016 um 03:26 hat Fam Zheng geschrieben:
> > > Commit d62d9dc4b8 lifted streamOptimized images's version to 3, but we
> > > now refuse to open version 3 images read-write. We need to make
> > >
On Tue, 01/26 10:49, Vladimir Sementsov-Ogievskiy wrote:
> On 26.01.2016 09:25, Fam Zheng wrote:
> >On Fri, 01/22 15:05, Vladimir Sementsov-Ogievskiy wrote:
> >>>In my migration series I need iterators, get granularity, and
> >>>something like hbitmap_count for meta bitmaps. You can add them
> >>>
59 matches
Mail list logo
