On Tue, Mar 15, 2016 at 03:52:02PM -0400, Jeff Cody wrote:
> On Tue, Mar 15, 2016 at 03:50:17PM -0400, Jeff Cody wrote:
> > On Thu, Mar 10, 2016 at 07:38:00PM +0100, Niels de Vos wrote:
> > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
> > > it possible to detect sparse a
On 03/11/2016 08:21 PM, Alberto Garcia wrote:
> On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote:
>> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {
>> bool rewrite_corrupted;/* true if the driver must rewrite-on-read
>> corrupted
>> * block if Quorum is
Test vm can launch and print output in case of fail. This function is
needed for testing erroneous cases
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 20
1 file changed, 20 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/q
The funcion loads dirty bitmap from file, using underlying driver
function.
Note: the function doesn't change BdrvDirtyBitmap.file field. This field
is only used by bdrv_store_dirty_bitmap() function and is ONLY written
by bdrv_dirty_bitmap_set_file() function.
Signed-off-by: Vladimir Sementsov-O
Adds qcow2_read_bitmaps, reading bitmap directory as
specified in docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 165 +
block/qcow2.h | 10 +++
2 files changed, 175 insertions(+)
diff --
This function stores block dirty bitmap to qcow2. If the bitmap with
the same name, size and granularity already exists, it will be
rewritten, if the bitmap with the same name exists but granularity or
size does not match, an error will be genrated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
From: Fam Zheng
For dirty bitmap users to get the size and the name of a
BdrvDirtyBitmap.
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 10 ++
include/block/dirty-bitmap.h | 2 ++
2 files changed, 12 in
Check, that bitmap is stored to the owning bs.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 12
block/qcow2-dirty-bitmap.c | 5 +
include/block/dirty-bitmap.h | 2 ++
3 files changed, 19 insertions(+)
diff --git a/block/dirty-bitmap.c b/blo
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 1 +
include/qemu/hbitmap.h | 8
qapi/block-core.json | 5 -
util/hbitmap.c | 8
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a
If this flag is unset and exta data present the bitmap should be
read-only. For now just return error for this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 8
1 file changed, 8 insertions(+)
diff --git a/block/qcow2-dirty-bitmap.c b/block/qcow2-dir
Add functions for load/store HBitmap to BDS, using clusters table:
Last level of the bitmap is splitted into chunks of 'cluster_size'
size. Each cell of the table contains offset in bds, to load/store
corresponding chunk.
Also,
0 in cell means all-zeroes-chunk (should not be saved)
1 in ce
This function loads block dirty bitmap from qcow2.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 110 +
block/qcow2.c | 2 +
block/qcow2.h | 3 ++
include/block/block_int.h | 4 ++
4 files
The patch adds the following command line option:
-dirty-bitmap [option1=val1][,option2=val2]...
Avaliable options are:
name
The name of the bitmap.
Should be unique per 'file'/'node' and per 'for_node'.
node
The node to load and bind the bitmap.
It should be specified as 'id' suboption of one
Add autoclear bit for handling rewriting image by old qemu version.
If autoclear bit is not set, but bitmaps extension is found it
would not be loaded and warning will be generated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 4
block/qcow2.c
The only problem with it is the same qmp socket name (which is
vm._monitor_path) for all vms. And because of this second vm couldn't be
lauched (vm.launch() fails because of socket is already in use).
This patch adds a number of vm into vm._monitor_path
Reviewed-by: John Snow
Signed-off-by: Vladi
Make getter signature const-correct. This allows other functions with
const dirty bitmap parameter use bdrv_dirty_bitmap_granularity().
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 2 +-
include/block/dirty-bitmap
Persistent dirty bitmaps are the bitmaps, for which the new field
BdrvDirtyBitmap.file is not NULL. We save all persistent dirty bitmaps
owned by BlockDriverState in corresponding bdrv_close().
BdrvDirtyBitmap.file is a BlockDriverState, where we want to save the
bitmap. It may be set in bdrv_dirty
This flag is set on bitmap load and unset on store. If it is already
set when loading the bitmap, the bitmap should not be load (it is in
use by other drive or it is inconsistent (was not successfully saved))
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 45 +++
Add simple test cases for testing persistent dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/160| 112 ++
tests/qemu-iotests/160.out| 21
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iote
Add data structures and constraints accordingly to docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/Makefile.objs| 2 +-
block/qcow2-dirty-bitmap.c | 47 ++
block/qcow2.h | 34
Add dirty bitmap extension as specified in docs/specs/qcow2.txt.
Load bitmap headers on open. Handle close and update_header.
Handle resize: for now, just block resize if there are dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 89 +++
When testing migration, auto-generated by qemu node-names differs in
source and destination qemu and migration fails. After this patch,
auto-generated by iotest nodenames will be the same.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 1 +
1 file changed, 1 inse
The function checks existing of the bitmap without loading it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 15 +++
block/qcow2-dirty-bitmap.c | 5 +
block/qcow2.c| 1 +
block/qcow2.h| 1 +
include/block/block
This series add persistent dirty bitmaps feature to qcow2.
Specification is in docs/spec/qcow2.txt
v5:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v5
Rebased on master. RFC removed. All necessary preparations are included.
changes:
patches 01-05 was n
The bitmap should be auto-loaded if auto flag is set.
For now, actually, there are no methods to set it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-dirty-bitmap.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-dirty-bitmap.c b/block
On 15.03.2016 23:04, Vladimir Sementsov-Ogievskiy wrote:
From: Fam Zheng
For dirty bitmap users to get the size and the name of a
BdrvDirtyBitmap.
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
it's an accidental s.o.b., actually there are no c
On Tue, Mar 15, 2016 at 03:50:17PM -0400, Jeff Cody wrote:
> On Thu, Mar 10, 2016 at 07:38:00PM +0100, Niels de Vos wrote:
> > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
> > it possible to detect sparse areas in files.
> >
> > Signed-off-by: Niels de Vos
> >
> > ---
>
On Thu, Mar 10, 2016 at 07:38:00PM +0100, Niels de Vos wrote:
> GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes
> it possible to detect sparse areas in files.
>
> Signed-off-by: Niels de Vos
>
> ---
> Tested by compiling and running "qemu-img map gluster://..." with a
> bu
From: Roman Kagan
When populating ACPI objects for floppy drives one needs to provide the
maximum values for cylinder, sector, and head number the drive supports.
This patch adds a function that iterates through the array of predefined
floppy drive formats and returns the maximum values of c, h,
Signed-off-by: Kevin Wolf
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 322ca03..e7b8676 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -4221,7 +4221,7 @@ QemuOptsList qemu_common_drive_opts = {
static QemuOptsList qemu_root_bds_o
On 10/03/2016 20:30, rutu.shah...@gmail.com wrote:
> From: Rutuja Shah
>
> ---
> audio/audio.c | 2 +-
> audio/noaudio.c | 4 ++--
> audio/spiceaudio.c| 2 +-
> audio/wavaudio.c | 2 +-
> backends/baum.c | 2 +-
> block/qed.c
On Tue, Mar 15, 2016 at 07:59:19AM -0600, Eric Blake wrote:
> On 02/29/2016 05:00 AM, Daniel P. Berrange wrote:
> > Add a block driver that is capable of supporting any full disk
> > encryption format. This utilizes the previously added block
> > encryption code, and at this time supports the LUKS
On 02/29/2016 05:00 AM, Daniel P. Berrange wrote:
> Add a block driver that is capable of supporting any full disk
> encryption format. This utilizes the previously added block
> encryption code, and at this time supports the LUKS format.
>
> The driver code is capable of supporting any format sup
On 14 March 2016 at 17:37, Kevin Wolf wrote:
> The following changes since commit 0dcee62261cb044339b10e4bda1f67ef7dc82803:
>
> Merge remote-tracking branch
> 'remotes/amit-migration/tags/migration-for-2.6-7' into staging (2016-03-14
> 13:51:21 +)
>
> are available in the git repository at
If there's an I/O error in one of Quorum children then QEMU
should emit QUORUM_REPORT_BAD. However this is not working with
read-pattern=fifo. This patch fixes this problem.
Signed-off-by: Alberto Garcia
---
block/quorum.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/148 | 17 +++--
tests/qemu-iotests/148.out | 4 ++--
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/148 b/tests/qemu-iotests/148
index 30bc379..d066ec3 100644
--- a/tests/qemu-iotests/148
+++
This is a follow-up to the "Separate QUORUM_REPORT_BAD events" series:
https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02402.html
If there's an I/O error in one of Quorum children then QEMU should
emit QUORUM_REPORT_BAD. However this is not working with
read-pattern=fifo. This patch f
37 matches
Mail list logo