Re: [Qemu-block] [Qemu-devel] [PATCH 03/12] block: Introduce BlockBackendPublic

2016-03-23 Thread Eric Blake
On 03/23/2016 03:09 AM, Kevin Wolf wrote: >>> +++ b/block/block-backend.c >>> @@ -33,6 +33,7 @@ struct BlockBackend { >>> DriveInfo *legacy_dinfo;/* null unless created by drive_new() */ >>> QTAILQ_ENTRY(BlockBackend) link; /* for block_backends */ >>>

Re: [Qemu-block] [PATCH 10/12] block: Drain throttling queue with BdrvChild callback

2016-03-23 Thread Paolo Bonzini
On 22/03/2016 16:33, Kevin Wolf wrote: > This removes the last part of I/O throttling from block/io.c and moves > it to the BlockBackend. > > When draining the queue of a BlockDriverState, we must make sure that no > new requests can come in for it. Request sources from outside the block >

Re: [Qemu-block] [Qemu-devel] [PATCH] quorum: add child name into filename

2016-03-23 Thread Max Reitz
On 18.03.2016 04:21, Wen Congyang wrote: > The monitor command 'query-block' or 'info block' will output the filename. > So we can get each children's child-name after this patch. This useful for > dynamic reconfiguration. > > Signed-off-by: Wen Congyang > --- >

Re: [Qemu-block] [PATCH v5 6/7] block: add generic full disk encryption driver

2016-03-23 Thread Eric Blake
On 03/18/2016 09:19 AM, Kevin Wolf wrote: +ov = opts_visitor_new(opts); + +visit_start_struct(opts_get_visitor(ov), + "luks", NULL, 0, _err); >>> >>> As this refers to "luks" specifically, shouldn't it be inside the switch >>> below? >> >> Or

Re: [Qemu-block] [PATCH] block: Remove bdrv_make_anon()

2016-03-23 Thread Max Reitz
On 18.03.2016 11:31, Kevin Wolf wrote: > The call in hmp_drive_del() is dead code because blk_remove_bs() is > called a few lines above. Ah, so that's why I didn't have it in v3. Thanks for solving that mystery for me. :-) > The only other remaining user is >

Re: [Qemu-block] [PATCH v4 00/17] blockdev: Further BlockBackend work

2016-03-23 Thread Max Reitz
On 17.03.2016 14:44, Kevin Wolf wrote: > Am 16.03.2016 um 19:54 hat Max Reitz geschrieben: >> This series appears to reinvent itself with every revision. This time, >> its main implication is that BBs are no longer automatically treated as >> monitor-owned, and that a BB's name is tightly tied to

Re: [Qemu-block] [PATCH for-2.6 0/7] block: VHD format fixes

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:37PM -0400, Jeff Cody wrote: > Fixes for a regression in vpc_create(), as well as a few issues with VHD > format > compatibility. > > > Jeff Cody (6): > block/vpc: fix VPC 'qemu-img create' regression > block/vpc: use current_size field for XenConverter VHD

Re: [Qemu-block] [PATCH v2 0/3] Various block-stream fixes

2016-03-23 Thread Jeff Cody
On Mon, Mar 21, 2016 at 03:47:24PM +0200, Alberto Garcia wrote: > This series is a follow-up to the patch I sent last week[1]. It > contains a few fixes from my intermediate block streaming branch, but > are independent from that feature, so they can be applied now without > problems. > > Berto >

Re: [Qemu-block] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > This fails silently as well, since vpc_create() did not set errp > in this failuer case. Set errp in all instances in vpc_create(). s/faileur/failure/ Can be done when merging, no need to resend. signature.asc Description: PGP

Re: [Qemu-block] [PATCH v6 00/11] Add new LUKS block driver (for 2.6)

2016-03-23 Thread Kevin Wolf
Am 21.03.2016 um 15:11 hat Daniel P. Berrange geschrieben: > This series is just the block layer parts needed to add > a LUKS driver to QEMU. It was previously posted as part > of the larger series > > v1: https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04748.html > v2:

Re: [Qemu-block] [PATCH v3 10/10] vnc: allow specifying a custom ACL object name

2016-03-23 Thread Daniel P. Berrange
On Tue, Mar 22, 2016 at 03:38:14PM -0600, Eric Blake wrote: > On 03/10/2016 11:59 AM, Daniel P. Berrange wrote: > > The VNC server has historically had support for ACLs to check > > both the SASL username and the TLS x509 distinguished name. > > The VNC server was responsible for creating the

Re: [Qemu-block] [PATCH v3 07/10] qemu-nbd: add support for ACLs for TLS clients

2016-03-23 Thread Daniel P. Berrange
On Tue, Mar 22, 2016 at 12:14:27PM -0600, Eric Blake wrote: > On 03/10/2016 11:59 AM, Daniel P. Berrange wrote: > > Currently any client which can complete the TLS handshake > > is able to use the NBD server. The server admin can turn > > on the 'verify-peer' option for the x509 creds to require >

Re: [Qemu-block] [PATCH v3 05/10] util: add QAuthZSimple object type for a simple access control list

2016-03-23 Thread Daniel P. Berrange
On Tue, Mar 22, 2016 at 11:38:53AM -0600, Eric Blake wrote: > On 03/10/2016 11:59 AM, Daniel P. Berrange wrote: > > Add a QAuthZSimple object type that implements the QAuthZ > > interface. This simple built-in implementation maintains > > a trivial access control list with a sequence of match > >

Re: [Qemu-block] [Qemu-devel] [PATCH 06/22] hbitmap: load/store

2016-03-23 Thread Vladimir Sementsov-Ogievskiy
On 23.03.2016 00:49, John Snow wrote: On 03/15/2016 04:04 PM, Vladimir Sementsov-Ogievskiy wrote: Add functions for load/store HBitmap to BDS, using clusters table: Last level of the bitmap is splitted into chunks of 'cluster_size' size. Each cell of the table contains offset in bds, to

Re: [Qemu-block] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Alberto Garcia
On Wed 23 Mar 2016 10:03:41 AM CET, Kevin Wolf wrote: >> This series would mess up my own I/O throttling cleanups that have >> been posted in February and have hardly seen a review for one month. > > Which cleanups? The ones that you hid in an I/O path locking series? > Whose

Re: [Qemu-block] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Kevin Wolf
[ Cc: Stefan ] Am 23.03.2016 um 10:28 hat Paolo Bonzini geschrieben: > On 23/03/2016 10:03, Kevin Wolf wrote: > > Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben: > >> On 22/03/2016 16:33, Kevin Wolf wrote: > >>> This is another feature that was "logically" part of the BlockBackend, but >

Re: [Qemu-block] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 10:03, Kevin Wolf wrote: > Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben: >> On 22/03/2016 16:33, Kevin Wolf wrote: >>> This is another feature that was "logically" part of the BlockBackend, but >>> implemented as a BlockDriverState feature. It was always kept on top using

Re: [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-23 Thread Christian Borntraeger
On 03/23/2016 10:08 AM, Paolo Bonzini wrote: > > > On 23/03/2016 09:10, Cornelia Huck wrote: >>> -/* Kick right away to begin processing requests already in vring */ >>> -event_notifier_set(virtio_queue_get_host_notifier(s->vq)); >>> +vblk->dataplane_started = true; >>> >>> -/*

Re: [Qemu-block] [Qemu-devel] [PATCH 03/12] block: Introduce BlockBackendPublic

2016-03-23 Thread Kevin Wolf
Am 22.03.2016 um 22:53 hat Eric Blake geschrieben: > On 03/22/2016 09:33 AM, Kevin Wolf wrote: > > Some features, like I/O throttling, are implemented outside > > block-backend.c, but still want to keep BlockBackends in a list. In > > order to avoid exposing the whole struct layout in the public

Re: [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-23 Thread Paolo Bonzini
On 23/03/2016 09:10, Cornelia Huck wrote: >> -/* Kick right away to begin processing requests already in vring */ >> -event_notifier_set(virtio_queue_get_host_notifier(s->vq)); >> +vblk->dataplane_started = true; >> >> -/* Get this show started by hooking up our callbacks */ >> +

Re: [Qemu-block] [PATCH 00/12] block: Move I/O throttling to BlockBackend

2016-03-23 Thread Kevin Wolf
Am 22.03.2016 um 22:33 hat Paolo Bonzini geschrieben: > On 22/03/2016 16:33, Kevin Wolf wrote: > > This is another feature that was "logically" part of the BlockBackend, but > > implemented as a BlockDriverState feature. It was always kept on top using > > swap_feature_fields(). > > > > This

Re: [Qemu-block] [PATCH 20/22] iotests: test internal persistent dirty bitmap

2016-03-23 Thread Vladimir Sementsov-Ogievskiy
On 22.03.2016 21:27, Eric Blake wrote: On 03/15/2016 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: Add simple test cases for testing persistent dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/160| 112

Re: [Qemu-block] [PATCH 10/22] qcow2-dirty-bitmap: add qcow2_bitmap_store()

2016-03-23 Thread Vladimir Sementsov-Ogievskiy
On 22.03.2016 21:49, Eric Blake wrote: On 03/15/2016 02:04 PM, Vladimir Sementsov-Ogievskiy wrote: This function stores block dirty bitmap to qcow2. If the bitmap with the same name, size and granularity already exists, it will be rewritten, if the bitmap with the same name exists but

Re: [Qemu-block] [PATCH 4/4] virtio-blk: Clean up start/stop with mutex and BH

2016-03-23 Thread Cornelia Huck
On Tue, 22 Mar 2016 19:05:09 +0100 Paolo Bonzini wrote: > On 22/03/2016 13:52, Fam Zheng wrote: > >> You're right. After unrealizing virtio_blk_data_plane_stop has set of > >> vblk->dataplane_started = false, so that's covered. However, you still > >> need an