Re: [Qemu-block] [Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread John Snow
On 08/18/2016 05:48 AM, Hervé Poussineau wrote: This fixes Windows NT4 startup when a cdrom is inserted. Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 Signed-off-by: Hervé Poussineau --- hw/ide/atapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-block] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread Kevin Wolf
Am 18.08.2016 um 11:48 hat Hervé Poussineau geschrieben: > This fixes Windows NT4 startup when a cdrom is inserted. > > Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 > Signed-off-by: Hervé Poussineau Hm, which of the paths in cmd_read_cd() does this hit? Is it the one

Re: [Qemu-block] [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:50, Vladimir Sementsov-Ogievskiy wrote: > > from nbd proto.md: > > "Finally, it SHOULD return |EPERM| if it receives a write or trim > request on a read-only export." > > And EROFS is not mentioned in proto.md > > (however the same bug is in NBD_CMD_WRITE case.)

Re: [Qemu-block] [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-08-18 Thread Vladimir Sementsov-Ogievskiy
On 19.07.2016 07:08, Eric Blake wrote: Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. Signed-off-by: Eric Blake --- v4: rebase, fix

Re: [Qemu-block] [Qemu-devel] [PATCH for 2.7 0/2] block: fixes for deadlock in flush code

2016-08-18 Thread Stefan Hajnoczi
On Wed, Aug 17, 2016 at 09:06:52PM +0300, Denis V. Lunev wrote: > We have suffered from the following deadlock > > Thread 2 (Thread 0x7f1b7edf9700 (LWP 240293)): > #0 0x7f1bd1f0675f in ppoll () from /lib64/libc.so.6 > #1 0x7f1bd8c1d78b in ppoll (__ss=0x0, __timeout=0x0, __nfds= out>,

Re: [Qemu-block] [Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471513714-11709-1-git-send-email-hpous...@reactos.org Subject: [Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-block] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread Hervé Poussineau
This fixes Windows NT4 startup when a cdrom is inserted. Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 Signed-off-by: Hervé Poussineau --- hw/ide/atapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index