Re: [Qemu-block] [PATCH v3 2/2] qemu: use bdrv_flush_all for vm_stop et al

2016-09-16 Thread John Snow
On 09/15/2016 07:42 PM, John Snow wrote: Bypass the usual check to see if we are "allowed" to flush via the block model, and manually flush the BDS nodes themselves instead. This allows us to do things like migrate when we have a device with an open tray, but has a node that may need to be

Re: [Qemu-block] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-16 Thread John Snow
On 09/16/2016 04:33 AM, Kevin Wolf wrote: Am 16.09.2016 um 01:42 hat John Snow geschrieben: One more try. The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed.

Re: [Qemu-block] [PATCH] block: Fix 'since' for compressed Drive/BlockdevBackup

2016-09-16 Thread Eric Blake
On 09/16/2016 10:43 AM, Kevin Wolf wrote: > These patches missed 2.7, update the QAPI documentation. > > Reported-by: Eric Blake > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-block] [PATCH] block: Fix 'since' for compressed Drive/BlockdevBackup

2016-09-16 Thread Kevin Wolf
These patches missed 2.7, update the QAPI documentation. Reported-by: Eric Blake Signed-off-by: Kevin Wolf --- qapi/block-core.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index

Re: [Qemu-block] [Qemu-devel] [PULL 27/42] blockdev-backup: added support for data compression

2016-09-16 Thread Eric Blake
On 09/05/2016 01:13 PM, Kevin Wolf wrote: > From: Pavel Butsykin > > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > +++ b/qapi/block-core.json > @@

Re: [Qemu-block] [Qemu-devel] [PULL 26/42] drive-backup: added support for data compression

2016-09-16 Thread Eric Blake
On 09/05/2016 01:13 PM, Kevin Wolf wrote: > From: Pavel Butsykin > > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. > > The patch adds a flag to the

Re: [Qemu-block] [Qemu-devel] [PULL 00/42] Block layer patches

2016-09-16 Thread Peter Lieven
Am 06.09.2016 um 12:36 schrieb Kevin Wolf: Am 06.09.2016 um 12:12 hat Peter Maydell geschrieben: On 5 September 2016 at 19:13, Kevin Wolf wrote: The following changes since commit e87d397e5ef66276ccc49b829527d605ca07d0ad: Open 2.8 development tree (2016-09-05 11:38:54

Re: [Qemu-block] [PATCH v2 0/7] Add "read-only" to the options QDict

2016-09-16 Thread Kevin Wolf
Am 15.09.2016 um 16:52 hat Alberto Garcia geschrieben: > This series adds "read-only" to the options QDict, fixing a > long-standing problem with the reopening code. > >[E] <- [D] <- [C] <- [B] <- [A] > > In a normal scenario, the active layer [A] is in read-write mode and > everything else

Re: [Qemu-block] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-16 Thread Denis V. Lunev
On 09/16/2016 11:08 AM, Kevin Wolf wrote: > Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: >> On 09/15/2016 07:09 PM, Kevin Wolf wrote: >>> Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: This mode could be very useful for flush bottlenecks evaluation and for running

Re: [Qemu-block] [Qemu-devel] [PATCH] hmp: Remove dead code in hmp_qemu_io()

2016-09-16 Thread Marc-André Lureau
On Thu, Sep 15, 2016 at 7:50 PM Kevin Wolf wrote: > blk can never be NULL, drop the check. This fixes a Coverity warning. > > Signed-off-by: Kevin Wolf > Reviewed-by: Marc-André Lureau > --- > hmp.c | 14 +- > 1

Re: [Qemu-block] [PATCH 1/1] tests: allow to specify list of formats to test for check-block.sh

2016-09-16 Thread Kevin Wolf
Am 15.09.2016 um 18:42 hat Denis V. Lunev geschrieben: > This would make code better and allow to test specific format. > > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Paolo Bonzini

Re: [Qemu-block] [PATCH v3 0/2] block: allow flush on devices with open tray

2016-09-16 Thread Kevin Wolf
Am 16.09.2016 um 01:42 hat John Snow geschrieben: > One more try. > > The move to blk_flush altered the behavior of migration and flushing > nodes that are not reachable via the guest, but are still reachable > via QEMU and may or may not need to be flushed. > > This is likely the simplest

Re: [Qemu-block] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-16 Thread Kevin Wolf
Am 16.09.2016 um 10:15 hat Denis V. Lunev geschrieben: > On 09/16/2016 11:08 AM, Kevin Wolf wrote: > > Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: > >> On 09/15/2016 07:09 PM, Kevin Wolf wrote: > >>> Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: > This mode could be very

Re: [Qemu-block] [PATCH 1/1] block: add cache mode with direct IO and without flushes

2016-09-16 Thread Kevin Wolf
Am 15.09.2016 um 18:39 hat Denis V. Lunev geschrieben: > On 09/15/2016 07:09 PM, Kevin Wolf wrote: > > Am 15.09.2016 um 15:19 hat Denis V. Lunev geschrieben: > >> This mode could be very useful for flush bottlenecks evaluation and for > >> running non-persistent VMs, when host crash is considered