Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

On 11/02/2016 03:49 PM, Hervé Poussineau wrote: Le 01/11/2016 à 04:16, John Snow a écrit : v2: - Actually applied the changes this time ... - And added a test to the AHCI suite... - ...Which revealed a few small issues in the suite. The AHCI test should be sufficient in terms of general

Re: [Qemu-block] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

Le 01/11/2016 à 04:16, John Snow a écrit : v2: - Actually applied the changes this time ... - And added a test to the AHCI suite... - ...Which revealed a few small issues in the suite. The AHCI test should be sufficient in terms of general proof for ATAPI regardless of the HBA used. All

Re: [Qemu-block] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol

On Wed, Nov 02, 2016 at 06:55:38PM +0100, Max Reitz wrote: > A follow-up patch will remove the curl block driver's TFTP support, so > remove the protocol from the QAPI schema. > > Signed-off-by: Max Reitz > --- > docs/qmp-commands.txt | 2 +- > qapi/block-core.json | 7

Re: [Qemu-block] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support

On Wed, Nov 02, 2016 at 06:55:37PM +0100, Max Reitz wrote: > A follow-up patch will remove the curl block driver's TFTP support; > therefore, we should no longer mention it anywhere in our documentation. > > Signed-off-by: Max Reitz > --- > qemu-options.hx | 6 +++--- > 1

Re: [Qemu-block] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). > > I would consider this series a bug fix because, well, it doesn't really > change any

Re: [Qemu-block] [PULL v2 00/14] Block patches for 2.8

On 2 November 2016 at 17:03, Stefan Hajnoczi wrote: > On Tue, Nov 01, 2016 at 08:50:57AM -0400, Jeff Cody wrote: >> The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1: >> >> Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into

[Qemu-block] [PATCH for-2.8? 2/3] qapi: Drop curl's TFTP protocol

A follow-up patch will remove the curl block driver's TFTP support, so remove the protocol from the QAPI schema. Signed-off-by: Max Reitz --- docs/qmp-commands.txt | 2 +- qapi/block-core.json | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[Qemu-block] [PATCH for-2.8? 3/3] block/curl: Drop TFTP "support"

Because TFTP does not support byte ranges, it was never usable with our curl block driver. Since apparently nobody has ever complained loudly enough for someone to take care of the issue until now, it seems reasonable to assume that nobody has ever actually used it. Therefore, it should be safe

[Qemu-block] [PATCH for-2.8? 1/3] qemu-options: Drop mentions of curl's TFTP support

A follow-up patch will remove the curl block driver's TFTP support; therefore, we should no longer mention it anywhere in our documentation. Signed-off-by: Max Reitz --- qemu-options.hx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx

[Qemu-block] [PATCH v3 6/6] iotests: add transactional failure race test

Add a regression test for the case found by Vladimir. Reported-by: Vladimir Sementsov-Ogievskiy Signed-off-by: John Snow --- tests/qemu-iotests/124 | 53 ++ tests/qemu-iotests/124.out | 4 ++-- 2 files

[Qemu-block] [PATCH for-2.8? 0/3] block/curl: Drop TFTP "support"

See patch 3 for the reason why we have actually never supported TFTP at all (except for very small files (i.e. below 256 kB or so)). I would consider this series a bug fix because, well, it doesn't really change any functionality, and the bug is "We don't support TFTP but we pretend we do".

[Qemu-block] [PATCH v3 2/6] blockjob: add .clean property

Cleaning up after we have deferred to the main thread but before the transaction has converged can be dangerous and result in deadlocks if the job cleanup invokes any BH polling loops. A job may attempt to begin cleaning up, but may induce another job to enter its cleanup routine. The second job,

[Qemu-block] [PATCH v3 0/6] jobs: fix transactional race condition

There are a few problems with transactional job completion right now. First, if jobs complete so quickly they complete before remaining jobs get a chance to join the transaction, the completion mode can leave well known state and the QLIST can get corrupted and the transactional jobs can complete

[Qemu-block] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create

Refactor backup_start as backup_job_create, which only creates the job, but does not automatically start it. The old interface, 'backup_start', is not kept in favor of limiting the number of nearly-identical interfaces that would have to be edited to keep up with QAPI changes in the future.

[Qemu-block] [PATCH v3 4/6] blockjob: add block_job_start

Instead of automatically starting jobs at creation time via backup_start et al, we'd like to return a job object pointer that can be started manually at later point in time. For now, add the block_job_start mechanism and start the jobs automatically as we have been doing, with conversions

[Qemu-block] [PATCH v3 1/6] blockjob: fix dead pointer in txn list

From: Vladimir Sementsov-Ogievskiy Though it is not intended to be reached through normal circumstances, if we do not gracefully deconstruct the transaction QLIST, we may wind up with stale pointers in the list. The rest of this series attempts to address the

Re: [Qemu-block] [PULL v2 00/14] Block patches for 2.8

On Tue, Nov 01, 2016 at 08:50:57AM -0400, Jeff Cody wrote: > The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1: > > Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into > staging (2016-11-01 11:21:02 +) > > are available in the git

Re: [Qemu-block] [PATCH v2 3/3] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

Am 02.11.2016 um 16:01 hat John Snow geschrieben: > > > On 11/02/2016 09:33 AM, Kevin Wolf wrote: > >Am 01.11.2016 um 04:16 hat John Snow geschrieben: > >>Commit 9ef2e93f introduced the concept of tagging ATAPI commands as > >>NONDATA, but this introduced a regression for certain commands better

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

On 11/02/2016 06:15 AM, Kevin Wolf wrote: > Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben: >> Sorry for a bit late response. The function looks fine but just some >> doubt on g_renew in this piece of code(and the legacy), does >> g_renew(realloc) has much performance impact if it's call many

Re: [Qemu-block] [PATCH v2 3/3] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

On 11/02/2016 09:33 AM, Kevin Wolf wrote: Am 01.11.2016 um 04:16 hat John Snow geschrieben: Commit 9ef2e93f introduced the concept of tagging ATAPI commands as NONDATA, but this introduced a regression for certain commands better described as CONDDATA. read_cd is such a command that both

Re: [Qemu-block] [PATCH 00/19] block: Fix some filename generation issues

On Tue 26 Apr 2016 11:31:59 PM CEST, Max Reitz wrote: > There are some issues regarding filename generation right now: > > - You always get a JSON filename if you set even a single qcow2-specific > runtime options (as long as it does not have a dot in it, which is a > bug, too, but here it is

Re: [Qemu-block] [PATCH 00/19] block: Fix some filename generation issues

On 02.11.2016 16:00, Alberto Garcia wrote: > On Tue 26 Apr 2016 11:31:59 PM CEST, Max Reitz wrote: > >> There are some issues regarding filename generation right now: >> >> - You always get a JSON filename if you set even a single qcow2-specific >> runtime options (as long as it does not have a

Re: [Qemu-block] [PATCH v2 0/3] atapi: classify read_cd as conditionally returning data

Am 01.11.2016 um 04:16 hat John Snow geschrieben: > v2: > - Actually applied the changes this time ... > - And added a test to the AHCI suite... > - ...Which revealed a few small issues in the suite. > > The AHCI test should be sufficient in terms of general proof > for ATAPI regardless of the

Re: [Qemu-block] [PATCH v2 3/3] ahci-test: test atapi read_cd with bcl, nb_sectors = 0

Am 01.11.2016 um 04:16 hat John Snow geschrieben: > Commit 9ef2e93f introduced the concept of tagging ATAPI commands as > NONDATA, but this introduced a regression for certain commands better > described as CONDDATA. read_cd is such a command that both requires > a non-zero BCL if a transfer size

Re: [Qemu-block] ping Re: [PATCH 00/18] Dirty bitmaps postcopy migration

On 11/02/2016 02:13 PM, Stefan Hajnoczi wrote: > On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> ping >> >> For now there are some notes mostly about accessory patches. What about >> migration itself? Is it ok? Has it a chance of being merged one day? > This series

Re: [Qemu-block] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

在 2016-11-02 19:15, Kevin Wolf 写道: Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben: Sorry for a bit late response. The function looks fine but just some doubt on g_renew in this piece of code(and the legacy), does g_renew(realloc) has much performance impact if it's call many times since

Re: [Qemu-block] [PATCH 2/3] block: Emit modules in bdrv_iterate_format()

Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben: > Sorry for a bit late response. The function looks fine but just some > doubt on g_renew in this piece of code(and the legacy), does > g_renew(realloc) has much performance impact if it's call many times > since alloc and memory copy are both

Re: [Qemu-block] [PATCH v2] block/ssh: Code cleanup for unused parameter

Am 02.11.2016 um 11:53 hat Ashijeet Acharya geschrieben: > This patch drops the unused parameter "BDRVSSHState" being passed into > the ssh_config() function and does code cleanup. The unused parameter > was introduced by the commit c322712. > > Signed-off-by: Ashijeet Acharya

Re: [Qemu-block] ping Re: [PATCH 00/18] Dirty bitmaps postcopy migration

On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > ping > > For now there are some notes mostly about accessory patches. What about > migration itself? Is it ok? Has it a chance of being merged one day? This series mostly touches migration/ code. Juan or DaveG? >

[Qemu-block] [PATCH v2] block/ssh: Code cleanup for unused parameter

This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and does code cleanup. The unused parameter was introduced by the commit c322712. Signed-off-by: Ashijeet Acharya --- Changes in v2: - Modify the commit message and subject

Re: [Qemu-block] [PATCH v3] block/nbd: Fix the leaked visitor

Am 02.11.2016 um 11:40 hat Ashijeet Acharya geschrieben: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. The leak was introduced by the commit 491d6c7. > > Signed-off-by: Ashijeet Acharya > Reviewed-by: Eric Blake

[Qemu-block] [PATCH v3] block/nbd: Fix the leaked visitor

This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake --- Changes in v3: - Modify the Subject line - Free

Re: [Qemu-block] [PATCH] block/ssh: Fix the regression of unused parameter

On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf wrote: > Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: >> This patch drops the unused parameter "BDRVSSHState" being passed into >> the ssh_config() function and fixes the bug. >> >> Signed-off-by: Ashijeet Acharya

Re: [Qemu-block] [PATCH v2] block/nbd: Fix the regression to free leaked visitor

On Wed, Nov 2, 2016 at 4:00 PM, Kevin Wolf wrote: > Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben: >> This patch frees the leaked visitor in nbd_refresh_filename() and uses >> visit_free() to fix it. The leak was introduced by the commit 491d6c7. >> >> Signed-off-by:

Re: [Qemu-block] [PATCH] block/ssh: Fix the regression of unused parameter

Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: > This patch drops the unused parameter "BDRVSSHState" being passed into > the ssh_config() function and fixes the bug. > > Signed-off-by: Ashijeet Acharya The patch looks good, but why do claim that this is a

Re: [Qemu-block] [PATCH v2] block/nbd: Fix the regression to free leaked visitor

Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. The leak was introduced by the commit 491d6c7. > > Signed-off-by: Ashijeet Acharya > Reviewed-by: Eric Blake

[Qemu-block] [PATCH v2] block/nbd: Fix the regression to free leaked visitor

This patch frees the leaked visitor in nbd_refresh_filename() and uses visit_free() to fix it. The leak was introduced by the commit 491d6c7. Signed-off-by: Ashijeet Acharya Reviewed-by: Eric Blake --- Changes in v2: - Include the regression commit

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] migration: fix compiler warning on uninitialized variable

On 31/10/16 21:50, Jeff Cody wrote: > Some older GCC versions (e.g. 4.4.7) report a warning on an > uninitialized variable for 'request', even though all possible code > paths that reference 'request' will be initialized. To appease > these versions, initialize the variable to 0. > >