Re: [Qemu-block] null-co undefined read behavior

2017-06-12 Thread Fam Zheng
On Mon, 06/12 17:20, John Snow wrote: > I noticed while debugging an unrelated test that our use of the null > driver has a habit of making functions like find_image_format trigger a > lot of uninitialized memory errors in valgrind, because it will return a > successful read without actually

Re: [Qemu-block] NVME: is there any plan to support SGL data transfer?

2017-06-12 Thread Qu Wenruo
At 06/12/2017 10:05 PM, Keith Busch wrote: On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote: Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben: When going through NVMe specification and hw/block/nvme.c, I found that it seems that NVMe qemu implementation only support PRP for sq

[Qemu-block] null-co undefined read behavior

2017-06-12 Thread John Snow
I noticed while debugging an unrelated test that our use of the null driver has a habit of making functions like find_image_format trigger a lot of uninitialized memory errors in valgrind, because it will return a successful read without actually touching the buffer. I see that in March there was

[Qemu-block] [PATCH 1/2] block/rbd: enable filename option and parsing

2017-06-12 Thread Jeff Cody
When enabling option parsing and blockdev-add for rbd, we removed the 'filename' option. Unfortunately, this was a bit optimistic, as previous versions of QEMU allowed the use of the option in backing filenames via json. This means that without parsing this option, we cannot open existing images

[Qemu-block] [PATCH 0/2] Parse 'filename' option for RBD/iSCSI

2017-06-12 Thread Jeff Cody
We need to be able to parse the 'filename' option for rbd and iscsi, because there may exist images in the wild that have json backing files, that specify the filename argument. Jeff Cody (2): block/rbd: enable filename option and parsing block/iscsi: enable filename option and parsing

[Qemu-block] [PATCH 2/2] block/iscsi: enable filename option and parsing

2017-06-12 Thread Jeff Cody
When enabling option parsing and blockdev-add for iscsi, we removed the 'filename' option. Unfortunately, this was a bit optimistic, as previous versions of QEMU allowed the use of the option in backing filenames via json. This means that without parsing this option, we cannot open existing

Re: [Qemu-block] [Qemu-devel] Fwd: [BUG] Failed to compile using gcc7.1

2017-06-12 Thread Max Reitz
On 2017-06-12 05:19, Philippe Mathieu-Daudé wrote: > Hi Tsung-en, > > On 06/11/2017 04:08 PM, Tsung-en Hsiao wrote: >> Hi all, >> I encountered the same problem on gcc 7.1.1 and found Qu's mail in >> this list from google search. >> >> Temporarily fix it by specifying the string length in

Re: [Qemu-block] [Qemu-devel] [RFC 0/2] Parse 'filename' option for RBD/iSCSI

2017-06-12 Thread Richard W.M. Jones
On Mon, Jun 12, 2017 at 12:05:12AM -0400, Jeff Cody wrote: > We need to be able to parse the 'filename' option for both rbd and iscsi, > because there may exist images in the wild that have json backing files, > that specify the filename argument. > > Marking the series as RFC at least partially

Re: [Qemu-block] NVME: is there any plan to support SGL data transfer?

2017-06-12 Thread Keith Busch
On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote: > Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben: > > When going through NVMe specification and hw/block/nvme.c, > > I found that it seems that NVMe qemu implementation only support PRP > > for sq entry. > > And NvmeRwCmd doesn't even

Re: [Qemu-block] [PATCH v3 0/4] block: fix 'savevm' hang with -object iothread

2017-06-12 Thread Stefan Hajnoczi
On Mon, May 22, 2017 at 02:57:00PM +0100, Stefan Hajnoczi wrote: > v3: > * Add missing bdrv_drain_all_end() in error code paths [Kevin] > v2: > * New patch to use bdrv_drain_all_begin/end() in savevm/loadvm [Kevin] >(All other patches unchanged) > > The 'savevm' command hangs when -object

Re: [Qemu-block] [PATCH v2 4/7] qcow2: Split do_perform_cow() into _read(), _encrypt() and _write()

2017-06-12 Thread Alberto Garcia
On Fri 09 Jun 2017 04:53:05 PM CEST, Eric Blake wrote: > Let's suppose we have a guest issuing 512-byte aligned requests and a > host that requires 4k alignment; and the guest does an operation that > needs a COW with one sector at both the front and end of the cluster. > >> @@ -760,22 +776,59 @@

Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block layer patches

2017-06-12 Thread Peter Maydell
On 7 June 2017 at 18:50, Kevin Wolf wrote: > The following changes since commit b55a69fe5f0a504dac6359bb7e99a72b130c3661: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170607' > into staging (2017-06-07 15:06:42 +0100) > > are available in the git