[Qemu-block] [PATCH for-2.10] qemu-img: Sort sub-command names in --help

'amend' was the only sub-command not listed alphabetically; hoist it earlier, and separate the @end table block to make it easier to copy-and-paste the addition of future sub-commands. Signed-off-by: Eric Blake --- qemu-img-cmds.hx | 9 ++--- 1 file changed, 6

Re: [Qemu-block] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/qcow2.c| 7 +++ > qapi/block-core.json | 6 +- > 2 files changed, 12 insertions(+), 1 deletion(-) > > +++ b/qapi/block-core.json > @@ -68,6 +68,9 @@ > # @encrypt: details about

Re: [Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format

On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/qcow2-cluster.c | 15 +++ > block/qcow2.c | 25 - > configure | 2 +- > docs/interop/qcow2.txt | 2 ++ > qapi/block-core.json | 15

Re: [Qemu-block] [PATCH 1/2] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

On 07/25/2017 04:28 PM, John Snow wrote: > > > On 07/21/2017 02:32 PM, Eric Blake wrote: >> We've been documenting the value in bytes since its introduction >> in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. >> >> Commit e4654d2 (v2.0) then removed things from block/qapi.c,

Re: [Qemu-block] [PATCH V5 04/10] qemu-img: add documentation for compress settings

On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > qemu-img.texi | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index 72dabd6..3612c59 100644 > --- a/qemu-img.texi > +++

Re: [Qemu-block] [PATCH V5 03/10] block/qcow2: parse compress create options

On 07/25/2017 09:41 AM, Peter Lieven wrote: > this adds parsing and validation for the compress create > options. They are only validated but not yet used. > > Signed-off-by: Peter Lieven > --- > block/qcow2.c | 86 > +-- >

Re: [Qemu-block] [PATCH 1/2] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

On 07/21/2017 02:32 PM, Eric Blake wrote: We've been documenting the value in bytes since its introduction in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. Commit e4654d2 (v2.0) then removed things from block/qapi.c, in preparation for a rewrite to a list of dirty sectors

[Qemu-block] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input

From: Markus Armbruster Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the commit before previous. The case in qpci_plug_device_test() is a bit complicated: it interpolates several JSON object members, not just a

Re: [Qemu-block] [PATCH V5 02/10] qapi/block-core: add Qcow2Compress parameters

On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > qapi/block-core.json | 40 > 1 file changed, 40 insertions(+) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 833c602..f652206 100644 >

[Qemu-block] [PATCH v3 08/12] qtests: convert tests to use qmp_cmd

Now that we have the qmp_cmd() helper, we can further simplify some of the tests by using it. Signed-off-by: Eric Blake --- tests/device-introspect-test.c | 3 +-- tests/ide-test.c | 2 +- tests/libqos/libqos.c | 5 +++-- tests/libqos/pci-pc.c

[Qemu-block] [PATCH v3 04/12] tests: Pass literal format strings directly to qmp_FOO()

From: Markus Armbruster The qmp_FOO() take a printf-like format string. In a few places, we assign a string literal to a variable and pass that instead of simply passing the literal. Clean that up. Bonus: gets rid of non-literal format strings. A step towards compile-time

Re: [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

On 07/25/2017 03:29 PM, Peter Lieven wrote: >>> + deflate: Standard zlib deflate compression without >>> +compression header >> Why did you name it "deflate" instead of "zlib" again? > > zlib provides raw deflate encoding and gzip encoding both with

Re: [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

Am 25.07.2017 um 17:03 schrieb Eric Blake: > On 07/25/2017 09:41 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> docs/interop/qcow2.txt | 51 >> +- >> roms/ipxe | 2 +- >> 2 files changed, 51

Re: [Qemu-block] [PATCH 2/2] iotests: Redirect stderr to stdout in 186

On 07/25/2017 10:56 AM, Max Reitz wrote: > Without redirecting qemu's stderr to stdout, _filter_qemu will not apply > to warnings. This results in $QEMU_PROG not being replaced by QEMU_PROG > which is not great if your qemu executable is not called > qemu-system-x86_64 (e.g. qemu-system-i386). >

Re: [Qemu-block] [PATCH 1/2] iotests: Fix test 156

On 07/25/2017 10:56 AM, Max Reitz wrote: > On one hand, the _make_test_img invocation for creating the target image > was missing a -u because its backing file is not supposed to exist at > that point. > > On the other hand, nobody noticed probably because the backing file is > created later on

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On 07/25/2017 12:24 PM, Daniel P. Berrange wrote: >> >> OK, let's abstract a bit more. Let's take this part of your statement: >> >> "if qemu-io in this environment cannot do aio=native" >> >> Let's call that a feature check. Depending on how the *feature check* >> is written, a negative

Re: [Qemu-block] [Qemu-devel] [PATCH v2] qemu-iotests: add a "how to" to ./README

On 07/25/2017 11:36 AM, Stefan Hajnoczi wrote: There is not much getting started documentation for qemu-iotests. This patch explains how to create a new test and covers the overall testing approach. Cc: Ishani Chugh Reviewed-by: Eric Blake

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote: > > > On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: > > On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: > >> On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: > >>> On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan

Re: [Qemu-block] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

On Tue, Jul 25, 2017 at 05:09:41PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 25, 2017 at 01:29:08PM +0300, Manos Pitsidianakis wrote: On Mon, Jul 24, 2017 at 04:12:47PM +0100, Stefan Hajnoczi wrote: > On Fri, Jul 14, 2017 at 12:45:18PM +0300, Manos Pitsidianakis wrote: > > ThrottleGroup is

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: > On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: >> On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: >>> On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan Hajnoczi wrote: On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa

Re: [Qemu-block] [Qemu-devel] [PULL 0/3] Block patches for 2.10-rc0

On 25 July 2017 at 16:12, Max Reitz wrote: > The following changes since commit 4c4414a4388f902b7ae2814f9a64898dd0e426a5: > > hw/display/sm501: Don't use vmstate_register_ram_global() (2017-07-25 > 13:04:28 +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

On Tue, Jul 25, 2017 at 01:29:08PM +0300, Manos Pitsidianakis wrote: > On Mon, Jul 24, 2017 at 04:12:47PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jul 14, 2017 at 12:45:18PM +0300, Manos Pitsidianakis wrote: > > > ThrottleGroup is converted to an object. This will allow the future > > > throttle

[Qemu-block] [PATCH 2/2] iotests: Redirect stderr to stdout in 186

Without redirecting qemu's stderr to stdout, _filter_qemu will not apply to warnings. This results in $QEMU_PROG not being replaced by QEMU_PROG which is not great if your qemu executable is not called qemu-system-x86_64 (e.g. qemu-system-i386). Signed-off-by: Max Reitz ---

[Qemu-block] [PATCH 0/2] iotests: Fixes to 156 and 186

This series contains some small fixes for issues I stumbled upon when preparing my pull request. Max Reitz (2): iotests: Fix test 156 iotests: Redirect stderr to stdout in 186 tests/qemu-iotests/156 | 4 ++-- tests/qemu-iotests/186 | 2 +- tests/qemu-iotests/186.out | 12

[Qemu-block] [PATCH 1/2] iotests: Fix test 156

On one hand, the _make_test_img invocation for creating the target image was missing a -u because its backing file is not supposed to exist at that point. On the other hand, nobody noticed probably because the backing file is created later on and _cleanup failed to remove it: The quotation marks

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

On Fri, Jul 21, 2017 at 10:21:24AM -0400, Cleber Rosa wrote: > On 07/21/2017 10:01 AM, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 01:33:25PM +0100, Stefan Hajnoczi wrote: > >> On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa wrote: > Without the static capabilities defined, the

Re: [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087

On Tue, Jul 25, 2017 at 04:45:46PM +0100, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2017 at 02:44:13PM +0800, Jing Liu wrote: > > On 2017/7/21 上午11:47, Cleber Rosa wrote: > > > One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO. > > > > > > As a PoC/RFC, this goes the easy route and

Re: [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087

On Mon, Jul 24, 2017 at 02:44:13PM +0800, Jing Liu wrote: > On 2017/7/21 上午11:47, Cleber Rosa wrote: > > One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO. > > > > As a PoC/RFC, this goes the easy route and skips the test as a whole > > when that feature is missing. Other approaches

[Qemu-block] [PATCH v2] qemu-iotests: add a "how to" to ./README

There is not much getting started documentation for qemu-iotests. This patch explains how to create a new test and covers the overall testing approach. Cc: Ishani Chugh Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

On 25 July 2017 at 16:20, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote: >> Should ./check be run from the source tree, or the build tree? The >> existing README text doesn't say and I don't think your additions >> do either. > > It

Re: [Qemu-block] [Qemu-devel] [PATCH for 2.10 06/35] qcow2: remove inconsistent check

On 24/07/2017 20:42, Eric Blake wrote: > On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote: >> This is equivalent to assert(russian roulette) so better remove it. >> >> block/qcow2-bitmap.c:259:29: warning: The left operand of '==' is a garbage >> value >> assert(bitmap_table == NULL);

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2-bitmap: fix bitmap_free

On 07/25/2017 10:02 AM, Philippe Mathieu-Daudé wrote: > Maybe worth adding "Coverity: CID 1377700" At this point, the PULL request is already posted, so it may be too late. But it's not the end of the world if we miss the extra comment. > > On 07/14/2017 01:00 PM, Max Reitz wrote: >> On

Re: [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README

On Mon, Jul 24, 2017 at 11:11:28AM +0200, Kevin Wolf wrote: > Am 21.07.2017 um 11:34 hat Stefan Hajnoczi geschrieben: > > +5. Generate the golden master file > > + > > +Run your test with "./check ". You may need to pass > > additional > > +options to use an image format or protocol. > >

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote: > On 21 July 2017 at 10:34, Stefan Hajnoczi wrote: > > There is not much getting started documentation for qemu-iotests. This > > patch explains how to create a new test and covers the overall testing > >

[Qemu-block] [PULL 3/3] qemu-iotests: Fix reference output for 186

From: Kevin Wolf Commits 70f17a1 ('error: Revert unwanted change of warning messages') and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge conflict, which results in failure for qemu-iotests case 186. Fix the reference output to consider the changes of 70f17a1.

[Qemu-block] [PULL 2/3] qcow2-bitmap: fix bitmap_free

From: Vladimir Sementsov-Ogievskiy Fix possible crash on error path in qcow2_remove_persistent_dirty_bitmap. Although bitmap_free was added in 88ddffae8fc the bug was introduced later in commit 469c71edc72 (when qcow2_remove_persistent_dirty_bitmap was added).

[Qemu-block] [PULL 0/3] Block patches for 2.10-rc0

The following changes since commit 4c4414a4388f902b7ae2814f9a64898dd0e426a5: hw/display/sm501: Don't use vmstate_register_ram_global() (2017-07-25 13:04:28 +0100) are available in the git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2017-07-25 for you to fetch changes

[Qemu-block] [PULL 1/3] qcow: fix memory leaks related to encryption

From: "Daniel P. Berrange" Fix leak of the 'encryptopts' string, which was mistakenly declared const. Fix leak of QemuOpts entry which should not have been deleted from the opts array. Reported by: coverity Signed-off-by: Daniel P. Berrange

Re: [Qemu-block] [PATCH] qemu-iotests: Fix reference output for 186

On 2017-07-25 10:59, Kevin Wolf wrote: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to consider the changes

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2-bitmap: fix bitmap_free

Maybe worth adding "Coverity: CID 1377700" On 07/14/2017 01:00 PM, Max Reitz wrote: On 2017-07-14 14:33, Vladimir Sementsov-Ogievskiy wrote: Fix possible crash on error path in qcow2_remove_persistent_dirty_bitmap. Although bitmap_free was added in 88ddffae8fc the bug was introduced later in

Re: [Qemu-block] [PATCH] qemu-iotests: Fix reference output for 186

On 2017-07-25 10:59, Kevin Wolf wrote: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to consider the changes

Re: [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > docs/interop/qcow2.txt | 51 > +- > roms/ipxe | 2 +- > 2 files changed, 51 insertions(+), 2 deletions(-) > > + > +== Compress format

[Qemu-block] [PATCH V5 04/10] qemu-img: add documentation for compress settings

Signed-off-by: Peter Lieven --- qemu-img.texi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 72dabd6..3612c59 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -676,6 +676,32 @@ file which is COW and has data

[Qemu-block] [PATCH V5 08/10] block/qcow2: start using the compress format extension

we now pass the parameters to the zlib compressor if the extension is present and use the old default values if the extension is absent. Signed-off-by: Peter Lieven --- block/qcow2-cluster.c | 58 ++- block/qcow2.c | 53

[Qemu-block] [PATCH V5 07/10] block/qcow2: optimize qcow2_co_pwritev_compressed

if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ffe609d..a12b3d7 100644 ---

[Qemu-block] [PATCH V5 05/10] block/qcow2: read and write the compress format extension

we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven --- block/qcow2.c | 92 +++ block/qcow2.h | 21 ++ 2 files changed, 108 insertions(+), 5 deletions(-)

[Qemu-block] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

Signed-off-by: Peter Lieven --- block/qcow2.c| 7 +++ qapi/block-core.json | 6 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 0e9c2b8..7e03877 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3968,6 +3968,13

[Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format

Signed-off-by: Peter Lieven --- block/qcow2-cluster.c | 15 +++ block/qcow2.c | 25 - configure | 2 +- docs/interop/qcow2.txt | 2 ++ qapi/block-core.json | 15 --- qemu-img.texi | 1 + 6 files

[Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension

Signed-off-by: Peter Lieven --- docs/interop/qcow2.txt | 51 +- roms/ipxe | 2 +- 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index d7fdb1f..d0d2a8f

[Qemu-block] [PATCH V5 00/10] add Qcow2 compress format extension

this adds a create option for Qcow2 images to specify the compression format and level for compressed clusters. The series adds 2 algorithms to choose from: zlib and lzo. zlib is the current default, but with unoptimal settings. If no compress.format option is specified the old zlib with the old

[Qemu-block] [PATCH V5 03/10] block/qcow2: parse compress create options

this adds parsing and validation for the compress create options. They are only validated but not yet used. Signed-off-by: Peter Lieven --- block/qcow2.c | 86 +-- include/block/block_int.h | 39 +++-- 2 files

[Qemu-block] [PATCH V5 06/10] block/qcow2: simplify ret usage in qcow2_create

Signed-off-by: Peter Lieven --- block/qcow2.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7fd52e1..ffe609d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3031,7 +3031,7 @@ static int qcow2_create(const

[Qemu-block] [PATCH V5 02/10] qapi/block-core: add Qcow2Compress parameters

Signed-off-by: Peter Lieven --- qapi/block-core.json | 40 1 file changed, 40 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 833c602..f652206 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@

Re: [Qemu-block] [PATCH for-2.10 0/2] Test for bug fixes from byte-based block status

On Mon, Jul 24, 2017 at 10:39:50AM -0500, Eric Blake wrote: > Kevin is correct, and I need tests of my recent bug fixes :) > > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07235.html > > Eric Blake (2): > iotests: Check dirty bitmap statistics in 124 > iotests: Add test of recent

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Fix reference output for 186

On Tue, Jul 25, 2017 at 10:59:36AM +0200, Kevin Wolf wrote: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Fix reference output for 186

Kevin Wolf writes: > Commits 70f17a1 ('error: Revert unwanted change of warning messages') > and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge > conflict, which results in failure for qemu-iotests case 186. Fix the > reference output to consider the changes

Re: [Qemu-block] [PATCH 4/7] block: convert ThrottleGroup to object with QOM

On Mon, Jul 24, 2017 at 04:12:47PM +0100, Stefan Hajnoczi wrote: On Fri, Jul 14, 2017 at 12:45:18PM +0300, Manos Pitsidianakis wrote: ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and

Re: [Qemu-block] [Qemu-devel] [PATCH v3] util: remove the obsolete non-blocking connect

On Tue, Jul 25, 2017 at 08:18:31AM +0200, Markus Armbruster wrote: > Mao Zhongyi writes: > > > On 07/25/2017 06:07 AM, John Snow wrote: > >> This was posted over a month ago with two R-Bs, did it get merged or > >> dropped? > >> > >> --js > > > > Not yet, I hope that

[Qemu-block] [PATCH] qemu-iotests: Fix reference output for 186

Commits 70f17a1 ('error: Revert unwanted change of warning messages') and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge conflict, which results in failure for qemu-iotests case 186. Fix the reference output to consider the changes of 70f17a1. Signed-off-by: Kevin Wolf

Re: [Qemu-block] [Qemu-devel] [PATCH v3] util: remove the obsolete non-blocking connect

Mao Zhongyi writes: > On 07/25/2017 06:07 AM, John Snow wrote: >> This was posted over a month ago with two R-Bs, did it get merged or dropped? >> >> --js > > Not yet, I hope that it will. get_maintainers.pl blames Daniel, Gerd and Paolo :)