Re: [Qemu-block] [Qemu-devel] Why is there no qom_get in hmp.c?

2018-04-18 Thread QingFeng Hao
在 2018/4/18 22:04, Dr. David Alan Gilbert 写道: > * QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: >> Hi all, >> I did some investigation and found that "virsh qemu-monitor-command" >> supports qom-get, >> but qemu hmp doesn't. However, in hmp.c there are qom_list and qom_set. It >> confused me

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

2018-04-18 Thread Markus Armbruster
John Snow writes: > On 04/18/2018 03:25 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 04/17/2018 09:44 AM, Markus Armbruster wrote: John Snow writes: > This series seeks to address two distinct but closely

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

2018-04-18 Thread John Snow
On 04/18/2018 03:25 AM, Markus Armbruster wrote: > John Snow writes: > >> On 04/17/2018 09:44 AM, Markus Armbruster wrote: >>> John Snow writes: >>> This series seeks to address two distinct but closely related issues concerning the job management

Re: [Qemu-block] [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 06:52:08PM +0200, Kevin Wolf wrote: > Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > > > > > Note that users can still

Re: [Qemu-block] [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 18:34 hat Daniel P. Berrangé geschrieben: > On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > > > Note that users can still configure authentication methods with a > > > configuration file. They

Re: [Qemu-block] [PATCH] nbd/server: introduce NBD_CMD_CACHE

2018-04-18 Thread Eric Blake
On 04/13/2018 09:31 AM, Vladimir Sementsov-Ogievskiy wrote: > Handle nbd CACHE command. Just do read, without sending read data back. > Cache mechanism should be done by exported node driver chain. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-block] [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 06:28:23PM +0200, Kevin Wolf wrote: > Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > > Note that users can still configure authentication methods with a > > configuration file. They probably do that anyway if they use Ceph > > outside QEMU as

Re: [Qemu-block] [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 17:06 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > We tried during

Re: [Qemu-block] [RFC] Intermediate block mirroring

2018-04-18 Thread Alberto Garcia
On Mon 16 Apr 2018 05:15:21 PM CEST, Max Reitz wrote: > On 2018-04-16 16:59, Alberto Garcia wrote: >> On Fri 13 Apr 2018 04:23:07 PM CEST, Max Reitz wrote: >>> On 2018-04-12 19:07, Alberto Garcia wrote: Hello, I mentioned this some time ago, but I'd like to retake it now: I'm

Re: [Qemu-block] [Qemu-devel] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Markus Armbruster
Kevin Wolf writes: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. We tried during development of v2.9.0 (commit 0a55679b4a5), but reverted before the release:

Re: [Qemu-block] [Qemu-devel] semantics of FIEMAP without FIEMAP_FLAG_SYNC

2018-04-18 Thread Eric Blake
On 04/18/2018 09:25 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Do your code with >>> >>> /* Found an extent, and we're inside it.  */ >>> *next = f.fe.fe_logical + f.fe.fe_length; >>> if (f.fe.fe_flags & FIEMAP_EXTENT_UNWRITTEN) { >>> return

Re: [Qemu-block] [Qemu-devel] semantics of FIEMAP without FIEMAP_FLAG_SYNC (was Re: [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server)

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
15.02.2018 19:42, Paolo Bonzini wrote: On 15/02/2018 17:40, Vladimir Sementsov-Ogievskiy wrote: Hi all. Two years later, is there are any news on the topic? I can't understand the following thing:  - FIEMAP without FLAG_SYNC is unsafe  - FIEMAP with FLAG_SYNC is safe but slow  - so, we've

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 16:16 hat Eric Blake geschrieben: > On 04/18/2018 08:50 AM, Kevin Wolf wrote: > > >>> @@ -3195,6 +3215,8 @@ > >>> '*conf': 'str', > >>> '*snapshot': 'str', > >>> '*user': 'str', > >>> +'*auth-none': 'bool', > >>> +

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/18/2018 08:50 AM, Kevin Wolf wrote: >>> @@ -3195,6 +3215,8 @@ >>> '*conf': 'str', >>> '*snapshot': 'str', >>> '*user': 'str', >>> +'*auth-none': 'bool', >>> +'*auth-cephx': 'RbdAuthCephx', >>> '*server':

Re: [Qemu-block] [PATCH v2 2/3] nbd/server: implement dirty bitmap export

2018-04-18 Thread Eric Blake
On 04/13/2018 01:14 PM, Vladimir Sementsov-Ogievskiy wrote: > Handle new NBD meta namespace: "qemu", and corresponding queries: > "qemu:dirty-bitmap:". > > With new metadata context negotiated, BLOCK_STATUS query will reply > with dirty-bitmap data, converted to extents. New public function >

Re: [Qemu-block] [Qemu-devel] Why is there no qom_get in hmp.c?

2018-04-18 Thread Dr. David Alan Gilbert
* QingFeng Hao (ha...@linux.vnet.ibm.com) wrote: > Hi all, > I did some investigation and found that "virsh qemu-monitor-command" supports > qom-get, > but qemu hmp doesn't. However, in hmp.c there are qom_list and qom_set. It > confused me > and my question is: why is this? And how can I get a

[Qemu-block] Restoring bitmaps after failed/cancelled migration

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
Hi all. We now have the following problem: If dirty-bitmaps migration capability is enabled, persistance flag is dropped for all migrated bitmaps, to prevent their storing to the storage on inactivate. It works ok, persistence itself is migrated through the migration channel. But on source,

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:26 hat Eric Blake geschrieben: > On 04/05/2018 12:06 PM, Kevin Wolf wrote: > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > > > This patch introduces

Re: [Qemu-block] [PATCH v4 2/5] qcow2: Document some maximum size constraints

2018-04-18 Thread Eric Blake
On 04/13/2018 12:08 PM, Max Reitz wrote: With 512 byte clusters and 64 bit refcount entries I still get 8 PB, way over what's limited by the L1/L2 tables (128 GB). >>> >>> Do I need to make any modifications to the sentence, then? >> >> I guess what surprised me the first time that I

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 18.04.2018 um 15:21 hat Eric Blake geschrieben: > On 04/06/2018 03:04 AM, Kevin Wolf wrote: > > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > >> The legacy command line syntax supports a "password-secret" option that > >> allows to pass an authentication key to Ceph. This was not

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/05/2018 12:06 PM, Kevin Wolf wrote: > The legacy command line syntax supports a "password-secret" option that > allows to pass an authentication key to Ceph. This was not supported in > QMP so far. > > This patch introduces authentication options in the QAPI schema, makes > them do the

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Eric Blake
On 04/06/2018 03:04 AM, Kevin Wolf wrote: > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: >> The legacy command line syntax supports a "password-secret" option that >> allows to pass an authentication key to Ceph. This was not supported in >> QMP so far. >> >> This patch introduces

Re: [Qemu-block] [PATCH v3 0/2] Give the refcount cache the minimum possible size by default

2018-04-18 Thread Max Reitz
On 2018-04-17 14:37, Alberto Garcia wrote: > Hi, > > we talked about this the other day, so here are the patches to change > the default cache sizes in qcow2. > > Without this patch: > > * refcount-cache-size = l2-cache-size / 4 > > unless otherwise specified by the user. This is wasteful,

Re: [Qemu-block] [Qemu-discuss] qemu-img convert stuck

2018-04-18 Thread David Lee
On Wed, Apr 18, 2018 at 4:44 PM, Fam Zheng wrote: > > qemu-img hangs because the convert_iteration_sectors loop cannot make any > progress when it reaches the end of the base image. It is a bug (implicitly?) > fixed by Eric Blake (Cc'ed) 's BDRV_BLOCK_EOF patches on upstream,

Re: [Qemu-block] [PATCH 3/3] qemu-iotests: Test new qemu-nbd --nolist option

2018-04-18 Thread Vladimir Sementsov-Ogievskiy
17.04.2018 22:56, Eric Blake wrote: On 04/13/2018 02:26 PM, Nir Soffer wrote: Add new test module for tesing the --nolist option. Signed-off-by: Nir Soffer --- +iotests.log('Check that listing exports is allowed by default') +disk, nbd_sock = iotests.file_path('disk1',

Re: [Qemu-block] [RFC][BROKEN] rbd: Allow configuration of authentication scheme

2018-04-18 Thread Kevin Wolf
Am 06.04.2018 um 10:04 hat Kevin Wolf geschrieben: > Am 05.04.2018 um 19:06 hat Kevin Wolf geschrieben: > > The legacy command line syntax supports a "password-secret" option that > > allows to pass an authentication key to Ceph. This was not supported in > > QMP so far. > > > > This patch

Re: [Qemu-block] [Qemu-discuss] qemu-img convert stuck

2018-04-18 Thread Fam Zheng
On Wed, 04/18 15:58, Fam Zheng wrote: > On Wed, 04/18 15:42, David Lee wrote: > > On Thu, Apr 12, 2018 at 11:57 PM, David Lee wrote: > > >>> > > >>> We tested qemu-kvm-ev-2.9.0-16.el7_4.14.1 - where from the source RPM we > > >>> verified it does contain

Re: [Qemu-block] [Qemu-discuss] qemu-img convert stuck

2018-04-18 Thread Fam Zheng
On Wed, 04/18 15:42, David Lee wrote: > On Thu, Apr 12, 2018 at 11:57 PM, David Lee wrote: > >>> > >>> We tested qemu-kvm-ev-2.9.0-16.el7_4.14.1 - where from the source RPM we > >>> verified it does contain ef6dada8b44e1e7c4bec5c1115903af9af415b50 > >>> > >>> But the issue

Re: [Qemu-block] [Qemu-discuss] qemu-img convert stuck

2018-04-18 Thread David Lee
On Thu, Apr 12, 2018 at 11:57 PM, David Lee wrote: >>> >>> We tested qemu-kvm-ev-2.9.0-16.el7_4.14.1 - where from the source RPM we >>> verified it does contain ef6dada8b44e1e7c4bec5c1115903af9af415b50 >>> >>> But the issue still exists. The convert got stuck if one of the

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/21] blockjobs: add explicit job management

2018-04-18 Thread Markus Armbruster
John Snow writes: > On 04/17/2018 09:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> This series seeks to address two distinct but closely related issues >>> concerning the job management API. >>> >>> (1) For jobs that complete when a monitor is