Re: [Qemu-block] [Qemu-devel] [PATCH] block: Make more block drivers compile-time configurable

2018-11-06 Thread Markus Armbruster
Max Reitz writes: > On 05.11.18 16:25, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 19.10.18 13:34, Markus Armbruster wrote: From: Jeff Cody This adds configure options to control the following block drivers: * Bochs * Cloop * Dmg * Qcow (V1)

[Qemu-block] [PATCH v2] block: Make more block drivers compile-time configurable

2018-11-06 Thread Markus Armbruster
From: Jeff Cody This adds configure options to control the following block drivers: * Bochs * Cloop * Dmg * Qcow (V1) * Vdi * Vvfat * qed * parallels * sheepdog Each of these defaults to being enabled. Signed-off-by: Jeff Cody Signed-off-by: Markus Armbruster --- v2: Fix handling of

Re: [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-06 Thread Markus Armbruster
Eduardo Habkost writes: > The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis > seems to provide an older version. Change the existing rules to > use command output instead of exit code, to make it compatible > with older GNU make versions. > > Signed-off-by: Eduardo Habkost > ---

Re: [Qemu-block] [PATCH 7/7] qcow2: do decompression in threads

2018-11-06 Thread Paolo Bonzini
On 01/11/2018 19:27, Vladimir Sementsov-Ogievskiy wrote: > -/* See qcow2_compress definition for parameters description */ > -static ssize_t qcow2_co_compress(BlockDriverState *bs, > - void *dest, size_t dest_size, > - const void

Re: [Qemu-block] [Qemu-devel] [PULL 12/15] Acceptance tests: add make rule for running them

2018-11-06 Thread Paolo Bonzini
On 31/10/2018 01:31, Eduardo Habkost wrote: > From: Cleber Rosa > > The acceptance (aka functional, aka Avocado-based) tests are > Python files located in "tests/acceptance" that need to be run > with the Avocado libs and test runner. > > Let's provide a convenient way for QEMU developers to

Re: [Qemu-block] ping Re: [PATCH v4 00/11] backup-top filter driver for backup

2018-11-06 Thread John Snow
On 11/06/2018 12:21 PM, Kevin Wolf wrote: > Am 02.11.2018 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: >> ping >> >> 15.10.2018 19:06, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> These series introduce backup-top driver. It's a filter-node, which >>> do copy-before-write

Re: [Qemu-block] [PATCH v4 03/11] block: allow serialized reads to intersect

2018-11-06 Thread Kevin Wolf
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > Otherwise, if we have serialized read-part in copy_range from backing > file to its parent if CoW take place, this CoW's sub-reads will > intersect with firstly created serialized read request. > > Anyway, reads should not

Re: [Qemu-block] [PATCH v4 04/11] block: improve should_update_child

2018-11-06 Thread Kevin Wolf
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > As it already said in the comment, we don't want to create loops in > parent->child relations. So, when we try to append @to to @c, we should > check that @c is not in @to children subtree, and we should check it > recursively,

Re: [Qemu-block] [PATCH v4 11/11] block/backup: use backup-top instead of write notifiers

2018-11-06 Thread Kevin Wolf
Am 15.10.2018 um 18:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > Drop write notifiers and use filter node instead. Changes: > > 1. copy-before-writes now handled by filter node, so, drop all >is_write_notifier arguments. > > 2. we don't have intersecting requests, so their handling is

Re: [Qemu-block] ping Re: [PATCH v4 00/11] backup-top filter driver for backup

2018-11-06 Thread Kevin Wolf
Am 02.11.2018 um 17:41 hat Vladimir Sementsov-Ogievskiy geschrieben: > ping > > 15.10.2018 19:06, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > These series introduce backup-top driver. It's a filter-node, which > > do copy-before-write operation. Mirror uses filter-node for handling >

Re: [Qemu-block] ping2 Re: [PATCH 0/2] replication: drop extra sync

2018-11-06 Thread Kevin Wolf
Am 31.10.2018 um 10:30 hat Vladimir Sementsov-Ogievskiy geschrieben: > ping2 > > Hi, it's a first step to backup refactoring and improving. Just get rid > of this extra and unnatural synchronization. The replication maintainers don't seem to have an opinion about this, so thanks, applied to

Re: [Qemu-block] [PATCH] blockdev: handle error on block latency histogram set error

2018-11-06 Thread Kevin Wolf
Am 05.11.2018 um 04:04 hat zhenwei pi geschrieben: > Function block_latency_histogram_set may return error, but qapi ignore this. > This can be reproduced easily by qmp command: > virsh qemu-monitor-command INSTANCE > '{"execute":"x-block-latency-histogram-set", >

Re: [Qemu-block] [PATCH v3 0/4] Adding LZFSE compression support for DMG block driver.

2018-11-06 Thread Kevin Wolf
Am 05.11.2018 um 16:08 hat Julio Faracco geschrieben: > Since Mac OS X El Capitain (v10.11), Apple uses LZFSE compression to > generate compressed DMGs as an alternative to BZIP2. Possible, Apple > want to keep this algorithm as default in long term. Some years ago, > Apple opened the LZFSE

Re: [Qemu-block] [PATCH for-3.1] blockdev: Consistently use snapshot_node_name in external_snapshot_prepare()

2018-11-06 Thread Kevin Wolf
Am 01.11.2018 um 17:30 hat Peter Maydell geschrieben: > In the function external_snapshot_prepare() we have a > BlockdevSnapshotSync struct, which has the usual combination > of has_snapshot_node_name and snapshot_node_name fields for an > optional field. We set up a local variable > const

Re: [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-06 Thread Vladimir Sementsov-Ogievskiy
06.11.2018 18:30, Alberto Garcia wrote: > On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> 06.11.2018 18:06, Alberto Garcia wrote: >>> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> +buf = g_try_malloc(csize); +if (!buf) {

[Qemu-block] [PATCH 1/1] virtio-blk: rename iov to out_iov in virtio_blk_handle_request()

2018-11-06 Thread Dongli Zhang
In virtio_blk_handle_request(), in_iov is used for input header while iov is used for output header. Rename iov to out_iov to pair output header's name with in_iov to avoid confusing people when reading source code. Signed-off-by: Dongli Zhang --- hw/block/virtio-blk.c | 8 1 file

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] nvme: don't unref ctrl_mem when device unrealized

2018-11-06 Thread Igor Mammedov
On Sun, 28 Oct 2018 23:29:40 -0700 Li Qiang wrote: > Currently, when hotplug/unhotplug nvme device, it will cause an > assert in object.c. Following is the backtrack: > > ERROR:qom/object.c:981:object_unref: assertion failed: (obj->ref > 0) > > Thread 2 "qemu-system-x86" received signal

Re: [Qemu-block] [Qemu-devel] [PATCH v6 06/10] hw/m68k: add Nubus support

2018-11-06 Thread Thomas Huth
On 2018-11-02 16:22, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- > hw/Makefile.objs| 1 + > hw/nubus/Makefile.objs | 4 + >

Re: [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-06 Thread Peter Maydell
On 6 November 2018 at 14:13, Eduardo Habkost wrote: > The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis > seems to provide an older version. Change the existing rules to > use command output instead of exit code, to make it compatible > with older GNU make versions. > >

Re: [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-06 Thread Alberto Garcia
On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote: > 06.11.2018 18:06, Alberto Garcia wrote: >> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> >>> +buf = g_try_malloc(csize); >>> +if (!buf) { >>> +return -ENOMEM; >>> +} >>> +

Re: [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-06 Thread Vladimir Sementsov-Ogievskiy
06.11.2018 18:06, Alberto Garcia wrote: > On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote: > >> +buf = g_try_malloc(csize); >> +if (!buf) { >> +return -ENOMEM; >> +} >> +iov.iov_base = buf; >> +iov.iov_len = csize; >> +

Re: [Qemu-block] [PATCH 5/7] qcow2: use byte-based read in qcow2_decompress_cluster

2018-11-06 Thread Vladimir Sementsov-Ogievskiy
06.11.2018 16:53, Alberto Garcia wrote: > On Thu 01 Nov 2018 07:27:36 PM CET, Vladimir Sementsov-Ogievskiy wrote: > >> diff --git a/block/qcow2.c b/block/qcow2.c >> index e9d24b801e..950b9f7ec6 100644 >> --- a/block/qcow2.c >> +++ b/block/qcow2.c >> @@ -3956,14 +3956,15 @@ fail: >> int

Re: [Qemu-block] [Qemu-devel] [PATCH v6 02/10] hw/m68k: implement ADB bus support for via

2018-11-06 Thread Thomas Huth
On 2018-11-02 16:22, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > --- > hw/misc/mac_via.c | 190 >

Re: [Qemu-block] [Qemu-devel] [PATCH v6 04/10] hw/m68k: add macfb video card

2018-11-06 Thread Thomas Huth
On 2018-11-02 16:22, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > --- > arch_init.c| 4 + > hw/display/Makefile.objs | 1 + >

Re: [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-06 Thread Alberto Garcia
On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote: > +buf = g_try_malloc(csize); > +if (!buf) { > +return -ENOMEM; > +} > +iov.iov_base = buf; > +iov.iov_len = csize; > +qemu_iovec_init_external(_qiov, , 1); > > -iov.iov_base =

Re: [Qemu-block] [Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-06 Thread Thomas Huth
On 2018-11-04 14:41, Mark Cave-Ayland wrote: > On 04/11/2018 06:53, no-re...@patchew.org wrote: > >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk >>

Re: [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-06 Thread Philippe Mathieu-Daudé
Hi Peter, Can you apply this patch as a CI bug-fix? Thanks, Phil. On 6/11/18 15:27, Philippe Mathieu-Daudé wrote: On 6/11/18 15:13, Eduardo Habkost wrote: The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis seems to provide an older version.  Change the existing rules to use

Re: [Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-06 Thread Philippe Mathieu-Daudé
On 6/11/18 15:13, Eduardo Habkost wrote: The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis seems to provide an older version. Change the existing rules to use command output instead of exit code, to make it compatible with older GNU make versions. You were quicker, I just found

Re: [Qemu-block] [PATCH 7/7] qcow2: do decompression in threads

2018-11-06 Thread Alberto Garcia
On Thu 01 Nov 2018 07:27:38 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Do decompression in threads, like it is already done for compression. > This improves asynchronous compressed reads performance. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

[Qemu-block] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-06 Thread Eduardo Habkost
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis seems to provide an older version. Change the existing rules to use command output instead of exit code, to make it compatible with older GNU make versions. Signed-off-by: Eduardo Habkost --- I think that's the cause of the Travis

Re: [Qemu-block] [PATCH 5/7] qcow2: use byte-based read in qcow2_decompress_cluster

2018-11-06 Thread Alberto Garcia
On Thu 01 Nov 2018 07:27:36 PM CET, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/block/qcow2.c b/block/qcow2.c > index e9d24b801e..950b9f7ec6 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3956,14 +3956,15 @@ fail: > int qcow2_decompress_cluster(BlockDriverState *bs, uint64_t

Re: [Qemu-block] [Qemu-devel] [PULL 11/15] Bootstrap Python venv for tests

2018-11-06 Thread Philippe Mathieu-Daudé
On 6/11/18 14:10, Peter Maydell wrote: On 31 October 2018 at 00:31, Eduardo Habkost wrote: From: Cleber Rosa A number of QEMU tests are written in Python, and may benefit from an untainted Python venv. By using make rules, tests that depend on specific Python libs can set that rule as a

Re: [Qemu-block] [PULL 11/15] Bootstrap Python venv for tests

2018-11-06 Thread Peter Maydell
On 31 October 2018 at 00:31, Eduardo Habkost wrote: > From: Cleber Rosa > > A number of QEMU tests are written in Python, and may benefit > from an untainted Python venv. > > By using make rules, tests that depend on specific Python libs > can set that rule as a requirement, along with rules

Re: [Qemu-block] [PATCH v3] file-posix: Use error API properly

2018-11-06 Thread Kevin Wolf
Am 01.11.2018 um 07:29 hat Fam Zheng geschrieben: > Use error_report for situations that affect user operation (i.e. we're > actually returning error), and warn_report/warn_report_err when some > less critical error happened but the user operation can still carry on. > > For

[Qemu-block] [PATCH] block/nvme: call blk_drain in NVMe reset code to avoid lockups

2018-11-06 Thread Igor Druzhinin
When blk_flush called in NVMe reset path S/C queues are already freed which means that re-entering AIO handling loop having some IO requests unfinished will lockup or crash as their SG structures being potentially reused. Call blk_drain before freeing the queues to avoid this nasty scenario.

Re: [Qemu-block] [PATCH 1/2] The discard flag for block stream operation

2018-11-06 Thread Andrey Shinkevich
Berto, Well noted about the "after implementation". Kindly, Andrey Shinkevich On 05.11.2018 19:08, Alberto Garcia wrote: > On Wed 31 Oct 2018 05:47:19 PM CET, Andrey Shinkevich > wrote: >> Adding a parameter to QMP block-stream command to allow discarding >> blocks in the backing chain

Re: [Qemu-block] [PATCH 1/2] The discard flag for block stream operation

2018-11-06 Thread Andrey Shinkevich
OK, David, I will implement that with the next series. Kindly, Andrey Shinkevich On 31.10.2018 20:38, Dr. David Alan Gilbert wrote: > * Andrey Shinkevich (andrey.shinkev...@virtuozzo.com) wrote: >> Adding a parameter to QMP block-stream command to allow discarding >> blocks in the backing

Re: [Qemu-block] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-06 Thread Kevin Wolf
Am 06.11.2018 um 09:56 hat Leonid Bloch geschrieben: > Hi Phil, Hi Eric, > > (Eric, for some reason you weren't CC'd to this thread - sorry.) > > On 11/5/18 5:58 PM, Philippe Mathieu-Daudé wrote: > > Hi Leonid, > > > > On 4/11/18 19:07, Leonid Bloch wrote: > >> The lookup table for power-of-two

Re: [Qemu-block] [PATCH 4/7] qcow2: refactor decompress_buffer

2018-11-06 Thread Alberto Garcia
On Thu 01 Nov 2018 07:27:35 PM CET, Vladimir Sementsov-Ogievskiy wrote: > - make it look more like a pair of qcow2_compress - rename the function > and its parameters > - drop extra out_len variable, check filling of output buffer by strm > structure itself > - fix code style > - add some

Re: [Qemu-block] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-06 Thread Leonid Bloch
Hi Phil, Hi Eric, (Eric, for some reason you weren't CC'd to this thread - sorry.) On 11/5/18 5:58 PM, Philippe Mathieu-Daudé wrote: > Hi Leonid, > > On 4/11/18 19:07, Leonid Bloch wrote: >> The lookup table for power-of-two sizes was added in commit 540b8492618eb >> for the purpose of having