Re: [Qemu-block] [PATCH] scsi: Address spurious clang warning

2018-11-27 Thread Peter Maydell
On Tue, 27 Nov 2018 at 18:49, John Snow wrote: > > Some versions of Clang prior to 6.0 (and some builds of clang after, > such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer > for a struct with subobjects when -Wmissing-braces is enabled. > >

Re: [Qemu-block] [PATCH] qemu-img info lists bitmap directory entries

2018-11-27 Thread Eric Blake
On 11/27/18 6:41 AM, Andrey Shinkevich wrote: The 'Format specific information' of qemu-img info command will show the name, flags and granularity for every QCOW2 bitmap. Signed-off-by: Andrey Shinkevich --- Dear colleagues, With this patch, qemu-img info will display a name, flags and

Re: [Qemu-block] [Qemu-devel] [PATCH] scsi: Address spurious clang warning

2018-11-27 Thread John Snow
On 11/27/18 2:02 PM, Eric Blake wrote: > On 11/27/18 12:49 PM, John Snow wrote: >> Some versions of Clang prior to 6.0 (and some builds of clang after, >> such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer >> for a struct with subobjects when -Wmissing-braces is enabled. >> >>

Re: [Qemu-block] [Qemu-devel] [PATCH] scsi: Address spurious clang warning

2018-11-27 Thread Peter Maydell
On Tue, 27 Nov 2018 at 19:02, Eric Blake wrote: > > On 11/27/18 12:49 PM, John Snow wrote: > > Some versions of Clang prior to 6.0 (and some builds of clang after, > > such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer > > for a struct with subobjects when -Wmissing-braces is

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Caio Carrara
On Tue, Nov 27, 2018 at 03:02:03PM -0500, Cleber Rosa wrote: > > > On 11/27/18 2:00 PM, Caio Carrara wrote: > > Hi, Cleber. > > > > On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: > >> This is a simple move of Python code that wraps common QEMU > >> functionality, and are used by a

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Cleber Rosa
On 11/27/18 2:49 PM, Eduardo Habkost wrote: > On Tue, Nov 27, 2018 at 05:00:07PM -0200, Caio Carrara wrote: >> Hi, Cleber. >> >> On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: >>> This is a simple move of Python code that wraps common QEMU >>> functionality, and are used by a

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Cleber Rosa
On 11/27/18 2:00 PM, Caio Carrara wrote: > Hi, Cleber. > > On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: >> This is a simple move of Python code that wraps common QEMU >> functionality, and are used by a number of different tests >> and scripts. >> >> By treating that code as a

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Eduardo Habkost
On Tue, Nov 27, 2018 at 05:00:07PM -0200, Caio Carrara wrote: > Hi, Cleber. > > On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: > > This is a simple move of Python code that wraps common QEMU > > functionality, and are used by a number of different tests > > and scripts. > > > > By

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Caio Carrara
Hi, Cleber. On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: > This is a simple move of Python code that wraps common QEMU > functionality, and are used by a number of different tests > and scripts. > > By treating that code as a real Python module, we can more easily, > among other

Re: [Qemu-block] [Qemu-devel] [PATCH] scsi: Address spurious clang warning

2018-11-27 Thread Eric Blake
On 11/27/18 12:49 PM, John Snow wrote: Some versions of Clang prior to 6.0 (and some builds of clang after, such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer for a struct with subobjects when -Wmissing-braces is enabled. https://bugs.llvm.org/show_bug.cgi?id=21689 and

Re: [Qemu-block] [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-11-27 Thread Stefano Stabellini
On Wed, 21 Nov 2018, Paul Durrant wrote: > I have made many significant contributions to the Xen code in QEMU, > particularly the recent patches introducing a new PV device framework. > I intend to make further significant contributions, porting other PV back- > ends to the new framework with the

[Qemu-block] [PATCH] scsi: Address spurious clang warning

2018-11-27 Thread John Snow
Some versions of Clang prior to 6.0 (and some builds of clang after, such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer for a struct with subobjects when -Wmissing-braces is enabled. https://bugs.llvm.org/show_bug.cgi?id=21689 and https://reviews.llvm.org/rL314499 suggests this

Re: [Qemu-block] [PATCH 00/11] qcow2: encryption threads

2018-11-27 Thread Daniel P . Berrangé
On Fri, Nov 23, 2018 at 07:55:00PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > The series brings threads to qcow2 encryption/decryption path, > like it is already done for compression. > > Based-on: Kevin's block-next branch [d3db1496c5] > > Performance gain is illustrated by the

Re: [Qemu-block] [PATCH 07/11] qcow2-threads: add encryption

2018-11-27 Thread Daniel P . Berrangé
On Fri, Nov 23, 2018 at 07:55:07PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add thread-based encrypt/decrypt. QCrypto don't support parallel > operations with one block, so we need QCryptoBlock for each thread. > +static int qcow2_crypto_blocks_open(BDRVQcow2State *s, > +

Re: [Qemu-block] encrypt in threads

2018-11-27 Thread Daniel P . Berrangé
On Thu, Nov 22, 2018 at 01:01:20PM +, Vladimir Sementsov-Ogievskiy wrote: > 21.11.2018 20:30, Vladimir Sementsov-Ogievskiy wrote: > > Hi Daniel! > > > > After moving compression to threads in Qcow2 it's an obvious next step to > > "threadyfy" encryption in Qcow2 too. > > > > But it turned

Re: [Qemu-block] encrypt in threads

2018-11-27 Thread Daniel P . Berrangé
On Wed, Nov 21, 2018 at 05:30:53PM +, Vladimir Sementsov-Ogievskiy wrote: > Hi Daniel! > > After moving compression to threads in Qcow2 it's an obvious next step to > "threadyfy" encryption in Qcow2 too. > > But it turned out to be not as simple as I assumed. If I call >

Re: [Qemu-block] [PATCH 0/6] Misc fixes to NBD

2018-11-27 Thread Eric Blake
On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: This does two minor fixes to the NBD code and adds significant coverage of the NBD TLS support to detect future problems. The first two patches should be for 3.1. The tests can wait till 4.0 if desired. Although this series is now in 3.1, I can

Re: [Qemu-block] [PULL 0/3] Block layer patches

2018-11-27 Thread Peter Maydell
On Tue, 27 Nov 2018 at 14:07, Kevin Wolf wrote: > > The following changes since commit d5d31c9a8ab5e87db4230602a6fd5da8eb13135c: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/x86-for-3.1-pull-request' into staging (2018-11-27 > 09:55:05 +) > > are available in the Git

[Qemu-block] [PULL 0/3] Block layer patches

2018-11-27 Thread Kevin Wolf
The following changes since commit d5d31c9a8ab5e87db4230602a6fd5da8eb13135c: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-for-3.1-pull-request' into staging (2018-11-27 09:55:05 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[Qemu-block] [PULL 2/3] iotests: Test migration with -blockdev

2018-11-27 Thread Kevin Wolf
Check that block node activation and inactivation works with a block graph that is built with individually created nodes. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/234 | 121 + tests/qemu-iotests/234.out | 30 +

[Qemu-block] [PULL 1/3] block: Don't inactivate children before parents

2018-11-27 Thread Kevin Wolf
bdrv_child_cb_inactivate() asserts that parents are already inactive when children get inactivated. This precondition is necessary because parents could still issue requests in their inactivation code. When block nodes are created individually with -blockdev, all of them are monitor owned and

[Qemu-block] [PULL 3/3] nvme: Fix spurious interrupts

2018-11-27 Thread Kevin Wolf
From: Keith Busch The code had asserted an interrupt every time it was requested to check for new completion queue entries.This can result in spurious interrupts seen by the guest OS. Fix this by asserting an interrupt only if there are un-acknowledged completion queue entries available.

Re: [Qemu-block] [PATCH] qemu-img info lists bitmap directory entries

2018-11-27 Thread Andrey Shinkevich
Patch amendments below: 1. A description of the 'bitmaps' new member of the structure 'ImageInfoSpecificQCow2' has been added to the file qapi/block-core.json. 2. Per Eric Blake's note, the version number at the 'Since:' field of comments was changed to '4.0'. Kindly, Andrey Shinkevich On

Re: [Qemu-block] [PATCH] qemu-img info lists bitmap directory entries

2018-11-27 Thread Vladimir Sementsov-Ogievskiy
27.11.2018 15:41, Andrey Shinkevich wrote: > The 'Format specific information' of qemu-img info command will show > the name, flags and granularity for every QCOW2 bitmap. > > Signed-off-by: Andrey Shinkevich > --- > Dear colleagues, > > With this patch, qemu-img info will display a name, flags

[Qemu-block] [PATCH] qemu-img info lists bitmap directory entries

2018-11-27 Thread Andrey Shinkevich
The 'Format specific information' of qemu-img info command will show the name, flags and granularity for every QCOW2 bitmap. Signed-off-by: Andrey Shinkevich --- Dear colleagues, With this patch, qemu-img info will display a name, flags and granularity information for every bitmap in the

[Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Cleber Rosa
This is a simple move of Python code that wraps common QEMU functionality, and are used by a number of different tests and scripts. By treating that code as a real Python module, we can more easily, among other things: * reuse more code * apply a more consistent style * add tests to that code