There are certainly some improvements to be made with regards
to kvm capabilities detection, but this seems good enough for
this specific case.
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/235 | 5 +++--
tests/qemu-iotests/238 | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
dif
I usually keep an eye if I'm breaking stuff by looking at Travis
(too). So it seems like a good idea to add a job that will do that.
A few things deserve a better explanation:
* test 233 requires "--enable-gnutls", and fails without it
* QEMU seems unable to initialize sound devices on the
Besides the obvious reasons of testing more, and somewhat for free,
running the qemu-iotests along the other tests on Travis also makes
sure that changes to shared code such as "scripts/qemu.py" and the
like won't break other users of the same code.
Cleber Rosa (2):
qemu-iotests: only enable kvm
On 2/8/19 11:34 PM, John Snow wrote:
> On 2/7/19 1:51 PM, Thomas Huth wrote:
>> On 2019-02-07 17:50, Philippe Mathieu-Daudé wrote:
>>> On 2/5/19 1:18 AM, Philippe Mathieu-Daudé wrote:
Since the ahci-test uses qemu-img, add a dependency to build it
before using it.
This fixes:
>>
On 2/7/19 1:51 PM, Thomas Huth wrote:
> On 2019-02-07 17:50, Philippe Mathieu-Daudé wrote:
>> On 2/5/19 1:18 AM, Philippe Mathieu-Daudé wrote:
>>> Since the ahci-test uses qemu-img, add a dependency to build it
>>> before using it.
>>> This fixes:
>>>
>>> $ gmake check-qtest V=1
>>> QTEST_QE
On 07.02.19 07:56, Markus Armbruster wrote:
> Max Reitz writes:
>
>> This patch allows specifying a discriminator that is an optional member
>> of the base struct. In such a case, a default value must be provided
>> that is used when no value is given.
>>
>> Signed-off-by: Max Reitz
>> ---
>>
On 06.02.19 21:43, Eric Blake wrote:
> On 2/6/19 1:55 PM, Max Reitz wrote:
>
> In the subject, s/well typed/well-typed/
>
>> By applying a health mix of qdict_flatten(), qdict_crumple(),
>
> s/health/healty/
>
>> qdict_stringify_for_keyval(), the keyval input visitor, and the QObject
>> output
Philippe Mathieu-Daudé writes:
> Hi Alex,
>
> Can you queue this patch?
Done.
>
> On 1/29/19 6:53 PM, Philippe Mathieu-Daudé wrote:
>> Depending of the host hardware, copying and extracting VM images can
>> take up to few minutes. Add verbosity to avoid the user to worry about
>> VMs hanging.
On 08/02/2019 18:53, Eric Blake wrote:
> On 2/8/19 9:37 AM, Andrey Shinkevich wrote:
>>
>>
>> On 08/02/2019 18:25, Eric Blake wrote:
>>> On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
v14:
The test 242 was amended to be safer against changes in the bitmap
allocation
algorithm be
On 08/02/2019 18:53, Eric Blake wrote:
> On 2/8/19 9:37 AM, Andrey Shinkevich wrote:
>>
>>
>> On 08/02/2019 18:25, Eric Blake wrote:
>>> On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
v14:
The test 242 was amended to be safer against changes in the bitmap
allocation
algorithm be
On 2/8/19 9:37 AM, Andrey Shinkevich wrote:
>
>
> On 08/02/2019 18:25, Eric Blake wrote:
>> On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
>>> v14:
>>> The test 242 was amended to be safer against changes in the bitmap
>>> allocation
>>> algorithm because the bitmap directory is reallocated on VM s
On 2/8/19 9:44 AM, Alberto Garcia wrote:
> L1 table entries have a field to store the offset of an L2 table.
> The rest of the bits of the entry are currently reserved except from
> bit 63, which stores the COPIED flag.
>
> The offset is always taken from the entry using L1E_OFFSET_MASK to
> ensur
>
> This series adds the support of DISCARD and WRITE_ZEROES commands
> and extends the virtio-blk-test to test WRITE_ZEROES command when
> the feature is enabled.
>
> v4:
> - fixed error with mingw compiler in patch 4
> gcc and clang want %lu, but mingw wants %llu for BDRV_REQUEST_MAX_SECTOR
On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
> A new test file 242 added to the qemu-iotests set. It checks
> the format of qcow2 specific information for the new added
> section that lists details of bitmaps.
>
> Signed-off-by: Andrey Shinkevich
> ---
> tests/qemu-iotests/242 | 103 +
08.02.2019 18:25, Eric Blake wrote:
> On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
>> v14:
>> The test 242 was amended to be safer against changes in the bitmap allocation
>> algorithm because the bitmap directory is reallocated on VM shutdown.
>> Unfortunately, an empty line at the end of the bench
L1 table entries have a field to store the offset of an L2 table.
The rest of the bits of the entry are currently reserved except from
bit 63, which stores the COPIED flag.
The offset is always taken from the entry using L1E_OFFSET_MASK to
ensure that we only use the bits that belong to that field
On 08/02/2019 18:25, Eric Blake wrote:
> On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
>> v14:
>> The test 242 was amended to be safer against changes in the bitmap allocation
>> algorithm because the bitmap directory is reallocated on VM shutdown.
>> Unfortunately, an empty line at the end of the
On 08/02/2019 16:13, Alberto Garcia wrote:
> On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote:
>> +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp)
>> +{
>> +BlockDriverState *cor_filter_bs;
>> +Error *local_err = NULL;
>> +
>> +cor_filter_bs = cre
On 2/8/19 9:06 AM, Andrey Shinkevich wrote:
> v14:
> The test 242 was amended to be safer against changes in the bitmap allocation
> algorithm because the bitmap directory is reallocated on VM shutdown.
> Unfortunately, an empty line at the end of the benchmark file 242.out
> persists.
Easy solut
In the 'Format specific information' section of the 'qemu-img info'
command output, the supplemental information about existing QCOW2
bitmaps will be shown, such as a bitmap name, flags and granularity:
image: /vz/vmprivate/VM1/harddisk.hdd
file format: qcow2
virtual size: 64G (68719476736 bytes)
v14:
The test 242 was amended to be safer against changes in the bitmap allocation
algorithm because the bitmap directory is reallocated on VM shutdown.
Unfortunately, an empty line at the end of the benchmark file 242.out persists.
The version #13 was discussed in email thread with the message ID:
Inform a user in case qcow2_get_specific_info fails to obtain
QCOW2 image specific information. This patch is preliminary to
the one "qcow2: Add list of bitmaps to ImageInfoSpecificQCow2".
Signed-off-by: Andrey Shinkevich
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewe
A new test file 242 added to the qemu-iotests set. It checks
the format of qcow2 specific information for the new added
section that lists details of bitmaps.
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/242 | 103
tests/qemu-iotests/242.out | 165
In several part we still using req->dev or VIRTIO_DEVICE(req->dev)
when we have already defined s and vdev pointers:
VirtIOBlock *s = req->dev;
VirtIODevice *vdev = VIRTIO_DEVICE(s);
Signed-off-by: Stefano Garzarella
---
hw/block/virtio-blk.c | 22 +-
1 file changed,
attached generated file
--
Best regards,
Vladimir
/*
* File is generated by scripts/coroutine-wrapper.py
*/
#include "qemu/osdep.h"
#include "block/block_int.h"
/*
* Wrappers for bdrv_co_check
*/
typedef struct bdrv_co_check__ArgumentsPack {
BlockDriverState *bs;
BdrvCheckResult
Hi all!
We have a very frequent pattern of wrapping a coroutine_fn function
to be called from non-coroutine context:
- create structure to pack parameters
- create function to call original function taking parameters from
struct
- create wrapper, which in case of non-coroutine context w
If the WRITE_ZEROES feature is enabled, we check this command
in the test_basic().
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Acked-by: Thomas Huth
Signed-off-by: Stefano Garzarella
---
tests/virtio-blk-test.c | 60 +
1 file changed, 6
This patch adds the support of DISCARD and WRITE_ZEROES commands,
that have been introduced in the virtio-blk protocol to have
better performance when using SSD backend.
We support only one segment per request since multiple segments
are not widely used and there are no userspace APIs that allow
a
The size of data in the virtio_blk_request must be a multiple
of 512 bytes for IN and OUT requests, or a multiple of the size
of struct virtio_blk_discard_write_zeroes for DISCARD and
WRITE_ZEROES requests.
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
Si
In order to avoid migration issues, we enable DISCARD and
WRITE_ZEROES features only for machine type >= 4.0
As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the
list [1], DISCARD operation should not have security implications
(eg. page cache attacks), so we can enable it by default.
Since configurable features for virtio-blk are growing, this patch
adds host_features field in the struct VirtIOBlock. (as in virtio-net)
In this way, we can avoid to add new fields for new properties and
we can directly set VIRTIO_BLK_F* flags in the host_features.
We update "config-wce" and "scs
This series adds the support of DISCARD and WRITE_ZEROES commands
and extends the virtio-blk-test to test WRITE_ZEROES command when
the feature is enabled.
v4:
- fixed error with mingw compiler in patch 4
gcc and clang want %lu, but mingw wants %llu for BDRV_REQUEST_MAX_SECTORS.
Since is less
We add acct_failed param in order to use virtio_blk_handle_rw_error()
also when is not required to call block_acct_failed(). (eg. a discard
operation is failed)
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
hw/block/virtio-blk.c | 10 ++-
On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote:
> +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp)
> +{
> +BlockDriverState *cor_filter_bs;
> +Error *local_err = NULL;
> +
> +cor_filter_bs = create_filter_node(bs, errp);
> +if (cor_filter_bs =
On Sun 30 Dec 2018 09:09:12 PM CET, Andrey Shinkevich wrote:
> +static BlockDriverState *child_file_bs(BlockDriverState *bs)
> +{
> +return bs->file ? bs->file->bs : NULL;
> +}
In addition to Vladimir's comments, I wonder if it's useful to put this
in block_int.h (together with backing_bs()).
Take a VhostUserState* that can be pre-allocated, and initialize it
with the associated chardev.
Signed-off-by: Marc-André Lureau
Reviewed-by: Tiwei Bie
---
include/hw/virtio/vhost-user-blk.h | 2 +-
include/hw/virtio/vhost-user-scsi.h | 2 +-
include/hw/virtio/vhost-user.h | 2 +-
bac
Am 24.01.2019 um 08:48 hat Denis Plotnikov geschrieben:
> When there is a Backup Block Job running and shutdown command is sent to
> a guest, the guest crushes due to assert(!bs->walking_aio_notifiers).
>
> Call stack:
>
> 0 __GI_raise
> 1 __GI_abort
> 2 __assert_fail_base
> 3 __GI___assert_f
ping ping!
On 24.01.2019 10:48, Denis Plotnikov wrote:
> When there is a Backup Block Job running and shutdown command is sent to
> a guest, the guest crushes due to assert(!bs->walking_aio_notifiers).
>
> Call stack:
>
> 0 __GI_raise
> 1 __GI_abort
> 2 __assert_fail_base
> 3 __GI___assert_f
On Fri, Feb 08, 2019 at 02:06:18PM +0800, Stefan Hajnoczi wrote:
> On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote:
> > This series adds the support of DISCARD and WRITE_ZEROES commands
> > and extends the virtio-blk-test to test WRITE_ZEROES command when
> > the feature is enabl
39 matches
Mail list logo
