Re: bitmap migration bug with -drive while block mirror runs

2019-10-05 Thread John Snow
On 10/4/19 9:07 AM, Eric Blake wrote: > On 10/4/19 4:24 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> The way I see it, we know an auto-generated node name will never be >>> correct, but an explicitly specified one represents an explicit user >>> configuration. >>> >>> It's wrong to use

Re: bitmap migration bug with -drive while block mirror runs

2019-10-05 Thread John Snow
On 10/4/19 4:33 AM, Peter Krempa wrote: > On Thu, Oct 03, 2019 at 19:34:56 -0400, John Snow wrote: >> On 10/3/19 6:14 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 03.10.2019 0:35, John Snow wrote: On 10/2/19 6:46 AM, Peter Krempa wrote: >>> > > [...] > > (I'm sorry if I ignored

Re: [PATCH 00/11] hw: Convert various reset() handler to DeviceReset

2019-10-05 Thread Michael S. Tsirkin
On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote: > Hi. > > Following the thread discussion between Peter/Markus/Damien about > reset handlers: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg617103.html > I started to remove qemu_register_reset() calls from few

[PATCH 1/1] MAINTAINERS: Add Vladimir as a reviewer for bitmaps

2019-10-05 Thread John Snow
I already try to make sure all bitmaps patches have been reviewed by both Red Hat and Virtuozzo anyway, so this formalizes the arrangement. Fam meanwhile is no longer as active, so I am removing him as a co-maintainer simply to reflect the current practice. Signed-off-by: John Snow ---

[PATCH 0/1] MAINTAINERS: Add Vladimir as a reviewer for bitmaps

2019-10-05 Thread John Snow
Hi; I'll be going away on an extended trip this November and have made arrangements for reviews to be handled in my absence. I've asked Vladimir to take point on any reviews for patches he didn't author, and have asked Eric to take point on reviewing any of Vladimir's patches for this tree.

[PATCH v6 1/4] block/replication.c: Ignore requests after failover

2019-10-05 Thread Lukas Straub
After failover the Secondary side of replication shouldn't change state, because it now functions as our primary disk. In replication_start, replication_do_checkpoint, replication_stop, ignore the request if current state is BLOCK_REPLICATION_DONE (sucessful failover) or

[PATCH v6 4/4] colo: Update Documentation for continuous replication

2019-10-05 Thread Lukas Straub
Document the qemu command-line and qmp commands for continuous replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 213 +++-- docs/block-replication.txt | 28 +++-- 2 files changed, 174 insertions(+), 67 deletions(-) diff --git

[PATCH v6 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-10-05 Thread Lukas Straub
To switch the Secondary to Primary, we need to insert new filters before the filter-rewriter. Add the options insert= and position= to be able to insert filters anywhere in the filter list. position should be "head" or "tail" to insert at the head or tail of the filter list or it should be "id="

[PATCH v6 0/4] colo: Add support for continuous replication

2019-10-05 Thread Lukas Straub
Hello Everyone, These Patches add support for continuous replication to colo. This means that after the Primary fails and the Secondary did a failover, the Secondary can then become Primary and resume replication to a new Secondary. Regards, Lukas Straub v6: - properly documented the position=

[PATCH v6 2/4] tests/test-replication.c: Add test for for secondary node continuing replication

2019-10-05 Thread Lukas Straub
This simulates the case that happens when we resume COLO after failover. Signed-off-by: Lukas Straub --- tests/test-replication.c | 52 1 file changed, 52 insertions(+) diff --git a/tests/test-replication.c b/tests/test-replication.c index