Re: [PATCH] virtio: don't enable notifications during polling

On Wed, Dec 11, 2019 at 10:58:43AM -0500, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2019 at 09:09:57PM +, Stefan Hajnoczi wrote: > > Virtqueue notifications are not necessary during polling, so we disable > > them. This allows the guest driver to avoid MMIO vmexits. > > Unfortunately the

Re: [PATCH v6 28/42] stream: Deal with filters

Am 11.12.2019 um 17:12 hat Max Reitz geschrieben: > On 11.12.19 16:52, Kevin Wolf wrote: > > Am 11.12.2019 um 13:52 hat Max Reitz geschrieben: > >> On 16.09.19 11:52, Max Reitz wrote: > >>> On 13.09.19 16:16, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >

Re: Insufficiently documented deprecated command arguments

Peter Krempa writes: > On Wed, Dec 11, 2019 at 12:32:10 +, Daniel Berrange wrote: >> On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote: >> > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: >> > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > > [...] > >> > > Well,

Re: [PATCH v6 28/42] stream: Deal with filters

On 11.12.19 16:52, Kevin Wolf wrote: > Am 11.12.2019 um 13:52 hat Max Reitz geschrieben: >> On 16.09.19 11:52, Max Reitz wrote: >>> On 13.09.19 16:16, Kevin Wolf wrote: Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Because of the recent changes that make the stream job independent

Re: [PATCH] virtio: don't enable notifications during polling

On Mon, Dec 09, 2019 at 09:09:57PM +, Stefan Hajnoczi wrote: > Virtqueue notifications are not necessary during polling, so we disable > them. This allows the guest driver to avoid MMIO vmexits. > Unfortunately the virtio-blk and virtio-scsi handler functions re-enable > notifications,

Re: [PATCH v6 28/42] stream: Deal with filters

Am 11.12.2019 um 13:52 hat Max Reitz geschrieben: > On 16.09.19 11:52, Max Reitz wrote: > > On 13.09.19 16:16, Kevin Wolf wrote: > >> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >>> Because of the recent changes that make the stream job independent of > >>> the base node and instead track

Re: [PATCH] tests: skip block layer tests if !CONFIG_TOOLS

On 11/12/2019 15.24, Paolo Bonzini wrote: > From: Marc-André Lureau > > The block tests, as well as ahci-test needs qemu-img. Do not run > them if it wasn't built. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 4 > 1 file changed,

[PATCH] tests: skip block layer tests if !CONFIG_TOOLS

From: Marc-André Lureau The block tests, as well as ahci-test needs qemu-img. Do not run them if it wasn't built. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 4 1 file changed, 4 insertions(+) diff --git a/tests/Makefile.include

Re: Insufficiently documented deprecated command arguments

On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > > > Commit 7a9877a026 "block: Accept device model name for > > > block_set_io_throttle" (v2.8.0)

Re: Insufficiently documented deprecated command arguments

Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > > > > Commit 7a9877a026 "block: Accept device model

Re: [PATCH v6 28/42] stream: Deal with filters

On 16.09.19 11:52, Max Reitz wrote: > On 13.09.19 16:16, Kevin Wolf wrote: >> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >>> Because of the recent changes that make the stream job independent of >>> the base node and instead track the node above it, we have to split that >>> "bottom" node

Re: Insufficiently documented deprecated command arguments

On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote: > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: > > > Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > > > > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus

Re: Insufficiently documented deprecated command arguments

On Wed, Dec 11, 2019 at 12:32:10 +, Daniel Berrange wrote: > On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote: > > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben: > > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote: [...] > > > Well, in some specific cases we could

Re: Insufficiently documented deprecated command arguments

Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben: > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > > Commit 7a9877a026 "block: Accept device model name for > > block_set_io_throttle" (v2.8.0) deprecated block_set_io_throttle > > argument @device. > > This one is

Re: Insufficiently documented deprecated command arguments

On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote: > I went through the QAPI schema looking for deprecated stuff not > mentioned in qemu-deprecated.texi. Here's what I found: > > Commit b33945cfff "block: Accept device model name for > blockdev-open/close-tray" (v2.8.0)

Insufficiently documented deprecated command arguments

I went through the QAPI schema looking for deprecated stuff not mentioned in qemu-deprecated.texi. Here's what I found: Commit b33945cfff "block: Accept device model name for blockdev-open/close-tray" (v2.8.0) deprecated blockdev-open-tray, blockdev-close-tray argument @device.

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

10.12.2019 23:27, John Snow wrote: > > > On 12/10/19 8:24 AM, Max Reitz wrote: >> On 10.12.19 09:11, Max Reitz wrote: >>> On 09.12.19 23:03, Eric Blake wrote: On 12/9/19 11:58 AM, Max Reitz wrote: > On 09.12.19 17:30, Max Reitz wrote: >> On 02.12.19 15:09, Vladimir