Re: [PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound for cid

2023-09-26 Thread Stefan Hajnoczi
On Tue, Sep 26, 2023 at 11:15:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than > NVME_QUEUE_SIZE by 1. > > Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist") > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound for cid

2023-09-26 Thread Vladimir Sementsov-Ogievskiy
NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than NVME_QUEUE_SIZE by 1. Fixes: 1086e95da17050 ("block/nvme: switch to a NVMeRequest freelist") Signed-off-by: Vladimir Sementsov-Ogievskiy --- Cc: stefa...@redhat.com Cc: alex.c...@huawei.com Cc: euler.ro...@huawei.com Note, that

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

2023-09-26 Thread Denis V. Lunev
On 9/7/23 23:53, Denis V. Lunev wrote: Unfortunately 271 IO test is broken if started in non-cached mode. Commits commit a6b257a08e3d72219f03e461a52152672fec0612 Author: Nir Soffer Date: Tue Aug 13 21:21:03 2019 +0300 file-posix: Handle undetectable alignment and

Automatic block overlay creation with freeing the write lock

2023-09-26 Thread Rafael Pizarro Solar
Dear QEMU maintainers, For reference, I am using QEMU 8.0.0, and running with softmmu-aarch64. I have been trying implement a feature that directly creates an overlay with the goal of booting multiple instances from the same base image. Creating a backing file with `qemu-img` does work, but

Re: [PATCH] hw/nvme: Clean up local variable shadowing in nvme_ns_init()

2023-09-26 Thread Jesper Wendel Devantier
Klaus Jensen writes: > From: Klaus Jensen > > Fix local variable shadowing in nvme_ns_init(). > > Reported-by: Markus Armbruster > Signed-off-by: Klaus Jensen > --- > hw/nvme/ns.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c >

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

2023-09-26 Thread John Snow
On Tue, Sep 26, 2023, 8:06 AM Niklas Cassel wrote: > Hello Marcin, > > I will have a look at this. > > > Kind regards, > Niklas > Thanks. You have my blessing in advance to get any hot fixes for this merged ASAP, as long as another block maintainer is willing to give it an ACK. (I'll try to be

Re: [PATCH v2 12/22] hw/m68k: Clean up local variable shadowing

2023-09-26 Thread Thomas Huth
On 04/09/2023 18.12, Philippe Mathieu-Daudé wrote: Fix: hw/m68k/virt.c:263:13: error: declaration shadows a local variable [-Werror,-Wshadow] BOOTINFOSTR(param_ptr, BI_COMMAND_LINE, ^ hw/m68k/bootinfo.h:47:13: note: expanded from macro 'BOOTINFOSTR' int

[PATCH 1/5] block/fdc: 'phase' is not needed on load

2023-09-26 Thread marcandre . lureau
From: Marc-André Lureau It is reconstructed during fdc_post_load() Signed-off-by: Marc-André Lureau --- hw/block/fdc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index d7cc4d3ec1..fc71660ba0 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@

[PATCH 2/5] virtio: make endian_needed() work during loading

2023-09-26 Thread marcandre . lureau
From: Marc-André Lureau There is no simple way to distinguish when the callback is used for load or save, AFAICT. Signed-off-by: Marc-André Lureau --- hw/virtio/virtio.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index

[PATCH 5/5] RFC: migration: check required entries are loaded, once

2023-09-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- migration/savevm.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index bb3e99194c..6a17bb0f73 100644 --- a/migration/savevm.c +++

[PATCH 3/5] net/slirp: use different IDs for each instance

2023-09-26 Thread marcandre . lureau
From: Marc-André Lureau Using always 0, QEMU will end up loading the same instance, even if multiple have been saved. Signed-off-by: Marc-André Lureau --- net/slirp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index c33b3e02e7..af1451b60f

[PATCH 4/5] RFC: migration: check required subsections are loaded, once

2023-09-26 Thread marcandre . lureau
From: Marc-André Lureau Check that required subsections have been loaded. Signed-off-by: Marc-André Lureau --- migration/vmstate.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index

[PATCH 0/5] RFC: migration: check required entries and sections are loaded

2023-09-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, To my surprise, QEMU didn't seem to check that required migration entries and subsections are loaded. I took a naive approach to add such check, by adding some "visited" marks along the loading path, and checking by the end that all required entries have been loaded.

Re: [PATCH v3 0/4] block: clean up coroutine versions of bdrv_{is_allocated, block_status}*

2023-09-26 Thread Paolo Bonzini
On Mon, Sep 4, 2023 at 12:03 PM Paolo Bonzini wrote: > > Provide coroutine versions of bdrv_is_allocated* and bdrv_block_status*, > since the underlying BlockDriver API is coroutine-based, and use > automatically-generated wrappers for the "mixed" versions. > > v2->v3: cleaned up formatting

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

2023-09-26 Thread John Snow
On Tue, Sep 26, 2023, 3:11 AM Fiona Ebner wrote: > Am 25.09.23 um 21:53 schrieb John Snow: > > On Thu, Sep 21, 2023 at 12:07 PM Simon Rowe > wrote: > >> > >> When an IDE controller is reset, its internal state is being cleared > >> before any outstanding I/O is cancelled. If a response to DMA

FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

2023-09-26 Thread Marcin Juszkiewicz
I work on SBSA Reference Platform (sbsa-ref) at Linaro. And yesterday I wanted to check how non-Linux operating systems work on sbsa-ref machine. One of them was FreeBSD 13.2 - the latest one. Fetched bootonly ISO image [1] and booted system. 1.

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

2023-09-26 Thread Niklas Cassel
Hello Marcin, I will have a look at this. Kind regards, Niklas On 26 September 2023 13:23:46 CEST, Marcin Juszkiewicz wrote: >I work on SBSA Reference Platform (sbsa-ref) at Linaro. And yesterday I >wanted to check how non-Linux operating systems work on sbsa-ref machine. > >One of them

Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid

2023-09-26 Thread Peter Maydell
On Mon, 25 Sept 2023 at 20:42, Vladimir Sementsov-Ogievskiy wrote: > > NVMeQueuePair::reqs as length NVME_NUM_REQS, which less than > NVME_QUEUE_SIZE by 1. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nvme.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

2023-09-26 Thread Fiona Ebner
Am 25.09.23 um 21:53 schrieb John Snow: > On Thu, Sep 21, 2023 at 12:07 PM Simon Rowe wrote: >> >> When an IDE controller is reset, its internal state is being cleared >> before any outstanding I/O is cancelled. If a response to DMA is >> received in this window, the aio callback will incorrectly