Ping: Re: [PULL 4/5] hw/ufs: Support for UFS logical unit

2023-10-03 Thread Jeuk Kim
Dear Paolo This is a ping for the following. If you don't mind, could you give me some feedback? Thank you very much. Jeuk On 23. 9. 21. 17:38, Jeuk Kim wrote: Dear Paolo Hi. I've been looking into how ufs-lu can share code with scsi-hd. I have verified that ufs-lu can use scsi-hd's code,

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

2023-10-03 Thread Niklas Cassel
On Tue, Oct 03, 2023 at 08:11:39PM +0300, Michael Tokarev wrote: > 26.09.2023 15:05, Niklas Cassel: > > Hello Marcin, > > > > I will have a look at this. > > Hi Marcin, Hi Niklas! > > Niklas, I remember asking you if the whole thing is okay for the -stable, > and you was a bit unsure about it

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

2023-10-03 Thread Michael Tokarev
26.09.2023 15:05, Niklas Cassel: Hello Marcin, I will have a look at this. Hi Marcin, Hi Niklas! Niklas, I remember asking you if the whole thing is okay for the -stable, and you was a bit unsure about it :) Regardless, I picked the changes up for -stable. I don't think it was anyone's

Re: FreeBSD 13.2 installer does not see AHCI devices on aarch64/sbsa-ref and x86-64/q35

2023-10-03 Thread John Snow
While I'm poking at IDE today ... any news here? On Tue, Sep 26, 2023, 12:35 PM John Snow wrote: > > > On Tue, Sep 26, 2023, 8:06 AM Niklas Cassel wrote: > >> Hello Marcin, >> >> I will have a look at this. >> >> >> Kind regards, >> Niklas >> > > Thanks. You have my blessing in advance to get

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

2023-10-03 Thread John Snow
On Tue, Oct 3, 2023, 10:07 AM Niklas Cassel wrote: > On Mon, Sep 25, 2023 at 03:53:23PM -0400, John Snow wrote: > > Niklas, I'm sorry to lean on you here a little bit - You've been > > working on the SATA side of this a bit more often, can you let me know > > if you think this patch is safe? > >

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

2023-10-03 Thread Niklas Cassel
On Mon, Sep 25, 2023 at 03:53:23PM -0400, John Snow wrote: > Niklas, I'm sorry to lean on you here a little bit - You've been > working on the SATA side of this a bit more often, can you let me know > if you think this patch is safe? FWIW, I prefer Fiona's patch series which calls

Re: [PATCH v2 0/2] virtio-blk: add iothread-vq-mapping parameter

2023-10-03 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 12:16:02PM -0400, Stefan Hajnoczi wrote: > virtio-blk and virtio-scsi devices need a way to specify the mapping between > IOThreads and virtqueues. At the moment all virtqueues are assigned to a > single > IOThread or the main loop. This single thread can be a CPU

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

2023-10-03 Thread Simon Rowe
On Monday, 2 October 2023 John Snow wrote: > Which reset pathway are you testing that causes the problem? The test centres on a VM-initiated bus reset because a DMA write has stalled (I deliberately discard the iSCSI response). > I'm not fully clear on why checking for DRQ is legitimate here.

Re: [PATCH v4] block-jobs: flush target at the end of .run()

2023-10-03 Thread Vladimir Sementsov-Ogievskiy
On 03.08.23 05:43, Evanzhang wrote: [...] diff --git a/block/mirror.c b/block/mirror.c index d3cacd1708..cd19b49f7f 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1143,6 +1143,10 @@ immediate_exit: g_free(s->in_flight_bitmap); bdrv_dirty_iter_free(s->dbi); +if (ret >= 0) {

Re: [PATCH 1/2] blockdev: qmp_transaction: harden transaction properties for bitmaps

2023-10-03 Thread Vladimir Sementsov-Ogievskiy
On 19.09.23 13:02, Andrey Zhadchenko wrote: Hi! Thanks for the review On 9/12/23 21:29, Vladimir Sementsov-Ogievskiy wrote: On 04.09.23 11:31, Andrey Zhadchenko wrote: Unlike other transaction commands, bitmap operations do not drain target bds. If we have an IOThread, this may result in