On Mon, Jan 1, 2024 at 4:45 PM Hervé Poussineau wrote:
>
> Ping.
>
> Le 12/08/2023 à 10:59, Hervé Poussineau a écrit :
> > I don't understand when SEEK must be set or not, but it seems to fix
> > Minix...
> >
> > Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1522
> > Signed-off-by: Hervé
On Mon, Oct 16, 2023 at 3:21 PM Stefan Hajnoczi wrote:
>
> Applied, thanks.
>
> Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any
> user-visible changes.
Hi Vladimir: all done!
I've created a MR to backport your changes to the standalone repo
here:
ide_atapi_cmd_reply(s, ret, max_len);
> }
>
> break;
> }
> /* TODO: BD support, fall through for now */
> +fallthrough;
ACK. For a moment I was wondering if this was something new to gcc,
but I guess it's just
Create a socketpair for the console output. This should help eliminate
race conditions around console text early in the boot process that might
otherwise have been dropped on the floor before being able to connect to
QEMU under "server,nowait".
Signed-off-by: John Snow
Reviewed-by:
Python 3.12 has released, so update the test infrastructure to test
against this version. Update the configure script to look for it when an
explicit Python interpreter isn't chosen.
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20231006195243.3131140-5-js
-by: John Snow
---
python/qemu/qmp/qmp_shell.py | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/python/qemu/qmp/qmp_shell.py b/python/qemu/qmp/qmp_shell.py
index 619ab42ced..988d79c01b 100644
--- a/python/qemu/qmp/qmp_shell.py
+++ b/python/qemu/qmp
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-7-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index
- but instead, this waits for all connections to
close. Or, it would have, if it wasn't broken since it was introduced.
3.12 fixes the bug, which now causes a hang in our code. The fix is just
to remove the wait.
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id
This property isn't meant to do much else besides return a list of
strings, so move this setup back out into _pre_launch().
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P. Berrangé
Message-id: 20230928044943.849073-2-js...@redhat.com
Signed-off-by: John Snow
---
python
-4-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
scripts/cpu-x86-uarch-abi.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py
index 82ff07582f..893afd1b35 100644
--- a/scripts/cpu-x86-uarch-abi.py
From: Vladimir Sementsov-Ogievskiy
Add similar method for consistency.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-8-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 7 ++-
1 file changed, 6
Useful if we want to use ConsoleSocket() for a socket created by
socketpair().
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P. Berrangé
Message-id: 20230928044943.849073-4-js...@redhat.com
Signed-off-by: John Snow
---
python/qemu/machine/console_socket.py | 29
From: Vladimir Sementsov-Ogievskiy
We don't expect failure here and need 'result' object. cmd() is better
in this case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-14-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
tests/vm
.)
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20231006195243.3131140-2-js...@redhat.com
Signed-off-by: John Snow
---
tests/qemu-iotests/tests/nbd-multiconn | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-9-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
tests/qemu-iotests/041| 1 +
tests/qemu-iotests/151
-team.ru
Signed-off-by: John Snow
---
python/qemu/qmp/legacy.py | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index e1e9383978..fe115e301c 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -195,20
From: Vladimir Sementsov-Ogievskiy
To simplify further conversion.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-10-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
tests/qemu-iotests/040 | 3 ++-
tests/qemu-iotests/147 | 3
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-11-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
tests/qemu-iotests/041 | 2 +-
tests/qemu-iotests/196 | 2 +-
2 files changed, 2 insertions
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20231006195243.3131140-4-js...@redhat.com
Signed-off-by: John Snow
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 8fada85a71..a49fc7b7e7 100755
update three occurrences in
tests/avocado/machine_aspeed.py and keep r-b]
Signed-off-by: John Snow
---
docs/devel/testing.rst| 10 +-
python/qemu/machine/machine.py| 8 +-
python/qemu/qmp/legacy.py | 2 +-
python/qemu/qmp/qmp_shell.py
Signed-off-by: John Snow
---
tests/qemu-iotests/040| 4 +-
tests/qemu-iotests/041| 14 +++---
tests/qemu-iotests/129| 2 +-
tests/qemu-iotests/147| 2 +-
tests/qemu-iotests/155
Like the QMP and console sockets, begin using socketpairs for the qtest
connection, too. After this patch, we'll be able to remove the vestigial
sock_dir argument, but that cleanup is best done in its own patch.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
Message-id
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-5-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 2 +-
python/qemu/qmp/legacy.py | 4 ++--
tests/qemu-iotests/iotests.py | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Vladimir Sementsov-Ogievskiy
The returned value is unused. It's simple to check by command
git grep -B 3 '\.pause_job('
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-13-vsement...@yandex-team.ru
Signed-off-by: John Snow
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-id: 20231006154125.1068348-15-vsement...@yandex-team.ru
Signed-off-by: John Snow
---
scripts/python_qmp_updater.py | 136 ++
1 file changed, 136 insertions(+)
create mode 1007
but flubbed the launch and need to clean up resources. These resources
*would* be handled by the garbage collector, but that can happen at
unpredictable times. Nicer to just clean them up synchronously on the
exit path, here.
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P
long" as
a socket name on macOS. We don't need it for this class now. In one
case, avocado testing takes over responsibility for creating an
appropriate sockdir.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
Message-id: 20230928044943.849073-7-js...@redhat.com
Signed-off-by: John Snow
-
connections
- Support Python 3.12
- Switch iotests over to using raise-on-error QMP command interface
(Thank you very much, Vladimir!)
John Snow (10):
python/machine: move socket setup out of _base_args property
python/machine: close
ch, char *isoimage)
>^
> tests/qtest/cdrom-test.c:18:13: note: previous declaration is here
> static char isoimage[] = "cdrom-boot-iso-XX";
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: John Snow
> ---
On Thu, Oct 12, 2023 at 1:52 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 12.10.23 01:04, John Snow wrote:
> > On Fri, Oct 6, 2023 at 11:41 AM Vladimir Sementsov-Ogievskiy
> > wrote:
> >>
> >> Hi all!
> >>
> >> Let's
n_qmp_updater.py
>
> --
> 2.34.1
>
I rebased this on top of my python branch today and confirmed all of
my python tests pass - I'm happy enough with it from the Python
perspective. I think it's the right thing to do, and I'm happy you did
it, but I can't begin to pretend I audited the rewrite script or the
actual output it produced - I did not.
But:
Reviewed-by: John Snow (Patches 1-6, Patch 13)
Tested-by: John Snow (All - I went patch by patch
and ran my Python tests and made sure nothing regressed.)
Acked-by: John Snow (All)
--js
On Fri, Oct 6, 2023 at 4:40 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 06.10.23 22:52, John Snow wrote:
> > Python 3.12 has released, so update the test infrastructure to test
> > against this version. Update the configure script to look for it when an
> > explicit
Python 3.12 has released, so update the test infrastructure to test
against this version. Update the configure script to look for it when an
explicit Python interpreter isn't chosen.
Signed-off-by: John Snow
---
configure | 3 ++-
python/setup.cfg
A few mostly trivial fixes, one backport from the qemu.qmp repo, and
enabling the Python tests to run against Python3.12.
John Snow (4):
Python/iotests: Add type hint for nbd module
python/qmp: remove Server.wait_closed() call for Python 3.12
configure: fix error message to say Python 3.8
Signed-off-by: John Snow
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index e08127045d..e9a921ffb0 100755
--- a/configure
+++ b/configure
@@ -944,7 +944,7 @@ then
# If first_python is set, there was a binary somewhere even though
- but instead, this waits for all connections to
close. Or, it would have, if it wasn't broken since it was introduced.
3.12 fixes the bug, which now causes a hang in our code. The fix is just
to remove the wait.
Signed-off-by: John Snow
---
python/qemu/qmp/protocol.py | 1 -
1 file changed, 1
.)
Signed-off-by: John Snow
Reviewed-by: Eric Blake
---
tests/qemu-iotests/tests/nbd-multiconn | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/tests/nbd-multiconn
b/tests/qemu-iotests/tests/nbd-multiconn
index 478a1eaba2..7e686a786e 100755
--- a/tests
revious declaration is here
> void ahci_uninit(AHCIState *s)
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: John Snow
> ---
> hw/ide/ahci.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/ide
On Thu, Oct 5, 2023, 9:00 AM Stefan Hajnoczi wrote:
> On Thu, 5 Oct 2023 at 00:49, Philippe Mathieu-Daudé
> wrote:
> >
> > Hi John,
> >
> > On 4/10/23 21:46, John Snow wrote:
> > > The following changes since commit
> da1034094d375afe9e3d8ec8
On Thu, Oct 5, 2023, 10:05 AM Eric Blake wrote:
> On Wed, Oct 04, 2023 at 03:46:05PM -0400, John Snow wrote:
> > The test bails gracefully if this module isn't installed, but linters
> > need a little help understanding that. It's enough to just declare the
> > type in this
This property isn't meant to do much else besides return a list of
strings, so move this setup back out into _pre_launch().
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P. Berrangé
Message-id: 20230928044943.849073-2-js...@redhat.com
Signed-off-by: John Snow
---
python
Python 3.12 has released, so update the test infrastructure to test
against this version.
Signed-off-by: John Snow
---
python/setup.cfg | 3 ++-
tests/docker/dockerfiles/python.docker | 6 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/python
.)
Signed-off-by: John Snow
---
tests/qemu-iotests/tests/nbd-multiconn | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/tests/nbd-multiconn
b/tests/qemu-iotests/tests/nbd-multiconn
index 478a1eaba27..7e686a786ea 100755
--- a/tests/qemu-iotests/tests/nbd
but flubbed the launch and need to clean up resources. These resources
*would* be handled by the garbage collector, but that can happen at
unpredictable times. Nicer to just clean them up synchronously on the
exit path, here.
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P
- but instead, this waits for all connections to
close. Or, it would have, if it wasn't broken since it was introduced.
3.12 fixes the bug, which now causes a hang in our code. The fix is just
to remove the wait.
Signed-off-by: John Snow
---
python/qemu/qmp/protocol.py | 1 -
1 file changed, 1
Like the QMP and console sockets, begin using socketpairs for the qtest
connection, too. After this patch, we'll be able to remove the vestigial
sock_dir argument, but that cleanup is best done in its own patch.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
Message-id
Useful if we want to use ConsoleSocket() for a socket created by
socketpair().
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P. Berrangé
Message-id: 20230928044943.849073-4-js...@redhat.com
Signed-off-by: John Snow
---
python/qemu/machine/console_socket.py | 29
long" as
a socket name on macOS. We don't need it for this class now. In one
case, avocado testing takes over responsibility for creating an
appropriate sockdir.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
Message-id: 20230928044943.849073-7-js...@redhat.com
Signed-off-by: John Snow
-
Create a socketpair for the console output. This should help eliminate
race conditions around console text early in the boot process that might
otherwise have been dropped on the floor before being able to connect to
QEMU under "server,nowait".
Signed-off-by: John Snow
Reviewed-by:
John Snow (9):
Python/iotests: Add type hint for nbd module
python/machine: move socket setup out of _base_args property
python/machine: close sock_pair in cleanup path
python/console_socket: accept existing FD in initializer
While I'm poking at IDE today ... any news here?
On Tue, Sep 26, 2023, 12:35 PM John Snow wrote:
>
>
> On Tue, Sep 26, 2023, 8:06 AM Niklas Cassel wrote:
>
>> Hello Marcin,
>>
>> I will have a look at this.
>>
>>
>> Kind regards,
>> Niklas
On Tue, Oct 3, 2023, 10:07 AM Niklas Cassel wrote:
> On Mon, Sep 25, 2023 at 03:53:23PM -0400, John Snow wrote:
> > Niklas, I'm sorry to lean on you here a little bit - You've been
> > working on the SATA side of this a bit more often, can you let me know
> > if you thi
On Mon, Oct 2, 2023 at 5:09 AM Simon Rowe wrote:
>
> On Thursday, 28 September 2023 Fiona Ebner wrote:
>
>
>
> > AFAICT, yes, because the DMA callback is invoked before resetting the
> > state now. But not 100% sure if it can't be triggered in some other way,
> > maybe Simon knows more? I don't
On Thu, Sep 28, 2023, 4:12 AM Daniel P. Berrangé
wrote:
> On Thu, Sep 28, 2023 at 12:49:37AM -0400, John Snow wrote:
> > Like we did for the QMP socket, use socketpair() for the console socket
> > so that hopefully there isn't a race condition during early boot where
> > d
This property isn't meant to do much else besides return a list of
strings, so move this setup back out into _pre_launch().
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P. Berrangé
---
python/qemu/machine/machine.py | 5 ++---
1 file changed, 2 insertions(+), 3
.
- dropped sock_dir arg from *all* machine.py classes
- Tested quite a bit more thoroughly ...
CI: https://gitlab.com/jsnow/qemu/-/pipelines/1019123030
John Snow (6):
python/machine: move socket setup out of _base_args property
python/machine: close sock_pair in cleanup path
python
long" as
a socket name on macOS. We don't need it for this class now. In one
case, avocado testing takes over responsibility for creating an
appropriate sockdir.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
---
python/qemu/machine/machine.py | 18 --
python/qe
but flubbed the launch and need to clean up resources. These resources
*would* be handled by the garbage collector, but that can happen at
unpredictable times. Nicer to just clean them up synchronously on the
exit path, here.
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P
Useful if we want to use ConsoleSocket() for a socket created by
socketpair().
Signed-off-by: John Snow
Reviewed-by: Ani Sinha
Reviewed-by: Daniel P. Berrangé
---
python/qemu/machine/console_socket.py | 29 +++
1 file changed, 21 insertions(+), 8 deletions(-)
diff
Like the QMP and console sockets, begin using socketpairs for the qtest
connection, too. After this patch, we'll be able to remove the vestigial
sock_dir argument, but that cleanup is best done in its own patch.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
---
python/qemu/machine
Create a socketpair for the console output. This should help eliminate
race conditions around console text early in the boot process that might
otherwise have been dropped on the floor before being able to connect to
QEMU under "server,nowait".
Signed-off-by: John Snow
Reviewed-by:
On Tue, Sep 26, 2023, 8:06 AM Niklas Cassel wrote:
> Hello Marcin,
>
> I will have a look at this.
>
>
> Kind regards,
> Niklas
>
Thanks. You have my blessing in advance to get any hot fixes for this
merged ASAP, as long as another block maintainer is willing to give it an
ACK. (I'll try to be
On Tue, Sep 26, 2023, 3:11 AM Fiona Ebner wrote:
> Am 25.09.23 um 21:53 schrieb John Snow:
> > On Thu, Sep 21, 2023 at 12:07 PM Simon Rowe
> wrote:
> >>
> >> When an IDE controller is reset, its internal state is being cleared
> >> before any outstanding
Niklas, I'm sorry to lean on you here a little bit - You've been
working on the SATA side of this a bit more often, can you let me know
if you think this patch is safe?
I'm not immediately sure what the impact of applying it is, but I have
some questions about it:
(1) When does ide_dma_cb get
On Thu, Sep 7, 2023, 12:49 PM Michael Tokarev wrote:
> 07.09.2023 06:42, John Snow wrote:
>
> >
> > IDE Pull request
> >
> >
> >
all ncq_finish(), thus using ncq_tfs->used is
sufficient to tell if finished should get set or not.
Signed-off-by: Niklas Cassel
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20230609140844.202795-9-...@flawful.org
Signed-off-by: John Snow
---
hw/ide/ahci.c | 3 +--
1 file changed, 1 ins
I guess the last time I sent IDE patches was for 6.2 and that tag got
stuck in my git-publish invocation, oops. I am not suggesting we break
the laws of causality to merge these patches.
On Wed, Sep 6, 2023 at 11:42 PM John Snow wrote:
>
> The following changes since
and
RegFIS:ClearCI.
Signed-off-by: Niklas Cassel
Message-id: 20230609140844.202795-5-...@flawful.org
Signed-off-by: John Snow
---
hw/ide/ahci.c | 70 ---
1 file changed, 50 insertions(+), 20 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index
by: Niklas Cassel
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20230609140844.202795-6-...@flawful.org
Signed-off-by: John Snow
---
hw/ide/ahci.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 3deaf01add..a31e6fa65e 100644
--- a/hw/ide/ahci.c
++
).
Before this commit, there was never a TFES IRQ raised on NCQ error.
Signed-off-by: Niklas Cassel
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20230609140844.202795-8-...@flawful.org
Signed-off-by: John Snow
---
hw/ide/ahci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions
The following changes since commit c152379422a204109f34ca2b43ecc538c7d738ae:
Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into
staging (2023-09-06 11:16:01 -0400)
are available in the Git repository at:
https://gitlab.com/jsnow/qemu.git tags/ide-pull-request
for
-...@flawful.org
Signed-off-by: John Snow
---
hw/ide/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index ee116891ed..b5e0dcd29b 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -533,9 +533,9 @@ BlockAIOCB *ide_issue_trim(
void
Message-id: 20230609140844.202795-4-...@flawful.org
Signed-off-by: John Snow
---
hw/ide/ahci.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 48d550f633..4b272397fd 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -43,7 +43,7 @@
s
-off-by: John Snow
---
tests/qtest/libqos/ahci.h | 8 ++-
hw/ide/ahci.c | 7 ++-
tests/qtest/libqos/ahci.c | 106 --
3 files changed, 88 insertions(+), 33 deletions(-)
diff --git a/tests/qtest/libqos/ahci.h b/tests/qtest/libqos/ahci.h
index
On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev
wrote:
>
> On 8/16/23 12:22, Andrey Drobyshev wrote:
> > On 7/31/23 17:51, Andrey Drobyshev wrote:
> >> On 7/24/23 16:11, Andrey Drobyshev wrote:
> >>> On 7/11/23 20:25, Andrey Drobyshev wrote:
> v1 --> v2:
> * Fixed line indentation;
>
On Mon, Aug 7, 2023, 6:33 AM Niklas Cassel wrote:
> On Tue, Jul 25, 2023 at 03:00:56PM -0400, John Snow wrote:
> > On Tue, Jul 25, 2023 at 9:04 AM Philippe Mathieu-Daudé
> > wrote:
> > >
> > > Hi Niklas, John, Paolo, Kevin,
> > >
&
On Wed, Jul 26, 2023, 6:50 AM Ani Sinha wrote:
>
>
> > On 25-Jul-2023, at 11:33 PM, John Snow wrote:
> >
> > Create a socketpair for the console output. This should help eliminate
> > race conditions around console text early in the boot process that might
&
On Tue, Jul 25, 2023 at 9:04 AM Philippe Mathieu-Daudé
wrote:
>
> Hi Niklas, John, Paolo, Kevin,
>
> On 19/7/23 12:47, Niklas Cassel wrote:
>
> >> Niklas Cassel (8):
> >>hw/ide/ahci: remove stray backslash
> >>hw/ide/core: set ERR_STAT in unsupported command completion
> >>
On Tue, Jul 25, 2023 at 2:26 PM Daniel P. Berrangé wrote:
>
> On Tue, Jul 25, 2023 at 02:03:37PM -0400, John Snow wrote:
> > By using a socketpair for all of the sockets managed by the VM class and
> > its extensions, we don't need the sock_dir argument anymore, so remove
>
from *all* machine.py classes
- Tested quite a bit more thoroughly ...
CI: https://gitlab.com/jsnow/qemu/-/pipelines/945067498
John Snow (6):
python/machine: move socket setup out of _base_args property
python/machine: close sock_pair in cleanup path
python/console_socket: accept existing
Like the QMP and console sockets, begin using socketpairs for the qtest
connection, too. After this patch, we'll be able to remove the vestigial
sock_dir argument, but that cleanup is best done in its own patch.
Signed-off-by: John Snow
---
python/qemu/machine/qtest.py | 49
Create a socketpair for the console output. This should help eliminate
race conditions around console text early in the boot process that might
otherwise have been dropped on the floor before being able to connect to
QEMU under "server,nowait".
Signed-off-by: John Snow
---
python/qe
long" as
a socket name on macOS. We don't need it for this class now. In one
case, avocado testing takes over responsibility for creating an
appropriate sockdir.
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 18 --
python/qemu/machine/qtest.py
Useful if we want to use ConsoleSocket() for a socket created by
socketpair().
Signed-off-by: John Snow
---
python/qemu/machine/console_socket.py | 29 +++
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/python/qemu/machine/console_socket.py
b/python/qemu
but flubbed the launch and need to clean up resources. These resources
*would* be handled by the garbage collector, but that can happen at
unpredictable times. Nicer to just clean them up synchronously on the
exit path, here.
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 5 +
1
This property isn't meant to do much else besides return a list of
strings, so move this setup back out into _pre_launch().
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/python/qemu/machine/machine.py b
On Thu, Jul 20, 2023 at 10:01 AM Daniel P. Berrangé wrote:
>
> On Thu, Jul 20, 2023 at 09:04:46AM -0400, John Snow wrote:
> > Useful if we want to use ConsoleSocket() for a socket created by
> > socketpair().
> >
> > Signed-off-by: John Snow
> > ---
> &
On Thu, Jul 20, 2023 at 10:05 AM Daniel P. Berrangé wrote:
>
> On Thu, Jul 20, 2023 at 09:04:48AM -0400, John Snow wrote:
> > By using a socketpair for the console, we don't need the sock_dir
> > argument for the base class anymore, remove it.
> >
> > The qtest su
This property isn't meant to do much else besides return a list of
strings, so move this setup back out into _pre_launch().
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/python/qemu/machine/machine.py b
Create a socketpair for the console output. This should help eliminate
race conditions around console text early in the boot process that might
otherwise have been dropped on the floor before being able to connect to
QEMU under "server,nowait".
Signed-off-by: John Snow
---
python/qe
Useful if we want to use ConsoleSocket() for a socket created by
socketpair().
Signed-off-by: John Snow
---
python/qemu/machine/console_socket.py | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/python/qemu/machine/console_socket.py
b/python/qemu/machine
By using a socketpair for the console, we don't need the sock_dir
argument for the base class anymore, remove it.
The qtest subclass still uses the argument for the qtest socket for now.
Signed-off-by: John Snow
---
python/qemu/machine/machine.py | 18 --
python
Like we did for the QMP socket, use socketpair() for the console socket
so that hopefully there isn't a race condition during early boot where
data might get dropped on the floor.
"lightly tested"; passes local tests and gitlab CI. Doesn't seem to make
anything worse.
John Snow (4)
On Thu, Jun 22, 2023 at 5:12 PM Paolo Bonzini wrote:
>
> On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote:
> >
> > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote:
> > >
> > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote:
> > > > If we
On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote:
>
> On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote:
> > If we always install it in editable mode, and the path where it is
> > "installed" is what we expect it to be, it shouldn't have any problems
> > with
On Thu, Jun 22, 2023 at 5:24 AM Paolo Bonzini wrote:
>
> On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini wrote:
> > Maybe patch 4 can use distlib.scripts as well to create the check script in
> > the build directory? (Yes that's another mkvenv functionality...) On a
> > phone and don't have the
Resolve the build_root before we append more items onto it so that the
environment output is more concise with less parent directory confetti
in it.
Signed-off-by: John Snow
---
tests/qemu-iotests/testenv.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests
h 4 to use the correct Python to launch
iotests, but I'm wondering if there's a nicer way to solve this
more *completely*.
John Snow (6):
experiment: add mkvenv install
build, tests: Add qemu in-tree packages to pyvenv at configure time.
iotests: get rid of '..' in path environment output
io
qemu.* should be provided by the configure-time venv, now.
Signed-off-by: John Snow
---
tests/qemu-iotests/testenv.py | 4
1 file changed, 4 deletions(-)
diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py
index 1b095d70f2..6441145701 100644
--- a/tests/qemu-iotests
Whichever python is used to run iotest 297 should be the one used to
actually run the linters.
Signed-off-by: John Snow
---
tests/qemu-iotests/linters.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/linters.py b/tests/qemu-iotests/linters.py
index
1 - 100 of 5295 matches
Mail list logo
