On 06/29/2015 10:24 AM, Stefan Hajnoczi wrote:
On Fri, Jun 26, 2015 at 02:27:39PM -0400, John Snow wrote:
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256
On 06/26/2015 11:35 AM, Stefan Hajnoczi wrote:
On Mon, Jun 22, 2015 at 08:21:05PM -0400, John Snow wrote:
Handle NCQ failures
On 07/05/2015 10:53 AM, Kevin O'Connor wrote:
On Tue, Jun 30, 2015 at 09:20:40PM -0400, John Snow wrote:
The 2.88 drive is more suitable as a default because
it can still read 1.44 images correctly, but the reverse
is not true.
Since there exist virtio-win drivers that are shipped on
2.88
.
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch ahci-sig
https://github.com/jnsnow/qemu/tree/ahci-sig
This version is tagged ahci-sig-v1:
https://github.com/jnsnow/qemu/releases/tag/ahci-sig-v1
Hannes Reinecke (1):
ahci: Fix CD-ROM signature
John Snow (1
From: Hannes Reinecke h...@suse.de
The CD-ROM signature is 0xeb140101, not 0xeb14.
Without this change OVMF/Duet runs into a timeout trying
to detect a SATA cdrom.
Signed-off-by: Hannes Reinecke h...@suse.de
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.h | 2 +-
1 file changed
) port reset.
(2) the signature cache register is no longer set manually per-each
device type, but instead just once during ahci_init_d2h.
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 33 -
1 file changed, 20 insertions(+), 13 deletions(-)
diff
On 06/29/2015 09:34 AM, Stefan Hajnoczi wrote:
On Fri, Jun 26, 2015 at 02:16:57PM -0400, John Snow wrote:
On 06/26/2015 10:32 AM, Stefan Hajnoczi wrote:
On Mon, Jun 22, 2015 at 08:21:00PM -0400, John Snow wrote:
diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 4afd0cf..a295baa
100644 --- a/hw
On 05/20/2015 05:27 AM, Stefan Hajnoczi wrote:
On Tue, May 19, 2015 at 06:15:23PM -0400, John Snow wrote:
On 05/18/2015 11:45 AM, Stefan Hajnoczi wrote:
On Mon, May 11, 2015 at 07:04:21PM -0400, John Snow wrote:
If we want to get at the job after the life of the job, we'll
need a refcount
-by: Kevin Wolf kw...@redhat.com
---
hw/block/fdc.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
Reviewed-by: John Snow js...@redhat.com
have all parameters
* and will be able to treat the command
*/
+fdctrl-phase = FD_PHASE_EXECUTION;
if (fdctrl-data_state FD_STATE_FORMAT) {
fdctrl_format_sector(fdctrl);
return;
Acked-by: John Snow js...@redhat.com
Looks ok
On 05/22/2015 04:22 AM, Kevin Wolf wrote:
Am 21.05.2015 um 23:48 hat John Snow geschrieben:
On 05/20/2015 04:20 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 05/12/2015 04:06 PM, Eric Blake wrote:
On 05/12/2015 01:53 PM, John Snow wrote:
Bitmaps can be in a handful
On 05/22/2015 11:02 AM, Kevin Wolf wrote:
Am 18.04.2015 um 01:50 hat John Snow geschrieben:
Signed-off-by: John Snow js...@redhat.com
Reviewed-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/124 | 174
+++--
tests/qemu-iotests/124.out
RHEL6 doesn't have Python 2.7, so replace this call with
assertNotEqual(x, None) which will work just as well.
Reported-by: Kevin Wolf kw...@redhat.com
Signed-off-by: John Snow js...@redhat.com
---
tests/qemu-iotests/124 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
On 07/04/2015 02:47 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
On 07/03/2015 09:34 AM, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Respect the default drive type as proffered via the CLI.
This patch overloads the drive out parameter of pick_geometry
On 06/29/2015 04:16 PM, John Snow wrote:
This RFC requires my ahci-ncq-s2 patchset and all of its dependencies.
Fix the BMDMA underflow code to acknowledge the new 'limit' parameter,
without breaking or modifying the existing ide-tests.
This approach uses s-io_buffer_size as a return
final ping:
I'll pull this as a pre-requisite for the NCQ fixes (part 1) series that
has been reviewed unless there are objections to this series.
--js
On 06/16/2015 12:02 PM, John Snow wrote:
This is a small handful of fixes for the ahci-tests/ahci device,
alongside two new tests. I have
Peter: I assume you still want this for 2.4 to fix the clang warnings, yes?
On 07/21/2015 02:02 PM, John Snow wrote:
There are likely others that could be updated, but we'll
go with a light touch for 2.4 for now.
Without the Unsigned specifier, this shifts bits into the
signed bit, which
On 07/14/2015 04:30 AM, Paolo Bonzini wrote:
On 13/07/2015 21:41, John Snow wrote:
s-ports should never exceed 32, but coverity doesn't know that.
ncq_tfs-sector_count should also never exceed 64K.
Personally I tend to mark that kind of thing as a false
positive in the coverity UI
Just a handful of casts to quiet coverity up.
s-ports should never exceed 32, but coverity doesn't know that.
ncq_tfs-sector_count should also never exceed 64K.
Why not make Coverity a happy camper, though.
Signed-off-by: John Snow js...@redhat.com
---
hw/ide/ahci.c | 8
hw/ide
On 07/13/2015 03:40 PM, Peter Maydell wrote:
On 13 July 2015 at 20:26, John Snow js...@redhat.com wrote:
Just a handful of casts to quiet coverity up.
s-ports should never exceed 32, but coverity doesn't know that.
ncq_tfs-sector_count should also never exceed 64K.
Personally I tend
On 07/13/2015 06:18 AM, Kevin Wolf wrote:
Am 11.07.2015 um 03:05 hat John Snow geschrieben:
We're supposed to abort on transfers like this, unless we fill
Word 125 of our IDENTIFY data with a default transfer size, which
we don't currently do.
This is an ATA error, not a SCSI/ATAPI one
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
qemu-io-cmds.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 6e5d1e4..704db89 100644
--- a/qemu-io-cm
On 10/26/2015 05:18 PM, Max Reitz wrote:
> On 26.10.2015 19:12, John Snow wrote:
>> For more complex BDS trees that can be created under normal circumstances,
>> we lose the ability to issue query commands because of our inability to
>> re-construct the absolute filename
Signed-off-by: John Snow <js...@redhat.com>
---
qemu-io-cmds.c | 58 +-
1 file changed, 37 insertions(+), 21 deletions(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index e2477fc..92c6b87 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-
Make sure there's not trailing garbage, e.g.
"64k-whatever-i-want-here"
Reported-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
qemu-io-cmds.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qemu-io-cmds.c
cvtnum() returns int64_t: we should not be storing this
result inside of an int.
In a few cases, we need an extra sprinkling of error handling
where we expect to pass this number on towards a function that
expects something smaller than int64_t.
Signed-off-by: John Snow <js...@redhat.
is available at:
https://github.com/jnsnow/qemu.git branch qemu-io-tidy
https://github.com/jnsnow/qemu/tree/qemu-io-tidy
This version is tagged qemu-io-tidy-v1:
https://github.com/jnsnow/qemu/releases/tag/qemu-io-tidy-v1
John Snow (3):
qemu-io: fix cvtnum lval types
qemu-io: Check for trailing chars
On 10/26/2015 06:54 PM, Eric Blake wrote:
> On 10/26/2015 04:06 PM, John Snow wrote:
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>> qemu-io-cmds.c | 58
>> +-
>> 1 file changed, 37 insertio
mpt to build one that big anymore.
Reported-by: Kevin Wolf <kw...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
hw/ide/ahci.c | 30 ++
hw/ide/internal.h | 2 +-
hw/ide/pci.c | 7 ---
3 files changed, 15 insertions(+), 24 deletions
On 10/26/2015 10:26 PM, Eric Blake wrote:
> On 10/26/2015 05:45 PM, John Snow wrote:
>> Reported-by: Max Reitz <mre...@redhat.com>
>> Signed-off-by: John Snow <js...@redhat.com>
>> Reviewed-by: Eric Blake <ebl...@redhat
the expected output in iotest 110, where we will now see a
json filename and the lack of an absolute filename instead of an error.
Signed-off-by: John Snow <js...@redhat.com>
---
block/qapi.c | 10 ++
tests/qemu-iotests/110.out | 5 -
2 files changed, 10 insertions
Switch over to the new .commit/.abort handlers for
cleaning up incremental bitmaps.
[split up from a patch originally by Stefan and Fam. --js]
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.c
unction
blockjob: Introduce reference count and fix reference to job->bs
blockjob: Add .commit and .abort block job actions
blockjob: Add "completed" and "ret" in BlockJob
blockjob: Simplify block_job_finish_sync
block: Add block job transactions
John Snow (7):
q
shouldn't live longer
than its bs, as asserted in bdrv_delete.
Now block_job_complete_sync can be simplified.
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
block/mirror.c | 2 +-
blockdev.c | 28 ---
alongside a full backup to
accomplish a clean synchronization point.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Stefan Hajno
y comments and names, and should not affect
behavior in any way.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Reviewed-by: Fam
From: Fam Zheng <f...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
include/block/blockjob.h | 20
Test simple usage cases for using transactions to create
and synchronize incremental backups.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefa...
From: Fam Zheng <f...@redhat.com>
This will be reused by the coming new transactional completion code.
Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redh
.
[split up from a patch originally by Stefan and Fam. --js]
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
block/backup.c
x Reitz <mre...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
tests/Makefile| 3 +
tests/test-blockjob-txn.c | 244 +++
From: Fam Zheng <f...@redhat.com>
With job->completed and job->ret to replace BlockFinishData.
Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Signed-off-by: John Snow <js...
() to convert underscores in Python argument names
to hyphens for QMP argument names.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
---
On 11/10/2015 03:16 PM, Thomas Huth wrote:
> The "return;" statements at the end of functions do not make
> much sense, so let's remove them.
>
> Cc: John Snow <js...@redhat.com>
> Cc: qemu-block@nongnu.org
> Signed-off-by: Thomas Huth <th...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
hw/ide/atapi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 747f466..1471ae2 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -167,6 +167,17 @
pi-bclimit-netbsd
This version is tagged atapi-bclimit-netbsd-v1:
https://github.com/jnsnow/qemu/releases/tag/atapi-bclimit-netbsd-v1
John Snow (2):
atapi: add byte_count_limit helper
atapi: Prioritize unknown cmd error over BCL error
hw/ide/atapi.c | 38 +++---
1
If we don't know about the command at all, we need to prioritize
that failure above the zero byte-count-limit failure.
This fixes a failure in the sparc64 NetBSD 7.0 installer bootup.
Reported-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
Signed-off-by: John Snow <js...@r
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 51 +--
1 file changed, 29 insertions(+), 22 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 59d387c..6d9ac84 100644
--- a/tests/ahci-test.c
+++ b/test
binaries a little more apparent in case we find a way to bump
into them again.
John Snow (3):
qtest/ahci: always specify image format
libqos: add qemu-img presence check
qtest/ahci: use raw format when qemu-img is absent
tests/ahci-test.c | 90
If we don't have the qemu-img tool, use the raw format
for tests and skip the high-sector LBA48 tests.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 41 -
1 file changed, 32 insertions(+), 9 deletions(-)
diff --git a/test
On 11/13/2015 06:13 AM, Mark Cave-Ayland wrote:
> On 12/11/15 16:30, Peter Lieven wrote:
>
>> This series aims at avoiding a hanging main-loop if a vserver has a
>> CDROM image mounted from a NFS share and that NFS share goes down.
>> Typical situation is that users mount an CDROM ISO to
On 11/12/2015 02:51 PM, John Snow wrote:
> If we don't have the qemu-img tool, use the raw format
> for tests and skip the high-sector LBA48 tests.
>
> Signed-off-by: John Snow <js...@redhat.com>
> ---
> tests/ahci-test.c | 41 ---
binaries a little more apparent in case we find a way to bump
into them again.
v2: Fix type; size_t -> uint64_t. (Fails i386 tests.)
John Snow (3):
qtest/ahci: always specify image format
libqos: add qemu-img presence check
qtest/ahci: use raw format when qemu-img is absent
tests/ahci-tes
To allow tests to optionally exercise additional tests
that require the qemu-img tool that may not be present
in all builds.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/libqos/libqos.c | 28 +++-
tests/libqos/libqos.h | 1 +
2 files changed, 24 insertions
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 51 +--
1 file changed, 29 insertions(+), 22 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 59d387c..6d9ac84 100644
--- a/tests/ahci-test.c
+++ b/test
On 11/12/2015 01:23 AM, Fam Zheng wrote:
> On Mon, 11/09 23:39, Max Reitz wrote:
>> bdrv_delete() is not very happy about deleting BlockDriverStates with
>> dirty bitmaps still attached to them. In the past, we got around that
>> very easily by relying on bdrv_close_all() bypassing
e/pci.c | 19
> include/sysemu/block-backend.h | 3 ++
> 6 files changed, 182 insertions(+), 25 deletions(-)
>
It looks sane to me:
Reviewed-by: John Snow <js...@redhat.com>
Fam, Stefan: Do you think this is still sane for 2.5? I am inclined to
get it in as a fix, especially since we've been bouncing it around for
so long.
--js
On 11/13/2015 06:00 PM, Peter Lieven wrote:
>
>
>> Am 13.11.2015 um 23:42 schrieb John Snow <js...@redhat.com>:
>>
>>
>>
>>> On 11/12/2015 11:30 AM, Peter Lieven wrote:
>>> PIO read requests on the ATAPI interface used to be sync blk r
address.
>>
>>>
>>> Only bug fixes are being merged for QEMU 2.5 now. I'm sorry that this
>>> patch didn't make it. My block-next branch will be opening on Monday
>>> and I'll merge this patch there for QEMU 2.6.
>>
>> Thats not critical
On 11/15/2015 08:27 PM, Fam Zheng wrote:
> On Fri, 11/13 17:49, John Snow wrote:
>>
>>
>> On 11/12/2015 01:23 AM, Fam Zheng wrote:
>>> On Mon, 11/09 23:39, Max Reitz wrote:
>>>> bdrv_delete() is not very happy about deleting BlockDriverStates with
On 11/16/2015 01:17 AM, Fam Zheng wrote:
> On Fri, 11/13 17:44, John Snow wrote:
>>
>>
>> On 11/12/2015 11:30 AM, Peter Lieven wrote:
>>> This series aims at avoiding a hanging main-loop if a vserver has a
>>> CDROM image mounted from a NFS share an
,
and that it finishes successfully after we send a resume command.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/qemu-iotests/030 | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 952a524..fd0d186 100755
--- a/tests/qemu-i
> +{
> +bdrv_do_release_matching_dirty_bitmap(bs, bitmap);
> +}
> +
> +/**
> + * Release all dirty bitmaps attached to a BDS (for use in bdrv_close()).
> There
> + * must not be any frozen bitmaps attached.
> + */
> +static void bdrv_release_all_dirty_bitmaps(BlockDriverState *bs)
> +{
> +bdrv_do_release_matching_dirty_bitmap(bs, NULL);
> +}
> +
> void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
> {
> assert(!bdrv_dirty_bitmap_frozen(bitmap));
>
Thanks!
Reviewed-by: John Snow <js...@redhat.com>
MESTAMP}, "event":
> "DEVICE_TRAY_MOVED", "data": {"device": "drv", "tray-open": true}}
> +{"return": {}}
> +qemu-io: can't open device nbd+unix:///drv?socket=TEST_DIR/nbd: Failed to
> read export length
> +no file open, try 'help open'
> +{"return": {}}
> +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event":
> "SHUTDOWN"}
> +*** done
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index c69265d..993711b 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -139,3 +139,4 @@
> 137 rw auto
> 138 rw auto quick
> 139 rw auto quick
> +140 rw auto quick
>
4-10:
Reviewed-by: John Snow <js...@redhat.com>
On 11/16/2015 11:22 PM, Fam Zheng wrote:
> On Mon, 11/16 12:07, John Snow wrote:
>>
>>
>> On 11/15/2015 08:27 PM, Fam Zheng wrote:
>>> On Fri, 11/13 17:49, John Snow wrote:
>>>>
>>>>
>>>> On 11/12/2015 01:23 AM, Fam Zheng wro
On 11/10/2015 06:09 PM, Eric Blake wrote:
> On 11/10/2015 04:00 PM, John Snow wrote:
>> Include new error handling scenarios for 2.5.
>>
>> Signed-off-by: John Snow <js...@redhat.com>
>> ---
>> docs/bitmaps.md | 157
>> ++
We need to say "hello!" to our ATAPI friends
in a slightly different manner.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 8 +++-
tests/libqos/ahci.c | 5 +
tests/libqos/ahci.h | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)
diff --
Use the proper free command to detroy an AHCICommand.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 59d387c..8370fa3 100644
--- a/tests/ahci-test.c
+++ b
Organize the prototypes into nice little sections.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/libqos/ahci.h | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/tests/libqos/ahci.h b/tests/libqos/ahci.h
index 2c2d2fc..6
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 59d387c..1bb7410 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -47,6
add ahci_exec, which is a standard purpose flexible command dispatcher
and tester for the AHCI device. The intent is to eventually cut down on
the absurd amount of boilerplate inside of the AHCI qtest.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/libqos/ahci.
rd towards shepherding all AHCI qtests into
a common set of commands in a unified pipeline.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/ahci-test.c | 8 +---
tests/libqos/ahci.c | 6 +++---
tests/libqos/malloc.c | 4
3 files changed, 8 insertions(+), 10 deletions(-)
diff --
is tagged ahci-atapi-qtests-v1:
https://github.com/jnsnow/qemu/releases/tag/ahci-atapi-qtests-v1
John Snow (9):
ahci-test: fix memory leak
libqos/ahci: ATAPI support
libqos/ahci: ATAPI identify
libqos/ahci: Switch to mutable properties
libqos: allow zero-size allocations
libqos/ahci: all
(10).
Signed-off-by: John Snow <js...@redhat.com>
---
tests/libqos/ahci.c | 83 ++---
tests/libqos/ahci.h | 14 +
2 files changed, 93 insertions(+), 4 deletions(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index adb2665..5
mechanism is PIO and the default
properties are adjusted accordingly.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/libqos/ahci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 81edf34..a219f67 100644
--
; +}
> return;
> +} else {
> +/* rebuffering within an elementary transfer is
> + * only possible with a sync request because we
> + * end up with a race condition otherwise */
> +
On 10/27/2015 12:50 PM, Stefan Hajnoczi wrote:
> On Mon, Oct 26, 2015 at 07:38:02PM -0400, John Snow wrote:
>> Not that you can request a >2GiB transaction, but that's why checking
>> for it makes no sense anymore.
>>
>> With the newer 'limit' parameter to
On 11/03/2015 10:22 AM, Stefan Hajnoczi wrote:
> On Fri, Oct 23, 2015 at 07:56:38PM -0400, John Snow wrote:
>> Welcome to V10!
>>
>> Where'd 8 and 9 go? Private off-list missives from Fam.
>> Now you, I, and everyone on qemu-devel are staring at V10.
>>
>&
On 11/03/2015 10:23 AM, Eric Blake wrote:
> On 10/23/2015 05:56 PM, John Snow wrote:
>> Add both transactional properties to the QMP transactional interface,
>> and add the BlockJobTxn that we create as a result of the err-cancel
>> property to the BlkActionState structure.
On 11/03/2015 12:46 PM, John Snow wrote:
>
>
> On 11/03/2015 10:22 AM, Stefan Hajnoczi wrote:
>> On Fri, Oct 23, 2015 at 07:56:38PM -0400, John Snow wrote:
>>> Welcome to V10!
>>>
>>> Where'd 8 and 9 go? Private off-list missives from Fam.
>>>
On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote:
> On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote:
>>
>>
>> On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote:
>>> On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote:
>>&
On 11/05/2015 02:35 PM, Markus Armbruster wrote:
> John Snow <js...@redhat.com> writes:
>
>> On 11/05/2015 05:47 AM, Stefan Hajnoczi wrote:
>>> On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote:
>>>>
>>>>
>>>> On 11/03/2
Make sure there's not trailing garbage, e.g.
"64k-whatever-i-want-here"
Reported-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Kevin Wolf <kw...@redhat.com>
---
qemu-io-cm
https://github.com/jnsnow/qemu/tree/qemu-io-tidy
This version is tagged qemu-io-tidy-v3:
https://github.com/jnsnow/qemu/releases/tag/qemu-io-tidy-v3
John Snow (3):
qemu-io: fix cvtnum lval types
qemu-io: Check for trailing chars
qemu-io: Correct error messages
qemu-io-cmds.c | 150
Reported-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Kevin Wolf <kw...@redhat.com>
---
qemu-io-cmds.c | 53 ++---
1 file chang
Signed-off-by: John Snow <js...@redhat.com>
---
qemu-io-cmds.c | 88 +++---
1 file changed, 53 insertions(+), 35 deletions(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 6e5d1e4..f04c1db 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds
On 10/23/2015 07:56 PM, John Snow wrote:
> Welcome to V10!
>
> Where'd 8 and 9 go? Private off-list missives from Fam.
> Now you, I, and everyone on qemu-devel are staring at V10.
>
> What's new in V10?
>
> I replaced the per-action "transactional-cancel" parameter
If we create a buffer directly on the stack by using 12 bytes, there's
no guarantee the 64bit value we want to swap will be aligned, which
could cause errors with undefined behavior.
Spotted with clang -fsanitize=undefined and observed in iotests 15, 26,
44, 115 and 121.
Signed-off-by: John Snow
On 10/12/2015 08:27 AM, Peter Lieven wrote:
> PIO read requests on the ATAPI interface used to be sync blk requests.
> This has two significant drawbacks. First the main loop hangs util an
> I/O request is completed and secondly if the I/O request does not
> complete (e.g. due to an unresponsive
() to convert underscores in Python argument names
to hyphens for QMP argument names.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
---
com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
blockdev.c | 78 +---
qapi-schema.json | 50 +---
qmp
edhat.com>
[Rewrite the implementation which is now contained in block_job_completed.
--Fam]
Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
x Reitz <mre...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
tests/Makefile| 3 +
tests/test-blockjob-txn.c | 250 +++
.
[split up from a patch originally by Stefan and Fam. --js]
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
block/backup.c
Test simple usage cases for using transactions to create
and synchronize incremental backups.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefa...
Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
blockdev.c | 124 ++---
1 file changed, 69 insertions(+), 55 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index f1388fd..ff397a7 100644
--- a/blockdev.c
+
From: Fam Zheng <f...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Signed-off-by: Fam Zheng <f...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
include/block/blockjob.h | 20
nspop-v11:
https://github.com/jnsnow/qemu/releases/tag/block-transpop-v11
Fam Zheng (6):
backup: Extract dirty bitmap handling as a separate function
blockjob: Introduce reference count and fix reference to job->bs
blockjob: Add .commit and .abort block job actions
blockjob: Add "comp
From: Fam Zheng <f...@redhat.com>
This will be reused by the coming new transactional completion code.
Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redh
alongside a full backup to
accomplish a clean synchronization point.
Signed-off-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Stefan Hajno
From: Fam Zheng <f...@redhat.com>
They are set when block_job_completed is called.
Signed-off-by: Fam Zheng <f...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Signed-off-by: John Snow <js...@redhat.com>
---
201 - 300 of 5295 matches
Mail list logo
