Do not merge; staged in Hanna's branch.
Signed-off-by: John Snow
---
tests/qemu-iotests/223.out | 4 ++--
tests/qemu-iotests/307.out | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests/223.out
index 06479415312..26fb34
From: Vladimir Sementsov-Ogievskiy
Do not merge: this is a copy of Vladimir's fix that will be taken in
through the iotests tree.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
tests/qemu-iotests/tests/copy-before-write | 5 +
1 file changed, 5 inser
eturn stub information
for these failed lookups.
This allows test-qga to pass under docker tests, which are in turn used
by the CentOS VM tests.
Signed-off-by: John Snow
---
qga/commands-posix.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c
The old CentOS image didn't work anymore because it was already EOL at
the beginning of 2022.
Signed-off-by: John Snow
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrangé
---
tests/vm/centos | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/vm/centos b/
rking reliably under TCG
- Upgrade ubuntu.aarch64 to 20.04 after fixing centos.aarch64
- Fix the Haiku build test, if possible.
- Ensure I can reliably run and pass "make vm-build-all".
(Remove VMs from this recipe if necessary.)
John Snow (11):
qga: treat get-guest-fsinfo as "best eff
our current CI infrastructure.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
---
tests/vm/centos | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/vm/centos b/tests/vm/centos
index 3a527c47b3d..097a9ca14d3 100755
--- a/tests/vm/centos
+++ b/tests/vm/centos
@@ -28,7 +28,6 @@
If the initial setup fails, you've permanently altered the state of the
downloaded image in an unknowable way. Use 'cp' like our other test
setup scripts do.
Signed-off-by: John Snow
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrangé
---
tests/vm/centos | 2 +-
1
vided, can still override it.
Signed-off-by: John Snow
Reviewed-by: Daniel P. Berrangé
---
tests/vm/basevm.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index d7d0413df35..4fd9af10b7f 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -9
ed to support this VM test anymore.
Signed-off-by: John Snow
Reviewed-by: Thomas Huth
Reviewed-by: Daniel P. Berrangé
---
tests/vm/Makefile.include | 3 +--
tests/vm/ubuntu.i386 | 40 ---
2 files changed, 1 insertion(+), 42 deletions(-)
delete mode 1
Do not merge: Staged in Hanna's branch.
Signed-off-by: John Snow
---
tests/qemu-iotests/108 | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108
index 9e923d6a59f..54e935acf28 100755
--- a/tests/qemu-iotests/108
+++ b/tests/qemu-iotest
the native asyncio interfaces I've been writing to help manage
this, but in the meantime I think this is probably a reasonable
concession and a more useful default.
...I think. Willing to take it for now and re-investigate when the
other fixes make it to the tree.
Reviewed-by: John Snow
On Mon, Jul 11, 2022 at 5:16 PM John Snow wrote:
>
> On Fri, Jun 24, 2022 at 3:53 PM Vladimir Sementsov-Ogievskiy
> wrote:
> >
> > I've spent much time trying to debug hanging pipeline in gitlab. I
> > started from and idea that I have problem in code in my ser
On Fri, May 27, 2022, 12:29 PM Kevin Wolf wrote:
> Am 26.05.2022 um 16:21 hat John Snow geschrieben:
> > On Thu, May 26, 2022, 3:54 AM Daniel P. Berrangé
> > wrote:
> >
> > > On Wed, May 25, 2022 at 08:25:12PM -0400, John Snow wrote:
> > > > If you i
lly better.
But, even if I did write it more generically here; iotests wouldn't be
able to use it anyway, because importing it would mean more sys.path
hacking. So... eh?
Signed-off-by: John Snow
---
tests/Makefile.include | 16 ++--
tests/mkvenv.py| 186 +++
see the subsequent commit "tests: Remove spurious pip
warnings on Ubuntu20.04" for more information.
Signed-off-by: John Snow
---
tests/Makefile.include | 21 ++---
tests/requirements.txt | 6 --
tests/setup.cfg| 20
tests/setup.py | 1
ror does
not seem to show up for the "qemu" package because we install that
package in editable mode. (I think, but did not test, that installing an
empty package in editable mode caused more problems than it fixed.)
Signed-off-by: John Snow
---
tests/mkvenv.py | 3 ++-
1 file change
NetBSD needs "py37-pip" in order to create virtual environments.
Signed-off-by: John Snow
---
tests/vm/netbsd | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index 45aa9a7fda7..53fe508e487 100755
--- a/tests/vm/netbsd
+++ b/tests/vm/netbsd
@@ -
as
much of this forward as I can to try and get some testing in for RC
phase to determine what problems might exist that I haven't noticed yet.
--js
John Snow (7):
tests: create optional tests/venv dependency groups
tests: pythonize test venv creation
tests: Remove spurious pip warnings on Ubu
H.
If the venv directory isn't found, raise a friendly exception that tries
to give the human operator a friendly clue as to what's gone wrong. The
subsequent commit attempts to address this shortcoming by teaching
iotests how to invoke the venv bootstrapper in this circumstance
instead.
ll miss
certain triggers to refresh the venv. It will miss when new dependencies
are added to either python/setup.cfg or tests/setup.cfg. It can be
coaxed into updating by running 'make check', 'make check-block', 'make
check-venv', etc.
Signed-off-by: John Snow
---
tests
ests, 'make
check-venv-avocado'.
Signed-off-by: John Snow
---
tests/Makefile.include | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index d8af6a38112..d484a335be5 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1
On Fri, Jul 8, 2022 at 11:35 AM John Snow wrote:
>
> Note: patches 10-12 are included for testing simplicity, they shouldn't
> be merged. They will be included in a forthcoming block PR.
Patches 1-9 are fully reviewed. Whose tree should this go in?
>
> V4:
>
> - Addre
On Mon, Jul 18, 2022 at 4:17 AM Thomas Huth wrote:
>
> On 08/07/2022 17.34, John Snow wrote:
> > Note: patches 10-12 are included for testing simplicity, they shouldn't
> > be merged. They will be included in a forthcoming block PR.
> >
> > V4:
> >
>
On Thu, Sep 22, 2022 at 4:03 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Tue, Sep 20, 2022 at 1:50 PM Bin Meng wrote:
>>
>> From: Bin Meng
>>
>> These test cases uses "blkdebug:path/to/config:path/to/image" for
>> testing. On Windows, absolute file paths contain the delimiter ':'
>> which causes t
On 10/12/2016 06:22 AM, Kevin Wolf wrote:
Am 11.10.2016 um 17:47 hat John Snow geschrieben:
On 10/10/2016 03:23 PM, Mark Cave-Ayland wrote:
On 10/10/16 17:34, Eric Blake wrote:
On 10/09/2016 11:43 AM, Mark Cave-Ayland wrote:
The hard-coded default alignment is BDRV_SECTOR_SIZE, however
t for
the next iteration.
On 01.10.2016 01:00, John Snow wrote:
Add a regression test for the case found by Vladimir.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 91
++
tests/qemu-iotests/12
As context to everyone else as to why I'm going down the rabbit hole of
trying to remove external references to AioContext at all, see
https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg00795.html
On 10/07/2016 03:49 AM, Paolo Bonzini wrote:
On 06/10/2016 22:22, John Snow
On 10/01/2016 09:37 AM, Max Reitz wrote:
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
v7:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
It should be noted that (a
From: Fam Zheng
Upon each bit toggle, the corresponding bit in the meta bitmap will be
set.
Signed-off-by: Fam Zheng
[Amended text inline. --js]
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
include/qemu/hbitmap.h | 21 +++
util/hbitmap.c | 69
From: Fam Zheng
The added group of operations enables tracking of the changed bits in
the dirty bitmap.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 52
include/block/dirty-bitmap.h
: Vladimir Sementsov-Ogievskiy
[Fix left shift operand to 1UL; add "finish" parameter. - Fam]
Signed-off-by: Fam Zheng
Signed-off-by: John Snow
---
include/qemu/hbitmap.h | 79
util/hbitmap.c | 137 +
2 fil
From: Fam Zheng
For dirty bitmap users to get the size and the name of a
BdrvDirtyBitmap.
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 10 ++
include/block/dirty-bitmap.h | 2 ++
2 files changed
Key:
[] : patches are identical
[] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/10:[] [--] 'block: Hide HBitmap in block dirty bitmap interface'
From: Fam Zheng
We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
blo
From: Vladimir Sementsov-Ogievskiy
Several functions to provide necessary access to BdrvDirtyBitmap for
block-migration.c
Signed-off-by: Vladimir Sementsov-Ogievskiy
[Add the "finish" parameters. - Fam]
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Reviewed-by: Max Reitz
Sig
BdrvDirtyBitmapIter must be dynamically allocated because
the structure definition is in block/dirty-bitmap.c.
Two current users are converted too.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block/backup.c | 14 --
block/dirty-bitmap.c
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: John Snow
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/test-hbitmap.c | 116 +++
1 file changed, 116 insertions(+)
diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c
Fam Zheng
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 19 +++
include/block/dirty-bitmap.h | 3 +++
2 files changed, 22 insertions(+)
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 384146b..519737c 100644
--- a/block/dirty-bitma
From: Fam Zheng
Signed-off-by: Fam Zheng
[Fixed minor constant issue. --js]
Signed-off-by: John Snow
Signed-off-by: John Snow
---
tests/test-hbitmap.c | 156 +++
1 file changed, 156 insertions(+)
diff --git a/tests/test-hbitmap.c b/tests/test
If jobs are not created directly by the user, do not allow them to be
seen by the user/management utility. At the moment, 'internal' jobs are
those that do not have an ID. As of this patch it is impossible to
create such jobs.
Signed-off-by: John Snow
---
blockdev.c
(Trivial)
Fix wrong function names in documentation.
Signed-off-by: John Snow
---
include/block/blockjob_int.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
index 8eced19..10ebb38 100644
--- a/include/block
ch is available at:
https://github.com/jnsnow/qemu.git branch job-refactor-pt1
https://github.com/jnsnow/qemu/tree/job-refactor-pt1
This version is tagged job-refactor-pt1-v1:
https://github.com/jnsnow/qemu/releases/tag/job-refactor-pt1-v1
John Snow (7):
blockjobs: hide internal jobs from manageme
Add the ability to create jobs without an ID.
Signed-off-by: John Snow
---
block/backup.c| 2 +-
block/commit.c| 2 +-
block/mirror.c| 3 ++-
block/stream.c| 2 +-
blockjob.c| 25 -
include/block
There's no reason to leave this to blockdev; we can do it in blockjobs
directly and get rid of an extra callback for most users.
All non-internal events, even those created outside of QMP, will
consistently emit events.
Signed-off-by: John Snow
---
block/commit.c
blockdev and others on the public interface.
There are remaining uses of private state by qemu-img, and several
cases in blockdev.c and block/io.c where we grab job->blk for the
purposes of acquiring an AIOContext.
These will be corrected in future patches.
Signed-off-by: John Sn
Bubble up the internal interface to commit and backup jobs, then switch
replication tasks over to using this methodology.
Signed-off-by: John Snow
---
block/backup.c| 3 ++-
block/mirror.c| 21 ++---
block/replication.c | 14
BlockJobs will begin hiding their state in preparation for some
refactorings anyway, so let's internalize the user_pause mechanism
instead of leaving it to callers to correctly manage.
Signed-off-by: John Snow
---
blockdev.c | 12 +---
blockjob.c
On 10/14/2016 08:58 AM, Kevin Wolf wrote:
Am 14.10.2016 um 00:56 hat John Snow geschrieben:
If jobs are not created directly by the user, do not allow them to be
seen by the user/management utility. At the moment, 'internal' jobs are
those that do not have an ID. As of this p
On 10/13/2016 06:56 PM, John Snow wrote:
This is a follow-up to patches 1-6 of:
[PATCH v2 00/11] blockjobs: Fix transactional race condition
That series started trying to refactor blockjobs with the goal of
internalizing BlockJob state as a side effect of having gone through
the effort of
On 10/14/2016 05:51 AM, Xiubo Li wrote:
Make it a bit clear and better readable.
Suggestion: "Make it clearer and more readable."
Signed-off-by: Xiubo Li
---
block/rbd.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/block/rbd.c b/block/rbd
On 10/14/2016 07:41 AM, Mark Cave-Ayland wrote:
This is a follow-up to the thread at
https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01396.html which
introduces an explicit alignment to the DMA helpers to facilitate conversion
of the macio controller over to use the now byte-aligned DM
rive_type(ISADevice *fdc, int i)
@@ -2744,6 +2773,7 @@ static void fdc_register_types(void)
type_register_static(&sysbus_fdc_type_info);
type_register_static(&sysbus_fdc_info);
type_register_static(&sun4m_fdc_info);
+type_register_static(&floppy_bus_info);
}
type_init(fdc_register_types)
Reviewed-by: John Snow
quot;, i);
+object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
+if (local_err) {
+error_propagate(errp, local_err);
+return;
}
-fd_revalidate(drive);
}
}
@@ -2774,6 +2862,7 @@ static void fdc_register_types(void)
type_register_static(&sysbus_fdc_info);
type_register_static(&sun4m_fdc_info);
type_register_static(&floppy_bus_info);
+type_register_static(&floppy_drive_info);
}
type_init(fdc_register_types)
Reviewed-by: John Snow
On 09/30/2016 03:39 PM, Kevin Wolf wrote:
This makes the FloppyDrive qdev object actually useful: Now that it has
all properties that don't belong to the controller, you can actually
use '-device floppy' and get a working result.
Command line semantics is consistent with CD-ROM drives: By defa
On 10/15/2016 04:26 AM, Xiubo Li wrote:
Make it a bit clearer and more readable.
Signed-off-by: Xiubo Li
CC: John Snow
---
V2:
- Advice from John Snow. Thanks.
block/rbd.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/block/rbd.c b/block
On 10/06/2016 06:44 PM, John Snow wrote:
On 10/05/2016 11:17 AM, Kevin Wolf wrote:
Am 01.10.2016 um 00:00 hat John Snow geschrieben:
Instead of automatically starting jobs at creation time via backup_start
et al, we'd like to return a job object pointer that can be started
manual
On 10/18/2016 06:22 AM, Kevin Wolf wrote:
This tests the different supported methods to create floppy drives and
how they interact.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/172 | 242 +
tests/qemu-iotests/172.out | 1205
tests
On 10/19/2016 03:37 AM, Kevin Wolf wrote:
Am 18.10.2016 um 21:53 hat Eric Blake geschrieben:
On 10/18/2016 02:45 PM, John Snow wrote:
On 10/18/2016 06:22 AM, Kevin Wolf wrote:
This tests the different supported methods to create floppy drives and
how they interact.
+function
On 10/20/2016 03:55 AM, Kevin Wolf wrote:
We have been complaining for a long time about how the floppy controller and
floppy drives are combined in a single qdev device and how this makes the
device awkward to work with because it behaves different from all other block
devices.
The latest rea
l actually start a BlockJob in block_job_start. This avoids
the sticky question of how to "un-create" a Coroutine that hasn't been
started yet.
Signed-off-by: John Snow
---
block/backup.c | 23 ---
block/commit.c | 3 ++-
block/mi
ix-race-condition-v1
John Snow (4):
blockjob: add .clean property
blockjob: add .start field
blockjob: add block_job_start
blockjob: refactor backup_start as backup_job_create
Vladimir Sementsov-Ogievskiy (1):
blockjob: fix dead pointer in txn list
block/backup.
not we actually started the job. Therefore,
cleanup callbacks should essentially confine themselves to undoing create
operations, e.g. setup actions taken in what is now backup_start.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
block/backup.c | 13
fix list inconsistencies.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Tested-by: John Snow
Reviewed-by: John Snow
[Rewrote commit message. --js]
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Signed-off-by: John Snow
---
blockjob.c | 1 +
1 file changed, 1
ob-by-job coming
in later patches.
Of note: cancellation of unstarted jobs will perform all the normal
cleanup as if the job had started, particularly abort and clean. The
only difference is that we will not emit any events, because the job
never actually started.
Signed-off-by: John Snow
---
e
jobs may finish before we even finish building the transaction. This may
happen, for instance, during empty block backup jobs.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
block/backup.c| 26 ---
block/replication.c | 12 ---
On 10/20/2016 06:20 PM, John Snow wrote:
Requires: [Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1
There are a few problems with transactional job completion right now.
First, if jobs complete so quickly they complete before remaining jobs
get a chance to join the
On 10/20/2016 04:25 AM, Alberto Garcia wrote:
On Wed 19 Oct 2016 07:11:20 PM CEST, Kevin Wolf wrote:
bdrv_drain_all() doesn't allow the caller to do anything after all
pending requests have been completed but before block jobs are
resumed.
This patch splits bdrv_drain_all() into _begin() and
On 10/21/2016 03:03 PM, Alberto Garcia wrote:
On Fri 21 Oct 2016 08:55:51 PM CEST, John Snow wrote:
bdrv_drain_all() doesn't allow the caller to do anything after all
pending requests have been completed but before block jobs are
resumed.
This patch splits bdrv_drain_all() into _
| 4 ++--
configure | 2 +-
9 files changed, 12 insertions(+), 12 deletions(-)
rename block/{raw-posix.c => file-posix.c} (100%)
rename block/{raw-win32.c => file-win32.c} (100%)
rename block/{raw_bsd.c => raw.c} (100%)
You got all the comments and everything!
On 10/24/2016 07:37 AM, Kevin Wolf wrote:
We have been complaining for a long time about how the floppy controller and
floppy drives are combined in a single qdev device and how this makes the
device awkward to work with because it behaves different from all other block
devices.
The latest rea
fix list inconsistencies.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Tested-by: John Snow
Reviewed-by: John Snow
[Rewrote commit message. --js]
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Signed-off-by: John Snow
---
blockjob.c | 1 +
1 file changed, 1
l actually start a BlockJob in block_job_start. This avoids
the sticky question of how to "un-create" a Coroutine that hasn't been
started yet.
Signed-off-by: John Snow
---
block/backup.c | 23 ---
block/commit.c | 3 ++-
block/mi
not we actually started the job. Therefore,
cleanup callbacks should essentially confine themselves to undoing create
operations, e.g. setup actions taken in what is now backup_start.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
block/backup.c | 13
ondition
This version is tagged job-fix-race-condition-v2:
https://github.com/jnsnow/qemu/releases/tag/job-fix-race-condition-v2
John Snow (5):
blockjob: add .clean property
blockjob: add .start field
blockjob: add block_job_start
blockjob: refactor backup_start as backup_job_create
i
Add a regression test for the case found by Vladimir.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 53 ++
tests/qemu-iotests/124.out | 4 ++--
2 files changed, 37 insertions(+), 20 deletions
e
jobs may finish before we even finish building the transaction. This may
happen, for instance, during empty block backup jobs.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
block/backup.c| 26 ---
block/replication.c | 12 ---
ob-by-job coming
in later patches.
Of note: cancellation of unstarted jobs will perform all the normal
cleanup as if the job had started, particularly abort and clean. The
only difference is that we will not emit any events, because the job
never actually started.
Signed-off-by: John Snow
---
fdc.use.separate.qdev.device.for.drives.EN.V5.REPACK.PC.LINUX-kw0lf-kr3w
_____ .__ _ __
| | _ _\ _ \ | |_/ \ | | \_ \_ _ __
| |/ /\ \/ \/ / /_\ \| |\ __\ | |/ /\_ __ \_(__ < \/ \/ /
|< \ /\ \_/ \ |_
On 10/26/2016 12:52 AM, Jeff Cody wrote:
On Fri, Oct 14, 2016 at 02:32:55PM -0400, John Snow wrote:
On 10/13/2016 06:56 PM, John Snow wrote:
This is a follow-up to patches 1-6 of:
[PATCH v2 00/11] blockjobs: Fix transactional race condition
That series started trying to refactor blockjobs
is version is tagged job-refactor-pt1-v2:
https://github.com/jnsnow/qemu/releases/tag/job-refactor-pt1-v2
John Snow (7):
blockjobs: hide internal jobs from management API
blockjobs: Allow creating internal jobs
Replication/Blockjobs: Create replication jobs as internal
blockjob: ce
If jobs are not created directly by the user, do not allow them to be
seen by the user/management utility. At the moment, 'internal' jobs are
those that do not have an ID. As of this patch it is impossible to
create such jobs.
Signed-off-by: John Snow
---
blockdev.c
BlockJobs will begin hiding their state in preparation for some
refactorings anyway, so let's internalize the user_pause mechanism
instead of leaving it to callers to correctly manage.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
---
blockdev.c
Ping?
On 10/24/2016 04:56 PM, John Snow wrote:
Requires: [Qemu-devel] [PATCH 0/7] blockjobs: preliminary refactoring work, Pt 1
There are a few problems with transactional job completion right now.
First, if jobs complete so quickly they complete before remaining jobs
get a chance to join the
(Trivial)
Fix wrong function names in documentation.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
---
include/block/blockjob_int.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
There's no reason to leave this to blockdev; we can do it in blockjobs
directly and get rid of an extra callback for most users.
All non-internal events, even those created outside of QMP, will
consistently emit events.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff
blockdev and others on the public interface.
There are remaining uses of private state by qemu-img, and several
cases in blockdev.c and block/io.c where we grab job->blk for the
purposes of acquiring an AIOContext.
These will be corrected in future patches.
Signed-off-by: John Snow
Bubble up the internal interface to commit and backup jobs, then switch
replication tasks over to using this methodology.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
---
block/backup.c| 3 ++-
block/mirror.c| 21 ++---
block
Add the ability to create jobs without an ID.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
---
block/backup.c| 2 +-
block/commit.c| 2 +-
block/mirror.c| 3 ++-
block/stream.c| 2 +-
blockjob.c| 25
/bugzilla.redhat.com/show_bug.cgi?id=1373264
Reported-by: Peter Krempa
Signed-off-by: John Snow
---
block/block-backend.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index c53ca30..2044f20 100644
--- a/block/block-b
On 10/28/2016 05:23 PM, John Snow wrote:
blk_eject is only used by scsi-disk and atapi, and in both cases we
only attempt to invoke blk_eject if we have a bona-fide change in
tray state.
The "issue" here is that the tray state does not generate a QMP event
unless there is a
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return data.
Reported-by: Hervé Poussineau
Signed-off-by: John Snow
---
hw/ide/atapi.c | 49
On 10/30/2016 01:49 PM, Hervé Poussineau wrote:
Le 29/10/2016 à 00:32, John Snow a écrit :
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return
On 10/31/2016 10:06 AM, Kevin Wolf wrote:
Am 29.10.2016 um 00:32 hat John Snow geschrieben:
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return
On 10/31/2016 10:13 AM, Kevin Wolf wrote:
Am 28.10.2016 um 23:30 hat John Snow geschrieben:
On 10/28/2016 05:23 PM, John Snow wrote:
blk_eject is only used by scsi-disk and atapi, and in both cases we
only attempt to invoke blk_eject if we have a bona-fide change in
tray state.
The "
.
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch ide-fix-read-cd
https://github.com/jnsnow/qemu/tree/ide-fix-read-cd
This version is tagged ide-fix-read-cd-v2:
https://github.com/jnsnow/qemu/releases/tag/ide-fix-read-cd-v2
John
These can simply be the size of the number of sectors we're reading,
plus one for a buffer. We don't need them to be any larger.
Signed-off-by: John Snow
---
tests/ahci-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/ahci-test.c b/tests/ahci-te
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return data.
Reported-by: Hervé Poussineau
Signed-off-by: John Snow
---
hw/ide/atapi.c | 51
BE)
(4) Add a nice human-readable message for future SCSI command additions
Signed-off-by: John Snow
---
tests/ahci-test.c | 36 +---
tests/libqos/ahci.c | 27 ---
tests/libqos/ahci.h | 17 ++---
3 files changed, 59 insertions
On 11/02/2016 09:33 AM, Kevin Wolf wrote:
Am 01.11.2016 um 04:16 hat John Snow geschrieben:
Commit 9ef2e93f introduced the concept of tagging ATAPI commands as
NONDATA, but this introduced a regression for certain commands better
described as CONDDATA. read_cd is such a command that both
fix list inconsistencies.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Tested-by: John Snow
Reviewed-by: John Snow
[Rewrote commit message. --js]
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Signed-off-by: John Snow
---
blockjob.c | 1 +
1 file changed, 1
501 - 600 of 5762 matches
Mail list logo
