Re: [PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred

Eric Blake wrote: > On Tue, Oct 24, 2023 at 05:10:32PM +0200, Juan Quintela wrote: >> This way we can read it from any thread. >> I checked that it gives the same value than the current one. We never > > s/than/as/ Done >> use to qemu_files at the same time. > > s/to/two/ Done Thanks.

[PATCH v2 11/12] migration: Remove transferred atomic counter

After last commit, it is a write only variable. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/multifd.c | 3 --- migration/ram.c | 1 - 3 files changed, 8 deletions(-) diff --git a/migration/migration-stats.h b

[PATCH v2 00/12] migration: Yet another round of atomic counters

have three atomic counters: - multifd_bytes - rdma_bytes - qemu_file_trasferred And we only need to setup one (and only one) of these each time that we sent anything. Please review. Later, Juan. Juan Quintela (12): qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer

[PATCH v2 10/12] migration: Use migration_transferred_bytes()

values are used to: a - present to the user b - calculate the rate_limit So a few KB here and there is not going to make a difference. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- migration/ram.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH v2 12/12] qemu-file: Make qemu_fflush() return errors

for f->last_error because qemu_fflush() returns it at the beggining of the function. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- In v2: Now that we call always qemu_fflush() for all files, we can simplify qemu_fclose() --- migration/q

[PATCH v2 09/12] qemu-file: Simplify qemu_file_get_error()

If we pass a NULL error is the same that returning directly the value. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 0158db2a54

[PATCH v2 07/12] migration: migration_transferred_bytes() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 6 +++--- migration/migration.c | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/migration/migration-stats.h b/migration

Re: [PULL 38/40] migration: Implement MigrateChannelList to qmp migration flow.

Peter Maydell wrote: > On Thu, 2 Nov 2023 at 11:46, Juan Quintela wrote: >> >> From: Het Gala >> >> Integrate MigrateChannelList with all transport backends >> (socket, exec and rdma) for both src and dest migration >> endpoints for qmp migration. &

[PATCH v2 05/12] qemu_file: Remove unused qemu_file_transferred()

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.h | 18 -- migration/qemu-file.c | 7 --- 2 files changed, 25 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h index a29c37b0d0..8b71152754 100644 --- a/migration/qemu

[PATCH v2 01/12] qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer

We only call qemu_file_transferred_* on the sending side. Remove the increment at qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration

[PATCH v2 03/12] qemu_file: total_transferred is not used anymore

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 384985f534..641ab703cc 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -41,9 +41,6

[PATCH v2 02/12] qemu_file: Use a stat64 for qemu_file_transferred

This way we can read it from any thread. I checked that it gives the same value as the current one. We never use two qemu_files at the same time. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/qemu-file.c | 5 +++-- 2 files

[PATCH v2 08/12] migration: migration_rate_limit_reset() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 2 +- migration/migration.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration

[PATCH v2 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush()

qemu_file_transferred() don't exist anymore, so we can reuse the name. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- v2: Update the documentation (thanks fabiano) --- migration/qemu-file.h | 9 - migration/block.c | 4 ++-- migration/qemu-file.c | 2 +- migration

[PATCH v2 04/12] migration: Use the number of transferred bytes directly

-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration-stats.c b/migration/migration-stats.c index 4cc989d975..1d9197b4c3 100644 --- a/migration/migration-stats.c +++ b/migration

[PATCH v6 5/5] migration: Deprecate old compression method

Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c | 13 3 files changed, 64 insertions

[PATCH v6 0/5] Migration deprecated parts

option that are already using "defer", and the code simplifacation if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (5): migration: Print block status when needed migration: migrate 'inc

[PATCH v6 3/5] migration: migrate 'blk' command option is deprecated.

Use blocked-mirror with NBD instead. Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7 --- migration/migration-hmp-cmds.c | 5

Re: [PATCH v5 5/7] migration: Deprecate old compression method

Markus Armbruster wrote: > Juan Quintela writes: > >> Signed-off-by: Juan Quintela >> Acked-by: Stefan Hajnoczi >> Acked-by: Peter Xu >> # @deprecated: Member @disk is deprecated because block migration is. >> +# Member @compression is

[PATCH v6 2/5] migration: migrate 'inc' command option is deprecated.

Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 9 + qapi/migration.json| 8 +++- migration/migration-hmp-cmds.c | 5

[PATCH v6 4/5] migration: Deprecate block migration

It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 10 ++ qapi

[PATCH v6 1/5] migration: Print block status when needed

The new line was only printed when command options were used. When we used migration parameters and capabilities, it wasn't. Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas --- migration/migration-hmp-cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PULL 10/13] migration/rdma: Remove QEMUFile parameter when not used

Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-13-quint...@redhat.com> --- migration/rdma.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 2a3c784328..9007

[PULL 03/13] migration-test: Add bootfile_create/delete() functions

The bootsector code is read only from the guest (otherwise we are going to have problems with it being read from both source and destination). Create a single copy for all the tests. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-10-quint...@redhat.com> Signed-off-by: Juan Qu

[PULL 02/13] migration-test: bootpath is the same for all tests and for all archs

So just make it a global variable. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-9-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tests/qtest/migration-

[PULL 12/13] migration: Remove unused qemu_file_credit_transfer()

After this change, nothing abuses QEMUFile to account for data transferrefd during migration. Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-15-quint...@redhat.com> --- migration/qemu-file.h | 8 migration/qemu-file.c | 5 - 2

[PULL 07/13] migration: Use qemu_file_transferred_noflush() for block migration.

We only care about the amount of bytes transferred. Flushing is done by the system somewhere else. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20230530183941.7223-4-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/block.c | 4 ++-- 1 file chan

[PULL 01/13] migration-test: Create kvm_opts

So arch_dirty_ring option becomes one option like the others. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-8-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests

[PULL 09/13] migration/RDMA: It is accounting for zero/normal pages in two places

Remove the one in control_save_page(). Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-12-quint...@redhat.com> --- migration/ram.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9040d66e61..f2c5

[PULL 04/13] migration-test: dirtylimit checks for x86_64 arch before

So no need to assert we are in x86_64. Once there, refactor the function to remove useless variables. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-11-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 5 + 1 file changed, 1 insertion

[PULL 06/13] migration: Refactor repeated call of yank_unregister_instance

From: Tejus GK In the function qmp_migrate(), yank_unregister_instance() gets called twice which isn't required. Hence, refactoring it so that it gets called during the local_error cleanup. Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Acked-by: Peter Xu Signed-off-by: Tejus GK

[PULL 05/13] migration-test: simplify shmem_opts handling

Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-4-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 3346

[PULL 13/13] migration/rdma: Simplify the function that saves a page

, but this needs to be done some other way. Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-16-quint...@redhat.com> --- migration/qemu-file.h | 14 ++ migration/qemu-file.c | 12 ++-- migration/ram.c | 10 +++--- mig

[PULL 08/13] migration: Don't abuse qemu_file transferred for RDMA

Just create a variable for it, the same way that multifd does. This way it is safe to use for other thread, etc, etc. Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-11-quint...@redhat.com> --- migration/migration-stats.h | 4 mig

[PULL 11/13] migration/rdma: Don't use imaginary transfers

Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-14-quint...@redhat.com> --- migration/qemu-file.c | 5 + migration/ram.c | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 19c33c9985..e

[PULL 00/13] Migration 20231002 patches

: - Refactor repeated call of yank_unregister_instance (tejus) - More migraton-test changes Please, apply. Juan Quintela (12): migration-test: Create kvm_opts migration-test: bootpath is the same for all tests and for all archs migration

Re: [PATCH 10/21] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value)

t; > @replace@ > expression match.errp; > constant match.param; > constant match.value; > identifier strformat.fixedfmt; > @@ > -error_setg(errp, QERR_INVALID_PARAMETER_VALUE, param, value); > +error_setg(errp, fixedfmt); > > Signed-off-b

Re: [PATCH 13/21] qapi: Inline and remove QERR_IO_ERROR definition

ansformation using: > > $ sed -i -e 's/QERR_IO_ERROR/"An IO error has occurred"/' \ > $(git grep -wl QERR_IO_ERROR) > > then manually removing the definition in include/qapi/qmp/qerror.h. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH 14/21] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition

al transformation using sed, manually > removing the definition in include/qapi/qmp/qerror.h. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH 21/21] qapi: Remove 'qapi/qmp/qerror.h' header

\/qmp\/qerror.h"/ && !p {p++;next}1' > $f; \ > done > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH v2 11/22] qapi: Inline QERR_INVALID_PARAMETER_VALUE definition (constant value)

.make_ident(fixedfmt) > > @replace@ > expression match.errp; > constant match.param; > constant match.value; > identifier strformat.fixedfmt; > @@ > -error_setg(errp, QERR_INVALID_PARAMETER_VALUE, param, value); > +error_setg(errp, fixedf

Re: [PATCH v2 10/22] qapi: Correct error message for 'vcpu_dirty_limit' parameter

ust greater then 1 > MB/s" > > Replace by: > > "Parameter 'vcpu_dirty_limit' is invalid, it must greater then 1 MB/s" > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v3 2/4] migration: migrate 'blk' command option is deprecated.

Set the 'block' migration capability to 'true' instead. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 10 +++--- migration/migration.c | 5 + 3 files changed, 19 insertions(+), 3 deletions(-) diff

[PATCH v3 1/4] migration: migrate 'inc' command option is deprecated.

Set the 'block_incremental' migration parameter to 'true' instead. Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 12 ++-- migration/migration.c | 6 ++ 3 files changed, 23 insertions(+), 2

[PATCH v3 3/4] migration: Deprecate block migration

It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 30 +- migration

[PATCH v3 4/4] migration: Deprecate old compression method

Signed-off-by: Juan Quintela Acked-by: Peter Xu --- docs/about/deprecated.rst | 8 +++ qapi/migration.json | 102 -- migration/options.c | 13 + 3 files changed, 86 insertions(+), 37 deletions(-) diff --git a/docs/about/deprecated.rst b

Re: [PATCH v3 1/4] migration: migrate 'inc' command option is deprecated.

Markus Armbruster wrote: > Juan Quintela writes: > >> Set the 'block_incremental' migration parameter to 'true' instead. >> >> # @blk: do block migration (full disk copy) >> # >> -# @inc: incremental disk copy migration >> +# @inc: incremental disk

Re: [PATCH v3 4/4] migration: Deprecate old compression method

Markus Armbruster wrote: > Juan Quintela writes: > >> -# @deprecated: @disk migration is deprecated. Use driver-mirror >> -# with NBD instead. >> +# @deprecated: @disk migration is deprecated. Use driver-mirror with >> +# NBD instead. @compress

Re: [PATCH v3 3/4] migration: Deprecate block migration

Markus Armbruster wrote: > Juan Quintela writes: > >> It is obsolete. It is better to use driver-mirror with NBD instead. > > drive-mirror > > Several more below. Done. >> +# Features: >> +# >> +# @deprecated: @disk migration is deprecated. Us

Re: How to tame CI?

Vladimir Sementsov-Ogievskiy wrote: > On 26.07.23 16:32, Thomas Huth wrote: >> On 26/07/2023 15.00, Peter Maydell wrote: >>> On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: >>>> To make things easier, this is the part that show how it breaks (this is >>

Re: [PATCH v6 3/5] migration: migrate 'blk' command option is deprecated.

Juan Quintela wrote: > Use blocked-mirror with NBD instead. > > Signed-off-by: Juan Quintela > Acked-by: Stefan Hajnoczi > Reviewed-by: Thomas Huth > Reviewed-by: Markus Armbruster Hi Kevin and Stefan Can we change the iotest output to fix this? https://gitlab.com/juan.qu

[PATCH v7 2/4] migration: migrate 'blk' command option is deprecated.

Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7 --- migration/migration-hmp-cmds.c | 5

[PATCH v7 4/4] migration: Deprecate old compression method

Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c | 13 3 files changed, 64 insertions

[PATCH v7 0/4] Migration deprecated parts

ecause management apps have a working option that are already using "defer", and the code simplifacation if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (4): migration: migrate 'inc' command opti

[PATCH v7 3/4] migration: Deprecate block migration

It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi

[PATCH v7 1/4] migration: migrate 'inc' command option is deprecated.

Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json| 8 +++- migration/migration-hmp-cmds.c | 5

Re: [PATCH v7 0/4] Migration deprecated parts

Juan Quintela wrote: > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com> > [PULL 00/11] Migration 20231018 patches > > And here we are, at v7: > - drop black line at the end of deprecated.rst > - change qemu-iotest output due to warnings for d

[PATCH v8 3/5] migration: migrate 'blk' command option is deprecated.

Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7 --- migration/migration-hmp-cmds.c | 5

[PATCH v8 1/5] qemu-iotests: Filter warnings about block migration being deprecated

Create a new filter that removes the two warnings for test 183. Signed-off-by: Juan Quintela --- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183

[PATCH v8 5/5] migration: Deprecate old compression method

Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c | 13 3 files changed, 64 insertions

[PATCH v8 2/5] migration: migrate 'inc' command option is deprecated.

Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json| 8 +++- migration/migration-hmp-cmds.c | 5

[PATCH v8 0/5] Migration deprecated parts

n if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintela (5): qemu-iotests: Filter warnings about block migration being deprecated migration: migrate 'inc' command option is deprecated. migration: migrate 'blk

[PATCH v8 4/5] migration: Deprecate block migration

It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi

Re: [PATCH v7 0/4] Migration deprecated parts

Daniel P. Berrangé wrote: > On Wed, Oct 18, 2023 at 12:38:10PM +0200, Juan Quintela wrote: >> Juan Quintela wrote: >> > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com> >> > [PULL 00/11] Migration 20231018 patches >> > >

Re: [PATCH v6 2/5] migration: migrate 'inc' command option is deprecated.

Markus Armbruster wrote: > Juan Quintela writes: > >> Use blockdev-mirror with NBD instead. >> >> Reviewed-by: Thomas Huth >> Acked-by: Stefan Hajnoczi >> Reviewed-by: Markus Armbruster >> Signed-off-by: Juan Quintela >> --- >>

Re: [PULL 13/38] migration: Non multifd migration don't care about multifd flushes

Michael Tokarev wrote: > 17.10.2023 11:29, Juan Quintela: >> RDMA was having trouble because >> migrate_multifd_flush_after_each_section() can only be true or false, >> but we don't want to send any flush when we are not in multifd >> migration. >> CC: Fab

Re: [PATCH v7 05/15] python/qemu: rename command() to cmd()

ocado/machine_aspeed.py and keep r-b] Reviewed-by: Juan Quintela

[PATCH v2 02/13] migration: Use vmstate_register_any()

This are the easiest cases, where we were already using VMSTATE_INSTANCE_ID_ANY. Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- backends/dbus-vmstate.c | 3 +-- backends/tpm/tpm_emulator.c | 3 +-- hw/i2c/core.c | 2 +- hw/input/adb.c | 2 +- hw

[PATCH v2 05/13] migration: Use VMSTATE_INSTANCE_ID_ANY for slirp

/qtest/libqtest.c:195: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) Aborted (core dumped) Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- net/slirp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/slirp.c b/net

[PATCH v2 13/13] migration: Use vmstate_register_any() for vmware_vga

I have no idea if we can have more than one vmware_vga device, so play it safe. Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index

[PATCH v2 04/13] migration: Use vmstate_register_any() for ipmi-bt*

Signed-off-by: Juan Quintela --- hw/ipmi/ipmi_bmc_extern.c | 2 +- hw/ipmi/ipmi_bmc_sim.c| 2 +- hw/ipmi/isa_ipmi_bt.c | 2 +- hw/ipmi/isa_ipmi_kcs.c| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index

[PATCH v2 06/13] migration: Use VMSTATE_INSTANCE_ID_ANY for s390 devices

(expected 0) Aborted (core dumped) Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- hw/s390x/s390-skeys.c| 3 ++- hw/s390x/s390-stattrib.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c index 5024faf411

Re: [PATCH v2 06/13] migration: Use VMSTATE_INSTANCE_ID_ANY for s390 devices

Christian Borntraeger wrote: > Am 20.10.23 um 11:07 schrieb Juan Quintela: >> Just with make check I can see that we can have more than one of this >> devices, so use ANY. >> ok 5 /s390x/device/introspect/abstract-interfaces >> ... >> Broken pipe >> ../../

Re: [PATCH 07/13] RFC migration: icp/server is a mess

"Nicholas Piggin" wrote: > On Fri Oct 20, 2023 at 7:39 AM AEST, Greg Kurz wrote: >> On Thu, 19 Oct 2023 21:08:25 +0200 >> Juan Quintela wrote: > So the reason we can't have duplicate names registered, aside from it > surely going bad if we actually send o

[PATCH v2 00/13] migration: Check for duplicates on vmstate_register()

- And now, another abuser: vmstate_register(VMSTATE_IF(tcet), tcet->liobn, _spapr_tce_table, tcet->liobn is an uint32_t, and instance_id is an int. And it just happens that is value is < VMSTATE_INSTANCE_ID_ANY. Please, review. Juan Quintela (12): migration: Create vmstate_re

[PATCH v2 01/13] migration: Create vmstate_register_any()

-by: Stefan Berger Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 1a31fb7293..9ca7e9cc48 100644 --- a/include/migration/vmstate.h +++ b/include

[PULL 13/17] tests/qtest/migration: Specify the geometry of the bootsector

ead of AHCI like q35 and SeaBIOS has an exception for ATA that ends up skipping the sanity checks and ignoring translation altogether. Workaround this situation by specifying a geometry in the command line. Signed-off-by: Fabiano Rosas Acked-by: Thomas Huth Reviewed-by: Juan Quintela Signed-o

[PULL 07/17] tests/qtest: Introduce qtest_init_with_env

QTEST_QEMU_BINARY. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Reviewed-by: Thomas Huth Signed-off-by: Juan Quintela Message-ID: <20231018192741.25885-3-faro...@suse.de> --- tests/qtest/libqtest.h | 13 + tests/qtest/libqtest.c | 26 +++--- 2 files c

[PULL 12/17] tests/qtest/migration: Define a machine for all architectures

Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231018192741.25885-8-faro...@suse.de> --- tests/qtest/migration-test.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c

[PATCH v2 08/13] migration: vmstate_register() check that instance_id is valid

Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 65deaecc92..896c3f69d2 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -28,6 +28,7

[PATCH v2 03/13] migration: Use vmstate_register_any() for isa-ide

exit status 1 (expected 0) Aborted (core dumped) $ Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- hw/ide/isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/isa.c b/hw/ide/isa.c index 95053e026f..ea60c08116 100644 --- a/hw/ide/isa.c +++ b/hw/ide/isa.c

[PATCH v2 10/13] migration: Improve example and documentation of vmstate_register()

Signed-off-by: Juan Quintela --- docs/devel/migration.rst | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index c3e1400c0c..bfd8710c95 100644 --- a/docs/devel/migration.rst +++ b/docs/devel/migration.rst

[PATCH v2 11/13] migration: Use vmstate_register_any() for audio

We can have more than one audio card. void audio_init_audiodevs(void) { AudiodevListEntry *e; QSIMPLEQ_FOREACH(e, , next) { audio_init(e->dev, _fatal); } } Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH v2 10/22] qapi: Correct error message for 'vcpu_dirty_limit' parameter

Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> QERR_INVALID_PARAMETER_VALUE is defined as: >> >> #define QERR_INVALID_PARAMETER_VALUE \ >> "Parameter '%s' expects %s" >> >> The current error is formatted as: >> >> "Parameter 'vcpu_dirty_limit' expects is invalid, it

Re: [PATCH 07/13] RFC migration: icp/server is a mess

Greg Kurz wrote: > On Fri, 20 Oct 2023 09:30:44 +0200 > Juan Quintela wrote: > >> Greg Kurz wrote: >> > On Thu, 19 Oct 2023 21:08:25 +0200 >> > Juan Quintela wrote: >> > >> >> Current code does: >> >> - register pre_2_10_v

Re: [PATCH 10/13] migration: Improve example and documentation of vmstate_register()

Stefan Berger wrote: > On 10/19/23 15:08, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/devel/migration.rst | 12 >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/docs/devel/migration.rst b/docs/

[PATCH v2 07/13] migration: Hack to maintain backwards compatibility for ppc

k_for_ppc() with warnings left and right that it is a hack. CC: Cedric Le Goater CC: Daniel Henrique Barboza CC: David Gibson CC: Greg Kurz Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 11 +++ hw/intc/xics.c | 17 +++-- hw

[PATCH v2 12/13] migration: Use vmstate_register_any() for eeprom93xx

We can have more than one eeprom93xx. For instance: e100_nic_realize() -> eeprom93xx_new() Reviewed-by: Stefan Berger Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvram/eeprom93xx.c b/hw/nvram/eeprom93xx.c in

[PATCH v2 09/13] migration: Check in savevm_state_handler_insert for dups

Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index d3a30686d4..3e0ece84e8 100644 --- a/migratio

Re: [PATCH 13/13] migration: Use vmstate_register_any() for vmware_vga

Stefan Berger wrote: > On 10/19/23 15:08, Juan Quintela wrote: >> I have no idea if we can have more than one vmware_vga device, so play >> it safe. >> >> Signed-off-by: Juan Quintela > > Reviewed-by: Stefan Berger > >> --- >> hw/display/vmwa

[PULL 16/17] tests/qtest/migration: Allow user to specify a machine type

binaries, to the latest common machine version between the two. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231018192741.25885-12-faro...@suse.de> --- tests/qtest/migration-helpers.h | 2 ++ tests/qtest/mig

[PULL 10/17] tests/qtest: Introduce qtest_resolve_machine_alias

with each release. QEMU provides a machine type alias that has a fixed name, but points to the latest machine type at each release. Add a helper to resolve the alias into the exact machine type. E.g. "-machine pc" resolves to "pc-i440fx-8.2" Reviewed-by: Juan Quintela Revi

[PULL 15/17] tests/qtest/migration: Support more than one QEMU binary

is selected automatically as the latest machine type version that works with both binaries. Usage (only one of SRC|DST is allowed): QTEST_QEMU_BINARY_SRC=../build-8.2.0/qemu-system-x86_64 \ QTEST_QEMU_BINARY=../build-8.1.0/qemu-system-x86_64 \ ./tests/qtest/migration-test Reviewed-by: Juan Quintela Signed

[PULL 03/17] migration: Fix parse_ramblock() on overwritten retvals

-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231017203855.298260-1-pet...@redhat.com> --- migration/ram.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 16c30a9d7a..92769902bb

[PULL 04/17] migration: simplify notifiers

list in a new function migration_call_notifiers, and make it externally visible so future live update code can call it. No functional change. Signed-off-by: Steve Sistare Reviewed-by: Peter Xu Tested-by: Michael Galaxy Reviewed-by: Michael Galaxy Reviewed-by: Juan Quintela Signed-off-by: Juan

[PULL 14/17] tests/qtest/migration: Set q35 as the default machine for x86_86

From: Fabiano Rosas Change the x86_64 to use the q35 machines in tests from now on. Keep testing the pc macine on 32bit. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231018192741.25885-10-faro...@suse

[PULL 08/17] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary

the environment variable changes. Reviewed-by: Juan Quintela Reviewed-by: Thomas Huth Signed-off-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018192741.25885-4-faro...@suse.de> --- tests/qtest/libqtest.c | 29 + 1 file changed, 25 insertions

[PULL 05/17] migration/multifd: Stop checking p->quit in multifd_send_thread

viewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231012140651.13122-3-faro...@suse.de> --- migration/multifd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 1fe53d3b98..e2a45c667a 100644 --- a/migration/multifd.c +++

[PULL 09/17] tests/qtest: Introduce qtest_has_machine_with_env

From: Fabiano Rosas Add a variant of qtest_has_machine() that receives an environment variable containing an alternate QEMU binary path. Reviewed-by: Juan Quintela Reviewed-by: Thomas Huth Signed-off-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018192741.25885-5-f

[PULL 17/17] tests/qtest: Don't print messages from query instances

d-by: Juan Quintela Reviewed-by: Thomas Huth Signed-off-by: Fabiano Rosas Message-ID: <20231018192741.25885-13-faro...@suse.de> Signed-off-by: Juan Quintela --- tests/qtest/libqtest.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/

<    1   2   3   4   5   6   7   8   9   10   >