read
classdesc = self.section_classes[section_key]
KeyError: ('s390-storage_attributes', 0)
It obviously never has been adapted to s390x yet, so until this
has been done, disable this test on s390x.
Signed-off-by: Thomas Huth
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <202
From: Fabiano Rosas
When using two different QEMU binaries for migration testing, we'll
need to find what is the machine version that will work with both
binaries. Add a helper for that.
Reviewed-by: Juan Quintela
Reviewed-by: Thomas Huth
Signed-off-by: Fabiano Rosas
Signed-off-by: Juan
use
QTEST_QEMU_BINARY as a fallback.
Reviewed-by: Juan Quintela
Reviewed-by: Thomas Huth
Signed-off-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231018192741.25885-2-faro...@suse.de>
---
tests/qtest/libqtest.c | 13 ++---
1 file changed, 10 insertions(+), 3 del
, and passing Error** will allow one Error object
to be registered for multiple modes.
No functional change.
Signed-off-by: Steve Sistare
Tested-by: Michael Galaxy
Reviewed-by: Michael Galaxy
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <1697634216-84
The following changes since commit 0d239e513e0117e66fa739fb71a43b9383a108ff:
Merge tag 'pull-lu-20231018' of https://gitlab.com/rth7680/qemu into staging
(2023-10-19 10:20:57 -0700)
are available in the Git repository at:
https://gitlab.com/juan.quintela/qemu.git
Greg Kurz wrote:
> On Thu, 19 Oct 2023 21:08:25 +0200
> Juan Quintela wrote:
>
>> Current code does:
>> - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
>> dependinfg on cpu number
>> - for newer machines, it register vmstate_icp
Thomas Huth wrote:
> On 20/10/2023 11.07, Juan Quintela wrote:
>> Otherwise qom-test fails.
>> ok 4 /i386/qom/x-remote
>> qemu-system-i386: savevm_state_handler_insert: Detected duplicate
>> SaveStateEntry: id=isa-ide, instance_id=0x0
>> Broken pipe
>>
Volker Rümelin wrote:
> Am 20.10.23 um 11:07 schrieb Juan Quintela:
>> We can have more than one audio card.
>
> Hi Juan,
>
> I wouldn't use the term "audio card" here. In QEMU speak, Audiodev is an
> "audio backend".
Thanks. Changed that.
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Set the 'block_incremental' migration parameter to 'true' instead.
>>
>> Reviewed-by: Thomas Huth
>> Acked-by: Stefan Hajnoczi
>> Signed-off-by: Juan Quintela
>>
>> ---
>>
>> Imp
Fiona Ebner wrote:
queued.
> This is intended to be a semantic revert of commit 9b09503752
> ("migration: run setup callbacks out of big lock"). There have been so
> many changes since that commit (e.g. a new setup callback
> dirty_bitmap_save_setup() that also needs to be adapted now), it's
>
the migration data to the file before the
destination can start reading. Add a new migration function
specifically to handle the file migration.
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20230712190742.22294-7-faro...@suse
Borisov
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-2-faro...@suse.de>
---
migration/migration.c | 1 +
migration/savevm.c| 20
2 files changed, 17 insertions(+), 4 deletions(-)
diff
Reported-by: Zhiyi Guo
Reviewed-by: Joao Martins
Reviewed-by: Juan Quintela
Signed-off-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20231010221922.40638-1-pet...@redhat.com>
---
qapi/migration.json| 34 +-
migration/migration
There is only one flag called with: RAM_CONTROL_BLOCK_REG.
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-6-quint...@redhat.com>
---
migration/qemu-file.h | 11 ---
migration/rdma.h | 3 +++
migration/qemu-file.c | 10 --
mig
Once there, all the uses are local to the for, so declare the variable
inside the for statement.
Reviewed-by: Fabiano Rosas
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-12-quint...@redhat.com>
---
migration/rdma.
semaphore.
The comment in ram_init_bitmaps() was introduced by 4987783400
("migration: fix incorrect memory_global_dirty_log_start outside BQL")
and is removed, because it referred to the qemu_mutex_lock_iothread()
call.
Signed-off-by: Fiona Ebner
Reviewed-by: Fabiano Rosas
Review
is the most
likely to know right away what the problem is.
Signed-off-by: Fabiano Rosas
Acked-by: Thomas Huth
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-7-faro...@suse.de>
---
tests/qtest/migration-test.
Once there:
- Remove unused data parameter
- unfold it in its callers.
- change all callers to call qemu_rdma_registration_start()
- We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma()
Reviewed-by: Li Zhijian
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-9-quint...@redhat.com>
---
migration/qemu-file.h | 17 -
migration/rdma.h | 16
migration/ram.c | 2 +-
3 files changed, 17 insertions(
From: Fabiano Rosas
The script is broken when the configuration/capabilities section is
present. Add support for parsing the capabilities so we can fix it in
the next patch.
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15
Wang
Reviewed-by: Peter Xu
Reviewed-by: Isaku Yamahata
Reviewed-by: Juan Quintela
Message-ID: <20230804093053.5037-1-wei.w.w...@intel.com>
Signed-off-by: Juan Quintela
---
migration/migration.c | 167 --
1 file changed, 94 insertions(+), 73 del
Functions are long enough even without this.
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-10-quint...@redhat.com>
---
migration/rdma.h | 12 ++--
migration/ram.c| 14 +++---
migration/
passing the error into the function.
Cc: Markus Armbruster
Signed-off-by: Fabiano Rosas
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231012134343.23757-4-faro...@suse.de>
---
migration/multifd.c
Once there:
- Remove unused data parameter
- unfold it in its callers
- change all callers to call qemu_rdma_registration_stop()
- We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma()
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-4-qu
: Merge save_zero_page functions
migration/multifd: Remove direct "socket" references
migration/multifd: Unify multifd_send_thread error paths
migration/multifd: Clarify Error usage in multifd_channel_connect
Fiona Ebner (1):
migration: hold the BQL during setup
Juan Qu
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-11-quint...@redhat.com>
---
migration/rdma.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index c147c94b08..e973
From: Fabiano Rosas
We're about to enable support for other transports in multifd, so
remove direct references to sockets.
Signed-off-by: Fabiano Rosas
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231012134343.23757-2-f
Reviewed-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011184358.97349-5-elena.ufimts...@oracle.com>
---
migration/multifd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/multifd.c b/migration/multifd.c
index e6e0013c16..c45f5015f8
PAGE_SIZE) that is being sent
as iov[0]. The packet_len part should be added to account for
the size of MultiFDPacket and the array of the offsets.
Signed-off-by: Elena Ufimtseva
Reviewed-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011184358.97349-4
hat's added when x-ignore-shared is used to fix the
script.
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-5-faro...@suse.de>
---
scripts/analyze-migration.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/
Xu
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231010104851.802947-1-fro...@swemel.ru>
---
migration/ram.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 24d91de8b3..e8df4dc862 100644
--- a/migration/ram.c
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Reviewed-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011023627.86691-1-phi...@linaro.org>
---
migration/ram.c | 17 ++---
RDMA was having trouble because
migrate_multifd_flush_after_each_section() can only be true or false,
but we don't want to send any flush when we are not in multifd
migration.
CC: Fabiano Rosas
Reviewed-by: Li Zhijian
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID
From: Fabiano Rosas
We don't need to do this in two pieces. One single function makes it
easier to grasp, specially since it removes the indirection on the
return value handling.
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Instead of going through ram_control_load_hook(), call
qemu_rdma_registration_handle() directly.
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-5-quint...@redhat.com>
---
migration/qemu-file.h | 1 -
migration/rdma.h | 3 +++
migration
The only user of ram_control_save_page() and save_page() hook was
rdma. Just move the function to rdma.c, rename it to
rdma_control_save_page().
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-7-quint...@redhat.com>
---
mig
ection_key]
KeyError: ('spapr_iommu', -2147483648)
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-6-faro...@suse.de>
---
scripts/analyze-migration.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
di
The only user was rdma, and its use is gone.
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-8-quint...@redhat.com>
---
migration/qemu-file.h | 4
migration/qemu-file.c | 6 --
migration/rdma.c | 9 -
3
there.
Signed-off-by: Elena Ufimtseva
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011184358.97349-2-elena.ufimts...@oracle.com>
---
migration/migration-stats.c | 9 +
1 file changed, 5 insertions(+), 4 del
Reviewed-by: Peter Xu
Reviewed-by: Juan Quintela
Signed-off-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231011184604.32364-3-faro...@suse.de>
---
migration/ram.c | 146 +++-
1 file changed, 82 insertions(+), 64 deletions(-)
Declare all variables that are only used inside a for loop inside the
for statement.
This makes clear that they are not used outside of the for loop.
Reviewed-by: Fabiano Rosas
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-13-quint...@redhat.
Change code that is:
int ret;
...
ret = foo();
if (ret[ < 0]?) {
to:
if (foo()[ < 0]) {
Reviewed-by: Fabiano Rosas
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-14-quint...@redhat.com>
---
migration/rdma.c | 29 -
-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011184604.32364-6-faro...@suse.de>
---
migration/ram.c | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 2ec28c4507..229cad5c74
From: Fabiano Rosas
We don't need the QEMUFile when we're already passing the
PageSearchStatus.
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011184604.32364-5-faro...@suse.de>
---
migration/ram.
Helper to say if we are doing a migration over rdma.
Reviewed-by: Peter Xu
Reviewed-by: Li Zhijian
Signed-off-by: Juan Quintela
Message-ID: <20231011203527.9061-2-quint...@redhat.com>
---
migration/migration.h | 2 ++
migration/options.h | 1 +
migration/migration.c | 1 +
mig
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
Message-ID: <20231013104736.31722-2-quint...@redhat.com>
---
qapi/migration.json | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 360e609f66..db3df12d6c
"./scripts/analyze-migration.py", line 571, in read
raise Exception("Unknown section type: %d" % section_type)
Exception: Unknown section type: 5
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231009184326.15777-3-faro
From: Fabiano Rosas
'rs' is not used in that function. It's a leftover from commit
9360447d34 ("ram: Use MigrationStats for statistics").
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231011184604
Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231012134343.23757-3-faro...@suse.de>
---
migration/multifd.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 8e9a5ee394..c92955de41 100644
--- a/migration/mul
marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Using always 0, QEMU will end up loading the same instance, even if
> multiple have been saved.
>
> Signed-off-by: Marc-André Lureau
Similar (but different) fix on next Migration PULL request.
Later, Juan.
> ---
> net/slirp.c |
ing error.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
queued.
marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Check that required subsections have been loaded.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
I will let other people to comment on this before merging.
I can see the (pontential problem) that
marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Check subsection support, and optional handling.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
Thomas Huth wrote:
> On 20/10/2023 21.42, Juan Quintela wrote:
>> Thomas Huth wrote:
>>> On 20/10/2023 11.07, Juan Quintela wrote:
>>>> Otherwise qom-test fails.
>>>> ok 4 /i386/qom/x-remote
>>>> qemu-system-i386: savevm_state_handler_inser
marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The function is used on save at this point. The following commits will
> use it on load.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
queued.
marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
> @@ -2541,6 +2572,11 @@ qemu_loadvm_section_start_full(QEMUFile *f,
> MigrationIncomingState *mis)
> idstr, instance_id);
r QEMU that didn't send
> -the subsection.
> +don't understand, we just fail the migration. If we understand all the
> +subsections, then we load the state with success. There's no check
> +that an optional subsection is loaded, so a newer QEMU that knows
> +about a subsection can (wi
Hanna Czenczek wrote:
> On 18.10.23 13:55, Juan Quintela wrote:
>> Create a new filter that removes the two warnings for test 183.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> tests/qemu-iotests/183 | 2 +-
>> tests/qemu-iotests/common.fil
Marc-André Lureau wrote:
> Hi
>
> On Tue, Oct 24, 2023 at 2:47 PM Juan Quintela wrote:
>>
>> marcandre.lur...@redhat.com wrote:
>> > From: Marc-André Lureau
>> >
>> > Signed-off-by: Marc-André Lureau
>> > ---
>> > docs/
State what are the requeriments to get migration working between qemu
versions. And once there explain how one is supposed to implement a
new feature/default value and not break migration.
Reviewed-by: Vladimir Sementsov-Ogievskiy
Acked-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID
oes a hard reboot.
Acked-by: Peter Xu
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231018112827.1325-5-quint...@redhat.com>
---
docs/devel/migration.rst | 202 +++
1 file changed, 202 insertions(+)
diff --git a/docs/devel/migr
Sometimes devices have different features depending of things outside
of qemu. For instance the kernel. Document how to handle that cases.
Acked-by: Peter Xu
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231018112827.1325-4-quint...@redhat.com>
---
docs
So we can move more compression_counters stuff to ram-compress.c.
Create compression_counters struct to add the stuff that was on
MigrationState.
Reviewed-by: Lukas Straub
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-8-quint...@redhat.
Now that we know it only handles zero, we can remove the ch parameter.
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20231019085259.13307-3-quint...@redhat.com>
---
migration/ram.h | 2 +-
migration/ram.c | 10 +-
migration/rdma.
Reviewed-by: Lukas Straub
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-5-quint...@redhat.com>
---
migration/ram-compress.h | 4 ++--
migration/ram-compress.c | 17 ++---
migration/ram.c | 3 +--
3 files changed, 13 inse
registration fixes (thomas, juan)
- start merging vmstate_section_needed changes (marc)
- migration depreactions (juan)
- migration documentation for backwards compatibility (juan)
Please apply.
Juan Quintela (31):
migration/doc: Add
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-3-quint...@redhat.com>
---
migration/options.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/migration/options.c b/migration/options.c
index b8c3c3218d..37fa1cfe74 100644
--- a/mig
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-11-quint...@redhat.com>
---
migration/ram-compress.h | 1 -
migration/ram-compress.c | 17 ++---
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/migration/ram-compre
And now we can simplify save_compress_page().
Reviewed-by: Lukas Straub
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-7-quint...@redhat.com>
---
migration/ram-compress.c | 1 +
migration/ram.c | 8 ++--
2 files changed, 3 inse
k_for_ppc() with warnings left and right
that it is a hack.
CC: Cedric Le Goater
CC: Daniel Henrique Barboza
CC: David Gibson
CC: Greg Kurz
Reviewed-by: Nicholas Piggin
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-8-quint...@redhat.com>
---
include/migration/vmstat
From: Thomas Huth
instance_init() can be called multiple times, e.g. during introspection
of the device. We should not install the vmstate handlers here. Do it
in the realize() function instead.
Signed-off-by: Thomas Huth
Reviewed-by: Juan Quintela
Acked-by: Corey Minyard
Signed-off-by: Juan
As we export it, rename it compress_flush_data().
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-10-quint...@redhat.com>
---
migration/ram-compress.h | 1 +
migration/ram-compress.c | 9 +
migration/ram.c | 17 --
a1febc4950f2c6232c002f401d7cd409f6fa6a88
Author: Richard Henderson
Date: Mon Aug 29 11:46:14 2016 -0700
cutils: Export only buffer_is_zero
Reviewed-by: Fabiano Rosas
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20231019085259.13307-2-quint...@redhat.com>
---
migration
From: Thomas Huth
There's no need for dedicated handlers here if they don't do anything
special.
Acked-by: David Hildenbrand
Reviewed-by: Eric Farman
Acked-by: Juan Quintela
Signed-off-by: Thomas Huth
Signed-off-by: Juan Quintela
Message-ID: <20231020150554.664422-3-th...@redhat.
From: Marc-André Lureau
The function is used on save at this point. The following commits will
use it on load.
Signed-off-by: Marc-André Lureau
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID: <20231024084043.2926316-5-marcandre.lur...@redhat.com>
---
include/mig
-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-2-quint...@redhat.com>
---
include/migration/vmstate.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 1af181877c..1ea9
We can have more than one eeprom93xx.
For instance:
e100_nic_realize() -> eeprom93xx_new()
Reviewed-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-13-quint...@redhat.com>
---
hw/nvram/eeprom93xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
After previous patch, we disable the posiblity that we use compression
together with xbzrle. So we can use directly migrate_compress().
Once there, now we don't need the rs parameter, so remove it.
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.1532
From: Thomas Huth
Rename the variable here to avoid that it shadows a variable from
the beginning of the function scope. With this change the code now
successfully compiles with -Wshadow=local.
Signed-off-by: Thomas Huth
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
Message-ID
I have no idea if we can have more than one vmware_vga device, so play
it safe.
Reviewed-by: Stefan Berger
Reviewed-by: Thomas Huth
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-14-quint...@redhat.com>
---
hw/display/vmware_vga.c | 2 +-
1 file changed, 1 insertion
It is obsolete. It is better to use driver-mirror with NBD instead.
CC: Kevin Wolf
CC: Eric Blake
CC: Stefan Hajnoczi
CC: Hanna Czenczek
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
Message-ID: <20231018115513.2163-5-quint...@redhat.com>
---
We can have more than one audio backend.
void audio_init_audiodevs(void)
{
AudiodevListEntry *e;
QSIMPLEQ_FOREACH(e, , next) {
audio_init(e->dev, _fatal);
}
}
Reviewed-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-12-quint...@redh
Use blocked-mirror with NBD instead.
Acked-by: Stefan Hajnoczi
Reviewed-by: Thomas Huth
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
Message-ID: <20231018115513.2163-4-quint...@redhat.com>
---
docs/about/deprecated.rst | 9 +
qapi/migration.json
Use blockdev-mirror with NBD instead.
Reviewed-by: Thomas Huth
Acked-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
Message-ID: <20231018115513.2163-3-quint...@redhat.com>
---
docs/about/deprecated.rst | 8
qapi/migration.json
From: Marc-André Lureau
commit 13cde50889237 ("vmstate: Return error in case of error") sets
QemuFile error to stop reading from it and report to the caller (checked
by unit tests). We should do the same on subsection loading error.
Signed-off-by: Marc-André Lureau
Reviewed-by: Jua
Move the goto to a while true.
Reviewed-by: Lukas Straub
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-6-quint...@redhat.com>
---
migration/ram-compress.c | 48
1 file changed, 24 insertions(+), 24 del
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231018112827.1325-2-quint...@redhat.com>
---
docs/devel/migration.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index c3e1400c0c..4d6a98ae58 100644
---
quite a bit.
Acked-by: David Hildenbrand
Reviewed-by: Eric Farman
Acked-by: Juan Quintela
Signed-off-by: Thomas Huth
Signed-off-by: Juan Quintela
Message-ID: <20231020150554.664422-2-th...@redhat.com>
---
hw/s390x/s390-skeys.c | 35 ---
1 file ch
Signed-off-by: Peter Xu
Reviewed-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-10-quint...@redhat.com>
---
migration/savevm.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/migration/savevm.c b/migratio
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-2-quint...@redhat.com>
---
migration/options.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/migration/options.c b/migration/options.c
index 42fb818956..b8c3c3218d 100644
--- a/mig
This function is only used for compression. So we rename it as
compress_send_queued_data(). We put it on ram-compress.h because we
are moving it later to ram-compress.c.
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-9-quint...@redhat.
This are the easiest cases, where we were already using
VMSTATE_INSTANCE_ID_ANY.
Reviewed-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-3-quint...@redhat.com>
---
backends/dbus-vmstate.c | 3 +--
backends/tpm/tpm_emulator.c | 3 +--
hw/i2c/
Create a new filter that removes the two warnings for test 183.
Reviewed-by: Hanna Czenczek
Signed-off-by: Juan Quintela
Message-ID: <20231018115513.2163-2-quint...@redhat.com>
---
tests/qemu-iotests/183 | 2 +-
tests/qemu-iotests/common.filter | 7 +++
2 files chan
From: Thomas Huth
We must not call register_savevm_live() from an instance_init() function
(since this could be called multiple times during device introspection).
Move this to the realize() function instead.
Acked-by: David Hildenbrand
Reviewed-by: Eric Farman
Signed-off-by: Juan Quintela
We are moving to have all functions exported from ram-compress.c to
start with compress_.
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20231019110724.15324-12-quint...@redhat.com>
---
migration/ram-compress.h | 2 +-
migration/ram-compress.c | 2 +-
migration
/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered exit status 1 (expected 0)
Aborted (core dumped)
Reviewed-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-6-quint...@redhat.com>
---
net/slirp.c | 5 +++--
1 file chan
Acked-by: Stefan Hajnoczi
Acked-by: Peter Xu
Reviewed-by: Markus Armbruster
Signed-off-by: Juan Quintela
Message-ID: <20231018115513.2163-6-quint...@redhat.com>
---
docs/about/deprecated.rst | 8 +
qapi/migration.json | 63 ++-
mig
Reviewed-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-11-quint...@redhat.com>
---
docs/devel/migration.rst | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index be91
exit status 1 (expected 0)
Aborted (core dumped)
$
Reviewed-by: Stefan Berger
Signed-off-by: Juan Quintela
Message-ID: <20231020090731.28701-4-quint...@redhat.com>
---
hw/ide/isa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/isa.c b/hw/ide/isa.c
index 9505
Remove the increase in qemu_file_fill_buffer() and add asserts to
qemu_file_transferred* functions.
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 3fb25148d1
501 - 600 of 1459 matches
Mail list logo
