Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this patch. Are you trying to say the /dev/sr(0 | 1) devices

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

On 25/06/2015 18:16, Paolo Bonzini wrote: On 25/06/2015 18:12, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

On 25/06/2015 19:19, Laurent Vivier wrote: On 25/06/2015 18:16, Paolo Bonzini wrote: On 25/06/2015 18:12, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used

Re: [Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

On 02/07/2015 09:18, Paolo Bonzini wrote: On 02/07/2015 00:13, Programmingkid wrote: Fix real cdrom access in Mac OS X so it can be used in QEMU. It simply removes the r from a device file's name. This allows for a real cdrom to be accessible to the guest. It has been successfully

Re: [Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

On 02/07/2015 13:14, Stefan Hajnoczi wrote: On Wed, Jul 1, 2015 at 11:13 PM, Programmingkid programmingk...@gmail.com wrote: Fix real cdrom access in Mac OS X so it can be used in QEMU. It simply removes the r from a device file's name. This allows for a real cdrom to be accessible to the

Re: [Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

On 02/07/2015 15:47, Paolo Bonzini wrote: On 02/07/2015 14:24, Laurent Vivier wrote: #ifdef __FreeBSD__ if (S_ISCHR(st.st_mode)) { /* * The file is a char device (disk), which on FreeBSD isn't behind * a pager, so force all requests to be aligned

Re: [Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

On 02/07/2015 16:03, Paolo Bonzini wrote: On 02/07/2015 15:58, Laurent Vivier wrote: Since any /dev entry can be treated as a raw disk image, it is worth noting which devices can be accessed when and how. /dev/rdisk nodes are character-special devices, but are raw in the BSD sense

Re: [Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

On 02/07/2015 16:20, Paolo Bonzini wrote: On 02/07/2015 16:18, Laurent Vivier wrote: I'm okay with doing the simple thing, but it needs a comment for non-BSDers. So, what we have to do, in our case, for MacOS X cdrom, is something like: ... GetBSDPath ... ... if (flags

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

On 29/06/2015 05:01, Programmingkid wrote: On Jun 28, 2015, at 8:29 PM, Laurent Vivier wrote: Hi, On 29/06/2015 01:43, Programmingkid wrote: On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com mailto:programmingk

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

Hi, On 29/06/2015 01:43, Programmingkid wrote: On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

On 29/06/2015 20:37, Programmingkid wrote: On Jun 29, 2015, at 2:16 PM, Peter Maydell wrote: On 29 June 2015 at 19:04, Programmingkid programmingk...@gmail.com mailto:programmingk...@gmail.com wrote: On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote: On 29 June 2015 at 17:54,

Re: [Qemu-block] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/07/2015 12:48, Stefan Hajnoczi wrote: On Fri, Jul 17, 2015 at 03:24:34PM -0400, Programmingkid wrote: On Jul 17, 2015, at 9:41 AM, Stefan Hajnoczi wrote: On Thu, Jul 16, 2015 at 04:46:07PM -0400, Programmingkid wrote: @@ -2014,7

Re: [Qemu-block] [PATCH] virtio-blk: Fix double completion for werror=stop

irtio-blk.h > +++ b/include/hw/virtio/virtio-blk.h > @@ -70,6 +70,7 @@ typedef struct VirtIOBlockReq { > size_t in_len; > struct VirtIOBlockReq *next; > struct VirtIOBlockReq *mr_next; > +bool merged; > BlockAcctCookie acct; > } VirtIOBlockReq; > > Tested-by: Laurent Vivier <lviv...@redhat.com> In my case, this patch fixes a memory corruption when the VM is stopped on io-error (no space) and restarted.

Re: [Qemu-block] [PATCH v2] virtio-blk: Fix double completion for werror=stop

> Fix this by marking request R as "merged" and skipping it in > virtio_blk_handle_rw_error. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Fam Zheng <f...@redhat.com> > > --- > > v2: Don't lose the request in migration. [Paolo] Tested-by: Laurent Vivier &l

Re: [Qemu-block] [PATCH v3] virtio-blk: Fix double completion for werror=stop

insertions(+) > > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block I have also tested this one and it works fine. Tested-by: Laurent Vivier <lviv...@redhat.com> Laurent

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: Make physical devices usable in QEMU

On 07/07/2015 19:33, Programmingkid wrote: Make physical devices like a USB flash drive or a CDROM drive work in QEMU. With this patch I can use a USB flash drive like a hard drive. Before this patch, QEMU would just quit with a message like resource busy. Now it handles issues like

[Qemu-block] [PATCH 03/10][TRIVIAL] escc: add to input category

ESCC is a serial port controller, so add it to the input category. Signed-off-by: Laurent Vivier <laur...@vivier.eu> --- hw/char/escc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/escc.c b/hw/char/escc.c index ba653ef..9816154 100644 --- a/hw/char/escc.c +++ b/hw/char/

[Qemu-block] [PATCH 00/10][TRIVIAL] Define categories for some PPC devices

Some PPC devices appear uncategorized in the output of "-device ?". This series tries to categorize some of them. Laurent Vivier (10): adb: add to input category cmd646: add to storage category escc: add to input category grackle: add to bridge category cuda: add to bridg

[Qemu-block] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category

macio-ide is an IDE controller, so add it to the storage category. Signed-off-by: Laurent Vivier <laur...@vivier.eu> --- hw/ide/macio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index 66ac2ba..893c9b9 100644 --- a/hw/ide/macio.c +++ b/hw/ide/m

[Qemu-block] [PATCH 01/10][TRIVIAL] adb: add to input category

The Apple Desktop Bus is used to connect a keyboard and a mouse, so add it to the input category. Signed-off-by: Laurent Vivier <laur...@vivier.eu> --- hw/input/adb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/input/adb.c b/hw/input/adb.c index a18eea2..09eead9 100644 --

[Qemu-block] [PATCH 09/10][TRIVIAL] macio-nvram: add to misc category

The macio nvram is a non volatile RAM, so add it the misc category. Signed-off-by: Laurent Vivier <laur...@vivier.eu> --- hw/nvram/mac_nvram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c index d35f8a3..9f16566 100644 --- a/hw/nvram/mac_n

[Qemu-block] [PATCH 10/10][TRIVIAL] openpic: add to misc category

openpic is a programmable interrupt controller, so add it to the misc category. Signed-off-by: Laurent Vivier <laur...@vivier.eu> --- hw/intc/openpic.c | 1 + hw/intc/openpic_kvm.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 1

[Qemu-block] [PATCH 08/10][TRIVIAL] macio: add to bridge category

macio is a bridge between the PCI bus and the Mac nvram, IDE controller and PIC, so add it to the bridge category. Signed-off-by: Laurent Vivier <laur...@vivier.eu> --- hw/misc/macio/macio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c

[Qemu-block] [PATCH 7/7] sheepdog: remove useless casts

This patch is the result of coccinelle script scripts/coccinelle/typecast.cocci CC: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp> CC: qemu-block@nongnu.org Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/sheepdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[Qemu-block] [PATCH 05/16] block: Use DIV_ROUND_UP

Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). This patch is the result of coccinelle script scripts/coccinelle/round.cocci CC: qemu-block@nongnu.org Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/vvfat.c | 3 +-- hw/block/tc58128.c | 2 +- 2 files changed, 2 inse

[Qemu-block] [PATCH 04/16] qed: Use DIV_ROUND_UP

Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). This patch is the result of coccinelle script scripts/coccinelle/round.cocci CC: qemu-block@nongnu.org Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/qed-check.c | 3 +-- block/qed.c | 3 +-- 2 files changed, 2 inse

[Qemu-block] [PATCH 03/16] qcow/qcow2: Use DIV_ROUND_UP

Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). This patch is the result of coccinelle script scripts/coccinelle/round.cocci CC: qemu-block@nongnu.org Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/qcow.c | 4 ++-- block/qcow2-cluster.c | 4 ++-- block

[Qemu-block] [PATCH 02/16] parallels: Use DIV_ROUND_UP

Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). This patch is the result of coccinelle script scripts/coccinelle/round.cocci CC: qemu-block@nongnu.org Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/parallels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-block] [Qemu-devel] [PULL 08/17] block: Assert no write requests under BDRV_O_INCOMING

Hi, this commit breaks incoming migration case: qemu-system-ppc64 XXX -incoming tcp:0: qemu-system-ppc64: .../qemu/block/io.c:1304: bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed. Without "-incoming", the same command line boots fine. Are you aware of the problem?

Re: [Qemu-block] [Qemu-devel] [PULL 08/17] block: Assert no write requests under BDRV_O_INCOMING

On 19/02/2016 10:17, Kevin Wolf wrote: > Am 18.02.2016 um 17:03 hat Laurent Vivier geschrieben: >> Hi, >> >> this commit breaks incoming migration case: >> >> qemu-system-ppc64 XXX -incoming tcp:0: >> qemu-system-ppc64: .../qemu/block/io.c:1304:

Re: [Qemu-block] [Qemu-ppc] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah...@gmail.com>

On 10/03/2016 20:30, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > --- > audio/audio.c | 2 +- > audio/noaudio.c | 4 ++-- > audio/spiceaudio.c| 2 +- > audio/wavaudio.c | 2 +- > backends/baum.c | 2 +- >

Re: [Qemu-block] [PATCH v2] block: Fix bdrv_drain in coroutine

_coroutine_yield() >> qcow2:qemu_co_mutex_lock.return >> ... >tracked request end > ... > (resumed from BH callback) > bdrv_drain.return > ... > > Reported-by: Laurent Vivier <lviv...@redhat.com> > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Fam Zheng <f...@redhat.com> Tested-by: Laurent Vivier <lviv...@redhat.com>

Re: [Qemu-block] [PATCH v2 3/8] hw: Default -drive to if=none instead of ide when ide cannot work

. > > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: qemu-...@nongnu.org > Cc: Edgar E. Iglesias <edgar.igles...@gmail.com> > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: xen-de...@lists.xensour

Re: [Qemu-block] [PATCH for-2.9?] block/io: Comment out permission assertions

broken, to Laurent. > > Reviewed-by: Kevin Wolf <kw...@redhat.com> > Tested-by: Kevin Wolf <kw...@redhat.com> > With postcopy migration Tested-by: Laurent Vivier <lviv...@redhat.com>

Re: [Qemu-block] [PATCH for-2.9?] block/io: Comment out permission assertions

On 12/04/2017 15:18, Kevin Wolf wrote: > Am 11.04.2017 um 17:07 hat Laurent Vivier geschrieben: >> On 11/04/2017 16:58, Kevin Wolf wrote: >>> Am 11.04.2017 um 16:50 hat Max Reitz geschrieben: >>>> In case of block migration, there may be writes to BlockBackends t

Re: [Qemu-block] [Qemu-trivial] [PATCH] iotests: Fix typo in 026

On 27/04/2017 00:10, Eric Blake wrote: > s/refcout/refcount/ > > CC: qemu-triv...@nongnu.org > Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Laurent Vivier <lviv...@redhat.com> > --- > tests/qemu-iotests/026 | 2 +- > tests/qemu-iotest

Re: [Qemu-block] [Qemu-trivial] [PATCH] MAINTAINERS: Update paths for AioContext implementation

AINTAINERS > +++ b/MAINTAINERS > @@ -1177,8 +1177,8 @@ M: Stefan Hajnoczi <stefa...@redhat.com> > M: Fam Zheng <f...@redhat.com> > L: qemu-block@nongnu.org > S: Supported > -F: async.c > -F: aio-*.c > +F: util/async.c > +F: util/aio-*.c > F: block/io.c

Re: [Qemu-block] [Qemu-trivial] [PATCH] MAINTAINERS: Update paths for AioContext implementation

On 03/05/2017 12:30, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 46cf4870f9..62d62a6675 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS

Re: [Qemu-block] [Qemu-trivial] [PATCH] hw/block/onenand: Remove dead code block

reak; > -} > if (s->blockwp[b] == ONEN_LOCK_LOCKTIGHTEN) > break; > > Looks like a bad cut'n'paste from case 0x23. Reviewed-by: Laurent Vivier <lviv...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [RFC 01/13] hw/m68k: add via support

Le 09/06/2018 à 17:48, Mark Cave-Ayland a écrit : > On 09/06/18 11:01, Mark Cave-Ayland wrote: > >> Yeah, we can certainly remove a huge chunk of this by converting over >> to the mos6522 device. My last set of updates to CUDA a couple of days >> ago are probably the best reference, but I can

[Qemu-block] [RFC 11/13] dp8393x: manage big endian bus

This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier --- hw/net/dp8393x.c | 101 ++- 1 file changed, 70 insertions(+), 31 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net

[Qemu-block] [RFC 12/13] dp8393x: put DMA temp buffer in the state, not in the stack

It's only 32 bytes, and this simplifies the dp8393x_get()/ dp8393x_put() interface. Signed-off-by: Laurent Vivier --- hw/net/dp8393x.c | 107 ++- 1 file changed, 51 insertions(+), 56 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net

[Qemu-block] [RFC 05/13] hw/m68k: Apple Sound Chip (ASC) emulation

From: Laurent Vivier This is broken as the linux driver seems broken too... Signed-off-by: Laurent Vivier --- hw/audio/Makefile.objs | 1 + hw/audio/asc.c | 492 + include/hw/audio/asc.h | 21 +++ 3 files changed, 514 insertions

[Qemu-block] [RFC 13/13] dp8393x: fix receiving buffer exhaustion

the buffers, but the card cannot receive new ones. This patch fixes the problem by not incrementing RRP when the driver clears the ISR RBE bit. Signed-off-by: Laurent Vivier --- hw/net/dp8393x.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/hw/net

[Qemu-block] [RFC 08/13] hw/m68k: add a dummy SWIM floppy controller

Signed-off-by: Laurent Vivier --- hw/block/Makefile.objs | 1 + hw/block/swim.c| 325 + 2 files changed, 326 insertions(+) create mode 100644 hw/block/swim.c diff --git a/hw/block/Makefile.objs b/hw/block/Makefile.objs index 53ce5751ae

[Qemu-block] [RFC 00/13] hw/m68k: add Apple Machintosh Quadra 800 machine

.15.0-2-m68k . copy-out /boot/initrd.img-4.15.0-2-m68k . _EOF_ and boot with: ... -append "root=/dev/sda2 rw console=ttyS0 console=tty \ -kernel vmlinux-4.15.0-2-m68k \ -initrd initrd.img-4.15.0-2-m68k Laurent Vivier (13): hw/m68k: add via support ADB: VIA probes ADB bus when it i

[Qemu-block] [RFC 04/13] hw/m68k: add video card

From: Laurent Vivier Signed-off-by: Laurent Vivier --- arch_init.c | 4 + hw/display/Makefile.objs| 1 + hw/display/macfb-template.h | 158 + hw/display/macfb.c | 283 qemu-options.hx

[Qemu-block] [RFC 06/13] ESP: add pseudo-DMA as used by Macintosh

From: Laurent Vivier Signed-off-by: Laurent Vivier --- hw/mips/mips_jazz.c | 2 +- hw/scsi/esp.c | 330 +- include/hw/scsi/esp.h | 15 ++- 3 files changed, 313 insertions(+), 34 deletions(-) diff --git a/hw/mips/mips_jazz.c b/hw

[Qemu-block] [RFC 07/13] hw/m68k: add Nubus support

Signed-off-by: Laurent Vivier --- hw/Makefile.objs | 1 + hw/display/macfb.c | 67 +++- hw/nubus/Makefile.objs | 4 + hw/nubus/mac.c | 112 +++ hw/nubus/nubus-bridge.c | 34 ++ hw/nubus/nubus-bus.c | 60 +++ hw/nubus/nubus

[Qemu-block] [RFC 01/13] hw/m68k: add via support

Signed-off-by: Laurent Vivier --- hw/input/adb.c| 99 - hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 940 ++ include/hw/input/adb.h| 8 + include/hw/misc/mac_via.h | 45 +++ 5 files changed, 1092 insertions

[Qemu-block] [RFC 02/13] ADB: VIA probes ADB bus when it is idle

Signed-off-by: Laurent Vivier --- hw/input/adb-kbd.c | 4 hw/input/adb-mouse.c | 4 hw/input/adb.c | 33 + hw/misc/mac_via.c | 27 ++- include/hw/input/adb.h | 1 + 5 files changed, 60 insertions(+), 9

[Qemu-block] [RFC 03/13] escc: introduce a selector for the register bit

From: Laurent Vivier On Sparc and PowerMac, the bit 0 of the address selects the register type (control or data) and bit 1 selects the channel (B or A). On m68k Macintosh, the bit 0 selects the channel and bit 1 the register type. This patch introduces a new parameter (bit_swap) to the device

[Qemu-block] [RFC 10/13] dp8393x: fix dp8393x_receive

address_space_rw() access size must be multiplied by width. dp8393x_receive() must return the number of bytes read, not the length of the last memory access. Signed-off-by: Laurent Vivier --- hw/net/dp8393x.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/net

[Qemu-block] [RFC 09/13] hw/m68k: define Macintosh Quadra 800

From: Laurent Vivier Signed-off-by: Laurent Vivier --- default-configs/m68k-softmmu.mak | 12 ++ hw/display/macfb.c | 31 ++-- hw/m68k/Makefile.objs| 6 +- hw/m68k/bootinfo.h | 99 ++ hw/m68k/mac.c| 384

Re: [Qemu-block] [Qemu-devel] [RFC 00/13] hw/m68k: add Apple Machintosh Quadra 800 machine

Le 09/06/2018 à 05:26, Philippe Mathieu-Daudé a écrit : > On 06/08/2018 05:05 PM, Laurent Vivier wrote: >> I'm rebasing some of these patches for seven years now, >> too many years... >> >> It's an RFC because things have changed in QEMU in seven years, >&g

[Qemu-block] [RFC v3 08/10] hw/m68k: add a dummy SWIM floppy controller

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/block/Makefile.objs | 1 + hw/block/swim.c | 284 include/hw/block/swim.h | 53 + 3 files changed, 338 insertions

[Qemu-block] [RFC v3 09/10] dp8393x: manage big endian bus

This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 1 file changed, 57 insertions(+), 31 deletions(-) diff --git a/hw

[Qemu-block] [C v2 10/10] hw/m68k: define Macintosh Quadra 800

From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- MAINTAINERS | 19 ++ default-configs/m68k-softmmu.mak | 14 ++ hw/intc/Makefile.objs| 1 + hw/intc/q800_irq.c | 73

[Qemu-block] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/block/Makefile.objs | 1 + hw/block/swim.c | 284 include/hw/block/swim.h | 53 + 3 files changed, 338 insertions

[Qemu-block] [RFC v3 02/10] ADB: VIA probes ADB bus when it is idle

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/input/adb-kbd.c| 4 ++ hw/input/adb-mouse.c | 4 ++ hw/input/adb.c| 115 ++ hw/misc/mac_via.c | 56

[Qemu-block] [RFC v3 01/10] hw/m68k: add via support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 675 ++ include/hw/misc/mac_via.h | 106 3 files changed, 782 insertions

[Qemu-block] [RFC v3 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

xes, because one of the patch breaks something Update "dp8393x: manage big endian bus" with idea from Thomas Mark has reworked most of the patches: - use mos6522 - some code move, renamings and cleanup Laurent Vivier (10): hw/m68k: add via support ADB: VIA probes ADB bu

[Qemu-block] [RFC v3 03/10] escc: introduce a selector for the register bit

bits usage must be swapped between registers and channels. For the moment all the machines use the bit 0, but this change will be needed to emulate Quadra 800. Signed-off-by: Laurent Vivier --- hw/char/escc.c | 30 -- include/hw/char/escc.h | 1 + 2 files

[Qemu-block] [RFC v3 05/10] hw/m68k: Apple Sound Chip (ASC) emulation

This is broken as the linux driver seems broken too... Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/audio/Makefile.objs | 1 + hw/audio/asc.c | 463 + include/hw/audio/asc.h

[Qemu-block] [RFC v3 04/10] hw/m68k: add video card

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- arch_init.c | 4 + hw/display/Makefile.objs| 1 + hw/display/macfb-template.h | 158 +++ hw/display/macfb.c | 252

[Qemu-block] [RFC v3 06/10] ESP: add pseudo-DMA as used by Macintosh

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/mips/mips_jazz.c | 2 +- hw/scsi/esp.c | 297 -- include/hw/scsi/esp.h | 11 +- 3 files changed, 276 insertions(+), 34 deletions

[Qemu-block] [RFC v3 07/10] hw/m68k: add Nubus support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/display/macfb.c | 56 ++ hw/nubus/Makefile.objs | 4 + hw/nubus/mac-nubus-bridge.c | 45

[Qemu-block] [RFC v3 10/10] hw/m68k: define Macintosh Quadra 800

From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- MAINTAINERS | 19 ++ default-configs/m68k-softmmu.mak | 14 ++ hw/intc/Makefile.objs| 1 + hw/intc/q800_irq.c | 73

[Qemu-block] [C v2 07/10] hw/m68k: add Nubus support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/display/macfb.c | 56 ++ hw/nubus/Makefile.objs | 4 + hw/nubus/mac-nubus-bridge.c | 45

[Qemu-block] [C v2 04/10] hw/m68k: add video card

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- arch_init.c | 4 + hw/display/Makefile.objs| 1 + hw/display/macfb-template.h | 158 +++ hw/display/macfb.c | 252

[Qemu-block] [C v2 01/10] hw/m68k: add via support

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 675 ++ include/hw/misc/mac_via.h | 106 3 files changed, 782 insertions

[Qemu-block] [C v2 02/10] ADB: VIA probes ADB bus when it is idle

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/input/adb-kbd.c| 4 ++ hw/input/adb-mouse.c | 4 ++ hw/input/adb.c| 115 ++ hw/misc/mac_via.c | 56

[Qemu-block] [C v2 03/10] escc: introduce a selector for the register bit

bits usage must be swapped between registers and channels. For the moment all the machines use the bit 0, but this change will be needed to emulate Quadra 800. Signed-off-by: Laurent Vivier --- hw/char/escc.c | 30 -- include/hw/char/escc.h | 1 + 2 files

[Qemu-block] [C v2 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

t;dp8393x: manage big endian bus" with idea from Thomas Mark has reworked most of the patches: - use mos6522 - some code move, renamings and cleanup Laurent Vivier (10): hw/m68k: add via support ADB: VIA probes ADB bus when it is idle escc: introduce a selector for the regist

[Qemu-block] [C v2 06/10] ESP: add pseudo-DMA as used by Macintosh

Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/mips/mips_jazz.c | 2 +- hw/scsi/esp.c | 297 -- include/hw/scsi/esp.h | 11 +- 3 files changed, 276 insertions(+), 34 deletions

Re: [Qemu-block] [PATCH 2/4] error: Remove NULL checks on error_propagate() calls

On 23/03/2018 21:50, Eric Blake wrote: > On 03/22/2018 11:12 AM, Laurent Vivier wrote: >> Re-run Coccinelle patch >> scripts/coccinelle/error_propagate_null.cocci >> >> Signed-off-by: Laurent Vivier <lviv...@redhat.com> >> --- >>   io/channel-websoc

Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not ""

Le 20/03/2018 à 02:54, Michael S. Tsirkin a écrit : > QEMU coding style at the moment asks for all non-system > include files to be used with #include "foo.h". > However this rule actually does not make sense and > creates issues for when the included file is generated. If you change that, we can

[Qemu-block] [PATCH 3/4] qdict: remove useless cast

Re-run Coccinelle script scripts/coccinelle/qobject.cocci Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/nvme.c | 11 +-- monitor.c| 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 8bca57aae6..c4f3a7bc94

[Qemu-block] [PATCH 2/4] error: Remove NULL checks on error_propagate() calls

Re-run Coccinelle patch scripts/coccinelle/error_propagate_null.cocci Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- io/channel-websock.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index ec48a305f0..e6608b969d

[Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

Re-run Coccinelle script scripts/coccinelle/return_directly.cocci Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- accel/tcg/translate-all.c | 5 +- block/quorum.c | 6 +-- hw/arm/exynos

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

On 22/03/2018 17:51, Max Filippov wrote: > On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier <lviv...@redhat.com> wrote: >> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci >> >> Signed-off-by: Laurent Vivier <lviv...@redhat.com> >> --- >>

[Qemu-block] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again again)

Re-run Coccinelle script scripts/coccinelle/err-bad-newline.cocci, and found new error_report() occurences with '\n'. Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- target/i386/hvf/hvf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/

[Qemu-block] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

I've re-run some scripts from the coccinelle directory, and they have found some problems. This series fixes them. Laurent Vivier (4): error: Strip trailing '\n' from error string arguments (again again) error: Remove NULL checks on error_propagate() calls qdict: remove useless cast

Re: [Qemu-block] [Qemu-devel] [PATCH] scsi: turn "is this a SCSI device?" into a conditional hint

On 21/03/2018 11:58, Paolo Bonzini wrote: > If the user does not have permissions to send ioctls to the device (due to > SELinux or cgroups, for example), the output can look like > > qemu-kvm: -device scsi-block,drive=disk: cannot get SG_IO version number: > Operation not permitted. Is this a

Re: [Qemu-block] [PATCH] scsi: turn "is this a SCSI device?" into a conditional hint

nt. > > Reported-by: Ala Hino <ah...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/scsi/scsi-disk.c| 7 --- > hw/scsi/scsi-generic.c | 7 --- > 2 files changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Laurent Vivier <lviv...@redhat.com>

Re: [Qemu-block] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

On 23/03/2018 13:37, Michael Tokarev wrote: > 22.03.2018 19:12, Laurent Vivier wrote: >> I've re-run some scripts from the coccinelle directory, >> and they have found some problems. >> >> This series fixes them. >> >> Laurent Vivier (4): >> error: St

[Qemu-block] [PATCH v2 4/5] qdict: remove useless cast

Re-run Coccinelle script scripts/coccinelle/qobject.cocci Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- block/nvme.c | 11 +-- monitor.c| 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 8bca57aae6..c4f3a7bc94

[Qemu-block] [PATCH v2 3/5] error: Remove NULL checks on error_propagate() calls

Re-run Coccinelle patch scripts/coccinelle/error_propagate_null.cocci Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- io/channel-websock.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index ec48a305f0..e6608b969d

[Qemu-block] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle

): make: improve check for stale generated files in source dir Laurent Vivier (4): error: Strip trailing '\n' from error string arguments (again again) error: Remove NULL checks on error_propagate() calls qdict: remove useless cast Remove unnecessary variables for function return value

[Qemu-block] [PATCH v2 2/5] error: Strip trailing '\n' from error string arguments (again again)

Re-run Coccinelle script scripts/coccinelle/err-bad-newline.cocci, and found new error_report() occurences with '\n'. Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- target/i386/hvf/hvf.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/

[Qemu-block] [PATCH v2 1/5] make: improve check for stale generated files in source dir

From: Daniel P. Berrangé When doing a build with builddir != srcdir, if any generated files are accidentally present in srcdir from a previous build, these can cause unexpected failures. Currently there is a rule that checks for existance of config-host.mak, but there have

[Qemu-block] [PATCH v2 5/5] Remove unnecessary variables for function return value

Re-run Coccinelle script scripts/coccinelle/return_directly.cocci Signed-off-by: Laurent Vivier <lviv...@redhat.com> --- accel/tcg/translate-all.c | 5 +- block/quorum.c | 6 +-- hw/arm/exynos

Re: [Qemu-block] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle

On 23/03/2018 18:47, Eric Blake wrote: > On 03/23/2018 09:31 AM, Laurent Vivier wrote: >> I've re-run some scripts from the coccinelle directory, >> and they have found some problems. >> >> This series fixes them. >> >> v2: only change PATCH 4/4 >&g

Re: [Qemu-block] [RFC v3 06/10] ESP: add pseudo-DMA as used by Macintosh

Le 28/06/2018 à 10:13, Paolo Bonzini a écrit : > On 28/06/2018 01:29, Laurent Vivier wrote: >> int32_t ti_size; >> @@ -46,6 +47,11 @@ struct ESPState { >> ESPDMAMemoryReadWriteFunc dma_memory_write; >> void *dma_opaque; >> void (*dma_cb)(ESPSt

Re: [Qemu-block] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller

Le 28/06/2018 à 10:44, Kevin Wolf a écrit : > Am 28.06.2018 um 01:23 hat Laurent Vivier geschrieben: >> Co-developed-by: Mark Cave-Ayland >> Signed-off-by: Mark Cave-Ayland >> Signed-off-by: Laurent Vivier > >> +static Property swim_properties[] = { >> +

Re: [Qemu-block] [PATCH v4 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

Le 18/10/2018 à 20:28, Mark Cave-Ayland a écrit : > (MCA: I've reposting this on behalf of Laurent as I've been working on the > feedback from v3 over the past months and therefore am better placed to > update the changelog. If all goes well, it would be good to get this merged > in time for 3.1

[Qemu-block] [PULL 10/20] linux-user: fix comment s/atomic_write/atomic_set/

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <20180811211011.6277-1-c...@braap.org> Signed-off-by: Laurent Vivier --- linux-user/qemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 1beb6a

[Qemu-block] [PULL 07/20] scripts/decodetree.py: remove unused imports

From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-8-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/decodetree.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodet

[Qemu-block] [PULL 18/20] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro

: <20180705155811.20366-8-f4...@amsat.org> Signed-off-by: Laurent Vivier --- include/hw/intc/arm_gicv3_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/intc/arm_gicv3_common.h b/include/hw/intc/arm_gicv3_common.h index b798486ecf..31ec9a1ae4 100644 --- a/i

[Qemu-block] [PULL 04/20] tests/tcg/README: fix location for lm32 tests

From: Cleber Rosa Point to the right and obvious location for lm32 tests. Signed-off-by: Cleber Rosa Reviewed-by: Thomas Huth Acked-by: Alex Bennée Message-Id: <20181004161852.11673-3-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/tcg/README | 2 +- 1 file changed, 1 ins

  1   2   3   4   5   6   >