).
Cc: qemu-stable <qemu-sta...@nongnu.org>
Signed-off-by: Max Reitz <mre...@redhat.com>
---
block/qcow2-cluster.c | 30 +++---
block/qcow2-refcount.c | 10 +++---
block/qcow2.h | 6 +++---
3 files changed, 29 insertions(+), 17 deletions(-)
diff -
).
Cc: qemu-stable <qemu-sta...@nongnu.org>
Signed-off-by: Max Reitz <mre...@redhat.com>
---
block/qcow2-cluster.c | 30 +++---
block/qcow2-refcount.c | 12
block/qcow2.h | 6 +++---
3 files changed, 30 insertions(+), 18 deletions(-)
diff -
eam/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/2:[0002] [FC] 'qcow2: Make size_to_clusters() return uint64_t'
002/2:[] [--] 'iotests: Add test for checking large image files'
Max Reitz (2):
qcow2: M
Add a test for checking a qcow2 file with a multiple of 2^32 clusters.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
tests/qemu-iotests/138 | 73 ++
tests/qemu-iotests/138.out | 9 ++
ewed-by: Eric Blake <ebl...@redhat.com>
> ---
> blockdev.c | 2 +-
> qapi-schema.json | 2 +-
> qapi/block-core.json | 8
> 3 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 11.09.2015 09:30, Wen Congyang wrote:
> On 09/11/2015 03:09 AM, Max Reitz wrote:
>> On 10.09.2015 03:12, Wen Congyang wrote:
>>> On 09/09/2015 08:59 PM, Max Reitz wrote:
>>>> On 09.09.2015 12:01, Wen Congyang wrote:
>>>>> On 09/09/2015 05:20 AM, Max
On 10.09.2015 15:39, Alberto Garcia wrote:
> If set to true, the image will be opened with the BDRV_O_NO_BACKING
> flag. This is useful for creating snapshots using images opened with
> blockdev-add, since they are not supposed to have a backing image
> before the operation.
>
> Signed-off-by:
On 11.09.2015 19:28, Kevin Wolf wrote:
> Am 11.09.2015 um 19:21 hat Max Reitz geschrieben:
>> On 10.09.2015 15:39, Alberto Garcia wrote:
>>> If set to true, the image will be opened with the BDRV_O_NO_BACKING
>>> flag. This is useful for creating snapshots using images o
gt; Signed-off-by: Alberto Garcia <be...@igalia.com>
> ---
> blockdev.c | 163
> ---
> qapi-schema.json | 2 +
> qapi/block-core.json | 26
> qmp-commands.hx | 29 +++++
> 4 files changed,
On 10.09.2015 03:12, Wen Congyang wrote:
> On 09/09/2015 08:59 PM, Max Reitz wrote:
>> On 09.09.2015 12:01, Wen Congyang wrote:
>>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>>> On 08.09.2015 11:13, Wen Congyang wrote:
>>>>> On 07/21/2015 01:45 AM,
On 10.09.2015 05:22, Wen Congyang wrote:
> On 09/09/2015 08:59 PM, Max Reitz wrote:
>> On 09.09.2015 12:01, Wen Congyang wrote:
>>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>>> On 08.09.2015 11:13, Wen Congyang wrote:
>>>>> On 07/21/2015 01:45 AM,
qemu-iotests/061 | 8
> tests/qemu-iotests/061.out | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
> block.c | 12
> 1 file changed, 12 insertions(+)
Reviewed-by: Max Reitz <mre...@redhat.com>
(and an ACK to "Op blockers are a mess.")
signature.asc
Description: OpenPGP digital signature
+
> 4 files changed, 49 insertions(+), 26 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 29.09.2015 15:51, Kevin Wolf wrote:
> Am 23.09.2015 um 18:36 hat Max Reitz geschrieben:
>> On 17.09.2015 15:48, Kevin Wolf wrote:
>>> Remember all parent nodes and just change the pointers there instead of
>>> swapping the contents of the BlockDriverState.
>>&
On 29.09.2015 11:15, Alberto Garcia wrote:
> On Fri 18 Sep 2015 05:22:42 PM CEST, Max Reitz wrote:
>> If bdrv_is_inserted() is called on the top level BDS, it should make
>> sure all nodes in the BDS tree are actually inserted.
>>
>> Signed-off-by: Max Reitz <mre...@
On 29.09.2015 17:22, Kevin Wolf wrote:
> Am 23.09.2015 um 19:08 hat Max Reitz geschrieben:
>> On 17.09.2015 15:48, Kevin Wolf wrote:
>>> This cleans up the mess we left behind in the mirror code after the
>>> previous patch. Instead of using bdrv_swap(), just change poin
iles changed, 19 insertions(+)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
> blockdev.c | 2 +-
> 2 files changed, 85 insertions(+), 29 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
12 ++---
> block/stream.c| 8 ++--
> block/vmdk.c | 21 +
> block/vvfat.c | 6 +--
> blockdev.c| 4 +-
> include/block/block_int.h | 12 +++--
> qemu-img.c | 4 +-
> 14 files changed, 125 inser
gt; include/block/blockjob.h | 8
> 3 files changed, 17 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
> block/stream.c| 30 +-
> block/vvfat.c | 6 +-
> include/block/block.h | 1 +
> 5 files changed, 33 insertions(+), 55 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
++-
> block/vhdx.c | 36 ++-
> block/vmdk.c | 27 ++--
> block/vpc.c | 34 +
> include/block/block.h | 8 +-
> include/block/block_int.h | 3 +--
> 26
t; block/mirror.c | 206
> ++---
> 1 file changed, 110 insertions(+), 96 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
include/block/block.h | 1 +
> migration/block.c | 2 +-
> 5 files changed, 25 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 28.09.2015 05:29, Jeff Cody wrote:
> During mirror, if the target device does not have support zero
> initialization, a mirror may result in a corrupt image.
>
> For instance, on mirror to a host device with format = raw, whatever
> random data is on the target device will still be there for
On 17.09.2015 15:48, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block/io.c| 2 +-
> include/block/block_int.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
In addition
On 17.09.2015 15:48, Kevin Wolf wrote:
> Some block jobs change the block device graph on completion. This means
> that the device that owns the job and originally was addressed with its
> device name may no longer be what the corresponding BlockBackend points
> to.
>
> Previously, the effects of
>
> ---
> block.c | 155
> +-
> block/qed.c | 7 ---
> block/vvfat.c | 7 ---
> include/block/block_int.h | 1 -
> include/qemu/queue.h | 6 --
> 5 files changed, 1 in
On 17.09.2015 15:48, Kevin Wolf wrote:
> It allows changing the BlockDriverState that a BlockBackend points to.
>
> Signed-off-by: Kevin Wolf
> ---
> block/block-backend.c | 16
> include/block/block_int.h | 2 ++
> 2 files changed, 18 insertions(+)
>
>
On 17.09.2015 15:48, Kevin Wolf wrote:
> After bdrv_swap(), some fields must be moved back to their original BDS
> to compensate for the effects that a swap of the contents of the objects
> has while keeping the old addresses. Other fields must be moved back
> because they should logically be
On 17.09.2015 15:48, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block.c | 3 +++
> include/block/block_int.h | 2 ++
> 2 files changed, 5 insertions(+)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
D
On 17.09.2015 15:48, Kevin Wolf wrote:
> Remember all parent nodes and just change the pointers there instead of
> swapping the contents of the BlockDriverState.
>
> Handling of snapshot=on must be moved further down in bdrv_open()
> because *pbs (which is the bs pointer in the BlockBackend) must
On 17.09.2015 15:48, Kevin Wolf wrote:
> This cleans up the mess we left behind in the mirror code after the
> previous patch. Instead of using bdrv_swap(), just change pointers.
>
> The interface change of the mirror job that callers must consider is
> that after job completion, their local BDS
On 17.09.2015 15:48, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block/vmdk.c | 99
> +++-
> 1 file changed, 51 insertions(+), 48 deletions(-)
Reviewed-by: Max Reitz <mre...@redh
On 17.09.2015 15:48, Kevin Wolf wrote:
> It is unused now.
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block.c | 34 --
> include/block/block.h | 4
> 2 files changed, 38 deletions(-)
Reviewed-by: M
On 17.09.2015 15:48, Kevin Wolf wrote:
> This is the final step in converting all of the BlockDriverState
> pointers that block drivers use to BdrvChild.
>
> After this patch, bs->children contains the full list of child nodes
> that are referenced by a given BDS, and these children are only
>
25 ++-
> block/vhdx.c | 36 ++-
> block/vmdk.c | 27 +++--
> block/vpc.c | 34 ++
> include/block/block.h | 8 +-
> include/block/block_int.h | 3 +--
>
On 17.09.2015 15:48, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block/blkverify.c | 41 +
> 1 file changed, 21 insertions(+), 20 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.
On 22.09.2015 19:14, Max Reitz wrote:
> On 17.09.2015 15:48, Kevin Wolf wrote:
>> Store the BdrvChild for bs->file. At this point, bs->file_child->bs just
>> duplicates the bs->file pointer. Later, it will completely replace it.
>>
>> Signed-off-by: Kevin Wol
> block.c | 12 +---
> include/block/block_int.h | 1 +
> 2 files changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
Although I have a small comment below:
>
> diff --git a/block.c b/block.c
> index 6268e37..2e9e5e2 100644
> --
On 22.09.2015 16:30, Kevin Wolf wrote:
> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>> If there is no BlockDriverState in a BlockBackend or if the tray of the
>> guest device is open, fail all requests (where that is possible) with
>> -ENOMEDIUM.
>>
>> T
On 22.09.2015 16:17, Kevin Wolf wrote:
> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>> This structure will store some of the state of the root BDS if the BDS
>> tree is removed, so that state can be restored once a new BDS tree is
>> inserted.
>
> This is mag
On 22.09.2015 16:42, Kevin Wolf wrote:
> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>> This function associates the given BlockDriverState with the given
>> BlockBackend.
>>
>> Signed-off-by: Max Reitz <mre...@redhat.com>
>> Reviewed-by: Eri
gt; Signed-off-by: Alberto Garcia <be...@igalia.com>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
> Cc: Max Reitz <mre...@redhat.com>
> ---
> blockdev.c | 163
> ---
> qapi-schema.json | 2 +
> qapi/blo
On 14.09.2015 18:01, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia
> ---
> tests/qemu-iotests/085 | 102
> ++---
> tests/qemu-iotests/085.out | 34 ++-
> 2 files changed, 128 insertions(+), 8 deletions(-)
Looks
BlockBackend as the guest uses should fail. If the BDS tree is supposed
to be usable even after ejecting it from the guest, a different
BlockBackend must be used.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
block/block-ba
> blockdev-add, since they are not supposed to have a backing image
> before the operation.
>
> Signed-off-by: Alberto Garcia <be...@igalia.com>
> ---
> block.c | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
Extract some of the blockdev option extraction code from blockdev_init()
into its own function. This simplifies blockdev_init() and will allow
reusing the code in a different function added in a follow-up patch.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c
Most of the options which blockdev_init() parses for both the
BlockBackend and the root BDS are valid for just the root BDS as well
(e.g. read-only). This patch allows specifying these options even if not
creating a BlockBackend.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c | 49 +
qapi/block-core.json | 23 +++
qmp-commands.hx | 39 +++
3 files changed, 111 insertions(+)
diff
find it useful to be able to therefore change
the read-only status of a block device when changing the medium.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
blockdev.c | 25 -
hmp.c| 2 +-
blk_bs() will not necessarily return a non-NULL value any more (unless
blk_is_available() is true or it can be assumed to otherwise, e.g.
because it is called immediately after a successful blk_new_with_bs() or
blk_new_open()).
Signed-off-by: Max Reitz <mre...@redhat.com>
---
b
This function removes the BlockDriverState associated with the given
BlockBackend from that BB and sets the BDS pointer in the BB to NULL.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
block/block-backend.c
should be sent whenever the status
changed).
Checking @load is now superfluous; it was necessary because it was
possible to change a medium without having explicitly opened the tray
and closed it again (or it might have been possible, at least). This is
no longer possible, though.
Signed-off-by: Max
met, I'll have to send a new
version of that series anyway...
So, since 096 is not a magic number I'm extremely keen on keeping in my
greedy claws:
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c | 30 ++
qapi/block-core.json | 15 +++
qmp-commands.hx | 45 +
3 files changed, 90 insertions(+)
diff --git a/blockdev.c b/bloc
Use separate code paths for the two overloaded functions of the 'change'
HMP command, and invoke the 'blockdev-change-medium' QMP command if used
on a block device (by calling qmp_blockdev_change_medium()).
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@r
Introduce a new QMP command 'blockdev-change-medium' which is intended
to replace the 'change' command for block devices. The existing function
qmp_change_blockdev() is accordingly renamed to
qmp_blockdev_change_medium().
Signed-off-by: Max Reitz <mre...@redhat.com>
---
bloc
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
tests/qemu-iotests/118 | 638 +
tests/qemu-iotests/118.out | 5 +
tests/qemu-iotests/group | 1 +
3 files changed, 644 insertions(+)
And a helper function for that, which directly takes a pointer to the
BDS to be inserted instead of its node-name (which will be used for
implementing 'change' using blockdev-insert-medium).
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c
S options which are not parsed by bdrv_open() (like caching)
cannot be specified for these BB-less BDS trees yet. A future patch will
remove this limitation.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c | 44 +++--
sertions(+), 8 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
Do not use "rudimentary" BDSs for empty drives any longer (for
freshly created drives).
After a follow-up patch, empty drives will generally use a NULL BDS, not
only the freshly created drives.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
Make bdrv_is_inserted(), blk_is_inserted(), and the callback
BlockDriver.bdrv_is_inserted() return a bool.
Suggested-by: Eric Blake <ebl...@redhat.com>
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Alberto Garcia
blk_is_available() returns true iff the BDS is inserted (which means
blk_bs() is not NULL and bdrv_is_inserted() returns true) and if the
tray of the guest device is closed.
blk_is_inserted() is changed to return true only if blk_bs() is not
NULL.
Signed-off-by: Max Reitz <mre...@redhat.
Tests 071 and 081 test giving references in blockdev-add. It is not
necessary to create a BlockBackend here, so omit it.
While at it, fix up some blockdev-add invocations in the vicinity
(s/raw/$IMGFMT/ in 081, drop the format BDS for blkverify's raw child in
071).
Signed-off-by: Max Reitz <
Only call bdrv_add_key() on the BlockDriverState if it is not NULL.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Alberto Garcia <be...@igalia.com>
---
hw/usb/dev-storage.c | 30 --
1 file chan
makes blk_get_aio_context() fall back to the main loop
context if the BDS pointer is NULL and implements
AIOCBInfo::get_aio_context() (blk_aiocb_get_aio_context()) which invokes
blk_get_aio_context().
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com&
If bdrv_is_inserted() is called on the top level BDS, it should make
sure all nodes in the BDS tree are actually inserted.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
block.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 4
calculate the volume usage by
(wr_highest_offset + 512) / volume_size, after this patch they will just
assume the volume to be full slightly earlier than before.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Alberto Garcia <be.
This flag should not be set for the root BDS only, but for any BDS that
is being created while incoming migration is pending, so setting it is
moved from blockdev_init() to bdrv_fill_options().
Signed-off-by: Max Reitz <mre...@redhat.com>
---
block.c| 4
blockdev.c | 4
2
As the comment above bdrv_get_stats() says, BlockAcctStats is something
which belongs to the device instead of each BlockDriverState. This patch
therefore moves it into the BlockBackend.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed
If there is no BDS tree attached to a BlockBackend, functions that can
do so should fall back to the BlockBackendRootState structure (which are
blk_is_read_only() and blk_get_flags(), because the read-only status and
the "open flags" are part of the BBRS).
Signed-off-by: Max
There are several BlockBackend functions which, in theory, cannot fail.
This patch makes them cope with the BlockDriverState pointer being NULL
by making them fall back to some default action like ignoring the value
in setters and returning the default in getters.
Signed-off-by: Max Reitz <
This structure will store some of the state of the root BDS if the BDS
tree is removed, so that state can be restored once a new BDS tree is
inserted.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
block/block-backend.c
The tray of an FDD is open iff there is no medium inserted (there are
only two states for an FDD: "medium inserted" or "no medium inserted").
Signed-off-by: Max Reitz <mre...@redhat.com>
---
hw/block/fdc.c | 20
tests/fdc-test.c | 4 +---
2 fi
These options are only relevant for the user of a whole BDS tree (like a
guest device or a block job) and should thus be moved into the
BlockBackend.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
---
block.c
guest_block_size is a guest device property so it should be moved into
the interface between block layer and guest devices, which is the
BlockBackend.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Alberto Garcia <b
Signed-off-by: Max Reitz <mre...@redhat.com>
---
blockdev.c | 23 +++
qapi/block-core.json | 16
qmp-commands.hx | 35 +++
3 files changed, 74 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 6
This function associates the given BlockDriverState with the given
BlockBackend.
Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Alberto Garcia <be...@igalia.com>
---
block/block-backend.c | 16
in
K so
append_open_options() will never have to handle anything but "file"
and "backing".
3. Fix bdrv_refresh_filename() so that it handles all children and not
just "file" and "backing".
Since we are shooting for 2.6 anyway (I assume ;-)), I think we should
go for option 3. This means that this patch is fine, and I'll see to
fixing bdrv_refresh_filename() (because I'm working on that anyway).
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 23.11.2015 16:59, Kevin Wolf wrote:
> Creating an empty drive while specifying 'format' doesn't make sense.
> The specified format driver would simply be ignored.
>
> Make a set 'format' option an indication that a non-empty drive should
> be created. This makes 'format' consistent with
On 23.11.2015 16:59, Kevin Wolf wrote:
> Just reopening the children (as block.c does now) is enough.
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block/blkdebug.c | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Max Reitz <mre...@redhat.com>
On 23.11.2015 16:59, Kevin Wolf wrote:
> This adds the cache mode options to the QDict, so that they can be
> specified for child nodes (e.g. backing.cache.direct=off).
>
> The cache modes are not removed from the flags at this point; instead,
> options and flags are kept in sync. If the user
ude/block/block.h | 1 +
> include/block/block_int.h | 1 +
> 3 files changed, 24 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 27.11.2015 18:58, Max Reitz wrote:
> On 23.11.2015 16:59, Kevin Wolf wrote:
>> Some drivers have nested options (e.g. blkdebug rule arrays), which
>> don't belong to a child node and shouldn't be removed. Don't remove all
>> options with "." in their name, but
gt; In preparation for the distinction, move json: parse to a separate
> function.
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block.c | 50 --
> 1 file changed, 32 insertions(+), 18 deletions(-)
Reviewed-by: Max
> @@ -724,6 +737,21 @@ static void mirror_start_job(BlockDriverState *bs,
> BlockDriverState *target,
> buf_size = DEFAULT_MIRROR_BUF_SIZE;
> }
>
> +/* We can't support this case as long as the block layer can't handle
> + * multple BlockBa
+++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
qdict_put(options, "driver", qstring_from_str(bs->backing_format));
> }
>
> assert(bs->backing == NULL);
This assert() can be dropped along with the bdrv_new() call (they are
related: originally, the bdrv_open_inherit() call below took
>backing_hd
c | 52
> ---
> include/block/block_int.h | 3 ++-
> 2 files changed, 33 insertions(+), 22 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 01.12.2015 14:16, Kevin Wolf wrote:
> Am 30.11.2015 um 18:22 hat Max Reitz geschrieben:
>> On 30.11.2015 16:36, Kevin Wolf wrote:
>>> Am 09.11.2015 um 23:39 hat Max Reitz geschrieben:
>>>> The NBD code uses the BDS close notifier to determine when a medium
On 01.12.2015 15:44, Alberto Garcia wrote:
> On Tue 10 Nov 2015 04:44:22 AM CET, Max Reitz wrote:
>> @@ -1398,32 +1397,21 @@ static int bdrv_open_inherit(BlockDriverState **pbs,
>> const char *filename,
>> bool options_non_empty = options ? qdict_
On 01.12.2015 15:35, Alberto Garcia wrote:
> On Tue 10 Nov 2015 04:44:18 AM CET, Max Reitz wrote:
>> -int bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, Error **errp)
>> +static BlockDriverState *bdrv_append_temp_snapshot(Block
On 01.12.2015 17:01, Kevin Wolf wrote:
> Am 10.11.2015 um 04:27 hat Max Reitz geschrieben:
>> Move bdrv_drain_all(), bdrv_commit_all(), bdrv_flush_all() and
>> bdrv_invalidate_cache_all() to BB.
>>
>> The only operation left is bdrv_close_all(), which cannot be moved to
y existing child nodes.
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> ---
> block.c | 20
> include/block/block_int.h | 1 +
> 2 files changed, 17 insertions(+), 4 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
evin Wolf <kw...@redhat.com>
> ---
> block.c| 100
> ++---
> blockdev.c | 52 ++--
> 2 files changed, 111 insertions(+), 41 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
sts/qemu-iotests/iotests.py | 2 +-
> 3 files changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
On 07.12.2015 19:11, Denis V. Lunev wrote:
> On 12/07/2015 08:54 PM, Eric Blake wrote:
>> On 12/07/2015 10:51 AM, Eric Blake wrote:
>>> [adding qemu-devel - ALL patches should go to qemu-devel, even if they
>>> are also going to a sub-list like qemu-block]
>>>
>>> On 12/07/2015 10:07 AM, Roman
501 - 600 of 9029 matches
Mail list logo