Re: [Qemu-block] [Qemu-devel] [PULL 00/17] Block patches for 2.3.0-rc0

On 16 March 2015 at 16:57, Kevin Wolf kw...@redhat.com wrote: The following changes since commit dcf848c478dd8765bd4f746fc4e80eaad44cf87d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150316' into staging (2015-03-16 13:56:10 +) are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL 0/3] Block patches for 2.3.0-rc1

On 19 March 2015 at 15:16, Kevin Wolf kw...@redhat.com wrote: The following changes since commit cd232acfa0d70002fed89e9293f04afda577a513: Update version for v2.3.0-rc0 release (2015-03-17 18:58:33 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git

Re: [Qemu-block] [Qemu-devel] [PULL 0/7] Block patches

On 30 April 2015 at 20:10, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 06feaacfb4cfef10cc0c93d97df7bfc8a71dbc7e: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-04-30 12:04:11 +0100) are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PULL 00/76] Block patches

On 28 April 2015 at 15:59, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 84cbd63f87c1d246f51ec8eee5367a5588f367fd: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-04-28 12:22:20 +0100) are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

On 20 May 2015 at 09:43, Kevin Wolf kw...@redhat.com wrote: Am 20.05.2015 um 10:06 hat Peter Maydell geschrieben: That handles migration, which is good. But I still think that storing the same information in two places in the device state (phase field and the register fields) is error-prone

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

On 19 May 2015 at 21:52, John Snow js...@redhat.com wrote: Hmm, I think this is not purely derived state because the flags are not necessarily sufficient for regenerating that state. Yeah, if there's genuinely an underlying state machine that's not completely visible in registers you need to

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

On 19 May 2015 at 16:35, Kevin Wolf kw...@redhat.com wrote: The floppy controller spec describes three different controller phases, which are currently not explicitly modelled in our emulation. Instead, each phase is represented by a combination of flags in registers. This patch makes

Re: [Qemu-block] [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data()

On 19 May 2015 at 16:35, Kevin Wolf kw...@redhat.com wrote: Instead of relying on a flag in the MSR to distinguish controller phases, use the explicit phase that we store now. Assertions of the right MSR flags are added. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/block/fdc.c | 67

Re: [Qemu-block] [PATCH 0/4] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

On 8 June 2015 at 09:18, Christian Borntraeger borntrae...@de.ibm.com wrote: Am 08.06.2015 um 10:02 schrieb Christian Borntraeger: So I would prefer to not have this workaround and doing index c480f64..7627d57 100644 --- a/blockdev.c +++ b/blockdev.c @@ -976,17 +976,6 @@ DriveInfo

[Qemu-block] [PATCH v2 2/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

the behaviour for hotplugged devices, it is not: although hotplugged devices used to call the code to create an implicit virtio device, this had no effect because the code in vl.c to create devices from the devopts list had already run once and would not be run again. Signed-off-by: Peter Maydell peter.mayd

[Qemu-block] [PATCH 0/4] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

is the oneliner to enable the default for virt once the underlying stuff lets us do this without breaking existing user command lines. Peter Maydell (4): blockdev: Factor out create_implicit_virtio_device blockdev: Don't call create_implicit_virtio_device() when it has no effect blockdev: Defer

[Qemu-block] [PATCH 3/4] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

change the behaviour for PCI because right now no machine specifies a block_default_type of IF_VIRTIO except for the S390 machines. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- blockdev.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git

[Qemu-block] [PATCH 2/4] blockdev: Don't call create_implicit_virtio_device() when it has no effect

. To avoid confusion, don't call the code at all if it isn't going to do anything. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- blockdev.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 9cf6123..177b285 100644

[Qemu-block] [PATCH 4/4] hw/arm/virt: Make block devices default to virtio

Now we have virtio-pci, we can make the virt board's default block device type be IF_VIRTIO. This allows users to use simplified command lines that don't have to explicitly create virtio-pci-blk devices; the -hda c very short options now also work. Signed-off-by: Peter Maydell peter.mayd

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] block: Warn if an if=something drive was also connected manually

On 22 June 2015 at 10:59, Markus Armbruster arm...@redhat.com wrote: What about this instead: 1. When -device creation connects a qdev_prop_drive property to a backend, fail when the backend has a DriveInfo and the DriveInfo has type != IF_NONE. Note: the connection is made in parse_drive().

[Qemu-block] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives

and if they use if=none as suggested by message 1 they'll then get message 2 and can fix their own double-usage...) Changes v1-v2: * drop warn if an if=something drive was also connected manually patch * change implementation of improve error message patch Peter Maydell (3): qdev-properties

[Qemu-block] [PATCH v2 for-2.4 1/3] qdev-properties-system: Change set_pointer's parse callback to use Error

than the generic ones. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/core/qdev-properties-system.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index

[Qemu-block] [PATCH v2 for-2.4 2/3] qdev-properties-system: Improve error message for drive assignment conflict

ide-hd,drive=foo Previously: qemu-system-x86_64: -device ide-hd,drive=foo: Property 'ide-hd.drive' can't take value 'foo', it's in use Now: qemu-system-x86_64: -device ide-hd,drive=foo: Drive 'foo' is already in use by another device Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-block] [PATCH v2 for-2.4 3/3] hw/arm/virt: Make block devices default to virtio

to include 'if=none', as the error message suggests. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f1e85c8..7e643ba 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -966,6 +966,8

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

On 20 June 2015 at 16:00, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I do definitely want to enable short-options for virt for 2.4... Enable short options = change virt's default block interface type from IF_IDE to IF_VIRTIO, I presume. For 2.4

Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] qdev-properties-system: Improve error message for drive assignment conflict

On 22 June 2015 at 10:12, Markus Armbruster arm...@redhat.com wrote: I think we should just bite the bullet and extend Error to support additional helpful information for humans. ...I thought all of the string was already just helpful information for humans? I certainly hope we aren't expecting

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

On 22 June 2015 at 10:39, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: Instead of having set_pointer() call a parse callback which returns an error number that we then convert to an Error string with error_set_from_qdev_prop_error(), make the parse

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent find_image_format() from executing. Otherwise find_image_format() would just quit QEMU with an error. The

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.4 3/3] hw/arm/virt: Make block devices default to virtio

On 25 June 2015 at 08:40, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: Now we have virtio-pci, we can make the virt board's default block device type be IF_VIRTIO. This allows users to use simplified command lines that don't have to explicitly

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] block: Warn if an if=something drive was also connected manually

On 22 June 2015 at 10:59, Markus Armbruster arm...@redhat.com wrote: What about this instead: 1. When -device creation connects a qdev_prop_drive property to a backend, fail when the backend has a DriveInfo and the DriveInfo has type != IF_NONE. Note: the connection is made in parse_drive().

Re: [Qemu-block] [Qemu-devel] [PULL 00/25] Block layer core and image format patches

On 12 June 2015 at 17:23, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 4cb618abc1818586c08011ff0a84a015787b1672: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150612' into staging (2015-06-12 12:49:40 +0100) are available in the git repository at:

[Qemu-block] [PATCH 4/4] hw/arm/virt: Make block devices default to virtio

getting a default cdrom device -- this is needed because the virtio-blk device will fail if it is connected to a block backend with no media, which is what the default cdrom device typically is. Providing a cdrom with media via -cdrom will still work. Signed-off-by: Peter Maydell peter.mayd

[Qemu-block] [PATCH 1/4] block: Warn if an if=something drive was also connected manually

a spurious warning. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- block/block-backend.c | 4 blockdev.c| 39 +++ include/sysemu/blockdev.h | 2 ++ 3 files changed, 45 insertions(+) diff --git a/block/block-backend.c b/block

[Qemu-block] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

than the generic ones. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/core/qdev-properties-system.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index

[Qemu-block] [PATCH 0/4] block: Improve warnings for doubly-connected drives

patch #4 as the motivation/context but in fact it doesn't depend on the first 3, so if you want to take the first 3 via block and have me put the 4th one in target-arm that's OK. thanks -- PMM Peter Maydell (4): block: Warn if an if=something drive was also connected manually qdev-properties

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/8] fdc: Introduce fdctrl-phase

On 29 May 2015 at 11:34, Dr. David Alan Gilbert dgilb...@redhat.com wrote: It's the destination I'm worried about here, not the source; lets say you have two devices, a b. 'a' gets serialised, but then 'b' finds it has to wait, so we return to running the source and sending pages across.

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

On 29 June 2015 at 17:54, Programmingkid programmingk...@gmail.com wrote: @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = { .bdrv_ioctl = hdev_ioctl, .bdrv_aio_ioctl = hdev_aio_ioctl, #endif + +#ifdef __APPLE__ +.bdrv_is_inserted =

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

On 29 June 2015 at 19:04, Programmingkid programmingk...@gmail.com wrote: On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote: On 29 June 2015 at 17:54, Programmingkid programmingk...@gmail.com wrote: @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = { .bdrv_ioctl

Re: [Qemu-block] [Qemu-devel] [PULL 00/22] Block layer core and image format patches

On 22 May 2015 at 16:26, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 8b6db32a4ec47d1171ccfa21d557096b99f4eef0: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2015-05-22 13:25:40 +0100) are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl-phase

On 21 May 2015 at 10:42, Kevin Wolf kw...@redhat.com wrote: Am 20.05.2015 um 14:07 hat Peter Maydell geschrieben: On 20 May 2015 at 12:55, John Snow js...@redhat.com wrote: So even if /currently/ we can reconstitute it from the register values, we may eventually be unable to. post_load

Re: [Qemu-block] [PULL for-2.4 0/2] block patches for 2.4-rc3

On 28 July 2015 at 05:23, Jeff Cody jc...@redhat.com wrote: The following changes since commit f8787f8723eaca1be99e3b1873e54de163fffa93: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150727' into staging (2015-07-27 19:37:09 +0100) are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PATCH] ahci: fix ICC mask definition

On 30 July 2015 at 19:41, John Snow js...@redhat.com wrote: Peter: I assume you still want this for 2.4 to fix the clang warnings, yes? Yeah, it's safe enough. (I don't actually require these clang warnings all fixed for 2.4; but it's a nice-to-have.) thanks -- PMM

Re: [Qemu-block] [Qemu-devel] [PATCH] block: don't register quorum driver if SHA256 support is unavailable

On 4 August 2015 at 15:48, Sascha Silbe si...@linux.vnet.ibm.com wrote: Commit 488981a4 [block: convert quorum blockdrv to use crypto APIs] broke qemu-iotest 041 on hosts with GnuTLS 2.10.0. It converted a compile-time check to a run-time check at device open time. The result is that we now

Re: [Qemu-block] [PULL 0/2] Block job patches

On 14 August 2015 at 14:57, Jeff Cody jc...@redhat.com wrote: The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into staging (2015-08-13 17:47:44 +0100) are available in the git repository at:

Re: [Qemu-block] [PULL 0/2] Block job patches

On 14 August 2015 at 15:55, Jeff Cody jc...@redhat.com wrote: On Fri, Aug 14, 2015 at 03:51:03PM +0100, Peter Maydell wrote: Your pull req tag has not only these two commits in it, but also a merge commit (Merge branch 'block-next' into HEAD). Why is that? I was trying to keep a commit id

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] replace qemu_fls() with pow2ceil()/pow2floor()

Ping? (Patches 1 and 2 have been reviewed; thanks.) -- PMM On 24 July 2015 at 13:33, Peter Maydell peter.mayd...@linaro.org wrote: We have a qemu_fls() function which is just a silly wrapper around clz32() and which is used in only a handful of places in the codebase. It turns out that all

[Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor()

; that may be a bit ambitious, so we'll see...) Peter Maydell (5): hw/pci: Use pow2ceil() rather than hand-calculation hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation hw/block/nvme.c: Use pow2ceil() rather than hand-calculation exec.c: Use pow2floor() rather than hand

[Qemu-block] [PATCH 1/5] hw/pci: Use pow2ceil() rather than hand-calculation

know the size can't be 0. In the case where the size value had bit 31 set, the old code would invoke undefined behaviour; the new code will give a result of 0. Presumably that could never happen either.) Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pci/msix.c | 4 +--- hw/pci/pci.c

[Qemu-block] [PATCH 4/5] exec.c: Use pow2floor() rather than hand-calculation

Use pow2floor() to round down to the nearest power of 2, rather than an inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- exec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 7d60e15..4710e2d 100644 --- a/exec.c +++ b

[Qemu-block] [PATCH 2/5] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation

Use the utility function pow2ceil() for rounding up to the next largest power of 2, rather than inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/virtio/virtio-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw

Re: [Qemu-block] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor()

On 24 July 2015 at 06:10, Paolo Bonzini pbonz...@redhat.com wrote: On 23/07/2015 22:10, Peter Maydell wrote: The series looks good, but I'd prefer (especially for patch 4 which is in a fast path) if pow2ceil and pow2floor were made inline. Yeah, I was wondering if I was going to be asked

[Qemu-block] [PATCH v2 2/6] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation

Use the utility function pow2ceil() for rounding up to the next largest power of 2, rather than inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/virtio/virtio-pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw

[Qemu-block] [PATCH v2 5/6] Remove unused qemu_fls function

Nothing uses qemu_fls() any more, so delete it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu-common.h | 1 - util/cutils.c | 5 - 2 files changed, 6 deletions(-) diff --git a/include/qemu-common.h b/include/qemu-common.h index 237d654..bc6f8f8 100644

[Qemu-block] [PATCH v2 4/6] exec.c: Use pow2floor() rather than hand-calculation

Use pow2floor() to round down to the nearest power of 2, rather than an inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- exec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 7d60e15..4710e2d 100644 --- a/exec.c +++ b

[Qemu-block] [PATCH v2 3/6] hw/block/nvme.c: Use pow2ceil() rather than hand-calculation

Use pow2ceil() to round up to the next power of 2, rather than an inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 40d4880..5da41b2 100644

[Qemu-block] [PATCH 3/5] hw/block/nvme.c: Use pow2ceil() rather than hand-calculation

Use pow2ceil() to round up to the next power of 2, rather than an inline calculation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 40d4880..5da41b2 100644

[Qemu-block] [PATCH v2 0/6] replace qemu_fls() with pow2ceil()/pow2floor()

the pow2ceil and pow2floor functions to inline. Peter Maydell (6): hw/pci: Use pow2ceil() rather than hand-calculation hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation hw/block/nvme.c: Use pow2ceil() rather than hand-calculation exec.c: Use pow2floor() rather than hand

Re: [Qemu-block] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On 17 July 2015 at 20:24, Programmingkid programmingk...@gmail.com wrote: Is pstrcpy() ansi c? I'm having trouble finding documentation for it. No, it's something we provide in util/cutils.c. We recommend it in HACKING, but we don't actually document the semantics, which is a bit unhelpful. I've

Re: [Qemu-block] [Qemu-devel] [PATCH] ide: coverity touchups

On 13 July 2015 at 20:26, John Snow js...@redhat.com wrote: Just a handful of casts to quiet coverity up. s-ports should never exceed 32, but coverity doesn't know that. ncq_tfs-sector_count should also never exceed 64K. Personally I tend to mark that kind of thing as a false positive in the

Re: [Qemu-block] [Qemu-devel] [PULL 0/1] Block layer patches for 2.4.0-rc2

On 20 July 2015 at 15:54, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 71358470eec668f5dc53def25e585ce250cea9bf: Merge remote-tracking branch 'remotes/amit-virtio-rng/tags/vrng-2.4' into staging (2015-07-17 15:22:45 +0100) are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PULL 00/11] Block layer patches for 2.4.0-rc1

On 14 July 2015 at 16:39, Kevin Wolf kw...@redhat.com wrote: The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-07-13 13:35:51 +0100) are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PULL 00/37] Block layer patches

On 23 October 2015 at 18:00, Kevin Wolf wrote: > The following changes since commit 1e700f4c6cddaf29ce1d205f0f8e8b9255481930: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-10-23-tag' > into staging (2015-10-23 15:55:50 +0100) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL v2 00/40] Block layer patches

On 10 November 2015 at 14:09, Kevin Wolf wrote: > The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' > into staging (2015-11-10 09:39:24 +) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL v3 00/41] Block layer patches

On 11 November 2015 at 16:08, Kevin Wolf wrote: > The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' into > staging (2015-11-11 09:34:18 +) > > are available in the git

Re: [Qemu-block] [PULL 0/1] Block patches

On 11 November 2015 at 18:00, Jeff Cody wrote: > The following changes since commit 3c07587d49458341510360557c849e93e9afaf59: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-next-2015' into > staging (2015-11-11 09:34:18 +) > > are available in the git

Re: [Qemu-block] [PULL v3 00/43] Block layer patches (Stefan's tree)

On 12 November 2015 at 15:37, Kevin Wolf wrote: > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2015-11-12 14:15:32 +) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL 00/37] Block layer patches

On 5 November 2015 at 18:17, Kevin Wolf wrote: > The following changes since commit 8835b9df3bddf332c883c861d6a1defc12c4ebe9: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-11-04-tag' > into staging (2015-11-05 10:52:35 +) > > are available in the git

[Qemu-block] [PATCH] hw/ide/ahci.c: Fix shift left into sign bit

omoted to signed int before shifting.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> --- clang's undefined sanitizer produces a lot of copies of this warning during 'make check'... hw/ide/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/ahci.c b/hw/id

Re: [Qemu-block] [Qemu-devel] [PULL 00/29] Block layer patches

On 16 October 2015 at 16:05, Kevin Wolf wrote: > The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' > into staging (2015-10-13 10:42:06 +0100) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PATCH] hw/ide/ahci.c: Fix shift left into sign bit

On 16 October 2015 at 21:43, John Snow <js...@redhat.com> wrote: > > > On 10/16/2015 01:48 PM, Peter Maydell wrote: >> Avoid undefined behaviour from shifting left into the sign bit: >> >> hw/ide/ahci.c:551:36: runtime error: left shift of 255 by 24 places canno

Re: [Qemu-block] [Qemu-devel] [PULL 0/4] Block patches for 2.5.0-rc1

On 18 November 2015 at 16:08, Kevin Wolf wrote: > The following changes since commit ab9b872ab3147faf3c04e91d525815b9139dd996: > > Merge remote-tracking branch > 'remotes/mdroth/tags/qga-pull-2015-11-13-v2-tag' into staging (2015-11-18 > 12:47:29 +) > > are available in

[Qemu-block] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+ doesn't have sparse file support, and Windows probably doesn't either. Worse, if the test fails an

Re: [Qemu-block] [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

On 31 August 2015 at 19:54, John Snow wrote: > Oh, taking a look at it, it needs to writethat MBR data to the file > before it opens it. We don't have an existing qemu-io dependency here to > use. > > I could add it, but the line between iotest and qtest starts to get > pretty

[Qemu-block] please fix block device FIXMEs in 2.4's changelog

There are two lines in 2.4's changelog (http://wiki.qemu.org/ChangeLog/2.4) in the "Block devices in system emulation" section which read: * FIXME: Throttle groups and * FIXME: incremental backup? Could somebody fill these in with real content before we all forget what was and wasn't in 2.4?

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] replace qemu_fls() with pow2ceil()/pow2floor()

Ping? Paolo, do you want to take these, should I just apply them to master, or what? thanks -- PMM On 24 July 2015 at 13:33, Peter Maydell <peter.mayd...@linaro.org> wrote: > We have a qemu_fls() function which is just a silly wrapper > around clz32() and which is used in on

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] replace qemu_fls() with pow2ceil()/pow2floor()

On 7 September 2015 at 13:34, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 07/09/2015 13:04, Peter Maydell wrote: >> Ping? >> >> Paolo, do you want to take these, should I just apply them >> to master, or what? > > Sorry, I thought you wer

Re: [Qemu-block] [Qemu-devel] [PULL 00/16] Block patches

On 4 September 2015 at 21:10, Kevin Wolf wrote: > The following changes since commit b597aa037dbd98014c8dec3d69a5e2240f432533: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-09-04' > into staging (2015-09-04 17:37:50 +0100) > > are available in the

Re: [Qemu-block] [Qemu-devel] [PULL v2 00/23] Block layer patches

On 14 September 2015 at 16:25, Kevin Wolf wrote: > The following changes since commit 2b750d9d261bda7f75b39dfc1e1e5f22502929d5: > > Merge remote-tracking branch 'remotes/aurel/tags/pull-sh4-next-20150913' > into staging (2015-09-14 10:46:38 +0100) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL 00/23] Block layer patches

On 11 September 2015 at 20:40, Kevin Wolf wrote: > The following changes since commit 30c38c90bd3f1bb105ebc069ac1821067c980b7c: > > scripts/qemu-gdb: Add brief comment describing usage (2015-09-11 17:14:50 > +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL 0/1] Block job patches

On 1 October 2015 at 20:05, Jeff Cody wrote: > The following changes since commit fa500928ad9da6dd570918e3dfca13c029af07a8: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20150930' > into staging (2015-10-01 10:49:38 +0100) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PATCH] block/raw-posix: Open file descriptor O_RDWR to work around glibc posix_fallocate emulation issue.

On 29 September 2015 at 16:54, Richard W.M. Jones wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1265196 > > The following command fails on an NFS mountpoint: > > $ qemu-img create -f qcow2 -o preallocation=falloc disk.img 262144 > Formatting 'disk.img', fmt=qcow2

Re: [Qemu-block] [PULL 0/7] Block patches

On 25 September 2015 at 08:50, Jeff Cody wrote: > The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24 > 01:32:11 +0100) > > are available in

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.5] virtio-blk/dataplane: parentize compat iothread

On 7 December 2015 at 16:27, Cornelia Huck wrote: > On Mon, 7 Dec 2015 16:50:01 +0100 > Cornelia Huck wrote: > >> For x-data-plane=true, we create an iothread automatically for >> compatibility. Commit d21e877 ("iothread: include id in thread

Re: [Qemu-block] [PATCH] virtio-blk: Drop x-data-plane option

On 7 December 2015 at 15:19, Paolo Bonzini wrote: > > > On 07/12/2015 14:02, Fam Zheng wrote: >> On Mon, 12/07 12:29, Cornelia Huck wrote: >>> On Mon, 7 Dec 2015 18:59:27 +0800 >>> Fam Zheng wrote: >>> The official way of enabling dataplane is through

Re: [Qemu-block] [PULL 0/1] Block patches for 2.5

On 2 December 2015 at 14:27, Jeff Cody wrote: > The following changes since commit 680617ed43a2811318ac2df63e686f6b7bc22f55: > > Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20151130' into > staging (2015-11-30 15:35:20 +) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL 0/2] Block patches for 2.5.0-rc3

On 2 December 2015 at 16:20, Kevin Wolf wrote: > The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into > staging (2015-12-02 10:16:53 +) > > are available in the git

Re: [Qemu-block] [PULL v2 0/1] Block patches for 2.5

On 2 December 2015 at 15:47, Jeff Cody wrote: > The following changes since commit 9d7b969ea6d9663a94760c6c131481b366f4d38a: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20151201' into > staging (2015-12-02 10:16:53 +) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.5?] qemu-iotests: Reduce racy output in 028

On 11 December 2015 at 03:27, Eric Blake wrote: > On my machine, './check -qcow2 028' was failing about 80% of the time, > due to a race in how many times the repeated attempts to run 'info > block-jobs' could occur before the job was done, showing up as a > failure of fewer

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

On 11 December 2015 at 15:30, Eric Blake wrote: > On 12/11/2015 08:23 AM, Max Reitz wrote: >> >> SQMP >> -blockdev-remove-medium >> +x-blockdev-remove-medium >> -- > > Formatting nit, but not worth holding this up (as it is really our last > chance to get

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 7 January 2016 at 19:37, Max Reitz wrote: > Compare floppy disks, for which we now have a "virtual" tray status: > Whenever a medium is inserted, the "tray" is considered closed. > Otherwise, it is open. This works pretty much like a physical tray would > work; whenever the

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 10 November 2015 at 14:09, Kevin Wolf wrote: > From: Max Reitz > > Implement 'change' on block devices by calling blockdev-open-tray, > blockdev-remove-medium, blockdev-insert-medium (a variation of that > which does not need a node-name) and

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 7 January 2016 at 20:14, Max Reitz <mre...@redhat.com> wrote: > On 07.01.2016 20:56, Peter Maydell wrote: >> It looks like sd.c is the only one which implements a change_media_cb >> but no is_tray_open, but it would be nice if we could implement this >> in the d

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 7 January 2016 at 21:57, Max Reitz <mre...@redhat.com> wrote: > On 07.01.2016 22:42, Peter Maydell wrote: >> Well, previously sd.c didn't need to have any state for this >> to all work right (or indeed care about implementing a fake >> tray status for a device th

Re: [Qemu-block] [Qemu-devel] [PULL 00/21] Block layer patches

On 7 January 2016 at 22:57, Max Reitz wrote: > Kevin is on PTO this week, so I am filling in for him. > > > The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e: > > petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07 > 14:57:26

Re: [Qemu-block] [Qemu-devel] [PULL v2 10/40] blockdev: Implement change with basic operations

On 7 January 2016 at 22:43, Max Reitz wrote: > I hope that the above explanation helped you understand why it bled into > tray-less devices, from a technical perspective. Yes, thanks, that was definitely a helpful explanation for why the design is the way it is. I'm still not

Re: [Qemu-block] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

On 20 December 2015 at 20:51, Peter Crosthwaite <crosthwaitepe...@gmail.com> wrote: > On Sun, Dec 20, 2015 at 9:10 AM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> On 19 December 2015 at 21:38, Peter Crosthwaite >> <crosthwaitepe...@gmail.com> wrote: &g

Re: [Qemu-block] [Qemu-devel] [PULL 00/48] Block patches

On 18 December 2015 at 15:07, Kevin Wolf wrote: > The following changes since commit 67a708406221f476c0f8fa60c192c186150c5185: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-io-channel-base-2015-12-18-1' into staging > (2015-12-18 12:42:10 +) > > are

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] qapi: Use Python 2.6 "except E as ..." syntax

On 17 December 2015 at 10:06, Markus Armbruster wrote: > PEP 8 calls for it, because it's forward compatibile with Python 3. Typo nit: "compatible". thanks -- PMM

Re: [Qemu-block] [Qemu-devel] [PULL 0/6] Block patches for 2.5.0-rc2

On 25 November 2015 at 14:10, Kevin Wolf wrote: > The following changes since commit 1aae36df4b8ed884c6ef6995e70c67fad79b49df: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-ivshmem-2015-11-25' > into staging (2015-11-25 11:38:03 +) > > are available in the

Re: [Qemu-block] [PATCH] tests: fix cdrom_pio_impl in ide-test

On 20 November 2015 at 14:29, Peter Lieven wrote: > The check for the cleared BSY flag has to be performed > before each data transfer and not just before the > first one. > > Commit 5f81724d revealed this glitch as the BSY flag > was not set in ATAPI PIO transfers before. > > While

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: fix cdrom_pio_impl in ide-test

On 20 November 2015 at 17:12, John Snow wrote: > This looks correct. This will definitely fix the race in the test, since > it was due to a race where we were reading the data when DRQ was not set. > > Where I still remain a little confused is the precise flow control that >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

On 12 January 2016 at 15:13, Denis V. Lunev wrote: > The idea of this patch was trivial. First of all, I would like to keep > this image internally snapshoted. That is why the ultimate goal > was to switch from raw to qcow2 to keep changes inside the > image. > > Though in this

Re: [Qemu-block] [Qemu-devel] [PULL 00/31] Block layer patches

On 8 June 2016 at 10:16, Kevin Wolf wrote: > The following changes since commit 6ed5546fa7bf12c5b87ef76bafb86e1d77ed6e85: > > Merge remote-tracking branch > 'remotes/mjt/tags/pull-trivial-patches-2016-06-07' into staging (2016-06-07 > 16:34:45 +0100) > > are available in the

Re: [Qemu-block] [Qemu-devel] [PATCH] scsi-disk: fix reads from scsi-disk devices

On 3 June 2016 at 13:42, Eric Blake wrote: > On 06/02/2016 11:17 PM, Mark Cave-Ayland wrote: >> Commit fcaafb1001b9c42817714dd3b2aadcfdb997b53d accidentally broke reads from >> scsi-disk devices when being updated from its original form to use the new >> byte-based block

Re: [Qemu-block] [Qemu-devel] [PATCH] m25p80: provide a realize to support late inits.

On 15 June 2016 at 15:00, Cédric Le Goater wrote: > We also need to realize() the SSISlave part of the object. This is why > the previous realize() ops is stored in M25P80Class and called in the > object realize() ops. > > This is fully compatible with the existing users of m25p80

  1   2   3   4   5   6   7   8   9   10   >