Re: [Qemu-block] [PULL 0/1] Block patches

On 13 June 2018 at 15:53, Jeff Cody wrote: > The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 > 15:34:34 +0100) > > are available in the git repository at: >

Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] More conversions away from old_mmio

On 11 June 2018 at 15:06, Peter Maydell wrote: > On 1 June 2018 at 15:12, Peter Maydell wrote: >> Peter Maydell (6): >> hw/sh/sh7750: Convert away from old_mmio >> hw/m68k/mcf5206: Convert away from old_mmio >> hw/block/pflash_cfi02: Convert away from old_mmio &g

Re: [Qemu-block] [Qemu-devel] [PATCH] m25p80: add support for two bytes WRSR for Macronix chips

On 11 June 2018 at 23:03, Alistair Francis wrote: > On Mon, Jun 11, 2018 at 10:18 AM, Cédric Le Goater wrote: >> On 06/11/2018 07:15 PM, Cédric Le Goater wrote: >>> On Macronix chips, two bytes can written to the WRSR. First byte will >>> configure the status register and the second the

Re: [Qemu-block] [Qemu-devel] [PULL 00/26] Block layer patches

On 15 June 2018 at 15:20, Kevin Wolf wrote: > The following changes since commit 91fe7a376ad46e3cc5e82d418aad22173c948a3c: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2018-06-15 11:41:44 +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [Qemu-devel] [PULL 00/35] Block layer patches

On 18 June 2018 at 17:44, Kevin Wolf wrote: > The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 > 18:13:35 +0100) > > are available in the git repository at:

Re: [Qemu-block] [Qemu-devel] [PULL 00/17] Block layer patches

On 30 May 2018 at 16:56, Kevin Wolf wrote: > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into > staging (2018-05-29 13:01:11 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for

[Qemu-block] [PATCH 1/6] hw/sh/sh7750: Convert away from old_mmio

Convert the sh7750 device away from using the old_mmio field of MemoryRegionOps. This device is used by the sh4 r2d board. Signed-off-by: Peter Maydell --- hw/sh4/sh7750.c | 44 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/hw/sh4

[Qemu-block] [PATCH 3/6] hw/block/pflash_cfi02: Convert away from old_mmio

Convert the pflash_cfi02 device away from using the old_mmio field of MemoryRegionOps. Signed-off-by: Peter Maydell --- hw/block/pflash_cfi02.c | 97 - 1 file changed, 18 insertions(+), 79 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block

[Qemu-block] [PATCH 2/6] hw/m68k/mcf5206: Convert away from old_mmio

Convert the mcf5206 device away from using the old_mmio field of MemoryRegionOps. This device is used by the an5206 board. Signed-off-by: Peter Maydell --- hw/m68k/mcf5206.c | 48 +++ 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/hw

[Qemu-block] [PATCH 5/6] hw/input/pckbd: Convert away from old_mmio

Convert the pckbd device away from using the old_mmio field of MemoryRegionOps. This change only affects the memory-mapped variant of the i8042, which is used by the Unicore32 'puv3' board and the MIPS Jazz boards 'magnum' and 'pica61'. Signed-off-by: Peter Maydell --- hw/input/pckbd.c | 14

[Qemu-block] [PATCH 4/6] hw/watchdog/wdt_i6300esb: Convert away from old_mmio

Convert the wdt_i6300esb device away from using the old_mmio field of MemoryRegionOps. Signed-off-by: Peter Maydell --- hw/watchdog/wdt_i6300esb.c | 48 -- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw

[Qemu-block] [PATCH 0/6] More conversions away from old_mmio

Half a dozen miscellaneous conversions away from old_mmio usage in the MemoryRegionOps struct. This leaves us with only 10 remaining in the tree. NB: mips parts tested only via 'make check'. thanks -- PMM Peter Maydell (6): hw/sh/sh7750: Convert away from old_mmio hw/m68k/mcf5206: Convert

[Qemu-block] [PATCH 6/6] hw/char/parallel: Convert away from old_mmio

Convert the parallel device away from using the old_mmio field of MemoryRegionOps. This change only affects the memory-mapped variant, which is used by the MIPS Jazz boards 'magnum' and 'pica61'. Signed-off-by: Peter Maydell --- hw/char/parallel.c | 50

Re: [Qemu-block] [PULL 00/11] Block patches

On 4 June 2018 at 12:20, Stefan Hajnoczi wrote: > The following changes since commit c25e8bba1f546ea72744ccfab77f8a9e8a323be8: > > Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180601' > into staging (2018-06-01 13:11:30 +0100) > > are available in the Git repository at: > >

Re: [Qemu-block] [PULL 0/2] Block patches

On 5 June 2018 at 15:19, Jeff Cody wrote: > The following changes since commit 41feb5b955f0d7c9d071b2c5adbc404ae2895c7a: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging > (2018-06-05 10:38:33 +0100) > > are available in the git repository

Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: Fix 219's timing

On 6 June 2018 at 19:37, Max Reitz wrote: > 219 has two issues that may lead to sporadic failure, both of which are > the result of issuing query-jobs too early after a job has been > modified. This can then lead to different results based on whether the > modification has taken effect already

Re: [Qemu-block] [Qemu-devel] [PULL 20/37] qcow2: Give the refcount cache the minimum possible size by default

On 28 May 2018 at 09:58, Alberto Garcia wrote: > On Mon 28 May 2018 10:38:55 AM CEST, Kevin Wolf wrote: >>> > +if (!refcount_cache_size_set) { >>> > +*refcount_cache_size = MIN_REFCOUNT_CACHE_SIZE * >>> > s->cluster_size; >>> >>> ...but in the else clause

Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On 25 June 2018 at 11:31, Peter Krempa wrote: > On Mon, Jun 25, 2018 at 11:01:46 +0100, Peter Maydell wrote: >> On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: >> > - SD card - requires -drive with if=sd, no -device support AFAICT >> >> Hmm? You can use -d

Re: [Qemu-block] [Qemu-devel] [PATCH] nbd/server: Silence gcc false positive

Hi Fam -- looks like patchew has got confused somehow... On 22 June 2018 at 17:31, wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180622125814.345274-1-ebl...@redhat.com > Subject: [Qemu-devel]

Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On 22 June 2018 at 16:40, Daniel P. Berrangé wrote: > - SD card - requires -drive with if=sd, no -device support AFAICT Hmm? You can use -device if you want: -drive if=none,id=mydrive,... -device sd-card,...,drive=mydrive (the sd-card device then plugs into the sd controller device via the

Re: [Qemu-block] [PATCH] nbd/server: Silence gcc false positive

On 22 June 2018 at 13:59, Peter Maydell wrote: > On 22 June 2018 at 13:58, Eric Blake wrote: >> The code has a while() loop that always initialized 'end', and >> the loop always executes at least once (as evidenced by the assert() >> just prior to the loop). But some

Re: [Qemu-block] [PULL 00/29] Block layer patches

On 29 June 2018 at 15:09, Kevin Wolf wrote: > The following changes since commit 609ef9f451759151d0bfe7c3843410ab94d68f18: > > Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' > into staging (2018-06-28 17:53:31 +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL 0/3] Block patches

On 3 July 2018 at 04:46, Jeff Cody wrote: > The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into > staging (2018-07-02 17:57:46 +0100) > > are available in the Git repository at: > >

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On 3 July 2018 at 12:32, Kevin Wolf wrote: > Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >> Just posted latest version here: >> >> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >> >> It will be in the next release on ~ Aug 1st > > It would have been a lot

Re: [Qemu-block] [Qemu-devel] [PULL 00/35] Block layer patches

On 26 October 2017 at 14:17, Kevin Wolf wrote: > The following changes since commit ae49fbbcd8e4e9d8bf7131add34773f579e1aff7: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171025' into > staging (2017-10-25 16:38:57 +0100) > > are available in the git

Re: [Qemu-block] [PULL v2 00/13] Block layer patches

On 21 December 2017 at 15:26, Kevin Wolf wrote: > The following changes since commit 4da5c51cac8363f86ec92dc99c38f9382d617647: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-12-20' > into staging (2017-12-20 20:38:36 +) > > are available in the git

Re: [Qemu-block] [PULL v3 00/35] Block layer patches

On 22 December 2017 at 15:18, Kevin Wolf wrote: > The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22 > 00:11:36 +) > > are available in

Re: [Qemu-block] [Qemu-devel] [PULL 00/29] Block layer patches

On 23 January 2018 at 14:01, Kevin Wolf wrote: > The following changes since commit ee86981bda9ecd40c8daf81b7307b1d2aff68174: > > migration: Revert postcopy-blocktime commit set (2018-01-23 10:08:05 +) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL 0/2] Block patches

On 1 February 2018 at 04:06, Jeff Cody wrote: > The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into > staging (2018-01-31 15:50:29 +) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [PULL 00/55] Block layer patches

On 13 February 2018 at 17:04, Kevin Wolf wrote: > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL v2 0/3] Block patches

On 15 February 2018 at 09:42, Stefan Hajnoczi wrote: > The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-02-13 18:24:08 +) > > are available in the Git

Re: [Qemu-block] [Qemu-devel] STOP Re: [PULL 4/4] qmp: add nbd-server-remove

On 21 December 2017 at 09:07, Vladimir Sementsov-Ogievskiy wrote: > no, I've updated it, we discussed with Kevin that this approach is bad To say that a pullreq is bad you need to reply to the cover letter, there's no guarantee I'll notice a followup to one of the

Re: [Qemu-block] [PULL 00/13] Block layer patches

On 30 July 2018 at 16:09, Kevin Wolf wrote: > The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 > 09:55:47 +0100) > > are available in the git repository at:

Re: [Qemu-block] [PULL 00/21] Block layer patches

On 15 August 2018 at 13:55, Kevin Wolf wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > >

Re: [Qemu-block] [PULL 0/2] Block patches

On 22 August 2018 at 04:43, Jeff Cody wrote: > The following changes since commit ee135aa0428fe5af2af7be04ff16d2b596a9330a: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.1-20180821' > into staging (2018-08-21 13:27:11 +0100) > > are available in the Git repository at: > >

Re: [Qemu-block] [PULL 0/7] Block layer patches

On 23 July 2018 at 17:45, Kevin Wolf wrote: > The following changes since commit 55b1f14cefcb19ce6d5e28c4c83404230888aa7e: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging > (2018-07-23 14:03:14 +0100) > > are available in the git

Re: [Qemu-block] [PULL for-v3.0 0/1] Block patches

On 19 July 2018 at 15:28, Stefan Hajnoczi wrote: > The following changes since commit ea6abffa8a08d832feb759d359d5b935e3087cf7: > > Update version for v3.0.0-rc1 release (2018-07-17 18:15:19 +0100) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git

Re: [Qemu-block] [PULL for-3.0 0/1] Block patches

On 24 July 2018 at 15:23, Stefan Hajnoczi wrote: > The following changes since commit 768cef2974fb1fa30dd188b043ea737e13fea477: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2018-07-24 10:37:52 +0100) > > are available in the Git repository at:

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img.c: add help for each command

On 8 September 2018 at 04:01, John Arbuckle wrote: > +/* print the help for this command */ > +if (strcmp("--help", argv[optind + 1]) == 0) { > +if (strcmp("amend", cmdname) == 0) { > +help_amend(); > +} else if (strcmp("bench", cmdname) == 0) { > +

Re: [Qemu-block] [PULL v2 00/12] Block layer patches

On 5 July 2018 at 11:25, Kevin Wolf wrote: > The following changes since commit fe8d2d5737ab20ed0118863f5eb888cae37122ab: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging > (2018-07-04 22:38:10 +0100) > > are available in the git

Re: [Qemu-block] [Qemu-devel] [RFC v3 09/10] dp8393x: manage big endian bus

On 28 June 2018 at 00:29, Laurent Vivier wrote: > This is needed by Quadra 800, this card can run on little-endian > or big-endian bus. > > Signed-off-by: Laurent Vivier > Tested-by: Hervé Poussineau > --- > hw/net/dp8393x.c | 88 > > 1

Re: [Qemu-block] [PULL 0/7] Block patches for 3.0-rc0

On 9 July 2018 at 19:58, Max Reitz wrote: > The following changes since commit ec7eb2ae77cc207064e17ace048f7ec0c4b85d6f: > > translate-all: honour CF_NOCACHE in tb_gen_code (2018-07-09 16:14:36 +0100) > > are available in the Git repository at: > > https://git.xanclic.moe/XanClic/qemu.git

Re: [Qemu-block] [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

On 10 July 2018 at 15:22, Cornelia Huck wrote: > On Tue, 10 Jul 2018 07:59:15 +0200 > Markus Armbruster wrote: > >> In addition to actively pulling libvirt developers into review of >> deprecation patches, we should pursue the idea to optionally let QEMU >> fail on use of deprecated features,

Re: [Qemu-block] [PULL 00/24] Block layer patches

On 10 July 2018 at 16:42, Kevin Wolf wrote: > The following changes since commit b34181056c04e05db6c632063012beaee7006a37: > > Merge remote-tracking branch 'remotes/rth/tags/pull-sh4-20180709' into > staging (2018-07-09 22:44:22 +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

On 6 July 2018 at 15:56, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> That way, we can still easily remove old cruft (case (a)), but still >> accommodate cases like this (case (c)). The obvious drawback is that >> we'd need someone to curate the deprecation

Re: [Qemu-block] [PULL 0/7] Block layer fixes for 3.0-rc1

On 12 July 2018 at 17:31, Kevin Wolf wrote: > The following changes since commit dc3c89d612252fc461a65f54885a1fe108e9ec05: > > ui/cocoa.m: replace scrollingDeltaY with deltaY (2018-07-12 16:03:50 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git

Re: [Qemu-block] [PULL 0/5] Block layer patches

On 3 July 2018 at 15:59, Kevin Wolf wrote: > The following changes since commit a395717cbd26e7593d3c3fe81faca121ec6d13e8: > > Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into > staging (2018-07-03 11:49:51 +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

On 4 July 2018 at 14:34, Kevin Wolf wrote: > Essentially, what is important to me isn't getting these options dropped > exactly in 3.0, but not setting a bad precedence that deprecation isn't > actually worth anything. We may easily end up with this deprecation > process: > > depreate a feature >

Re: [Qemu-block] [PULL 0/6] Qio next patches

On 7 March 2018 at 11:25, Daniel P. Berrangé wrote: > The following changes since commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-05 16:41:20 +) > > are available in

Re: [Qemu-block] [PULL 0/7] Block patches

On 9 March 2018 at 13:19, Stefan Hajnoczi wrote: > The following changes since commit 0ab4537f08e09b13788db67efd760592fb7db769: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2018-03-07-1' into staging (2018-03-08 > 12:56:39 +) > > are

Re: [Qemu-block] [Qemu-devel] [PULL 00/56] Block layer patches

On 9 March 2018 at 16:18, Kevin Wolf wrote: > The following changes since commit d9bbfea646e86426d549bd612cd9f91e49aa50c2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-upstream-v8.2' > into staging (2018-03-09 10:58:57 +) > > are available in the git

Re: [Qemu-block] [PULL 0/1] Block patches

On 12 March 2018 at 16:01, Stefan Hajnoczi wrote: > The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-09 17:28:16 +) > > are available in the

Re: [Qemu-block] [PULL 00/41] Block layer patches

On 13 March 2018 at 16:17, Kevin Wolf wrote: > The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: > > Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into > staging (2018-03-13 11:42:45 +) > > are available in the git

Re: [Qemu-block] [PULL 0/1] Block patches

On 13 March 2018 at 12:29, Jeff Cody wrote: > The following changes since commit 834eddf22ec762839b724538c7be1d1d3b2d9d3b: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-13 10:49:02 +) > > are available in the git

Re: [Qemu-block] [PULL v2 00/38] Block layer patches

On 5 March 2018 at 17:51, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the

Re: [Qemu-block] [PULL v2 00/38] Block layer patches

On 6 March 2018 at 10:24, Kevin Wolf <kw...@redhat.com> wrote: > Am 06.03.2018 um 11:09 hat Peter Maydell geschrieben: >> On 5 March 2018 at 17:51, Kevin Wolf <kw...@redhat.com> wrote: >> > The following changes since commit >> > 86f4c7e05b1c44dbe1b329a51f3

Re: [Qemu-block] [PULL 0/3] Block patches for 2.12-rc2

On 3 April 2018 at 17:13, Jeff Cody wrote: > The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 > 09:42:33 +0100) > > are available in

Re: [Qemu-block] [PULL 0/9] Block layer patches for 2.12.0-rc2

On 3 April 2018 at 17:33, Kevin Wolf wrote: > The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 > 09:42:33 +0100) > > are available in

Re: [Qemu-block] [PULL for-2.12 0/1] Block patches

On 4 April 2018 at 17:10, Jeff Cody wrote: > The following changes since commit fd69ad866b62ca8ed4337ffee83b6d82a4e99282: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-04-04 14:00:07 +0100) > > are available in the git repository at:

Re: [Qemu-block] [PULL 0/7] Block layer patches for 2.12.0-rc3

On 10 April 2018 at 16:37, Kevin Wolf wrote: > The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' > into staging (2018-04-10 14:04:27 +0100) > > are available in the git

Re: [Qemu-block] [PULL 0/2] Block patches for 2.12.0-rc4

On 16 April 2018 at 13:38, Max Reitz wrote: > The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16 > 10:11:17 +0100) > > are available in the

Re: [Qemu-block] [Qemu-devel] [PULL 00/19] Block layer patches

On 26 March 2018 at 15:35, Kevin Wolf wrote: > The following changes since commit 7b1db0908d88f0c9cfac24e214ff72a860692e23: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180323' into staging (2018-03-25 > 13:51:33 +0100) > > are available in the

Re: [Qemu-block] [PULL 0/4] Block patches for 2.12.0-rc1

On 26 March 2018 at 21:20, Max Reitz wrote: > The following changes since commit 7b93d78a04aa242d377ae213b79db6c319c71847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-03-26 15:17:25 +0100) > > are available in the Git repository

Re: [Qemu-block] [PULL v2 00/44] Block layer patches

On 15 March 2018 at 17:18, Kevin Wolf wrote: > The following changes since commit 56e8698ffa8aba9f762f980bc21b5340b006f24b: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-travis-speedup-130318-1' into staging (2018-03-15 > 14:48:09 +) > > are available in

Re: [Qemu-block] [PULL v3 00/46] Block layer patches

On 19 March 2018 at 11:04, Kevin Wolf wrote: > The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: > > Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into > staging (2018-03-17 14:15:03 +) > > are available in the git

Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not ""

On 20 March 2018 at 09:44, Daniel P. Berrangé wrote: > We can follow what autoconf does, and add a check to configure to see if > there are generated files left in the source dir, when configuring with > builddir != srcdir, and exit with error, telling user to clean their >

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

On 22 March 2018 at 17:19, Max Filippov wrote: > Ok, I can add a fixup that changes #include to #include > "xtensa-isa.h". > Adding #include "qemu/osdep.h" there seems pointless to me. Every top level .c file must start with including osdep.h. Other headers that it might

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

On 22 March 2018 at 17:57, wrote: > Checking PATCH 4/4: Remove unnecessary variables for function return value... > ERROR: return is not a function, parentheses are not required > #251: FILE: target/mips/dsp_helper.c:3281: > +return (temp[1] << 63) | (temp[0] >> 1);

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

On 22 March 2018 at 17:30, Eric Blake wrote: > I'm less certain of whether our Coccinelle scripts have easy ways to exclude > specific files. We already have scripts/cocci-macro-file.h to help > Coccinelle not choke on some our existing files, but I'm not sure if > Coccinelle

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

On 22 March 2018 at 19:12, Eric Blake wrote: > Or if we don't patch the false negative, you can bypass checkpatch with an > ugly hack: > > return 0 + (...) | (...); > > (I'm NOT going to do that bypass - it's too ugly for my taste) Yeah, that's definitely not something we

Re: [Qemu-block] [Qemu-devel] [PULL 00/37] Block layer patches

On 2 March 2018 at 18:54, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the

Re: [Qemu-block] [PULL 0/6] Block patches

On 5 March 2018 at 09:40, Stefan Hajnoczi wrote: > The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738: > > Merge remote-tracking branch > 'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02 > 16:56:20 +) > > are

Re: [Qemu-block] [PULL 0/2] Block patches

On 27 June 2018 at 15:48, Stefan Hajnoczi wrote: > The following changes since commit 00928a421d47f49691cace1207481b7aad31b1f1: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180626' into staging (2018-06-26 > 18:23:49 +0100) > > are available in the Git

Re: [Qemu-block] [PATCH] nbd/server: Silence gcc false positive

, so silence them. > > Signed-off-by: Eric Blake > --- > > Peter, do you want to apply this directly as a build fix, or shall > I submit a pull request? I'll just apply it directly. Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-block] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On 22 June 2018 at 15:38, Christian Borntraeger wrote: > So if everyone has adopted we can certainly follow our deprecation policy. > Now if deprecation breaks some real world cases it makes no sense to > "insist" on that deprecation policy. Really: If latest greatest libvirt > does not work 2

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 5 October 2018 at 17:17, Kevin Wolf wrote: > Am 05.10.2018 um 16:41 hat Peter Maydell geschrieben: >> On 5 October 2018 at 15:38, Peter Maydell wrote: >> > The test-bdrv-drain test fails at least 50% of the time >> > on my OS build system. Disable t

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 5 October 2018 at 15:38, Peter Maydell wrote: > The test-bdrv-drain test fails at least 50% of the time > on my OS build system. Disable the test until we can figure This is a typo: I meant "OSX build system". > out what's going on, as this makes pull request processi

[Qemu-block] [PATCH] tests: Disable test-bdrv-drain

The test-bdrv-drain test fails at least 50% of the time on my OS build system. Disable the test until we can figure out what's going on, as this makes pull request processing very difficult. Signed-off-by: Peter Maydell --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 5 October 2018 at 19:09, Kevin Wolf wrote: > And if we disable it wholesale, then nobody has any incentive to fix any > bug that the test case could have uncovered. Yes, that's fair. I'm sorry; I was a bit grumpy when I wrote that email because my test runs had been bumping into it all day.

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 8 October 2018 at 10:12, Peter Maydell wrote: > I looked back at the backtrace/etc that I posted earlier in this > thread, and it looked to me like maybe a memory corruption issue. > So I tried running the test under valgrind on Linux, and: ...which goes away if I do a complete b

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 8 October 2018 at 17:40, Kevin Wolf wrote: > By the way, can you reproduce this with virtio-blk/scsi and an iothread > in a real QEMU or is it only the test case that fails? In theory, I > don't see what would prevent QEMU from hanging at shutdown. I haven't tested, but I suspect this is less

Re: [Qemu-block] [RFC] Require Python 3 for building QEMU

On 15 October 2018 at 10:32, Daniel P. Berrangé wrote: > On Sat, Oct 13, 2018 at 02:02:27AM -0300, Eduardo Habkost wrote: >> Signed-off-by: Eduardo Habkost >> --- >> I'd like to do this in QEMU 3.1. I think it's time to drop >> support for old systems that have only Python 2. >> >> We still

Re: [Qemu-block] [Qemu-devel] [RFC] Require Python 3 for building QEMU

On 15 October 2018 at 19:01, Eduardo Habkost wrote: > On Mon, Oct 15, 2018 at 05:55:27PM +0100, Peter Maydell wrote: >> I also suspect "a few months" is an underestimate. My guess >> would be we're going to want to keep Python 2 support for >> at least the next

[Qemu-block] [PATCH] block/vdi: Don't take address of fields in packed structs

f a packed member in this file for other purposes than passing it to a byteswap function (all the calls to qemu_uuid_*()); we leave those for now. Signed-off-by: Peter Maydell --- Another "tested with make check" auto-conversion patch. In this case, as noted above, it doesn't

[Qemu-block] [PATCH] block/vhdx: Don't take address of fields in packed structs

quot; byte swapping functions. There are a few places where the in-place swap function is used on something other than a packed struct field; we convert those anyway, for consistency. Patch produced with scripts/coccinelle/inplace-byteswaps.cocci. Signed-off-by: Peter Maydell --- Usual disclaimer

Re: [Qemu-block] [Qemu-devel] [RFC] Require Python 3 for building QEMU

On 15 October 2018 at 17:33, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 15.10.2018 um 12:02 hat Peter Maydell geschrieben: >> It's easier to port stuff to Python 3 though than making them work with >> both. I think Eduardo's RFC is in part motivated by

[Qemu-block] could somebody who understands the block refcounting look at CID 1395870, CID 1395871?

Hi; could somebody who understands the block layer refcounting have a look at Coverity issues CID 1395870 and 1395871, please? In both cases, Coverity reports a use-after-free because it thinks that a sequence where a code path might (conditionally) end up calling blk_deref() twice could be

Re: [Qemu-block] [PULL 00/20] Trivial patches patches

On 26 October 2018 at 16:31, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository

[Qemu-block] [PATCH for-3.1] blockdev: Consistently use snapshot_node_name in external_snapshot_prepare()

ossible to get here with s->has_snapshot_node_name true but snapshot_node_name NULL, and warns that the call to qdict_put_str() will segfault in that case. Make the code consistent and unconfuse Coverity by using the same check for this conditional that we do in the rest of the surrounding code.

Re: [Qemu-block] [PULL 00/15] Python queue, 2018-10-30

On 31 October 2018 at 00:31, Eduardo Habkost wrote: > Sorry for submitting this at the last minute. > > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch > 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging >

Re: [Qemu-block] [PULL v2 00/20] Qemu trivial for 3.1 patches

On 30 October 2018 at 11:23, Laurent Vivier wrote: > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > > are available in the Git repository

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 4 November 2018 at 22:03, Paolo Bonzini wrote: > On 02/11/2018 14:33, Peter Maydell wrote: >> On 9 October 2018 at 12:16, Paolo Bonzini wrote: >>> Yup, we have to stop using pthread_key_create. Luckily, these days >>> there is always qemu_thread_start that wraps

Re: [Qemu-block] [PATCH 0/3] block/qcow*: Don't take address of fields in packed structs

On 10 October 2018 at 11:55, Kevin Wolf wrote: > Am 09.10.2018 um 19:24 hat Peter Maydell geschrieben: >> Taking the address of a field in a packed struct is a bad idea, because >> it might not be actually aligned enough for that pointer type (and >> thus cause a crash on der

Re: [Qemu-block] [PATCH] block/vhdx: Don't take address of fields in packed structs

On 17 October 2018 at 15:36, Kevin Wolf wrote: > Am 16.10.2018 um 19:09 hat Peter Maydell geschrieben: >> Taking the address of a field in a packed struct is a bad idea, because >> it might not be actually aligned enough for that pointer type (and >> thus cause a crash on der

Re: [Qemu-block] [PATCH] block/vdi: Don't take address of fields in packed structs

On 17 October 2018 at 15:55, Kevin Wolf wrote: > Am 16.10.2018 um 19:25 hat Peter Maydell geschrieben: >> Taking the address of a field in a packed struct is a bad idea, because >> it might not be actually aligned enough for that pointer type (and >> thus cause a crash on der

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain

On 9 October 2018 at 12:16, Paolo Bonzini wrote: > On 08/10/2018 18:40, Kevin Wolf wrote: >>> >>> I'm pretty confident this analysis of the problem is correct: >>> unfortunately I have no idea what the right way to fix it is... >> Yes, I agree with your analysis. If __thread variables can be

Re: [Qemu-block] [PULL 0/2] Block patches

On 29 October 2018 at 13:56, Stefan Hajnoczi wrote: > The following changes since commit 285278ca785f5fa9a570927e1c0958a2ca2b2150: > > Merge remote-tracking branch 'remotes/famz/tags/testing-pull-request' into > staging (2018-10-27 19:55:08 +0100) > > are available in the Git repository at: >

Re: [Qemu-block] [PULL 00/36] Block layer patches

On 5 November 2018 at 16:37, Kevin Wolf wrote: > The following changes since commit b2f7a038bb4c4fc5ce6b8486e8513dfd97665e2a: > > Merge remote-tracking branch 'remotes/rth/tags/pull-softfloat-20181104' > into staging (2018-11-05 10:32:49 +) > > are available in the Git repository at: > >

Re: [Qemu-block] [PULL 00/14] Block layer patches

On 12 November 2018 at 17:05, Kevin Wolf wrote: > The following changes since commit 5704c36d25ee84e7129722cb0db53df9faefe943: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-31-20181112-pull-request' into staging (2018-11-12 > 15:55:40 +) > > are available in the Git

Re: [Qemu-block] [PATCH] migration/block-dirty-bitmap: fix Coverity CID1390625

On 16 November 2018 at 03:28, John Snow wrote: > I looked again. I think Vladimir's patch will shut up Coverity for sure, > feel free to apply it if you want this out of your hair. > > Stefan suggests the following, however; > > > diff --git a/migration/block-dirty-bitmap.c

<    1   2   3   4   5   6   7   8   9   10   >