Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] qemu-img: Use qemu_strtoul() rather than raw strtoul()

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qemu-img.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 74e3362..aa71588 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3621,24 +3621,24 @@ static int img

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qemu-img: Avoid setting ret to unused value in img_convert()

into line with the following call to bdrv_snapshot_laod_tmp_by_id_or_name(). (Fixes CID 1247240.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qemu-img.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

On 03/22/2017 01:23 PM, Philippe Mathieu-Daudé wrote: On 03/22/2017 10:58 AM, Jeff Cody wrote: On Mon, Mar 20, 2017 at 06:33:04PM +, Peter Maydell wrote: On OpenBSD none of the ioctls probe_logical_blocksize() tries exist, so the variable sector_size is unused. Refactor the code to avoid

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

sector_size; +success = true; +} +} return success ? 0 : -errno; } -- 2.7.4 Reviewed-by: Jeff Cody <jc...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-block] [Qemu-devel] [PATCH] block/parallels.c: avoid integer overflow in allocate_clusters()

eter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- NB: compile-and-make-check tested only... --- block/parallels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index 4173b3f..3886c30 100644 --- a/block

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/parallels: Avoid overflows

hen invoking bat_entry_off() does not result in an integer overflow. Coverity-id: 1307776 Signed-off-by: Max Reitz <mre...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- This supercedes Peter's patch "block/parallels.c: avoid integer overflow in allocate_clu

Re: [Qemu-block] [Qemu-devel] [PATCH] curl: fix compilation on OpenBSD

On 03/17/2017 12:24 PM, Paolo Bonzini wrote: EPROTO is not found in OpenBSD. We usually use EIO when no better errno is available, do that here too. Reported-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe M

Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/3] qemu-img: fix switch indentation in img_amend()

com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qemu-img.c | 82 +++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index ce293a4..c7ffabb 100644 --- a/qemu-img.c +++

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 09/16] block/qcow2: Generalize preallocate()

Hi Max, On 04/03/2017 01:09 PM, Max Reitz wrote: This patch adds two new parameters to the preallocate() function so we will be able to use it not just for preallocating a new image but also for preallocated image growth. The offset parameter allows the caller to specify a virtual offset from

Re: [Qemu-block] [Qemu-devel] [RFC 05/19] pflash_cfi01: Remove user_creatable flag

ongnu.org Cc: Laszlo Ersek <ler...@redhat.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/block/pflash_cfi01.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/p

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9 1/2] block/mirror: Fix use-after-free

() it at the end of the fail path after we actually no longer need it. Signed-off-by: Max Reitz <mre...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/mirror.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/bl

Re: [Qemu-block] [Qemu-devel] [PATCH v4 09/13] qobject: Use simpler QDict/QList scalar insertion macros

scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h --dir . --in-place and needed only one touch-up in monitor.c to avoid a long line. Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v4: no change v

Re: [Qemu-block] [Qemu-devel] [PATCH v9 03/13] qemu-io: Switch 'alloc' command to byte-based length

return 0; } } else { -nb_sectors = 1; +bytes = BDRV_SECTOR_SIZE; } +if (bytes & 0x1ff) { This macro is self-explanatory: if(!QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)) Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> +p

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 12/16] block/qcow2: Extract qcow2_calc_size_usage()

com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/qcow2.c | 126 +++--- 1 file changed, 68 insertions(+), 58 deletions(-) diff --git a/block/qcow2.c b/b

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 1/2] block: An empty filename counts as no filename

me) { +if (drv->bdrv_needs_filename && (!filename || !filename[0])) { What do you think about adding an inline function in "qemu/option.h" like "is_valid_[option_]filename()" to avoid this bug template? Anyway: Reviewed-by: Philippe Mathieu-Daudé <f4.

Re: [Qemu-block] [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

On 04/20/2017 01:00 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/sheepdog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index fb9203e..7e889ee 100644

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 1/3] qemu-img/convert: Always set ret < 0 on error

On 04/13/2017 05:33 PM, Max Reitz wrote: Otherwise the qemu-img process will exit with EXIT_SUCCESS instead of EXIT_FAILURE. Cc: qemu-stable <qemu-sta...@nongnu.org> Signed-off-by: Max Reitz <mre...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qe

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile

viewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Does this mean our automated buildbots aren't building archipelago by default? diff --git a/block/archipelago.c b/block/archipelago.c index 2449cfc702..01c4ff2f7d 100644 --- a/block/archipe

Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] commit: Fix error handling

viewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/commit.c b/block/commit.c index 22a0a4d..e57c1cf 100644 --- a/block/commit.c +++ b/block/commit.c @@ -364,7 +364,7 @@ void commit_start(const

Re: [Qemu-block] [Qemu-devel] [PATCH 06/10] block: Factor out should_update_child()

ons(+), 15 deletions(-) >> > > Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > > -- > Eric Blake eblake redhat com+1-919-301-3266 > Libvirt virtualization library http://libvirt.org >

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Constify data passed by pointer to blk_name

On 03/05/2017 06:44 PM, Krzysztof Kozlowski wrote: blk_name() is not modifying data passed to it through pointer and it returns also a pointer to const so the argument can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> Reviewed-by: Philippe Mathieu

Re: [Qemu-block] [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()

elsewhere, instead of -EIO. No functional change, as connect_to_sdog() returns no other error code. Many more suspicious uses of error_report() and error_report_err() remain in other functions. Left for another day. Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe M

Re: [Qemu-block] [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

On 03/02/2017 08:32 PM, Eric Blake wrote: On 03/02/2017 03:43 PM, Markus Armbruster wrote: sd_parse_uri() truncates long VDI names silently. Reject them instead. Signed-off-by: Markus Armbruster --- block/sheepdog.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [Qemu-block] [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create()

On 03/02/2017 06:43 PM, Markus Armbruster wrote: sd_parse_uri() truncates long VDI names silently. Reject them instead. Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/sheepdog.c | 4 +++- 1 file changed,

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 06/16] block/file-posix: Extract raw_regular_truncate()

On 04/03/2017 01:09 PM, Max Reitz wrote: This functionality is part of raw_create() which we will be able to reuse nicely in raw_truncate(). Signed-off-by: Max Reitz <mre...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate

that if resizing failed, we should try to restore the original file size. This is important when using preallocation. Signed-off-by: Max Reitz <mre...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/file-

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9 2/2] block/curl: Check protocol prefix

<mre...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/curl.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/curl.c b/block/curl.c index 34dbd335f4..2708d57c2f 100644 --- a/block/curl.c +++ b/block/curl.c @@ -659,6 +659,7 @@ static i

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors

Hi Eric, On 04/24/2017 11:40 AM, Eric Blake wrote: On 04/23/2017 09:33 AM, jemmy858...@gmail.com wrote: From: Lidong Chen Fix some spelling errors in is_allocated_sectors comment. Signed-off-by: Lidong Chen --- qemu-img.c | 4 ++-- 1 file

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

On 07/31/2017 12:17 PM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 11:54:57AM -0300, Philippe Mathieu-Daudé wrote: On 07/31/2017 11:38 AM, Jeff Cody wrote: On Mon, Jul 31, 2017 at 02:51:11PM +0200, Kevin Wolf wrote: When skipping implicit nodes in bdrv_block_device_info(), we know that bs0

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10] block/qapi: Remove redundat NULL check to silence Coverity

of code right above this, so we'd segfault anyway if the initial value was NULL. Yes, please move your assert before: 137:if (bs0->drv && bs0->backing) { Once there: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> and a BdrvChild never has a NULL bs, and after

Re: [Qemu-block] [Qemu-devel] [PATCH v2 4/4] maint: Include bug-reporting info in --help output.

ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v2: tweak text to capitalize QEMU and use consistent trailing . include/qemu-common.h | 5 + vl.c | 4 +++- bsd-user/main.c | 2 ++ linux-user/main.c | 4 +++- qemu-img.c

Re: [Qemu-block] [Qemu-devel] [PATCH] ide: check BlockBackend object in ide_cancel_dma_sync

On Fri, Jul 14, 2017 at 7:00 AM, P J P wrote: > From: Prasad J Pandit > -blk_drain(s->blk); > -assert(s->bus->dma->aiocb == NULL); This assert looks weird > +if (s->blk) { > +blk_drain(s->blk); > +

[Qemu-block] [PATCH 27/29] tests/hbitmap: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/test-hbitmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index 1acb

[Qemu-block] [PATCH 05/29] block: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/io.c | 4 ++-- block/qcow2-cache.c | 2 +- block/vhdx-log.c| 2 +- block/vvfat.c | 2 +- 4 files changed, 5 insertions

[Qemu-block] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- migration/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/block.c b/migration/block.c index 9171f60028..498c

[Qemu-block] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 182e697f81..6f5f956302 100644 --- a/qemu

[Qemu-block] [PATCH 23/29] async: use ARRAY_SIZE macro

Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- util/aio-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/aio-posix.c b/util/aio-posix.c index 2d51239ec6..e89fd7024a

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] vvfat: add a constant for bootsector name

On 07/15/2017 10:28 AM, Hervé Poussineau wrote: Also add links to related compatibility problems. Signed-off-by: Hervé Poussineau <hpous...@reactos.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/vvfat.c | 8 +++- 1 file changed, 7 insertions(+)

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] vvfat: initialize memory after allocating it

Hi Hervé, On 07/15/2017 10:28 AM, Hervé Poussineau wrote: This prevents some host to guest memory content leaks. Fixes: https://bugs.launchpad.net/qemu/+bug/1599539 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2-bitmap: fix bitmap_free

Maybe worth adding "Coverity: CID 1377700" On 07/14/2017 01:00 PM, Max Reitz wrote: On 2017-07-14 14:33, Vladimir Sementsov-Ogievskiy wrote: Fix possible crash on error path in qcow2_remove_persistent_dirty_bitmap. Although bitmap_free was added in 88ddffae8fc the bug was introduced later in

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

ed to limit the scope of this README :). Maybe something tiny like: Congratulations, you've created a new test! To share your test to upstream QEMU (highly recommended!) just follow these recommendations: http://wiki.qemu.org/Contribute/SubmitAPatch Stefan Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

[Qemu-block] [PATCH for 2.10 05/35] nbd: fix memory leak in nbd_opt_go()

nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf' Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- nbd/client.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/nbd/client.c b/nbd/client.c

[Qemu-block] [PATCH for 2.10 08/35] qcow2: fix null pointer dereference

Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/qcow2-refcount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index c9b0dcb4f3..168fc32e7b 100644 --- a/block/qcow2-refcount.c +++ b

[Qemu-block] [PATCH for 2.10 06/35] qcow2: remove inconsistent check

This is equivalent to assert(russian roulette) so better remove it. block/qcow2-bitmap.c:259:29: warning: The left operand of '==' is a garbage value assert(bitmap_table == NULL); ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <

[Qemu-block] [PATCH for 2.10 07/35] qcow2: fix null pointer dereference

rom variable 'bm') g_free(bm->name); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/qcow2-bitmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qcow2-bitmap.c b/block/qcow2-bi

Re: [Qemu-block] [PATCH for 2.10 07/35] qcow2: fix null pointer dereference

Hi Eric, On 07/24/2017 03:46 PM, Eric Blake wrote: On 07/24/2017 01:27 PM, Philippe Mathieu-Daudé wrote: If find_bitmap_by_name() fails we have bm=NULL and go to the 'fail' label, then call bitmap_free(bm) which does g_free(bm->name) with bm=NULL... Clang's scan-build-5.0 output: block/qc

[Qemu-block] [PATCH for 2.10 2/8] docs: fix broken paths to docs/interop/qcow2.txt

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- docs/qcow2-cache.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 1fdd6f9ce7..b0571de4b8 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -15,7

[Qemu-block] [PATCH 19/47] MAINTAINERS: add missing qcow2 entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6b83dac812..2dcdda4cd5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1856,6 +1856,7 @@ M: Max Reitz <mre...@redhat.com> L

[Qemu-block] [PATCH 36/47] MAINTAINERS: add missing entry test for megasas

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b9a132d964..7649d57e0f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1144,6 +1144,7 @@ L: qemu-block@nongnu.org S: Supported F: h

[Qemu-block] [PATCH 38/47] MAINTAINERS: update docs/interop/ entries

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 23de632424..54e35fdab9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1283,7 +1283,7 @@ F: block/dirty-bitma

[Qemu-block] [PATCH 40/47] MAINTAINERS: add missing entry for AIO

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 83597fca4e..fb6a82c1ad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1253,6 +1253,7 @@ F: util/aio-*.c F: block/io.c F: migration

[Qemu-block] [PATCH 10/47] MAINTAINERS: add missing entry for virtio/blk

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4f9ce6e686..2958dd2479 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1067,6 +1067,7 @@ S: Supported F: hw/block/virtio-blk.c F: hw

[Qemu-block] [PATCH for 2.10 v2 04/20] nbd: fix memory leak in nbd_opt_go()

nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf' Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Eric Blake <ebl...@redhat.com> --- nbd/client.c | 8 +--- 1 file changed, 5 insertions(+), 3 deleti

Re: [Qemu-block] [PATCH v1 1/3] util/aio-win32: Only select on what we are actually waiting for

On 06/29/2017 02:16 PM, Alistair Francis wrote: Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com> Acked-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Changes since RFC: - Include more bitmasks f

Re: [Qemu-block] [Qemu-devel] [RFC v1 2/4] util/oslib-win32: Remove invalid check

-by: Alistair Francis <alistair.fran...@xilinx.com> > Acked-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > > util/oslib-win32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

grammatically correct. Suggested-by: Philippe Mathieu-Daudé <f4...@amsat.org> Suggested-by: Max Reitz <mre...@redhat.com> Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v11: retitle [was "qemu-io: Don't open-co

Re: [Qemu-block] [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

Hi Olaf, On 07/28/2017 10:11 AM, Olaf Hering wrote: g_malloc0_n is available since glib-2.24. To allow build with older glib versions use the generic g_new0, which is already used in many other places in the code. Can you provide information about which distrib/release/version/[packages?]

[Qemu-block] [PATCH v2 for 2.10 2/8] docs: fix broken paths to docs/interop/qcow2.txt

With the move of some docs to docs/interop on d59157ea05, a reference path was not updated. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Kevin Wolf <kw...@redhat.com> --- docs/qcow2-cache.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

On 08/08/2017 05:00 PM, Eric Blake wrote: On 08/08/2017 01:32 PM, John Snow wrote: Out with the old, in with the new. Signed-off-by: John Snow --- hw/ide/piix.c | 11 hw/ide/trace-events | 33 hw/ide/via.c

Re: [Qemu-block] [Qemu-devel] [PATCH 10/12] qemu-iotests: get rid of $iam

On 08/09/2017 06:55 PM, Paolo Bonzini wrote: The variable is almost unused, and one of the two uses is actually uninitialized. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/qemu-iotests/check | 5 +

Re: [Qemu-block] [Qemu-devel] [PATCH 03/12] qemu-iotests: move "check" code out of common.rc

Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/qemu-iotests/common| 30 ++- tests/qemu-iotests/common.config | 12 +++ tests/qemu-iotests/common.rc | 45

Re: [Qemu-block] [Qemu-devel] [PATCH 05/12] qemu-iotests: do not include common.rc in "check"

On 08/09/2017 06:55 PM, Paolo Bonzini wrote: It only provides functions used by the test programs. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/qemu-iotests/check | 6 -- tests/qemu-iotests/co

Re: [Qemu-block] [Qemu-devel] [PATCH 1/4] vpc: Check failure of bdrv_getlength()

On 08/07/2017 05:30 PM, Eric Blake wrote: vpc_open() was checking for bdrv_getlength() failure in one, but not the other, location. Reported-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qcow: Check failure of bdrv_getlength() and bdrv_truncate()

e <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/qcow.c | 64 ++-- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index c08cdc4a7b..937023d447 100644

Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] qcow2: Drop debugging dump_refcounts()

com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- > block/qcow2.c | 21 - 1 file changed, 21 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index d7c600b5a2..99407403ea 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3798,27 +3

Re: [Qemu-block] [Qemu-devel] [PATCH 4/4] qcow2: Check failure of bdrv_getlength()

On 08/07/2017 05:30 PM, Eric Blake wrote: qcow2_co_pwritev_compressed() should not call bdrv_truncate() if determining the size failed. Reported-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <

Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 2/4] block/vhdx: check for offset overflow to bdrv_truncate()

kw...@redhat.com> > Signed-off-by: Jeff Cody <jc...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > block/vhdx-log.c | 6 +- > block/vhdx.c | 3 +++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/block/vhdx-log.c

Re: [Qemu-block] [Qemu-devel] [PATCH v2 6/6] dev-storage: Fix the unusual function name

jitsu.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/usb/dev-storage.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 801f552..2a05cd5 100644 --- a/hw/usb/dev-storage.

Re: [Qemu-block] [Qemu-devel] [PATCH 03/10] scsi: introduce scsi_build_sense

On 08/22/2017 10:18 AM, Paolo Bonzini wrote: Move more knowledge of sense data format out of hw/scsi/scsi-bus.c for reusability. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/scsi/scsi-bus.c | 8 +---

Re: [Qemu-block] [Qemu-devel] [PATCH 02/10] scsi: move non-emulation specific code to scsi/

layer. Create a directory for this kind of shared code. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS| 7 + Makefile.objs | 2 +- hw/scsi/scsi-bus

[Qemu-block] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

dd (hmp.c:1925) Reported-by: Thomas Huth <th...@redhat.com> Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/acpi/piix4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/acpi/

Re: [Qemu-block] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: 9e047b982452 "piix4: add acpi pci hotplug support" introduced a new property 'use_acpi_pci_hotplug' for pc-1.7 and older machines. c24d5e0b91d1 "convert A

Re: [Qemu-block] [Qemu-devel] [PATCH 05/10] scsi: move block/scsi.h to include/scsi/constants.h

On 08/22/2017 10:18 AM, Paolo Bonzini wrote: Complete the transition by renaming this header, which was shared by block/iscsi.c and the SCSI emulation code. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- b

Re: [Qemu-block] [Qemu-devel] [PATCH 04/10] scsi: introduce sg_io_sense_from_errno

us) { +*sense = SENSE_CODE(I_T_NEXUS_LOSS); +return CHECK_CONDITION; +} else if (io_hdr->status) { +return io_hdr->status; +} else if (io_hdr->driver_status & SG_ERR_DRIVER_SENSE) { +return CHECK_CONDITION; + } +

Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] scsi: rename scsi_convert_sense

Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/scsi/scsi-bus.c | 10 +- hw/scsi/scsi-disk.c| 4 ++-- include/hw/scsi/scsi.h | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/

Re: [Qemu-block] [Qemu-devel] [PATCH] nbd-client: fix hang after server closes connection

dhat.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/nbd-client.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/nbd-client.c b/block/n

Re: [Qemu-block] [Qemu-devel] Use after free problem somewhere in ahci.c or ich.c code

On 08/22/2017 03:39 PM, John Snow wrote: On 08/22/2017 02:15 PM, Thomas Huth wrote: Looks like there is a use-after-free problem somewhere in the ahci.c or ich.c code when trying to add the ich9-ahci on a old PC machine. Using valgrind, I get: those old PC don't support AHCI hotplug, so

Re: [Qemu-block] [Qemu-devel] [PATCH 26/31] vdi: Avoid bitrot of debugging code

; Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> block/vdi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index d12d9cd..a70b969 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -86,12 +86,18 @@ #define DEFAULT_CLU

Re: [Qemu-block] [PATCH 2/3] ahci: Isolate public AHCI interface

future > patch. > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > include/hw/ide/ahci.h| 57 +++-

Re: [Qemu-block] [Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string

On Fri, Jun 23, 2017 at 7:18 PM, John Snow wrote: > This patch is fine, I took a stab at fixing the include issues in a > separate series. Try it all out and let me know. Thank John, your series does fix my include issues :)

Re: [Qemu-block] [PATCH 3/3] ahci: split public and private interface

lize the split by switching external users to the new header. > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/ide/ahci.c

Re: [Qemu-block] [PATCH 1/3] ahci: add ahci_get_num_ports

On Fri, Jun 23, 2017 at 7:09 PM, John Snow <js...@redhat.com> wrote: > Instead of reaching into the PCI state, allow the AHCIDevice to > respond with how many ports it has. > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@ams

Re: [Qemu-block] [Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

Hi Hervé, On 05/22/2017 06:12 PM, Hervé Poussineau wrote: According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some

Re: [Qemu-block] [Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

Hi Hervé, On 05/22/2017 06:11 PM, Hervé Poussineau wrote: - offset_to_bootsector is the number of sectors up to FAT bootsector - offset_to_fat is the number of sectors up to first File Allocation Table - offset_to_root_dir is the number of sectors up to root directory sector Eventually your

Re: [Qemu-block] [Qemu-devel] [PATCH v2 09/13] vvfat: correctly create base short names for non-ASCII filenames

Hi Hervé, On 05/22/2017 06:12 PM, Hervé Poussineau wrote: More specifically, create short name from filename and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about

Re: [Qemu-block] [Qemu-devel] [PATCH v2 12/13] vvfat: handle KANJI lead byte 0xe5

Hi Hervé, You explained in the cover "fix problems detected by disk checking utilities in read-only mode", do you think it would be doable to have unit-tests for those corner cases? On 05/22/2017 06:12 PM, Hervé Poussineau wrote: Specification: "FAT: General overview of on-disk format"

Re: [Qemu-block] [Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

On 05/23/2017 04:41 PM, Hervé Poussineau wrote: Hi Philippe, Le 23/05/2017 à 06:23, Philippe Mathieu-Daudé a écrit : Hi Hervé, On 05/22/2017 06:12 PM, Hervé Poussineau wrote: According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to

Re: [Qemu-block] [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create()

lt;peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow.c b/block/qcow.c index 95ab123..7bd94dc 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -852,6 +852,7 @@ static int qcow_creat

[Qemu-block] [RFC PATCH 2/2] ide/ahci: add missing includes

/highbank.o' failed make[1]: *** [hw/arm/highbank.o] Error 1 make: *** [subdir-arm-softmmu] Error 2 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/ide/ahci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/ide/ahci.h b/include/hw/ide/ahci.h index 0ca7

[Qemu-block] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/arm/highbank.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index d209b97dee..dd809b404b 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -31,6 +31,7 @@ #i

[Qemu-block] [RFC PATCH 0/2] ide/ahci: add missing includes

elated, I should have send them altogether, my bad :/ Regards, Phil. Philippe Mathieu-Daudé (2): arm/highbank: use defined type name instead of hard-coded string ide/ahci: add missing includes hw/arm/highbank.c | 3 ++- include/hw/ide/ahci.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.11.0

Re: [Qemu-block] [Qemu-devel] Fwd: [BUG] Failed to compile using gcc7.1

Hi Tsung-en, On 06/11/2017 04:08 PM, Tsung-en Hsiao wrote: Hi all, I encountered the same problem on gcc 7.1.1 and found Qu's mail in this list from google search. Temporarily fix it by specifying the string length in snprintf directive. Hope this is helpful to other people encountered the

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] scsi-disk: export rotational qdev property

On 05/06/2017 09:43 AM, Aurelien Jarno wrote: Export the rotational qdev property to the block device characteristics VPD page. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/scsi/scsi-disk.c | 14 ++

Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property

be configured as a rotational device or a non-rotational device. Default to true to not change the default behavior. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- blockdev.c | 4 include/hw/block

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] ide: export rotational qdev property

On 05/06/2017 09:43 AM, Aurelien Jarno wrote: Export the rotational qdev property in the IDENTIFY request. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ide/core.c | 3 +++ 1 file changed, 3 insertions(+) dif

[Qemu-block] [PATCH 04/11] ide/ahci: add missing includes

’ IDEBus port; ^~ qemu/include/hw/ide/ahci.h:305:15: error: field ‘parent_obj’ has incomplete type PCIDevice parent_obj; ^~ Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/ide/ahci.h | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Qemu-block] [Qemu-devel] [PATCH] block/gluster.c: Handle qdict_array_entries() failure

of qdict_array_entries() and also the type we use for the loop enumeration variable 'i'. (Spotted by Coverity, CID 1360960.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/gluster.c | 3 +-- 1 file changed,

Re: [Qemu-block] [Qemu-devel] [PATCH] throttle: Assert that bkt->max is valid in throttle_compute_wait()

Hi Alberto, On 09/13/2017 05:28 AM, Alberto Garcia wrote: If bkt->max == 0 and bkt->burst_length > 1 then we could have a division by 0 in throttle_do_compute_wait(). That configuration is however not permitted and is already detected by throttle_is_valid(), but let's assert it in

Re: [Qemu-block] [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization

com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Any magic cocci script to verify there aren't no more? --- I plan to take this through my NBD queue, unless it is picked up by qemu-trivial first... block/nbd-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [Qemu-block] [Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit

g_free(n->cmbuf); memory_region_unref(>ctrl_mem); } Anyway g_free() handles NULL, so: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

  1   2   3   4   5   6   7   8   9   10   >