Re: [Qemu-block] [PATCH 12/17] iscsi: Switch .bdrv_co_discard() to byte-based

ests are always aligned because the > block layer already ignored unaligned head/tail. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > block/iscsi.c | 18 -- > 1 file changed, 8 insertions(+), 10 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa.

Re: [Qemu-block] [PATCH 14/17] qcow2: Switch .bdrv_co_discard() to byte-based

On Wed, Jun 22, 2016 at 09:51:11AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > block/qcow2.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by

Re: [Qemu-block] [PATCH 16/17] sheepdog: Switch .bdrv_co_discard() to byte-based

On Wed, Jun 22, 2016 at 09:51:13AM -0600, Eric Blake wrote: > Another step towards killing off sector-based block APIs. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > block/sheepdog.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions

Re: [Qemu-block] [Qemu-devel] [PATCH v5 02/15] block/io: reuse bdrv_co_pwritev() for write compressed

enis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <stefa.

Re: [Qemu-block] [Qemu-devel] [PATCH v5 10/15] block: simplify drive-backup

ive-backup parameters. > > Signed-off-by: Pavel Butsykin <pbutsy...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC:

Re: [Qemu-block] [Qemu-devel] [PATCH v5 12/15] drive-backup: added support for data compression

> We can write data only once. Though for backup this is perfectly fine. > These limitations are maintained by the driver and the error will be > reported if we are doing something wrong. > > Signed-off-by: Pavel Butsykin <pbutsy...@virtuozzo.com> > Reviewed-by: Stefan Hajnoc

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/15] backup compression

> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > > CC: Jeff Cody <jc...@redhat.com> > > CC: Markus Armbruster <arm...@redhat.com> > > CC: Eric Blake <ebl...@redhat.com> > > CC: John Snow <js...@redhat.com> > > CC: Stefan Haj

Re: [Qemu-block] [Qemu-devel] [PATCH v5 07/15] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion

virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <st

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: add the 'dd' subcommand

On Thu, Jul 14, 2016 at 06:10:47AM +0200, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't >

Re: [Qemu-block] [PATCH v5 13/15] blockdev-backup: added support for data compression

nd compress it. > > Signed-off-by: Pavel Butsykin <pbutsy...@virtuozzo.com> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat

Re: [Qemu-block] [Qemu-devel] [PATCH v5 14/15] qemu-iotests: test backup compression in 055

...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <ste

Re: [Qemu-block] [PATCH 02/17] block: Convert bdrv_discard() to byte-based

y: Eric Blake <ebl...@redhat.com> > --- > include/block/block.h | 2 +- > block/block-backend.c | 3 ++- > block/io.c | 19 +-- > block/qcow2-refcount.c | 4 +--- > 4 files changed, 13 insertions(+), 15 deletions(-) Reviewed-by: Stefan Hajn

Re: [Qemu-block] [PATCH 05/17] block: Convert BB interface to byte-based discards

> hw/block/xen_disk.c| 7 --- > hw/ide/core.c | 6 -- > hw/scsi/scsi-disk.c| 8 > nbd/server.c | 19 +-- > qemu-io-cmds.c | 3 +-- > 8 files changed, 36 insertions

Re: [Qemu-block] [PATCH 07/17] rbd: Switch rbd_start_aio() to byte-based

;ebl...@redhat.com> > --- > block/rbd.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 06/17] raw-posix: Switch paio_submit() to byte-based

igned-off-by: Eric Blake <ebl...@redhat.com> > --- > block/raw-posix.c | 14 -- > block/raw-win32.c | 19 +++ > block/trace-events | 2 +- > 3 files changed, 20 insertions(+), 15 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 01/17] block: Convert bdrv_co_discard() to byte-based

ck.h | 2 +- > block/blkreplay.c | 3 ++- > block/block-backend.c | 3 ++- > block/io.c| 67 > +++ > block/raw_bsd.c | 3 ++- > 5 files changed, 42 insertions(+), 36 deletions(-) Reviewed-by: Stefan Haj

Re: [Qemu-block] [PATCH 04/17] block: Convert bdrv_aio_discard() to byte-based

3 insertions(+), 13 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [Qemu-devel] [PATCH v5 04/15] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion

virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <ste

Re: [Qemu-block] [PATCH 03/17] block: Switch BlockRequest to byte-based

On Wed, Jun 22, 2016 at 09:51:00AM -0600, Eric Blake wrote: > @@ -2204,14 +2203,15 @@ BlockAIOCB *bdrv_aio_discard(BlockDriverState *bs, > { > Coroutine *co; > BlockAIOCBCoroutine *acb; > +QEMUIOVector qiov = { .size = nb_sectors << BDRV_SECTOR_BITS, }; > >

Re: [Qemu-block] [PATCH v22 00/10] Block replication for continuous checkpoints

On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: > COLO block is the necessary prerequisite of COLO framework and COLO network, > what are blocked by these patchsets now. > > Since v19, Stefan said he had reviewed most part of this patchsets. So, this > series *REALLY* need more

Re: [Qemu-block] [PATCH v6] qemu-img: add the 'dd' subcommand

ged, 644 insertions(+), 1 deletion(-) > create mode 100755 tests/qemu-iotests/158 > create mode 100644 tests/qemu-iotests/158.out > create mode 100755 tests/qemu-iotests/159 > create mode 100644 tests/qemu-iotests/159.out Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Re: [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi wrote: > -qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, _abort); > +if (dd.flags & C_SKIP && size < in.bsz * in.offset) { > +error_report("%s: cannot skip to specified offset", in.filename); > +

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

On Mon, Jul 25, 2016 at 05:58:54PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi <stefa...@redhat.com> writes: > > > On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: > >> img_open_file() and img_open_opts() were printing error messages with a

Re: [Qemu-block] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard

nment ('discard 1M 15M' becomes a no-op > because it is not aligned). But obviously it needs to be > tested on the actual iscsi SAN that triggered the original > report. > --- > include/block/block_int.h | 37 - > block/io.c| 15 +-- > 2 files changed, 29 insertions(+), 23 deletions(-) Acked-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v3] qemu-img: add skip option to dd

On Thu, Jul 28, 2016 at 4:51 PM, Reda Sallahi <fullma...@gmail.com> wrote: > On 7/28/16, Stefan Hajnoczi <stefa...@gmail.com> wrote: >> On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi <fullma...@gmail.com> wrote: >>> -qemu_opt_set_number(opts, BLOCK_OPT_SIZE,

Re: [Qemu-block] [PATCH v7 02/16] block: Convert bdrv_pwrite_compressed() to BdrvChild

l...@redhat.com> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <stefa...@redhat.com> > CC: Kevin Wolf <kw...@redhat.com> &g

Re: [Qemu-block] [PATCH v24 02/12] Backup: clear all bitmap when doing block checkpoint

2 files changed, 43 insertions(+) > create mode 100644 include/block/block_backup.h Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v24 01/12] unblock backup operations in backing file

...@cn.fujitsu.com> > --- > block.c | 17 + > 1 file changed, 17 insertions(+) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v24 03/12] Backup: export interfaces for extra serialization

goto out; > } > ret = bdrv_co_readv(); > out: > return ret; > } > > Signed-off-by: Changlong Xie <xiecl.f...@cn.fujitsu.com> > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> > Signed-off-by: Wang WeiWei <wangww.f...

Re: [Qemu-block] [PATCH v7 00/16] backup compression

m> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <stefa...@redha

Re: [Qemu-block] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits

On Thu, Jul 28, 2016 at 11:08:11AM +0300, Alberto Garcia wrote: > Hello, > > Gu Nini found this problem and reported it in > > https://bugzilla.redhat.com/show_bug.cgi?id=1355665 > > When setting the throttling configuration, the burst limits can be > lower than the normal limits. This does not

Re: [Qemu-block] [PATCH v2] qemu-img: add conv=notrunc option to dd

On Thu, Aug 11, 2016 at 05:51:43AM +0200, Reda Sallahi wrote: > @@ -3997,6 +4017,14 @@ static int img_dd(int argc, char **argv) > g_free(arg); > arg = NULL; > } > +if (!(dd.conv & C_NOTRUNC)) { > +/* We make conv=notrunc mandatory for the moment to avoid

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: change opening method for the output in dd

On Thu, Aug 11, 2016 at 06:02:32AM +0200, Reda Sallahi wrote: > +bs = bdrv_open(out.filename, NULL, qoptions, BDRV_O_RDWR, _err); Why are bdrv_*() functions used instead of blk_*()? signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH] test-coroutine: Fix coroutine pool corruption

s trouble before, but it does test something useful... Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v7 1/4] blockdev: prepare iSCSI block driver for dynamic loading

t; > Reviewed-by: Fam Zheng <f...@redhat.com> > --- > block/iscsi.c | 36 > vl.c | 40 > 2 files changed, 40 insertions(+), 36 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 0/2] coroutine: Assertions and debugging aids

tine.h | 1 + > include/qemu/coroutine_int.h | 1 + > util/qemu-coroutine-lock.c | 14 ++ > util/qemu-coroutine.c| 1 + > 4 files changed, 17 insertions(+) > > -- > 1.8.3.1 > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH] linux-aio: Handle io_submit() failure gracefully

On Tue, Aug 09, 2016 at 01:20:19PM +0200, Kevin Wolf wrote: > It is generally not expected that io_submit() fails other than with > -EAGAIN, but corner cases like SELinux refusing I/O when permissions are > revoked are still possible. In this case, we shouldn't abort, but just > return an I/O

Re: [Qemu-block] [PATCH v9] qemu-img: add the 'dd' subcommand

84 insertions(+), 5 deletions(-) > create mode 100755 tests/qemu-iotests/158 > create mode 100644 tests/qemu-iotests/158.out > create mode 100755 tests/qemu-iotests/159 > create mode 100644 tests/qemu-iotests/159.out Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH] qemu-img: fix error messages emitted by img_open()

On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: > img_open_file() and img_open_opts() were printing error messages with a > duplicate part because of a wrong use of error_reportf_err() (e.g. > qemu-img: Could not open 'foo': Could not open 'foo': No such file or > directory) > >

Re: [Qemu-block] [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE

On Thu, Jul 14, 2016 at 09:10:43PM +0800, Cao jin wrote: > replace tab with spaces > > Signed-off-by: Cao jin > --- > async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block

Re: [Qemu-block] [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE

On Fri, Jul 15, 2016 at 09:48:50AM +0800, Cao jin wrote: > On 07/14/2016 10:08 PM, Eric Blake wrote: > > On 07/14/2016 07:10 AM, Cao jin wrote: > > > replace tab with spaces > > > > > > Signed-off-by: Cao jin > > > --- > > > async.c | 2 +- > > > 1 file changed, 1

Re: [Qemu-block] [PATCH] virtio-blk: dataplane cleanup

On Mon, Jul 18, 2016 at 12:05:49PM +0800, Cao jin wrote: > No need duplicate the judgment, there is one in function entry. > > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Cc: Kevin Wolf <kw...@redhat.com> > Cc: Max Reitz <mre...@redhat.com> > Signed-off-b

Re: [Qemu-block] [PATCH v4] aio-posix: remove useless parameter

On Fri, Jul 15, 2016 at 06:28:44PM +0800, Cao jin wrote: > Parameter **errp of aio_context_setup() is useless, remove it > and clean up the related code. > > Cc: Stefan Hajnoczi <stefa...@redhat.com> > Cc: Fam Zheng <f...@redhat.com> > Cc: Eric Blake <ebl...@red

Re: [Qemu-block] [PATCH v3 0/8] drive-mirror improvements

ng of .bdrv_co_write_zeroes is replaced with > >bdrv_can_write_zeroes_with_unmap > > - added fixes for bdrv_can_write_zeroes_with_unmap > > > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > > CC: Stefan Hajnoczi <stefa...@redhat.com> > > CC:

Re: [Qemu-block] [PATCH for-2.7 v2 00/19] byte-based block discard

On Fri, Jul 15, 2016 at 05:22:49PM -0600, Eric Blake wrote: > Allow NBD to pass a byte-aligned discard request over the wire. > > Prerequisite: Kevin's block branch merged with current qemu.git master, > plus my work on auto-fragmenting (v3 at the moment): >

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/6] Auto-fragment large transactions at the block layer

On Fri, Jul 15, 2016 at 12:31:58PM -0600, Eric Blake wrote: > We have max_transfer documented in BlockLimits, but while we > honor it during pwrite_zeroes, we were blindly ignoring it > during pwritev and preadv, leading to multiple drivers having > to implement fragmentation themselves. This

Re: [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand

On Tue, Jul 19, 2016 at 07:42:00AM +0200, Reda Sallahi wrote: > +struct DdIo { > +size_t bsz;/* Block size */ > +off_t offset; Oops, I did notice this. No POSIX APIs with off_t are used. Please use the QEMU block layer's int64_t type instead. Stefan signature.asc Description: PGP

Re: [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand

> tests/qemu-iotests/group | 2 + > 8 files changed, 620 insertions(+), 1 deletion(-) > create mode 100755 tests/qemu-iotests/158 > create mode 100644 tests/qemu-iotests/158.out > create mode 100755 tests/qemu-iotests/159 > create mode 100644 tests/qemu-iotests/159.out Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v2 4/7] virtio: Use aio_set_event_notifier for aio vq

On Fri, Jun 24, 2016 at 08:39:31PM +0800, Fam Zheng wrote: Commit description? For example: Distinguish between virtqueue processing in the iohandler context and main loop AioContext. iohandler context is isolated from AioContexts and therefore does not run during aio_poll(). signature.asc

Re: [Qemu-block] [PATCH v2 3/7] virtio: Introduce virtio_add_queue_aio

On Fri, Jun 24, 2016 at 08:39:30PM +0800, Fam Zheng wrote: > +VirtQueue *virtio_add_queue_aio(VirtIODevice *vdev, int queue_size, > +VirtIOHandleOutput handle_output) > +{ > +return virtio_add_queue_internal(vdev, queue_size, handle_output, true); > +} > + >

Re: [Qemu-block] [PATCH v2 1/7] virtio-bus: Drop "set_handler" parameter

On Fri, Jun 24, 2016 at 08:39:28PM +0800, Fam Zheng wrote: > It always equals to assign now. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > hw/virtio/virtio-bus.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajno

Re: [Qemu-block] [PATCH v2 2/7] virtio: Add typedef for handle_output

lude/hw/virtio/virtio.h | 5 +++-- > 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio

On Fri, Jun 24, 2016 at 08:39:32PM +0800, Fam Zheng wrote: > AIO based handler is more appropriate here because it will then > cooperate with bdrv_drained_begin/end. It is needed by the coming > revert patch. > > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 2 +- >

Re: [Qemu-block] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths

On Fri, Jun 24, 2016 at 08:39:27PM +0800, Fam Zheng wrote: > v2: Only convert virtio-{blk,scsi}. [Paolo] > > This series is based on top of Cornelia's > > [PATCH 0/6] virtio: refactor host notifiers > > The benifit is we don't use event_notifier_set_handler even in non-dataplane > now,

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] blockdev: Add dynamic module loading for block drivers

On Fri, Jun 24, 2016 at 11:37:56AM +0100, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 11:04:43AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jun 22, 2016 at 05:35:54PM -0400, Colin Lord wrote: > > > > > > > > @@ -447,8 +466,15 @@ int get_tmp_

Re: [Qemu-block] [PATCH 00/17] block: Convert common I/O path to BdrvChild

c| 24 > block/vvfat.c | 61 --- > include/block/block.h | 38 ++-- > include/block/block_int.h | 4 +- > include/sysemu/block-backend.h | 1 + > qemu-img.c | 2 +- > 33 files changed, 522 insertions(+), 459 deletions(-) Do you want to take it through your tree to avoid conflicts/dependencies? Acked-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH for-2.6 0/2] Fix regression with the default naming of throttling groups

tests/qemu-iotests/093.out | 4 +- > 3 files changed, 106 insertions(+), 5 deletions(-) > > -- > 2.8.1 > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 0/2] Fix regression with the default naming of throttling groups

+ > tests/qemu-iotests/093.out | 4 +- > 3 files changed, 105 insertions(+), 4 deletions(-) > > -- > 2.8.1 > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v6 3/4] blockdev: Add dynamic module loading for block drivers

; Makefile | 3 --- > block.c | 62 > +-- > block/Makefile.objs | 3 +-- > include/qemu/module.h | 3 +++ > util/module.c | 38 +------ > 5 files changed, 70 insertions(+), 39 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v24 00/12] Block replication for continuous checkpoints

On Wed, Jul 27, 2016 at 03:01:41PM +0800, Changlong Xie wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > You can get the detailed information about block replication from here: >

Re: [Qemu-block] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading

On Tue, Aug 02, 2016 at 10:12:14AM -0400, Colin Lord wrote: > diff --git a/vl.c b/vl.c > index e7c2c62..1a5f807 100644 > --- a/vl.c > +++ b/vl.c > @@ -506,6 +506,41 @@ static QemuOptsList qemu_fw_cfg_opts = { > }, > }; > > +static QemuOptsList qemu_iscsi_opts = { > +.name = "iscsi", >

Re: [Qemu-block] [PATCH v6 2/4] blockdev: Add dynamic generation of module_block.h

> 2 files changed, 115 insertions(+) > create mode 100644 scripts/modules/module_block.py Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH v6 4/4] blockdev: Modularize nfs block driver

On Tue, Aug 02, 2016 at 10:12:17AM -0400, Colin Lord wrote: > Modularizes the nfs block driver so that it gets dynamically loaded. > --- > block/Makefile.objs | 1 + > configure | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Stefan

Re: [Qemu-block] [Qemu-devel] [PATCH v7 00/16] backup compression

m> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Jeff Cody <jc...@redhat.com> > CC: Markus Armbruster <arm...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > CC: John Snow <js...@redhat.com> > CC: Stefan Hajnoczi <stefa...@redha

Re: [Qemu-block] [PATCH 1/1] spec/parallels: fix a mistake

f-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Stefan Hajnoczi <stefa...@redhat.com> > --- > docs/specs/parallels.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my b

Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-img: change opening method for the output in dd

On Mon, Aug 15, 2016 at 02:11:49PM +0200, Reda Sallahi wrote: > dd was creating an output image regardless of whether there was one already > created. With this patch we try to open first the output image and resize it > if necessary. > > We also make it mandatory to specify conv=notrunc when the

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command

On Wed, Feb 01, 2017 at 12:29:22PM -0800, Paolo Bonzini wrote: > On 01/02/2017 08:40, Stefan Hajnoczi wrote: > >> +goto out_free_range; > >> +} > >> + > >> +if (dma_buf_write((uint8_t *)range, sizeof(range), )) { > > > > Did y

Re: [Qemu-block] [PATCH 08/21] backup: skip unallocated clusters for full mode

On Fri, Dec 23, 2016 at 05:28:51PM +0300, Vladimir Sementsov-Ogievskiy wrote: > +if (is_top || bdrv_has_zero_init(blk_bs(job->target))) { /* * Returns 1 if newly created images are guaranteed to contain * only zeros, 0 otherwise. */ int

Re: [Qemu-block] [PATCH 00/21] new backup architecture

On Fri, Dec 23, 2016 at 05:28:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: > This is a new architecture for backup. It solves some current problems: > 1. intersecting requests: for now at request start we wait for all > intersecting requests, which means that > a. we may wait even for

Re: [Qemu-block] [PATCH 05/21] hbitmap: improve dirty iter

On Fri, Dec 23, 2016 at 05:28:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Make dirty iter resistant to resetting bits in corresponding HBitmap. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/qemu/hbitmap.h | 24 ++-- >

Re: [Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

On Fri, Dec 23, 2016 at 05:28:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > +/* init copy_bitmap from sync_bitmap */ > +static void backup_incremental_init_copy_bitmap(BackupBlockJob *job) > +{ > +int64_t sector; > +BdrvDirtyBitmapIter *dbi; > +uint32_t sect_gran = > +

Re: [Qemu-block] [PATCH 08/21] backup: skip unallocated clusters for full mode

On Fri, Dec 23, 2016 at 05:28:51PM +0300, Vladimir Sementsov-Ogievskiy wrote: > In case of full backup we can skip unallocated clusters if the target > disk is already zero-initialized. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 8

Re: [Qemu-block] [PATCH 12/21] iotests: add supported_cache_modes to main function

On Fri, Dec 23, 2016 at 05:28:55PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > tests/qemu-iotests/iotests.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Stef

Re: [Qemu-block] [PATCH 01/21] backup: move from done_bitmap to copy_bitmap

imir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/backup.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 10/21] backup: refactor backup_copy_cluster()

-- > block/trace-events | 4 ++-- > 2 files changed, 41 insertions(+), 16 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 11/21] backup: move r/w error handling code to r/w functions

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/backup.c | 141 > ++--- > 1 file changed, 74 insertions(+), 67 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 04/21] backup: use copy_bitmap in incremental backup

t; > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/backup.c | 58 > +++--- > 1 file changed, 19 insertions(+), 39 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.c

Re: [Qemu-block] [Qemu-devel] [PATCH 03/21] backup: improve non-dirty bits progress processing

On Tue, Jan 24, 2017 at 12:12:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 24.01.2017 10:17, Fam Zheng wrote: > > On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: > > > Set fake progress for non-dirty clusters in copy_bitmap initialization, > > > to: > > > 1. set progress in the same

Re: [Qemu-block] [PATCH 05/21] hbitmap: improve dirty iter

On Fri, Dec 23, 2016 at 05:28:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Make dirty iter resistant to resetting bits in corresponding HBitmap. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/qemu/hbitmap.h | 24 ++-- >

Re: [Qemu-block] [PATCH 06/21] backup: rewrite top mode cluster skipping

On Fri, Dec 23, 2016 at 05:28:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -374,6 +379,101 @@ static bool coroutine_fn yield_and_check(BackupBlockJob > *job) > return false; > } > > +static void backup_skip_clusters(BackupBlockJob *job, > + int64_t

Re: [Qemu-block] [PATCH 07/21] backup: refactor: merge top/full/incremental backup code

--- > 1 file changed, 9 insertions(+), 32 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 09/21] backup: separate copy function

ions(+), 42 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 13/21] coroutine: add qemu_coroutine_add_next

On Fri, Dec 23, 2016 at 05:28:56PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Simple add coroutine to self->co_queue_wakeup. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/qemu/coroutine.h | 2 ++ > util/qemu-coroutine.c| 7 +++ > 2 files

Re: [Qemu-block] [PATCH 16/21] hbitmap: add hbitmap_count_between() function

On Fri, Dec 23, 2016 at 05:28:59PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add this function only for HBitmap's with greanularity = 0. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Pavel Butsykin > --- >

Re: [Qemu-block] [PATCH 14/21] block: add trace point on bdrv_close_all

On Fri, Dec 23, 2016 at 05:28:57PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block.c| 1 + > block/trace-events | 1 + > 2 files changed, 2 insertions(+) Reviewed-by: S

Re: [Qemu-block] [PATCH 15/21] bitmap: add bitmap_count_between() function

On Fri, Dec 23, 2016 at 05:28:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Pavel Butsykin > --- > include/qemu/bitmap.h | 4 > util/bitmap.c | 27

Re: [Qemu-block] [PATCH] block: bdrv_invalidate_cache: invalidate children first

v_invalidate_cache is called not from bdrv_invalidate_cache_all. > > block.c | 11 +------ > 1 file changed, 5 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 17/21] backup: make all reads not serializing

they all > would be called from one place. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/backup.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 18/21] backup: new async architecture

On Fri, Dec 23, 2016 at 05:29:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: Just a few comments. I need to resume review of this series tomorrow. > diff --git a/include/block/blockjob.h b/include/block/blockjob.h > index 1acb256..7d24cf6 100644 > --- a/include/block/blockjob.h > +++

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] nvme: Implement Write Zeroes

gt; > --- > hw/block/nvme.c | 27 ++- > hw/block/nvme.h | 1 + > 2 files changed, 27 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

Re: [Qemu-block] [PATCH 18/21] backup: new async architecture

On Fri, Dec 23, 2016 at 05:29:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -120,11 +257,42 @@ static bool coroutine_fn yield_and_check(BackupBlockJob > *job) > uint64_t delay_ns = ratelimit_calculate_delay(>limit, >

Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command

On Mon, Jan 30, 2017 at 07:13:51PM +0100, Christoph Hellwig wrote: > +static uint16_t nvme_dsm_discard(NvmeCtrl *n, NvmeNamespace *ns, NvmeCmd > *cmd, > +NvmeRequest *req) > +{ > +uint16_t nr = (le32_to_cpu(cmd->cdw10) & 0xff) + 1; > +uint8_t lba_index =

[Qemu-block] [PATCH] aio-posix: honor is_external in AioContext polling

_begin() and virtio_queue_host_notifier_aio_poll() must not be called. Thanks to Fam Zheng <f...@redhat.com> for identifying the root cause of this crash. Reported-by: Alberto Garcia <be...@igalia.com> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- aio-posix.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-block] [PATCH] aio-posix: honor is_external in AioContext polling

On Tue, Jan 24, 2017 at 09:53:50AM +, Stefan Hajnoczi wrote: > AioHandlers marked ->is_external must be skipped when aio_node_check() > fails. bdrv_drained_begin() needs this to prevent dataplane from > submitting new I/O requests while another thread accesses the device

Re: [Qemu-block] blockdev-add I/O throttling parameters

On Mon, Feb 20, 2017 at 05:29:19PM +0100, Alberto Garcia wrote: > On Mon, Feb 20, 2017 at 04:45:54PM +0100, Kevin Wolf wrote: > > > I can imagine two solutions that do not need these parameters in > > > blockdev-add: > > > > > > 1. I/O throttling is implemented by a BlockDriver. Users are

Re: [Qemu-block] [RFC v6] RBD: Add support readv,writev for rbd

On Tue, Feb 21, 2017 at 03:43:59PM +0800, Jaze Lee wrote: > If I test , which cache mode i should choose ? > > writeback? or none? or default? Both cache=none and cache=writeback should be tested since block/rbd.c changes behavior depending on BDRV_O_NOCACHE. signature.asc Description: PGP

Re: [Qemu-block] [RFC PATCH V4] qemu-img: make convert async

On Mon, Feb 20, 2017 at 03:59:42PM +0100, Peter Lieven wrote: > Am 20.02.2017 um 15:50 schrieb Stefan Hajnoczi: > > On Fri, Feb 17, 2017 at 05:00:24PM +0100, Peter Lieven wrote: > > > +if (s->wr_in_order) { > > > +/* reenter the co

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-options: explain disk I/O throttling options

On Mon, Feb 20, 2017 at 01:40:21PM -0600, Eric Blake wrote: > On 02/20/2017 10:52 AM, Stefan Hajnoczi wrote: > > The disk I/O throttling options have been listed for a long time but > > never explained on the QEMU man page. > > > > Suggested-by: Nini Gu <n...@redh

Re: [Qemu-block] [PATCH] qemu-options: explain disk I/O throttling options

On Tue, Feb 21, 2017 at 11:58:00AM +0100, Alberto Garcia wrote: > On Mon 20 Feb 2017 05:52:04 PM CET, Stefan Hajnoczi wrote: > > The disk I/O throttling options have been listed for a long time but > > never explained on the QEMU man page. > > > +@item bps=@var{b},bps_

Re: [Qemu-block] [PATCH 3/3] iscsi: do not use aio_context_acquire/release

, 64 insertions(+), 19 deletions(-) Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> signature.asc Description: PGP signature

<    1   2   3   4   5   6   7   8   9   10   >