Re: [Qemu-block] [Qemu-devel] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category

dc->vmsd = _pmac; > +set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > } Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 01/10][TRIVIAL] adb: add to input category

t; amc->parent_realize = dc->realize; > dc->realize = adb_mouse_realizefn; > +set_bit(DEVICE_CATEGORY_INPUT, dc->categories); > > adc->devreq = adb_mouse_request; > dc->reset = adb_mouse_reset; Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 03/10][TRIVIAL] escc: add to input category

c_properties; > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories); > } Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 04/10][TRIVIAL] grackle: add to bridge category

ss, void *data) > { > SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); > +DeviceClass *dc = DEVICE_CLASS(klass); > > k->init = pci_grackle_init_device; > + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); > } Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 10/10][TRIVIAL] openpic: add to misc category

4 > --- a/hw/intc/openpic_kvm.c > +++ b/hw/intc/openpic_kvm.c > @@ -275,6 +275,7 @@ static void kvm_openpic_class_init(ObjectClass *oc, void > *data) > dc->realize = kvm_openpic_realize; > dc->props = kvm_openpic_properties; > dc->reset = kvm_openpic_reset; > +set_bit(DEVICE_CATEGORY_MISC, dc->categories); > } Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH 09/10][TRIVIAL] macio-nvram: add to misc category

sd = _macio_nvram; > dc->props = macio_nvram_properties; > + set_bit(DEVICE_CATEGORY_MISC, dc->categories); > } Reviewed-by: Thomas Huth <th...@redhat.com>

[Qemu-block] [PATCH] doc: Fix mailing list address in tests/qemu-iotests/README

The address of the mailing list is qemu-de...@nongnu.org instead of qemu-de...@savannah.nongnu.org. And while we're at it, also mention the qemu-block mailing list here. Signed-off-by: Thomas Huth <th...@redhat.com> --- tests/qemu-iotests/README | 3 ++- 1 file changed, 2 insertions

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/8] hw: Default -drive to if=none instead of ide when ide cannot work

/* for use with drive_add() only */ > /* > - * IF_IDE must be zero, because we want MachineClass member > - * block_default_type to default-initialize to IF_IDE > + * IF_NONE must be zero, because we want MachineClass member > + * block_default_type to default-initialize to IF_NONE > */ > -IF_IDE = 0, > -IF_NONE, > -IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN, > +IF_NONE = 0, > +IF_IDE, IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN, > IF_COUNT > } BlockInterfaceType; > > Makes sense. Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v2 4/8] hw: Default -drive to if=none instead of scsi when scsi cannot work

f --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c > index 7dac20d..3985356 100644 > --- a/hw/arm/xilinx_zynq.c > +++ b/hw/arm/xilinx_zynq.c > @@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc) > { > mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9"; > mc->init = zynq_init; > -mc->block_default_type = IF_SCSI; > mc->max_cpus = 1; > mc->no_sdcard = 1; > } Right, that looks like old copy-n-paste bugs from other machine types. Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v2 5/8] hw/arm/highbank: Default -drive to if=ide instead of if=scsi

X-2000)"; > mc->init = midway_init; > -mc->block_default_type = IF_SCSI; > +mc->block_default_type = IF_IDE; > +mc->units_per_default_bus = 1; > mc->max_cpus = 4; > } > > Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] MIPS machines (was: [PATCH v2 1/8] hw: Default -drive to if=ide explicitly where it works)

On 27.01.2017 11:21, Yongbok Kim wrote: > >>> Slightly off-topic, but: Is fulong2e still maintained? I did not spot an >>> entry in MAINTAINERS...? >> >> It's covered by the general MIPS stanza: >> >> $ scripts/get_maintainer.pl -f hw/mips/mips_fulong2e.c >> Aurelien Jarno

Re: [Qemu-block] [Qemu-devel] regarding bug name : -hda FAT:. limited to 504MBytes

Hi, On 14.02.2017 22:38, Shubham Kumar wrote: > Since the problem seems like the used FAT-16 file system , > Will it solve the problem if I change the code of vvfat.c for FAT-32 file > system to increase acceptable file size ? As far as I know, FAT16 can already support up to 4GB file

[Qemu-block] [PATCH] qemu-options: Fix broken sheepdog URL

The sheepdog URL is broken twice: First it uses a duplicated http:// prefix, second the website seems to have moved to https://sheepdog.github.io/sheepdog/ instead. Signed-off-by: Thomas Huth <th...@redhat.com> --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-block] [PATCH] option: Tweak invalid size error message and unbreak iotest 049

On 27.02.2017 13:55, Markus Armbruster wrote: > Commit 75cdcd1 neglected to update tests/qemu-iotests/049.out, and > made the error message for negative size worse. Fix that. > > Reported-by: Thomas Huth <th...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@re

[Qemu-block] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

The folder does not exist anymore, thus should be removed from the MAINTAINERS file, too. Signed-off-by: Thomas Huth <th...@redhat.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b6fb84e..ff45f8c 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [Qemu-block] [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

On 05.09.2016 13:05, Markus Armbruster wrote: > Thomas Huth <th...@redhat.com> writes: > >> On 05.09.2016 10:22, Markus Armbruster wrote: >>> Thomas Huth <th...@redhat.com> writes: >>> >>>> The folder does not exist anymore, thus

Re: [Qemu-block] [Qemu-devel] [PATCH] virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

On 05.09.2016 10:22, Markus Armbruster wrote: > Thomas Huth <th...@redhat.com> writes: > >> The folder does not exist anymore, thus should be removed from the >> MAINTAINERS file, too. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >

[Qemu-block] [PATCH] Put the copyright information on a separate line

The output string QEMU with "--version" is very long, it does not fit into a normal line of a terminal window anymore. By putting the copyright information on a separate line instead, the output looks much nicer. Signed-off-by: Thomas Huth <th...@redhat.com> --- Note: I'm

[Qemu-block] [PATCH] MAINTAINERS: Add some more headers to the IDE section

The folder include/hw/ide/ belongs to the IDE section. Signed-off-by: Thomas Huth <th...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d8a0cfc..acf6d6c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -791,6 +791,7 @@ M: Joh

Re: [Qemu-block] [Qemu-devel] [PATCH] MAINTAINERS: Add some more headers to the IDE section

On 26.09.2016 10:22, Kevin Wolf wrote: > Am 23.09.2016 um 18:42 hat John Snow geschrieben: >> On 09/23/2016 12:09 PM, Thomas Huth wrote: >>> The folder include/hw/ide/ belongs to the IDE section. >>> >>> Signed-off-by: Thomas Huth <th...@redhat.com> >&g

Re: [Qemu-block] [Qemu-devel] [PATCH] MAINTAINERS: Add Fam and Jsnow for Bitmap support

On 07.11.2016 17:40, Max Reitz wrote: > On 04.08.2016 20:18, John Snow wrote: >> These files are currently unmaintained. >> >> I'm proposing that Fam and I co-maintain them; under the model that >> whomever between us isn't authoring a given series will be responsible >> for reviewing it. >> >>

Re: [Qemu-block] [Qemu-devel] (no subject)

Hi Christopher, On 16.11.2016 20:41, Christopher Oliver wrote: > This patch (hack?) works around the slowness in SEEK_HOLE for large dense > files > on Linux tmpfs. It may improve life elsewhere as well, and the penalty of > the checks > should be vanishingly small where it is not needed. >

[Qemu-block] [PATCH] hw/block/nvme: Simplify if-statements a little bit

The condition '!A || (A && B)' is equivalent to '!A || B'. Buglink: https://bugs.launchpad.net/qemu/+bug/1464611 Signed-off-by: Thomas Huth <th...@redhat.com> --- hw/block/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/bloc

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9 5/5] MAINTAINERS: Add myself for files I touched recently

On 21.03.2017 08:17, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/20/2017 07:55 AM, Markus Armbruster wrote: >>> Signed-off-by: Markus Armbruster >>> --- >>> MAINTAINERS | 11 +++ >>> 1 file changed, 11 insertions(+) >> >> Reviewed-by:

Re: [Qemu-block] [RFC 03/19] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE

On 04.04.2017 08:53, Alexander Graf wrote: > > > On 03.04.17 23:00, Eduardo Habkost wrote: >> On Mon, Apr 03, 2017 at 10:15:44PM +0200, Alexander Graf wrote: >>> >>> >>> On 03.04.17 22:10, Eduardo Habkost wrote: On Mon, Apr 03, 2017 at 08:49:16PM +0100, Peter Maydell wrote: > On 1 April

Re: [Qemu-block] [PATCH v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo

redhat.com> > Cc: Max Reitz <mre...@redhat.com> > Cc: qemu-block@nongnu.org > Cc: Thomas Huth <th...@redhat.com> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > Changes v1 -> v2: > * Commit message rewrite only > --- > hw/block/fdc.c

[Qemu-block] [PATCH v2] Issue a deprecation warning if the user specifies the "-hdachs" option.

If the user needs to specify the disk geometry, the corresponding parameters of the "-drive" option should be used instead. "-hdachs" is considered as deprecated and might be removed soon. Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Thomas Huth <th...

Re: [Qemu-block] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.

On 26.04.2017 15:44, Paolo Bonzini wrote: > > > On 25/04/2017 10:08, Thomas Huth wrote: >> If the user needs to specify the disk geometry, the corresponding >> parameters of the "-drive" option should be used instead. "-hdachs" >> is con

[Qemu-block] [PATCH v3] Issue a deprecation warning if the user specifies the "-hdachs" option.

If the user needs to specify the disk geometry, the corresponding parameters of the "-device ide-hd" option should be used instead. "-hdachs" is considered as deprecated and might be removed soon. Signed-off-by: Thomas Huth <th...@redhat.com> --- v3: - Recommend to use

[Qemu-block] [PATCH] Issue a deprecation warning if the user specifies the "-hdachs" option.

If the user needs to specify the disk geometry, the corresponding parameters of the "-drive" option should be used instead. "-hdachs" is considered as deprecated and might be removed soon. Signed-off-by: Thomas Huth <th...@redhat.com> --- vl.c | 2 ++ 1 file changed, 2

[Qemu-block] Use after free problem somewhere in ahci.c or ich.c code

Hi! Looks like there is a use-after-free problem somewhere in the ahci.c or ich.c code when trying to add the ich9-ahci on a old PC machine. Using valgrind, I get: $ valgrind x86_64-softmmu/qemu-system-x86_64 -M pc-1.2 -nographic -S ==6604== Memcheck, a memory error detector ==6604== Copyright

Re: [Qemu-block] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

rty. >>> >>> Check for use_acpi_pci_hotplug before calling >>> acpi_pcihp_device_[un]plug_cb(). [...] >>> Reported-by: Thomas Huth <th...@redhat.com> >>> Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> >>> Signed-off-by: Philippe M

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

On 23.08.2017 07:40, Thomas Huth wrote: > On 23.08.2017 02:10, Philippe Mathieu-Daudé wrote: >> On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: >>> On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: >>>> 9e047b982452 "piix4: add acpi pc

[Qemu-block] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

. Signed-off-by: Thomas Huth <th...@redhat.com> --- v2: - Check for !qtest_enabled() since tests/hd-geo-test still uses these - Added "addr" to the list, too - Also mark the options as deprecated in the documentation blockdev.c | 14 ++ qemu-options.hx | 5 -

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: Print a warning for legacy drive options that belong to -device

On 11.05.2017 08:45, Markus Armbruster wrote: > Thomas Huth <th...@redhat.com> writes: > >> On 10.05.2017 17:55, Paolo Bonzini wrote: >>> >>> >>> On 10/05/2017 17:50, Thomas Huth wrote: >>>> We likely do not want to carry these legacy -d

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: Print a warning for legacy drive options that belong to -device

On 10.05.2017 17:50, Thomas Huth wrote: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of

[Qemu-block] [PATCH] blockdev: Print a warning for legacy drive options that belong to -device

-by: Thomas Huth <th...@redhat.com> --- blockdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/blockdev.c b/blockdev.c index 4d8cded..87a025a 100644 --- a/blockdev.c +++ b/blockdev.c @@ -797,6 +797,9 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_defaul

Re: [Qemu-block] [Qemu-devel] [PATCH] blockdev: Print a warning for legacy drive options that belong to -device

On 10.05.2017 17:55, Paolo Bonzini wrote: > > > On 10/05/2017 17:50, Thomas Huth wrote: >> We likely do not want to carry these legacy -drive options along forever. >> Let's emit a deprecation warning for the -drive options that have a >> replacement

[Qemu-block] Strange location of the "qemu-ga Invocation" chapter in the qemu-doc

Hi all, I noticed that the "qemu-ga Invocation" chapter in the QEMU doc is in a strange location - it's a sub-chapter of the "Disk images" chapter. Since the guest agent is not directly related to the handling of disk images, that sounds somewhat wrong to me - or do I miss something? Does

Re: [Qemu-block] [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

On 12.05.2017 12:33, Thomas Huth wrote: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of

Re: [Qemu-block] [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

On 12.05.2017 12:33, Thomas Huth wrote: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of

Re: [Qemu-block] [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

On 30.05.2017 07:20, Markus Armbruster wrote: > Thomas Huth <th...@redhat.com> writes: > >> We likely do not want to carry these legacy -drive options along forever. >> Let's emit a deprecation warning for the -drive options that have a >> replaceme

[Qemu-block] Dead code in cpu-models.h (was: block: Clean up some bad code in the vvfat driver)

On 19.09.2017 10:06, Paolo Bonzini wrote: > On 13/09/2017 21:08, John Snow wrote: [...] >> Farewell, bitrot code. >> >> Reviewed-by: John Snow >> >> Out of curiosity, I wonder ... >> >> jhuston@probe (foobar) ~/s/qemu> git grep '#if 0' | wc -l >> 320 > > $ git grep -c '#if 0' |

Re: [Qemu-block] [Qemu-devel] Dead code in cpu-models.h

On 19.09.2017 20:54, John Snow wrote: > > > On 09/19/2017 04:14 AM, Thomas Huth wrote: >> On 19.09.2017 10:06, Paolo Bonzini wrote: >>> On 13/09/2017 21:08, John Snow wrote: >> [...] >>>> Farewell, bitrot code. >>>> >>>> Revie

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Clean up some bad code in the vvfat driver

On 19.09.2017 21:01, John Snow wrote: > > > On 09/19/2017 04:06 AM, Paolo Bonzini wrote: >> On 13/09/2017 21:08, John Snow wrote: >>> >>> >>> On 09/13/2017 06:21 AM, Thomas Huth wrote: >>>> Remove the unnecessary home-grown redefinition of

Re: [Qemu-block] [Qemu-devel] [PATCH v7 31/38] libqtest: Merge qtest_clock_*() with clock_*()

On 12.09.2017 15:35, Eric Blake wrote: > On 09/12/2017 05:45 AM, Thomas Huth wrote: >> On 11.09.2017 19:20, Eric Blake wrote: >>> Maintaining two layers of libqtest APIs, one that takes an explicit >>> QTestState object, and the other that uses the implicit gl

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051

On 08.09.2017 13:54, Kevin Wolf wrote: > Am 08.09.2017 um 13:24 hat Cornelia Huck geschrieben: >> On Fri, 8 Sep 2017 13:04:25 +0200 >> Kevin Wolf wrote: >> >>> Am 05.09.2017 um 17:16 hat Cornelia Huck geschrieben: The default cpu model on s390x does not provide zPCI, which

Re: [Qemu-block] [PATCH v7 13/38] libqos: Use explicit QTestState for fw_cfg operations

state prior to creating > the fw_cfg (and drop a pointless strdup in the meantime), but that > test now no longer depends on global_qtest. > > Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [PATCH v7 12/38] libqos: Use explicit QTestState for virtio operations

--- > tests/libqos/virtio-pci.c | 8 ++--- > tests/libqos/virtio.c | 84 > ++ > tests/virtio-blk-test.c| 11 +++--- > 5 files changed, 94 insertions(+), 72 deletions(-) Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [PATCH v7 16/38] libqos: Use explicit QTestState for ahci operations

On 11.09.2017 19:20, Eric Blake wrote: > Drop one more client of global_qtest by teaching all ahci test > functionality to pass in an explicit QTestState. The state was > already available, so no callers had to be adjusted. > > Signed-off-by: Eric Blake <ebl...@redhat.com>

Re: [Qemu-block] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest_quit()

are updated. > > Signed-off-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [PATCH v2 3/3] iotests: use virtio aliases for 067

i -device scsi-cd,id=cd0 < { "execute": "qmp_capabilities" } > { "execute": "query-block" } > { "execute": "device_del", "arguments": { "id": "cd0" } } > @@ -150,6 +150,7 @@ run_qemu

Re: [Qemu-block] [PATCH v2 2/3] iotests: use -ccw on s390x for 051

Cornelia Huck <coh...@redhat.com> > --- > tests/qemu-iotests/051| 12 +++- > tests/qemu-iotests/051.out| 2 +- > tests/qemu-iotests/051.pc.out | 2 +- > 3 files changed, 13 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v7 28/38] libqtest: Add qtest_[v]startf()

On 12.09.2017 15:32, Eric Blake wrote: > On 09/12/2017 05:14 AM, Thomas Huth wrote: >> On 11.09.2017 19:20, Eric Blake wrote: >>> We have several callers that were formatting the argument strings >>> themselves; consolidate this effort by adding new convenience >>

Re: [Qemu-block] [Qemu-devel] [PATCH v7 09/38] libqos: Track QTestState with QVirtioBus

On 12.09.2017 15:28, Eric Blake wrote: > On 09/12/2017 02:21 AM, Thomas Huth wrote: [...] >> I fail to see why we need a separate bus object here for each device. >> The bus is only available one time, not multiple times, isn't it? So >> there should also only be one bus o

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests

On 12.09.2017 16:44, Paolo Bonzini wrote: > The purpose of this series is to separate the "check" sources from > the tests. After these patches, common.config is reduced to simple > shell initialization, and common.rc is only included by the tests. > > Along the way, a lot of dead code is

Re: [Qemu-block] [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename qpci_unplug_acpi_device_test() to pci.c

On 12.09.2017 15:28, Eric Blake wrote: > On 09/12/2017 02:29 AM, Thomas Huth wrote: >> On 11.09.2017 19:19, Eric Blake wrote: >>> Commit 2f8b2767 originally added qpci_plug_device_test() and >>> qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c. >>> L

[Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver

, it seems as it is apparently also only usable for one certain directory layout (with a file named USB.H in it) and thus is of no use for the rest of the world. Signed-off-by: Thomas Huth <th...@redhat.com> --- block/vvfat.c | 26 ++ 1 file changed, 2 insertions(+), 24 de

Re: [Qemu-block] [PATCH v7 31/38] libqtest: Merge qtest_clock_*() with clock_*()

On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-block] [PATCH v7 33/38] libqtest: Merge qtest_{in, out}[bwl]() with {in, out}[bwl]()

On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-block] [PATCH v7 28/38] libqtest: Add qtest_[v]startf()

On 11.09.2017 19:20, Eric Blake wrote: > We have several callers that were formatting the argument strings > themselves; consolidate this effort by adding new convenience > functions directly in libqtest, and update all call-sites that > can benefit from it. [...] > diff --git a/tests/libqtest.c

Re: [Qemu-block] [PATCH v7 29/38] libqtest: Merge qtest_init() into qtest_start()

On 11.09.2017 19:20, Eric Blake wrote: > Remove the trivial wrapper qtest_init(), and change qtest_start() > to no longer implicitly set global_qtest, to make it obvious in the > rest of the testsuite where we are still relying on global_qtest. > Everything now uses qtest_start() (and friends) and

Re: [Qemu-block] [PATCH v7 32/38] libqtest: Merge qtest_irq*() with irq*()

On 11.09.2017 19:20, Eric Blake wrote: > Maintaining two layers of libqtest APIs, one that takes an explicit > QTestState object, and the other that uses the implicit global_qtest, > is annoying. In the interest of getting rid of global implicit > state and having less code to maintain, merge: >

Re: [Qemu-block] [PATCH v7 10/38] libqos: Move/rename qpci_unplug_acpi_device_test() to pci.c

On 11.09.2017 19:19, Eric Blake wrote: > Commit 2f8b2767 originally added qpci_plug_device_test() and > qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c. > Later, commit cf716b31 moved one half of the pair to pci.c > when adding PPC64 support. Keep the implementations of the > two

Re: [Qemu-block] [Qemu-devel] [PATCH v6 12/29] libqos: Track QTestState with QPCIBus

On 06.09.2017 23:00, Eric Blake wrote: > On 09/05/2017 04:36 AM, Thomas Huth wrote: >> On 01.09.2017 20:03, Eric Blake wrote: >>> When initializing a QPCIBus, track which QTestState the bus is >>> associated with (so that a later patch can then explicitly use

Re: [Qemu-block] [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr, "*\n" with error_report()

-type f -exec sed -i \ > 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ > {} + > find ./* -type f -exec sed -i \ > 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ > {} + > &g

[Qemu-block] [PATCH] hw/block/onenand: Remove dead code block

The condition of the for-loop makes sure that b is always smaller than s->blocks, so the "if (b >= s->blocks)" statement is completely superfluous here. Buglink: https://bugs.launchpad.net/qemu/+bug/1715007 Signed-off-by: Thomas Huth <th...@redhat.com> --- hw/block/o

Re: [Qemu-block] [PATCH for-2.11] ide: ahci: unparent children buses before freeing their memory

vice_add() tries to unparent ich9-ahci > after failed device_set_realized(), > object_unparent() -> object_property_del_child() > iterates over existing QOM children including buses added by > ide_bus_new() and tries to unparent them, which causes access to > freed memory where they whe

[Qemu-block] [PATCH for-2.11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl) Aborted (core dumped) Looks like this device has to be wired up in code and is not meant to be hot-pluggable, so let's mark it with user_creatable = false. Signed-off-by: Thomas Huth <th...@redhat.com> --- hw/ide/microdrive

Re: [Qemu-block] [Qemu-devel] [PATCH] isa-fdc: assert replaced by proper error exit

goto error; > +} > } > > qdev_set_legacy_instance_id(dev, isa->iobase, 2); > fdctrl_realize_common(dev, fdctrl, ); > +error: > if (err != NULL) { > error_propagate(errp, err); > return; Maybe add the reproducer to the commit message: qemu-system-ppc64 -S -machine powernv -device isa-fdc Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v6 16/29] libqos: Use explicit QTestState for virtio operations

On 01.09.2017 20:03, Eric Blake wrote: > Drop one more client of global_qtest by teaching all virtio test > functionality to pass in an explicit QTestState in constructors, > where it is then reused for later access. Adjust all callers. > This gets us one step closer to eliminating implicit use

Re: [Qemu-block] [Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_qtest

(+), 95 deletions(-) Might be easier to review if you'd split the changes to libqos.c into a separate patch. But anyway: Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v6 12/29] libqos: Track QTestState with QPCIBus

On 01.09.2017 20:03, Eric Blake wrote: > When initializing a QPCIBus, track which QTestState the bus is > associated with (so that a later patch can then explicitly use > that test state for all communication on the bus, rather than > blindly relying on global_qtest). Update the initialization >

Re: [Qemu-block] [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations

On 01.09.2017 20:03, Eric Blake wrote: > Drop one more client of global_qtest by teaching all fw_cfg test > functionality (invoked through alloc-pc) to pass in an explicit > QTestState, adjusting all callers. In particular, fw_cfg-test > had to reorder things to create the test state prior to

Re: [Qemu-block] [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations

On 05.09.2017 12:12, Thomas Huth wrote: > On 01.09.2017 20:03, Eric Blake wrote: >> Drop one more client of global_qtest by teaching all fw_cfg test >> functionality (invoked through alloc-pc) to pass in an explicit >> QTestState, adjusting all callers. In particula

Re: [Qemu-block] [Qemu-devel] [PATCH v6 28/29] libqtest: Remove qtest_start() and qtest_end() shortcuts

On 01.09.2017 20:03, Eric Blake wrote: > Remove the trivial wrappers qtest_start() and qtest_end(), to make > it obvious in the rest of the testsuite where we are still relying on > global_qtest. Doing this makes it easier to see what remaining > cleanups will be needed if we don't want an

Re: [Qemu-block] [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to qtest_start()

On 01.09.2017 20:03, Eric Blake wrote: > We already have another qtest_init() in the tree, for the > top-level qtest.c device; having two functions with different > signatures is confusing. Rename the libqtest version to > qtest_start() to eliminate the duplication. This is too much code churn

Re: [Qemu-block] [PATCH 61/88] tests: use g_new() family of functions

-test.c | 2 +- > 7 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [Qemu-block] [Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

On 19.10.2017 18:18, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > diff --git a/util/aio-posix.c b/util/aio-posix.c > index

[Qemu-block] [PATCH] hw/ide/ahci: Move allwinner code into a separate file

CONFIG_ALLWINNER_A10 is set. Signed-off-by: Thomas Huth <th...@redhat.com> --- hw/ide/Makefile.objs| 1 + hw/ide/ahci-allwinner.c | 127 hw/ide/ahci.c | 95 3 files changed, 128 insertions(+), 95 del

Re: [Qemu-block] [Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

On 13.11.2017 10:43, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH] scripts/make-release: No need

[Qemu-block] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

The same definitions can also be found in include/hw/ide/ahci.h so let's remove these #defines from ahci_internal.h. Signed-off-by: Thomas Huth <th...@redhat.com> --- v2: Also remove TYPE_ICH9_AHCI as suggested by John hw/ide/ahci_internal.h | 12 1 file changed, 12 del

[Qemu-block] [PATCH 2/3] block: Remove the deprecated -hdachs option

It's been marked as deprecated since QEMU v2.10.0, and so far nobody complained that we should keep it, so let's remove this legacy option now to simplify the code quite a bit. Signed-off-by: Thomas Huth <th...@redhat.com> --- qemu-doc.texi | 8 -- qemu-options.hx | 19 ++---

[Qemu-block] [PATCH 1/3] block: Remove the obsolete -drive boot=on|off parameter

It's not working anymore since QEMU v1.3.0 - time to remove it now. Signed-off-by: Thomas Huth <th...@redhat.com> --- blockdev.c| 11 --- qemu-doc.texi | 6 -- 2 files changed, 17 deletions(-) diff --git a/blockdev.c b/blockdev.c index 56a6b24..c21ba27 100644 --- a/bloc

[Qemu-block] [PATCH 3/3] block: Mention -drive cyls/heads/secs/trans/serial/addr in deprecation chapter

Looks like we forgot to announce the deprecation of these options in the corresponding chapter of the qemu-doc text, so let's do that now. Signed-off-by: Thomas Huth <th...@redhat.com> --- qemu-doc.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qemu-doc.texi

[Qemu-block] [PATCH 0/3] block: Deprecated options

Remove the deprecated "-drive boot" and "-hdachs" options and properly mark some other deprecated options in the deprecation chapter. Thomas Huth (3): block: Remove the obsolete -drive boot=on|off parameter block: Remove the deprecated -hdachs option block: Mention -d

Re: [Qemu-block] [Qemu-devel] using "qemu-img convert -O qcow2" to convert qcow v1 to v2 creates a qcow v3 file?

On 14.11.2017 14:32, Max Reitz wrote: [...] > Well, do you want to document it? I'd rather deprecate it altogether. Maybe a first step could be to change qemu-img so that it refuses to create new qcow1 images (but still can convert them into other formats). So basically make qcow1 read-only?

Re: [Qemu-block] [Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

On 06.12.2017 23:16, John Snow wrote: > I tweaked this again, sorry: > > The names need to stay public, but the wrappers to manipulate the > objects can stay internal. Minor difference. > > If that's okay, I'll just merge this in. > OK? Sure. Feel also free to replace my "Signed-off-by" with

[Qemu-block] [PATCH for-2.12] hw/ide: Remove duplicated definitions from ahci_internal.h

The same definitions can also be found in include/hw/ide/ahci.h so let's remove these #defines from ahci_internal.h. Signed-off-by: Thomas Huth <th...@redhat.com> --- hw/ide/ahci_internal.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_inte

Re: [Qemu-block] [Qemu-devel] qemu-img crash when resize a qcow2 file created with preallocation=full/falloc .

On 24.10.2017 05:28, Changlimin wrote: > Hi, > I am glad to see that qcow2 file created with preallocation=full/falloc can > be resized. But when I test it, qemu-img crashs. > qemu-img: block/qcow2-refcount.c:530: qcow2_refcount_area: Assertion > `!(start_offset % s->cluster_size)' failed. > >

Re: [Qemu-block] [Qemu-devel] [Bug 1728615] [NEW] qemu-io crashes with SIGABRT and Assertion `c->entries[i].offset != 0' failed

On 30.10.2017 15:43, R.Nageswara Sastry wrote: > Public bug reported: > > git is at HEAD a93ece47fd9edbd4558db24300056c9a57d3bcd4 > This is on ppc64le architecture. > > Re-production steps: > > 1. Copy the attached files named backing_img.file and test.img to a directory > 2. And customize the

Re: [Qemu-block] [PATCH 0/3] block: Deprecated options

On 20.12.2017 22:40, John Snow wrote: > > > On 12/18/2017 12:14 PM, Thomas Huth wrote: >> Remove the deprecated "-drive boot" and "-hdachs" options and properly >> mark some other deprecated options in the deprecation chapter. >> >> Thomas

[Qemu-block] [PATCH v3 3/4] tests/cdrom-test: Test that -cdrom parameter is working

udé <f4...@amsat.org> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> Acked-By: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Signed-off-by: Thomas Huth <th...@redhat.com> --- tests/cdrom-test.c | 58

[Qemu-block] [PATCH v3 4/4] MAINTAINERS: Add the cdrom-test to John's section

The cdrom-test checks various block types - IDE, SCSI and virtio, so it's a little bit hard to decide where this should belong to in the MAINTAINERS file. But John volunteered to take it, so let's put it into the IDE section for now. Signed-off-by: Thomas Huth <th...@redhat.com> --- MAINT

[Qemu-block] [PATCH v3 0/4] Add new CD-ROM related qtests

) instead of execlp() to run genisoimage - The "-cdrom" parameter test is now run on all architectures (with machine "none" for the machines that are not explicitly checked) - Some rewordings and improved comments here and there Thomas Huth (4): tests/boot-sector: Add ma

[Qemu-block] [PATCH v3 2/4] tests/cdrom-test: Test booting from CD-ROM ISO image file

;f4...@amsat.org> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> Acked-By: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Signed-off-by: Thomas Huth <th...@redhat.com> --- tests/Makefile.include | 2 +

[Qemu-block] [PATCH v3 1/4] tests/boot-sector: Add magic bytes to s390x boot code header

rk.cave-ayl...@ilande.co.uk> Signed-off-by: Thomas Huth <th...@redhat.com> --- tests/boot-sector.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/boot-sector.c b/tests/boot-sector.c index c373f0e..7824286 100644 --- a/tests/boot-sector.c +++ b/tests/boo

Re: [Qemu-block] [Qemu-devel] [RFC 11/13] dp8393x: manage big endian bus

On 08.06.2018 22:05, Laurent Vivier wrote: > This is needed by Quadra 800, this card can run on little-endian > or big-endian bus. > > Signed-off-by: Laurent Vivier > --- > hw/net/dp8393x.c | 101 > ++- > 1 file changed, 70 insertions(+), 31

Re: [Qemu-block] [Qemu-devel] [RFC 00/13] hw/m68k: add Apple Machintosh Quadra 800 machine

On 09.06.2018 16:25, Philippe Mathieu-Daudé wrote: > Hi Laurent, > > On 06/08/2018 05:05 PM, Laurent Vivier wrote: >> if you want to test the machine, I'm sorry, it doesn't boot >> a MacROM, but you can boot a linux kernel from the command line. >> >> You can install your own disk using

Re: [Qemu-block] [Qemu-devel] [RFC 12/13] dp8393x: put DMA temp buffer in the state, not in the stack

On 08.06.2018 22:05, Laurent Vivier wrote: > It's only 32 bytes, and this simplifies the dp8393x_get()/ > dp8393x_put() interface. Maybe not worth the effort ... or do you need this in a later patch, too? If so, please mention it in the patch description here. > Signed-off-by: Laurent Vivier >

  1   2   3   4   5   6   7   8   9   10   >