[PATCH v2 1/6] iotests: remove 'linux' from default supported platforms

2019-10-21 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH v2 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-21 Thread Thomas Huth
for iothreads. For migration, let's enable 091, 181, 183, and 203 (which also tests iothreads). Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/group b/tests/qemu

[PATCH v2 2/6] iotests: Test 041 only works on certain systems

2019-10-21 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu

[PATCH v3 1/6] iotests: remove 'linux' from default supported platforms

2019-10-22 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH v3 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-22 Thread Thomas Huth
handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux, FreeBSD and NetBSD). Signed-off-by: Thomas Huth --- tests/qemu-iotests/183 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 index bced83fae

[PATCH v3 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-22 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this at the top level in the check-block.sh script instead (so that it is possible to run "make check" without the "check-block" part for qemu-system-tricore for example). Reviewed-by: Max Reitz Signed-o

[PATCH v3 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-22 Thread Thomas Huth
for iothreads. For migration, let's enable 091, 181, and 203 (which also tests iothreads). Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests

[PATCH v3 6/6] iotests: Remove 130 from the "auto" group

2019-10-22 Thread Thomas Huth
roup so that it does not gate the pull requests. Reviewed-by: John Snow Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 33b499ed41..4596497bce 100644 --- a/tests/qemu

[PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
erd's patches for creating NetBSD VM images) - Use 'openbsd' instead of 'openbsd6' - Use 'grep -q' instead of 'grep' for grep'ing silently - Added the patch to disable 130 from the "auto" group John Snow (1): iotests: remove 'linux' from default supported platforms Thomas Huth (5):

[PATCH v3 2/6] iotests: Test 041 only works on certain systems

2019-10-22 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 13.39, Alex Bennée wrote: > > Thomas Huth writes: > >> On 22/10/2019 09.21, Thomas Huth wrote: >>> As discussed here: >>> >>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html >>> >>> and here: &g

Re: [PATCH v4 07/16] libqos: enforce Device Initialization order

2019-10-23 Thread Thomas Huth
s/virtio.c | 7 +++ > 2 files changed, 8 insertions(+) Reviewed-by: Thomas Huth

Re: [PATCH v4 16/16] libqos: add VIRTIO PCI 1.0 support

2019-10-23 Thread Thomas Huth
anged, 476 insertions(+), 1 deletion(-) > create mode 100644 tests/libqos/virtio-pci-modern.h > create mode 100644 tests/libqos/virtio-pci-modern.c Acked-by: Thomas Huth

Re: [PATCH v4 06/16] libqos: add missing virtio-9p feature negotiation

2019-10-23 Thread Thomas Huth
n Hajnoczi > --- > tests/libqos/virtio-9p.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Thomas Huth"

Re: [PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-23 Thread Thomas Huth
-test.c | 8 ++++ > 1 file changed, 8 insertions(+) Reviewed-by: Thomas Huth"

Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step

2019-10-23 Thread Thomas Huth
-- > tests/libqos/virtio.c | 18 +++++- > 1 file changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth"

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 09.21, Thomas Huth wrote: > As discussed here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html > > and here: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html > > it would be good to have some mo

[PATCH] iotests: Remove 130 from the "auto" group

2019-10-18 Thread Thomas Huth
issue, so for the time being, let's disable it from the "auto" group so that it does not gate the pull requests. Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/gr

Re: [PATCH v2 15/23] iotests/201: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
e" > > # get standard environment, filters and checks > . ./common.rc > Reviewed-by: Thomas Huth

Re: [PATCH v2 05/23] iotests: Let common.nbd create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > In addition, drop the nbd_unix_socket assignment in 241 because it does > not really do anything. Right, common.nbd is included afterwards, so it gets overwritten. Reviewed-by: Thomas Huth

Re: [PATCH v2 13/23] iotests/192: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/192 | 4 ++-- > tests/qemu-iotests/192.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 21/23] iotests/240: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/240 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 04/23] iotests: Filter $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/common.filter | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 16/23] iotests/205: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
nbd_sock = os.path.join(iotests.sock_dir, 'nbd_sock') > nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock > disk = os.path.join(iotests.test_dir, 'disk') Reviewed-by: Thomas Huth

Re: [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd

2019-10-17 Thread Thomas Huth
\ > -e 's#\(foo\|PORT/\?\|.sock\): Failed to .*$#\1#' > } > Reviewed-by: Thomas Huth

Re: [PATCH v2 22/23] iotests/267: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/267 | 4 ++-- > tests/qemu-iotests/267.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 20/23] iotests/223: Create socket in $SOCK_DIR

2019-10-17 Thread Thomas Huth
On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/223 | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v3 07/16] libqos: enforce Device Initialization order

2019-10-22 Thread Thomas Huth
On 22/10/2019 17.48, Stefan Hajnoczi wrote: > On Mon, Oct 21, 2019 at 02:15:53PM +0200, Thomas Huth wrote: >> On 19/10/2019 08.38, Stefan Hajnoczi wrote: >>> According to VIRTIO 1.1 "3.1.1 Driver Requirements: Device >>> Initialization", configuration sp

Re: [PATCH v3 0/6] Enable more iotests during "make check-block"

2019-10-22 Thread Thomas Huth
On 22/10/2019 15.48, Alex Bennée wrote: > > Max Reitz writes: > >> On 22.10.19 15:11, Alex Bennée wrote: >>> >>> Thomas Huth writes: >>> >>>> As discussed here: >>>> >>>> https://lists.gnu.org/archive/html/qemu-de

[PATCH 3/6] tests/hd-geo-test: Skip test when images can not be created

2019-11-19 Thread Thomas Huth
In certain environments like restricted containers, we can not create huge test images. To be able to use "make check" in such container environments, too, let's skip the hd-geo-test instead of failing when the test images could not be created. Signed-off-by: Thomas Huth --- tests/hd-

[PATCH 6/6] travis.yml: Enable builds on arm64, ppc64le and s390x

2019-11-19 Thread Thomas Huth
, so we can not use the global list of packages to install, but have to provide individual package lists instead. Signed-off-by: Thomas Huth --- .travis.yml | 83 + 1 file changed, 83 insertions(+) diff --git a/.travis.yml b/.travis.yml index

[PATCH 4/6] tests/test-util-filemonitor: Skip test on non-x86 Travis containers

2019-11-19 Thread Thomas Huth
test-util-filemonitor fails in restricted non-x86 Travis containers since they apparently blacklisted some required system calls there. Let's simply skip the test if we detect such an environment. Signed-off-by: Thomas Huth --- tests/test-util-filemonitor.c | 11 +++ 1 file changed, 11

[PATCH 5/6] travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-19 Thread Thomas Huth
-off-by: Thomas Huth --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b9a026c8ee..c09b6a0014 100644 --- a/.travis.yml +++ b/.travis.yml @@ -79,7 +79,7 @@ env: - BASE_CONFIG="--disable-docs --disable-tools" - TEST

[PATCH 1/6] iotests: Skip test 060 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
Test 060 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. The repair process in test 060 creates a file of 64 GiB, so test first whether such large files are possible and skip the test if that's not the case. Signed-off-by: Thomas Huth

[PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-11-19 Thread Thomas Huth
hits the 50 minutes timeout otherwise. For the curious, here's a test run (non-x86 at the end of the page): https://travis-ci.com/huth/qemu/jobs/258095792 Thomas Alex Bennée (1): travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS Thomas Huth (5): iotests: Skip test 060

[PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
Test 079 fails in the arm64, s390x and ppc64le LXD containers, which apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file, so check first whether we can really create such files before executing the test. Signed-off-by: Thomas Huth --- tests/qemu-iotests

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
On 19/11/2019 18.50, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2019 at 06:38:20PM +0100, Philippe Mathieu-Daudé wrote: >> On 11/19/19 6:34 PM, Thomas Huth wrote: >>> On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: >>>> On 11/19/19 6:08 PM, Thomas Huth wrote: >

Re: [PATCH 2/6] iotests: Skip test 079 if it is not possible to create large files

2019-11-19 Thread Thomas Huth
On 19/11/2019 18.29, Philippe Mathieu-Daudé wrote: > On 11/19/19 6:08 PM, Thomas Huth wrote: >> Test 079 fails in the arm64, s390x and ppc64le LXD containers, which >> apparently do not allow large files to be created. Test 079 tries to >> create a 4G sparse file, so check

Re: [PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

2019-11-27 Thread Thomas Huth
On 25/11/2019 11.28, Alex Bennée wrote: Alex Bennée writes: Thomas Huth writes: Travis recently added build hosts for arm64, ppc64le and s390x, so this is a welcome addition to our Travis testing matrix. Unfortunately, the builds are running in quite restricted LXD containers

Re: [PATCH v3 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-11-27 Thread Thomas Huth
On 24/10/2019 13.14, Alex Bennée wrote: Thomas Huth writes: According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be good candidates for iothreads. For migration, let's enable 091, 181, and 203 (which also tests iothreads). @@ -112,7 +112,7

[PATCH v4 0/6] Enable more iotests during "make check-block"

2019-12-02 Thread Thomas Huth
uardo has re-activated Gerd's patches for creating NetBSD VM images) - Use 'openbsd' instead of 'openbsd6' - Use 'grep -q' instead of 'grep' for grep'ing silently - Added the patch to disable 130 from the "auto" group John Snow (1): iotests: remove 'linux' from default supported pl

[PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127

2019-12-02 Thread Thomas Huth
in iotest 267 - it has been added to the "auto" group already, but requires virtio-blk and thus currently fails with qemu-system-tricore for example. Let's also add aproper check there. Signed-off-by: Thomas Huth --- tests/qemu-iotests/127 | 2 ++ tests/qemu-iotests/267

[PATCH v4 1/6] iotests: remove 'linux' from default supported platforms

2019-12-02 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH 3/3] iotests: Skip test 079 if it is not possible to create large files

2019-12-02 Thread Thomas Huth
first whether we can really create such files before executing the test. Signed-off-by: Thomas Huth --- tests/qemu-iotests/079 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/079 b/tests/qemu-iotests/079 index 81f0c21f53..78536d3bbf 100755 --- a/tests/qemu-iotests/079

[PATCH 1/3] iotests: Provide a function for checking the creation of huge files

2019-12-02 Thread Thomas Huth
checks in the iotests 005 and 220 with this function. Signed-off-by: Thomas Huth --- tests/qemu-iotests/005 | 5 + tests/qemu-iotests/220 | 6 ++ tests/qemu-iotests/common.rc | 10 ++ 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/005

[PATCH v4 2/6] iotests: Test 041 only works on certain systems

2019-12-02 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu

[PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2019-12-02 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this a central spot in the "check" script instead (so that it is still possible to run "make check" for qemu-system-tricore for example). Signed-off-by: Thomas Huth --- tests/qemu-iotests/check |

[PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-12-02 Thread Thomas Huth
for iothreads. For migration, let's enable 181 and 203 (which also tests iothreads). (091 would be a good candidate for migration, too, but Alex Bennée reported that this test fails on ZFS file systems, so it can't be included yet) Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 14

[PATCH 2/3] iotests: Skip test 060 if it is not possible to create large files

2019-12-02 Thread Thomas Huth
and skip the test if that's not the case. Signed-off-by: Thomas Huth --- tests/qemu-iotests/060 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index b91d8321bb..d96f17a484 100755 --- a/tests/qemu-iotests/060 +++ b/tests/qemu-iotests/060

[PATCH 0/3] iotests: Check for the possibility to create large files

2019-12-02 Thread Thomas Huth
. Thomas Huth (3): iotests: Provide a function for checking the creation of huge files iotests: Skip test 060 if it is not possible to create large files iotests: Skip test 079 if it is not possible to create large files tests/qemu-iotests/005 | 5 + tests/qemu-iotests/060 | 3

Re: [Qemu-block] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface

2019-09-25 Thread Thomas Huth
On 24/09/2019 20.49, John Snow wrote: > Nobody was making movement on this patch series, and in response to Max > acking the whole series, I was just going to send a pull request for the > whole thing and see who barked, because nobody likes or hates this > series enough to offer any feedback. >

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-07 Thread Thomas Huth
On 04/10/2019 14.44, Max Reitz wrote: > On 04.10.19 12:19, Kevin Wolf wrote: >> Am 02.10.2019 um 19:47 hat Max Reitz geschrieben: >>> On 02.10.19 18:44, Kevin Wolf wrote: Am 02.10.2019 um 13:57 hat Max Reitz geschrieben: > It usually worked fine for me because it’s rather rare that

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-07 Thread Thomas Huth
On 07/10/2019 14.52, Max Reitz wrote: > On 07.10.19 14:16, Thomas Huth wrote: >> On 04/10/2019 14.44, Max Reitz wrote: >>> On 04.10.19 12:19, Kevin Wolf wrote: >>>> Am 02.10.2019 um 19:47 hat Max Reitz geschrieben: >>>>> On 02.10.19 18:44, Kevin Wolf

Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-10-07 Thread Thomas Huth
On 07/10/2019 15.11, Thomas Huth wrote: > On 07/10/2019 14.52, Max Reitz wrote: >> On 07.10.19 14:16, Thomas Huth wrote: >>> On 04/10/2019 14.44, Max Reitz wrote: >>>> On 04.10.19 12:19, Kevin Wolf wrote: >>>>> Am 02.10.2019 um 19:47 hat Max Reitz gesc

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread Thomas Huth
eter Krempa > Signed-off-by: John Snow > --- > qemu-deprecated.texi | 5 + > hw/ide/qdev.c | 3 +++ > tests/qemu-iotests/051.pc.out | 6 -- > 3 files changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 02/23] iotests.py: Store socket files in $SOCK_DIR

2019-10-11 Thread Thomas Huth
achine.py| 15 --- > python/qemu/qtest.py | 9 ++--- > tests/qemu-iotests/iotests.py | 4 +++- > 3 files changed, 21 insertions(+), 7 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 00/23] iotests: Add and use $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Hi, > > Perhaps the main reason we cannot run important tests such as 041 in CI > is that when they care Unix sockets in $TEST_DIR, the path may become > too long to connect to them. > > To get by this problem, this series lets the check script create a

Re: [PATCH 06/23] iotests/083: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/083 | 6 +++--- > tests/qemu-iotests/083.out | 34 +- > 2 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 10/23] iotests/181: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/181 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 09/23] iotests/147: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/147 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 11/23] iotests/182: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/182 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 04/23] iotests: Filter $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 11/10/2019 09.54, Max Reitz wrote: > On 10.10.19 20:42, Eric Blake wrote: >> On 10/10/19 10:24 AM, Max Reitz wrote: >>> Signed-off-by: Max Reitz >>> --- >>>   tests/qemu-iotests/common.filter | 8 ++-- >>>   1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git

Re: [PATCH 00/23] iotests: Add and use $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 11/10/2019 10.03, Max Reitz wrote: > On 11.10.19 09:27, Thomas Huth wrote: >> On 10/10/2019 17.24, Max Reitz wrote: >>> Hi, >>> >>> Perhaps the main reason we cannot run important tests such as 041 in CI >>> is that when they care Unix sockets i

Re: [PATCH 07/23] iotests/140: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/140 | 8 > tests/qemu-iotests/140.out | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 08/23] iotests/143: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/143 | 6 +++--- > tests/qemu-iotests/143.out | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 12/23] iotests/183: Create socket in $SOCK_DIR

2019-10-11 Thread Thomas Huth
On 10/10/2019 17.24, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/183 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH] iotests/028: Fix for long $TEST_DIRs

2019-10-11 Thread Thomas Huth
On 11/10/2019 11.07, Max Reitz wrote: > For long test image paths, the order of the "Formatting" line and the > "(qemu)" prompt after a drive_backup HMP command may be reversed. It is > not well-defined anyway, so just silence everything and wait until we > get a

[PATCH 5/5] iotests: Enable more tests in the 'auto' group to improve test coverage

2019-10-11 Thread Thomas Huth
for iothreads. For migration, let's enable 091, 181, 183, and 203 (which also tests iothreads). Signed-off-by: Thomas Huth --- tests/qemu-iotests/group | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index

[PATCH 1/5] iotests: remove 'linux' from default supported platforms

2019-10-11 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH 3/5] iotests: Test 183 does not work on macOS and OpenBSD

2019-10-11 Thread Thomas Huth
When running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it fails with an "Timeout waiting for return on handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux and FreeBSD). Signed-off-by: Thomas Huth --- tests/qe

[PATCH 4/5] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-11 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this at the top level in the check-block.sh script instead (so that it is possible to run "make check" without the "check-block" part for qemu-system-tricore for example). Signed-off-by: Thomas Huth

[PATCH 2/5] iotests: Test 041 does not work on macOS

2019-10-11 Thread Thomas Huth
041 works fine on Linux, FreeBSD and OpenBSD, so let's mark it as only supported on these systems. Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 8568426311

[PATCH 0/5] Enable more iotests during "make check-block"

2019-10-11 Thread Thomas Huth
with binaries like qemu-system-tricore anymore. But since the iotests were not very useful with such binaries anyway, I think it's ok now if we skip them there. Based-on: 20191010152457.17713-1-mre...@redhat.com John Snow (1): iotests: remove 'linux' from default supported platforms Thomas Huth

Re: [PATCH 4/5] iotests: Skip "make check-block" if QEMU does not support virtio-blk

2019-10-14 Thread Thomas Huth
On 14/10/2019 13.21, Kevin Wolf wrote: > Am 11.10.2019 um 16:50 hat Thomas Huth geschrieben: >> The next patch is going to add some python-based tests to the "auto" >> group, and these tests require virtio-blk to work properly. Running >> iotests without virtio-bl

Re: [PATCH v2] iotests/028: Fix for long $TEST_DIRs

2019-10-11 Thread Thomas Huth
Formatting" to being greppable at all after "read"-ing it (if the > prompt injects an IFS character into the "Formatting" string). > > So just wait until we get a prompt. At that point, the block job must > have been started, so "info block-jobs" will onl

[PATCH v2] iotests: Add more "skip_if_unsupported" statements to the python tests

2019-12-18 Thread Thomas Huth
The python code already contains a possibility to skip tests if the corresponding driver is not available in the qemu binary - use it in more spots to avoid that the tests are failing if the driver has been disabled. Signed-off-by: Thomas Huth --- v2: Thanks to Max' "iotests: Allow ski

[PATCH] iotests: Add more "_require_drivers" checks to the shell-based tests

2019-12-18 Thread Thomas Huth
Test 051 should be skipped if nbd is not available, and 267 should be skipped if copy-on-read is not enabled. Signed-off-by: Thomas Huth --- tests/qemu-iotests/051 | 1 + tests/qemu-iotests/267 | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051

Re: [PATCH] iotests/279: Fix for non-qcow2 formats

2020-01-27 Thread Thomas Huth
img_info > --backing-chain --image-opts \ > +| _filter_img_info | grep -v 'backing file format' > > # success, all done > echo "*** done" > This fixes the problems with "check -qed 279" and "check -vmdk 279" for me. Tested-by: Thomas Huth

[PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum

2020-01-29 Thread Thomas Huth
Commit d9df28e7b07 ("iotests: check whitelisted formats") added the modern @iotests.skip_if_unsupported() to the functions in this test, so we don't need the old explicit test here anymore. Signed-off-by: Thomas Huth --- tests/qemu-iotests/139 | 3 --- 1 file changed, 3 deletions(-)

Re: [PATCH v5 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2020-01-30 Thread Thomas Huth
On 30/01/2020 23.31, Philippe Mathieu-Daudé wrote: > On 1/21/20 10:52 AM, Thomas Huth wrote: >> We are going to enable some of the python-based tests in the "auto" >> group, >> and these tests require virtio-blk to work properly. Running iotests >> without vir

Re: Pre-Christmas meeting notes

2020-01-09 Thread Thomas Huth
On 09/01/2020 16.03, Vladimir Sementsov-Ogievskiy wrote: > 06.01.2020 20:15, Max Reitz wrote: >> Misc >> >> >> The Wiki’s TODO list is horribly outdated. What should we do about >> it? Maybe archive it and start a new one? (Most of the things on the >> current list are either done or we

[PATCH v3] iotests: Add more "skip_if_unsupported" statements to the python tests

2020-01-14 Thread Thomas Huth
iotests.supports_quorum() - and which were apparently not working as expected since the tests aborted instead of being skipped when "quorum" was missing in the QEMU binary. Signed-off-by: Thomas Huth --- v3: - Remove the old iotests.supports_quorum()-based tests - Check for "t

[PATCH] docs/devel: Fix qtest paths and info about check-block in testing.rst

2020-01-22 Thread Thomas Huth
The qtests have recently been moved to a separate subdirectory, so the paths that are mentioned in the documentation have to be adjusted accordingly. And some of the iotests are now always run as part of "make check", so this information has to be adjusted here, too. Signed-off-by: T

Re: [PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2020-01-20 Thread Thomas Huth
On 20/01/2020 15.50, Max Reitz wrote: > On 02.12.19 11:10, Thomas Huth wrote: >> We are going to enable some of the python-based tests in the "auto" group, >> and these tests require virtio-blk to work properly. Running iotests >> without virtio-blk likely does not

Re: [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2020-01-20 Thread Thomas Huth
On 20/01/2020 15.36, Max Reitz wrote: > On 02.12.19 11:10, Thomas Huth wrote: >> In the long term, we might want to add test 183 to the "auto" group >> (but it still fails occasionally, so we cannot do that yet). However, >> when running 183 in Cirrus-CI on macO

[PATCH v5 0/6] Enable more iotests during "make check-block"

2020-01-21 Thread Thomas Huth
'grep -q' instead of 'grep' for grep'ing silently - Added the patch to disable 130 from the "auto" group John Snow (1): iotests: remove 'linux' from default supported platforms Thomas Huth (5): iotests: Test 041 only works on certain systems iotests: Test 183 does not work on macOS

[PATCH v5 1/6] iotests: remove 'linux' from default supported platforms

2020-01-21 Thread Thomas Huth
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PATCH v5 3/6] iotests: Test 183 does not work on macOS and OpenBSD

2020-01-21 Thread Thomas Huth
handle 0" error. Let's mark it as supported only on systems where the test is working most of the time (i.e. Linux, FreeBSD and NetBSD). Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/183 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/183 b/te

[PATCH v5 2/6] iotests: Test 041 only works on certain systems

2020-01-21 Thread Thomas Huth
041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v5 4/6] iotests: Check for the availability of the required devices in 267 and 127

2020-01-21 Thread Thomas Huth
in iotest 267 - it has been added to the "auto" group already, but requires virtio-blk and thus currently fails with qemu-system-tricore for example. Let's also add aproper check there. Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/127 | 2 ++ te

[PATCH v5 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage

2020-01-21 Thread Thomas Huth
for iothreads. For migration, let's enable 181 and 203 (which also tests iothreads). (091 would be a good candidate for migration, too, but Alex Bennée reported that this test fails on ZFS file systems, so it can't be included yet) Reviewed-by: Max Reitz Signed-off-by: Thomas Huth --- tests/qemu

[PATCH v5 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk

2020-01-21 Thread Thomas Huth
every test (which does not sound very appealing), let's rather add a check for this a central spot in the "check" script instead (so that it is still possible to run "make check" for qemu-system-tricore for example). Signed-off-by: Thomas Huth --- tests/qemu-iotests/check | 12 ++

[PATCH] gitlab-ci: Refresh the list of iotests

2020-01-21 Thread Thomas Huth
ew iotests have been added to the QEMU repository in the past months, so we can now add some new test > 256 instead. Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d9a90f

Re: Priority of -accel

2020-01-08 Thread Thomas Huth
On 08/01/2020 14.24, Paolo Bonzini wrote: > On 08/01/20 14:10, Daniel P. Berrangé wrote: >> On Wed, Jan 08, 2020 at 01:41:59PM +0100, Paolo Bonzini wrote: >>> On 08/01/20 11:58, Thomas Huth wrote: >>>>> "-accel default" could be considered to have vibes

Re: [PATCH v2] iotests: Add more "skip_if_unsupported" statements to the python tests

2020-01-14 Thread Thomas Huth
On 19/12/2019 13.19, Kevin Wolf wrote: > Am 18.12.2019 um 15:43 hat Thomas Huth geschrieben: >> The python code already contains a possibility to skip tests if the >> corresponding driver is not available in the qemu binary - use it >> in more spots to avoid that

Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-07 Thread Thomas Huth
On 06/01/2020 14.09, Philippe Mathieu-Daudé wrote: > Commit 6f6e1698a6 desugarized "-machine accel=" to a list > of "-accel" options. Since now "-machine accel" and "-accel" > became incompatible, update the iotests to the new format. > > Error reported here: >

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-07 Thread Thomas Huth
On 07/01/2020 11.14, Paolo Bonzini wrote: > On 07/01/20 11:03, Thomas Huth wrote: >>> >>> vm = QEMUMachine(iotests.qemu_prog) >>> -vm.add_args('-machine', 'accel=kvm:tcg') >>> +vm.add_args('-accel', 'kvm', '-accel', 'tcg') >> Looking at this, I wond

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-07 Thread Thomas Huth
On 07/01/2020 15.37, Paolo Bonzini wrote: > On 07/01/20 14:55, Christophe de Dinechin wrote: >> So what about ranking the accelerators, so that all combinaisons >> -accel=kvm:tcg, -accel=tcg:kvm, -accel kvm -accel tcg, etc would > > (I assume you mean "-machine accel=kvm:tcg" and "-machine

Re: Priority of -accel

2020-01-07 Thread Thomas Huth
On 07/01/2020 15.27, Daniel P. Berrangé wrote: > On Tue, Jan 07, 2020 at 03:20:40PM +0100, Philippe Mathieu-Daudé wrote: >> On 1/7/20 3:14 PM, Thomas Huth wrote: >>> On 07/01/2020 13.54, Daniel P. Berrangé wrote: >>>> On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bo

Re: [PATCH] iotests: fix usage -machine accel= together with -accel option

2020-01-07 Thread Thomas Huth
On 23/12/2019 09.39, Paolo Bonzini wrote: > On 23/12/19 08:43, Vladimir Sementsov-Ogievskiy wrote: >> diff --git a/vl.c b/vl.c >> index 86474a55c9..9fb859969c 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2779,7 +2779,7 @@ static void configure_accelerators(const char >> *progname) >> for

<    1   2   3   4   5   6   7   8   9   10   >