On 11/08/2021 13.08, Peter Maydell wrote:
On Wed, 11 Aug 2021 at 11:00, Thomas Huth wrote:
The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY
points to a non-existing binary. Let's improve this situation by checking
for the availability of the binary first, so we can
On 15/10/2021 12.07, Paolo Bonzini wrote:
Hi all,
Starting with Meson 0.57, "meson test" has all features of QEMU's
makefile-based harness and more.
I just gave it a try, and basically I like this ... but I also encountered
two issues:
* CTRL+C will only interrupt the longest running
On 29/09/2021 07.30, ~farzon wrote:
From: Farzon Lotfi
Hi!
Thanks for your contribution! However, there are some more rules that need
to be followed to get a patch accepted in the QEMU project:
Please provide a proper patch description for your changes (something like:
"QEMU coding
The lsi53c895a SCSI adaptor might not be enabled in each and every
x86 QEMU binary, e.g. it's disabled in the RHEL/CentOS build.
Thus let's add a check to the 051 test so that it does not fail if
this device is not available.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/051 | 4
1
The lsi53c895a SCSI controller might have been disabled in the target
binary, so let's check for its availability first before using it.
Signed-off-by: Thomas Huth
---
tests/qtest/hd-geo-test.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/hd-geo-test.c
On 15/11/2021 08.12, Alistair Francis wrote:
On Mon, Nov 15, 2021 at 3:32 PM Markus Armbruster wrote:
Peter Maydell writes:
On Fri, 12 Nov 2021 at 13:34, Markus Armbruster wrote:
Thomas Huth writes:
On 03/11/2021 09.41, Markus Armbruster wrote:
Peter Maydell writes:
Does it make
Hi!
I think it has been working fine for me a couple of weeks ago,
but when I now run:
make check SPEED=slow
I'm getting a couple of failing iotests... not sure whether
these are known issues already, so I thought I'd summarize them
here:
*** First one is 045 in raw mode: ***
TEST
On 17/11/2021 11.59, Hanna Reitz wrote:
On 17.11.21 11:07, Thomas Huth wrote:
Hi!
I think it has been working fine for me a couple of weeks ago,
but when I now run:
make check SPEED=slow
I'm getting a couple of failing iotests... not sure whether
these are known issues already, so I
++--
tests/qemu-iotests/210.out | 6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
Thanks, this fixes the failure on my system!
Tested-by: Thomas Huth
On 17/11/2021 19.13, John Snow wrote:
On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <mailto:th...@redhat.com>> wrote:
Hi!
I think it has been working fine for me a couple of weeks ago,
but when I now run:
make check SPEED=slow
I'm getting a couple o
On 17/11/2021 20.59, John Snow wrote:
On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <mailto:th...@redhat.com>> wrote:
On 17/11/2021 19.13, John Snow wrote:
>
>
> On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth mailto:th...@redhat.com>
> <mailto:
{'selinux': selinux}
... then meson prints out the version of the library, too.
Apart from that, patch looks fine to me:
Reviewed-by: Thomas Huth
On 22/11/2021 08.49, Rao, Lei wrote:
From: "Rao, Lei"
In commit 5024340745 "qapi/qom: Drop deprecated 'props' from
object-add" (v6.0.0), we also should update documents.
Signed-off-by: Lei Rao
---
docs/COLO-FT.txt| 16
docs/system/authz.rst | 26
On 02/11/2021 12.34, Paolo Bonzini wrote:
On 28/10/21 20:59, Thomas Huth wrote:
Checking for xfsctl() can be done more easily in meson.build. Also,
this is not a "real" feature like the other features that we provide
with the "--enable-xxx" and "--disable-xxx" swi
On 26/10/2021 19.10, Richard Henderson wrote:
On 10/26/21 9:34 AM, Stefan Hajnoczi wrote:
On Tue, Oct 26, 2021 at 08:10:16AM -0700, Richard Henderson wrote:
On 10/26/21 6:22 AM, Stefan Hajnoczi wrote:
If "safe" TLS variables are opt-in then we'll likely have obscure bugs
when code changes to
On 01/11/2021 18.30, John Snow wrote:
Swap out the synchronous QEMUMonitorProtocol from qemu.qmp with the sync
wrapper from qemu.aqmp instead.
Add an escape hatch in the form of the environment variable
QEMU_PYTHON_LEGACY_QMP which allows you to cajole QEMUMachine into using
the old
On 03/11/2021 09.41, Markus Armbruster wrote:
Peter Maydell writes:
Does it make sense for a device/board to do drive_get_next(IF_NONE) ?
Short answer: hell, no! ;)
Would it make sense to add an "assert(type != IF_NONE)" to drive_get() to
avoid such mistakes in the future?
Thomas
On 10/12/2021 09.39, Paolo Bonzini wrote:
On 12/10/21 08:53, Thomas Huth wrote:
On 02/11/2021 12.34, Paolo Bonzini wrote:
On 28/10/21 20:59, Thomas Huth wrote:
Checking for xfsctl() can be done more easily in meson.build. Also,
this is not a "real" feature like the other featur
On 10/12/2021 11.10, Paolo Bonzini wrote:
On 12/10/21 09:46, Thomas Huth wrote:
platform_test_xfs_fd() is only used to decide whether to invoke
XFS_IOC_DIOINFO; but failures of XFS_IOC_DIOINFO are ignored anyway, so
we can get rid of is_xfs in BDRVRawState, too.
After staring at the code
e. Thus let's simplify this by providing the ioctl definition
on our own, so we can completely get rid of the header dependency and
thus the related code in the configure script.
Suggested-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
block/file-posix.c | 37 --
On 02/11/2021 12.34, Paolo Bonzini wrote:
On 28/10/21 20:59, Thomas Huth wrote:
Checking for xfsctl() can be done more easily in meson.build. Also,
this is not a "real" feature like the other features that we provide
with the "--enable-xxx" and "--disable-xxx" swi
On 20/07/2021 03.12, Eric Blake wrote:
On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote:
Hi,
iotest 206 fails for me with:
--- 206.out
+++ 206.out.bad
@@ -99,55 +99,19 @@
{"execute": "blockdev-create", "arguments": {"job-id": "j
Hi,
iotest 206 fails for me with:
$ ./check -qcow2 206
QEMU -- ".../tests/qemu-iotests/../../qemu-system-x86_64"
-nodefaults -display none -accel qtest
QEMU_IMG -- ".../tests/qemu-iotests/../../qemu-img"
QEMU_IO -- ".../tests/qemu-iotests/../../qemu-io" --cache writeback
On 21/07/2021 19.22, Daniel P. Berrangé wrote:
Peter caught the following transient fail on the staging tree:
https://gitlab.com/qemu-project/qemu/-/jobs/1438817749
--- /builds/qemu-project/qemu/tests/qemu-iotests/197.out
+++ 197.out.bad
@@ -12,13 +12,12 @@
128 KiB, X ops; XX:XX:XX.X (XXX
huge reads (which is likely also the reason
why they haven't been added to the "auto" group in the past), so let's
simply disable them in the gitlab-CI now, too.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/buildtest.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
On 15/01/2022 23.21, Paolo Bonzini wrote:
"meson test" can be asked to run tests verbosely; this makes it usable
also for qemu-iotests's own harness, and it lets "make check-block"
reuse mtest2make.py's infrastructure to find and build test dependencies.
Adjust check-block.sh to use the
as
direct program or as a wrapper around "sed" if it's the GNU version)
in the spots that rely on the GNU sed behavior. Then we also remove the
sed checks from the check-block.sh script, so that "make check-block"
can now be run on systems without GNU sed, too.
Signed-off-by:
On 15/02/2022 14.51, Daniel P. Berrangé wrote:
On Tue, Feb 15, 2022 at 02:28:24PM +0100, Thomas Huth wrote:
On 11/02/2022 17.48, Thomas Huth wrote:
On 11/02/2022 17.14, Eric Blake wrote:
On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote:
The current code with $SED has been
On 11/02/2022 17.48, Thomas Huth wrote:
On 11/02/2022 17.14, Eric Blake wrote:
On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote:
The current code with $SED has been introduced almost three years
ago already...
Can’t we just do `alias sed=gsed`?
Maybe ... but let's ask
On 11/02/2022 17.14, Eric Blake wrote:
On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote:
The current code with $SED has been introduced almost three years
ago already...
Can’t we just do `alias sed=gsed`?
Maybe ... but let's ask Philippe and Kevin first, who Signed-off
commit
config_host
+if targetos == 'linux' and 'CONFIG_VHOST_USER' in config_host
libvhost_user = subproject('libvhost-user')
vhost_user = libvhost_user.get_variable('vhost_user_dep')
endif
Reviewed-by: Thomas Huth
On 07/03/2022 09.05, Marc-André Lureau wrote:
Hi
On Mon, Mar 7, 2022 at 11:46 AM Thomas Huth <mailto:th...@redhat.com>> wrote:
On 07/03/2022 08.03, marcandre.lur...@redhat.com
<mailto:marcandre.lur...@redhat.com> wrote:
> From: Marc-André Lureau mailto:marcandre
On 07/03/2022 08.03, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
glib provides a convenience helper to measure elapsed time. It isn't
subject to wall-clock time changes.
Note that this changes the initial OPENED time, which used to print the
current time.
[...]
@@ -846,21
/commands-win32.c | 19 ---
qga/commands.c | 5 +
3 files changed, 5 insertions(+), 33 deletions(-)
Reviewed-by: Thomas Huth
On 04/03/2022 17.57, Daniel P. Berrangé wrote:
On Tue, Feb 08, 2022 at 07:44:32AM -0500, Paolo Bonzini wrote:
This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The
TAP output is inferior in that it does not include the diff for
failed tests.
Reported-by: Peter Maydell
On 15/03/2022 20.30, Peter Maydell wrote:
On Tue, 15 Mar 2022 at 18:58, Peter Maydell wrote:
On Tue, 15 Mar 2022 at 11:20, Thomas Huth wrote:
Hi Peter!
The following changes since commit 352998df1c53b366413690d95b35f76d0721ebed:
Merge tag 'i2c-20220314' of https://github.com/philmd
On 16/03/2022 12.15, Halil Pasic wrote:
On Wed, 16 Mar 2022 11:28:59 +0100
Thomas Huth wrote:
On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must
On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must be declared prior to
its usage. This avoids having a global configure time define, but also
prevents from
On 16/03/2022 14.16, Philippe Mathieu-Daudé wrote:
On 16/3/22 10:52, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
One less qemu-specific macro. It also helps to make some headers/units
only depend on glib, and thus moved in standalone projects eventually.
Signed-off-by:
Meson 0.61.3 contains an important fix which helps to see the
output of failed qemu-iotests on the console again:
https://gitlab.com/qemu-project/meson/-/commit/7534cf34f83b9c43
Signed-off-by: Thomas Huth
---
meson | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson b
Meson 0.61.3 contains an important fix which helps to see the
output of failed qemu-iotests on the console again:
https://gitlab.com/qemu-project/meson/-/commit/7534cf34f83b9c43
Acked-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
v2: Update the version in the configure script, too
ge of not getting
the detailed progress indication there anymore, but since that was
only working right in single-threaded "make -j1" mode anyway, it's
not a huge loss right now.
Signed-off-by: Thomas Huth
---
v4: updated commit description
meson.build| 6 +++---
These two spots have been missed in commit 9086c7639822 ("Rework the
checks and spots using GNU sed") - they need GNU sed, too, since they
are using the "+" address form.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/common.filter | 4 ++--
1 file changed, 2 insert
On 09/03/2022 11.24, Philippe Mathieu-Daudé wrote:
Hi Alex, Thomas, Daniel,
Could you ack this patch?
Basically fine for me, but can we really run additional cirrus-ci jobs by
default? IIRC the parallel execution of those were quite limited for the
free tier, so did you look close that we
On 06/02/2022 20.19, Jon Maloy wrote:
Trying again with correct email address.
///jon
On 2/6/22 14:15, Jon Maloy wrote:
On 1/27/22 15:14, Jon Maloy wrote:
On 11/18/21 06:57, Philippe Mathieu-Daudé wrote:
Trivial fix for CVE-2021-3507.
Philippe Mathieu-Daudé (2):
hw/block/fdc: Prevent
On 09/03/2022 13.50, Philippe Mathieu-Daudé wrote:
Would it be beneficial to have a 1 per OS job during PR, and
other jobs run nightly (once a day, not per PR)?
Is there a way to trigger nightly runs in gitlab?
Thomas
On 15/02/2022 23.10, Eric Blake wrote:
On Tue, Feb 15, 2022 at 02:20:31PM +0100, Thomas Huth wrote:
Instead of failing the iotests if GNU sed is not available (or skipping
them completely in the check-block.sh script), it would be better to
simply skip the bash-based tests that rely on GNU sed
orted build hosts
(most also support "-r", but macOS' sed only supports "-E"). With all
these changes in place, we then can also remove the sed checks from the
check-block.sh script, so that "make check-block" can now be run on
systems without GNU sed, too.
Signed-off-by: T
- so thanks for fixing this pro-actively! Now the test is
correctly skipped on my system.
Tested-by: Thomas Huth
On 21/02/2022 18.08, Hanna Reitz wrote:
Some test cases run in iotest 065 require zstd support. Skip them if
qemu-img reports it not to be available.
Reported-by: Thomas Huth
Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type")
Signed-off-by: Hanna Reitz
---
Quoting the TAP specification: "The plan tells how many tests will be
run [...]. It’s a check that the test file hasn’t stopped prematurely."
That's a good idea of course, so let's support that in the iotest
testrunner, too.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/testrun
orted build hosts
(most also support "-r", but macOS' sed only supports "-E"). With all
these changes in place, we then can also remove the sed checks from the
check-block.sh script, so that "make check-block" can now be run on
systems without GNU sed, too.
Reviewed-by: Phili
hould hopefully help to diagnose problems with the
iotests in most cases more easily.
[*] See v2 here:
https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg01942.html
Thomas Huth (4):
tests/qemu-iotests: Rework the checks and spots using GNU sed
tests/qemu-iotests/meson.build: Improve the
We want to get rid of check-block.sh in the long run, so let's move
the checks for the bash version and sanitizers from check-block.sh
into the meson.build file instead.
Signed-off-by: Thomas Huth
---
tests/check-block.sh | 26 --
tests/qemu-iotests/meson.build
By using subdir_done(), we can get rid of one level of indentation
in this file. This will make it easier to add more conditions to
skip the iotests in future patches.
Reviewed-by: Hanna Reitz
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/meson.build
it's nicer and easier if we simply do not treat the
iotests as separate test target anymore and integrate them along
with the other test suites.
Signed-off-by: Thomas Huth
---
meson.build| 6 +++---
scripts/mtest2make.py | 4
tests/Makefile.include | 9 +
3 files changed, 4
if 'throttle' has not been enabled in the QEMU
binaries.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/040 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 6af5ab9e76..0e1cfd7e49 100755
--- a/tests/qemu-iotests/040
+++ b/tests/qemu-iotests
-whitelist=copy-before-write,qcow2,raw,file,host_device,blkdebug,null-co,copy-on-read
so that iotest 041 will report that some tests are not run due to
the missing "quorum" driver. Without this change, "make check-block"
fails since the meson tap parser gets confused by these me
On 01/02/2022 15.42, Hanna Reitz wrote:
From: Vladimir Sementsov-Ogievskiy
The test checks different options. It of course fails if set
IMGOPTS='compression_type=zstd'. So, let's be explicit in what
compression type we want and independent of IMGOPTS. Test both existing
compression types.
Bulekov
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542
CVE: CVE-2021-3611
Message-Id: <20211218160912.1591633-3-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
hw/audio/intel-hda.c | 2 +-
1 file changed, 1 ins
whether these "owner" lines
really still make that much sense if they are neglected that much, or
whether the information should maybe rather be captured in MAINTAINERS instead?
Anyway:
Reviewed-by: Thomas Huth
remove "inline"]
Signed-off-by: Thomas Huth
---
include/exec/memattrs.h | 9 +
softmmu/physmem.c | 44 +++--
2 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/include/exec/memattrs.h b/include/exec/memattrs.h
index 95f2d2
: AddressSanitizer: stack-overflow softmmu/physmem.c:356 in
address_space_translate_internal
==1580408==ABORTING
Broken pipe
Aborted (core dumped)
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Thomas Huth
Message-Id: <20211218160912.1591633-4-phi...@redhat.com>
Signed-off-by: Thoma
fd
==447470==ABORTING
Broken pipe
ERROR qtest-i386/fuzz-sdcard-test - too few tests run (expected 3, got 2)
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Thomas Huth
Message-Id: <20211215205656.488940-4-phi...@redhat.com>
[thuth: Replaced "-m 4G" with "-m 512M"
), triggering a
re-entrancy issue.
Fix by prohibit transactions from the DMA to devices. The DMA engine
is thus restricted to memories.
Reported-by: OSS-Fuzz (Issue 36391)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/451
60912.1591633-2-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
hw/audio/intel-hda.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index 5f8a878f20..47a36acc71 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-h
On 21/03/2022 17.14, Hanna Reitz wrote:
On 23.02.22 10:38, Thomas Huth wrote:
Though "make check-block" is currently already run via the meson test
runner, it still looks like an oddball in the output of "make check". It
would be nicer if the iotests would show up like th
On 21/03/2022 14.11, Hanna Reitz wrote:
On 21.03.22 10:17, Thomas Huth wrote:
On 21/03/2022 10.06, Hanna Reitz wrote:
On 18.03.22 18:36, Thomas Huth wrote:
On 18/03/2022 18.04, Hanna Reitz wrote:
On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently
The following changes since commit 2058fdbe81e2985c226a026851dd26b146d3395c:
Merge tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu into
staging (2022-03-19 11:28:54 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-request-2022-03-21
ed-off-by: Thomas Huth
---
softmmu/physmem.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 43ae70fbe2..3d968ca92f 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -2816,14 +2816,11 @@ static MemTxResult flatview
hieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20211215205656.488940-2-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
hw/sd/sdhci.c | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index e0bbc90344..f
and 303 on my system!
Series
Tested-by: Thomas Huth
On 21/03/2022 10.06, Hanna Reitz wrote:
On 18.03.22 18:36, Thomas Huth wrote:
On 18/03/2022 18.04, Hanna Reitz wrote:
On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently not logged to
the console anymore. To get this working again, we need to run
available or whether CFLAGS contain -fsanitize switches)
to the meson.build file now, and add the environment variables
that have been set up by the tests/check-block.sh script before.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/meson.build | 45 --
1 file c
Now that the iotests are added by the meson.build file already,
we do not need the check-block.sh wrapper script anymore.
Signed-off-by: Thomas Huth
---
tests/check-block.sh | 73
1 file changed, 73 deletions(-)
delete mode 100755 tests/check
.sh script.
[*] Alternatively, I think we could also get rid of the "auto" group
and add the test list to the tests/qemu-iotests/meson.build file
directly ... not sure whether that's so much nicer, though.
Thomas Huth (6):
tests/qemu-iotests: Improve the check for GNU sed
as "not run" if GNU sed is not available. Then we can also
remove the sed checks from the check-block.sh script.
Signed-off-by: Thomas Huth
---
tests/check-block.sh | 12
tests/qemu-iotests/common.rc | 26 +-
2 files changed, 13 insertions(+), 25
By using subdir_done(), we can get rid of one level of indentation
in this file. This will make it easier to add more conditions to
skip the iotests in future patches.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/meson.build | 61 ++
1 file changed, 32
been built. Re-order
the code in the "check" a little bit so that we can use the -n option
without building the binaries first.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check | 52 ++--
1 file changed, 29 insertions(+), 23 deletions(-)
diff --git
Now that we add the single iotests directly in meson.build, we do
not have to separate the block suite from the other suites anymore.
Signed-off-by: Thomas Huth
---
meson.build| 6 +++---
scripts/mtest2make.py | 4
tests/Makefile.include | 9 +
3 files changed, 4
On 08/02/2022 11.26, Peter Maydell wrote:
On Tue, 8 Feb 2022 at 10:18, Thomas Huth wrote:
Now that we add the single iotests directly in meson.build, we do
not have to separate the block suite from the other suites anymore.
Signed-off-by: Thomas Huth
---
meson.build| 6
On 08/02/2022 12.46, Hanna Reitz wrote:
On 08.02.22 11:13, Thomas Huth wrote:
Instead of failing the iotests if GNU sed is not available (or skipping
them completely in the check-block.sh script), it would be better to
simply skip the bash-based tests, so that the python-based tests could
still
On 08/02/2022 13.28, Hanna Reitz wrote:
On 08.02.22 13:13, Thomas Huth wrote:
On 08/02/2022 12.46, Hanna Reitz wrote:
On 08.02.22 11:13, Thomas Huth wrote:
Instead of failing the iotests if GNU sed is not available (or skipping
them completely in the check-block.sh script), it would be better
On 08/02/2022 14.11, Philippe Mathieu-Daudé wrote:
On 8/2/22 13:38, Thomas Huth wrote:
On 08/02/2022 13.28, Hanna Reitz wrote:
On 08.02.22 13:13, Thomas Huth wrote:
On 08/02/2022 12.46, Hanna Reitz wrote:
On 08.02.22 11:13, Thomas Huth wrote:
Instead of failing the iotests if GNU sed
On 08/02/2022 13.36, Paolo Bonzini wrote:
On 2/8/22 11:13, Thomas Huth wrote:
We can get a nicer progress indication if we add the iotests
individually via the 'check' script instead of going through
the check-block.sh wrapper.
For this, we have to add some of the sanity checks that have
On 08/02/2022 14.12, Hanna Reitz wrote:
On 08.02.22 11:13, Thomas Huth wrote:
We can get a nicer progress indication if we add the iotests
individually via the 'check' script instead of going through
the check-block.sh wrapper.
For this, we have to add some of the sanity checks that have
ot;make check-block SPEED=thorough"
- Improve bash version check
- Rewrite the 'Allow to run "./check -n"' patch to be less ugly
- Add patch to print the "diff" of the iotests to stderr, so that
it shows up in TAP mode, too
Thomas Huth (8):
tests/qemu-iotests/testrunner: A
By using subdir_done(), we can get rid of one level of indentation
in this file. This will make it easier to add more conditions to
skip the iotests in future patches.
Reviewed-by: Hanna Reitz
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/meson.build
as "not run" if GNU sed is not available. Then we can also
remove the sed checks from the check-block.sh script.
Signed-off-by: Thomas Huth
---
tests/check-block.sh | 12
tests/qemu-iotests/common.rc | 26 +-
2 files changed, 13 insertions(+), 25
available or whether CFLAGS contain -fsanitize switches)
to the meson.build file now, and add the environment variables
that have been set up by the tests/check-block.sh script before.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/meson.build | 44 +++---
1 file c
Now that we add the single iotests directly in meson.build, we do
not have to separate the block suite from the other suits anymore.
Signed-off-by: Thomas Huth
---
meson.build| 6 +++---
scripts/mtest2make.py | 4
tests/Makefile.include | 9 +
3 files changed, 4
When running in TAP mode, stdout is reserved for the TAP protocol.
To see the "diff" of the failed test, we have to print it to
stderr instead.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/testrunner.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/
t. To fix this,
skip the check for the binaries while setting up the TestEnv.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check | 2 +-
tests/qemu-iotests/testenv.py | 9 -
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-
If multiple tests run in parallel, they must use unique file
names for the test output.
Suggested-by: Hanna Reitz
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/testrunner.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu
On 10/02/2022 15.51, Christian Borntraeger wrote:
Am 10.02.22 um 15:47 schrieb Vladimir Sementsov-Ogievskiy:
10.02.2022 10:57, Christian Borntraeger wrote:
Hello,
I do see spurious failures of 161 in our CI, but only when I use
make check with parallelism (-j).
I have not yet figured out
On 11/02/2022 10.29, Kevin Wolf wrote:
Am 09.02.2022 um 11:15 hat Thomas Huth geschrieben:
If multiple tests run in parallel, they must use unique file
names for the test output.
Suggested-by: Hanna Reitz
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/testrunner.py | 2 +-
1 file
1 file changed, 76 insertions(+)
Acked-by: Thomas Huth
On 20/01/2022 12.05, Philippe Mathieu-Daudé wrote:
From: Michael Tokarev
For a long time, we assumed that libxml2 is neecessary for parallels
block format support (block/parallels*). However, this format actually
does not use libxml [*]. Since this is the only user of libxml2 in
while qemu
b.com/qemu-project/vbootrom.git
[submodule "tests/lcitool/libvirt-ci"]
path = tests/lcitool/libvirt-ci
- url = http://gitlab.com/libvirt/libvirt-ci
+ url = https://gitlab.com/libvirt/libvirt-ci.git
Reviewed-by: Thomas Huth
7 files changed, 2 insertions(+), 14 deletions(-)
I think this should touch ./scripts/meson-buildoptions.sh , too?
If you also remove it from that file:
Reviewed-by: Thomas Huth
801 - 900 of 1251 matches
Mail list logo
