Re: [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

2020-03-21 Thread Aleksandar Markovic
12:47 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Fix trivial warnings reported by the Clang static code analyzer. > Philippe, It would be useful and customary for this type of fixes to provide here the environment you used for obtaining the warnings (clang version, configure

Re: [PATCH-for-5.0 01/11] block: Remove dead assignment

2020-03-21 Thread Aleksandar Markovic
12:49 PM Sub, 21.03.2020. Philippe Mathieu-Daudé је написао/ла: > > Fix warning reported by Clang static code analyzer: > > block.c:3167:5: warning: Value stored to 'ret' is never read > ret = bdrv_fill_options(, filename, , _err); > ^

Re: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment

2020-03-21 Thread Aleksandar Markovic
On Saturday, March 21, 2020, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC hw/ide/sii3112.o > hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read > val = 0; > ^ ~ > > Reported-by: Clang Static

Re: [PATCH v3 1/4] scripts/simplebench: add simplebench.py

2020-03-17 Thread Aleksandar Markovic
On Mon, Mar 2, 2020 at 10:05 PM Aleksandar Markovic wrote: > > > > > > >> + > > >> + > > >> +def ascii_one(result): > > >> +"""Return ASCII representation of bench_one() returned dict.""" > &g

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-15 Thread Aleksandar Markovic
On Monday, March 16, 2020, Philippe Mathieu-Daudé wrote: > Move out x86-specific structures from generic machine code. > > Philippe, I a kind of have hard time understanding what is achieved with this patch. Is this pure code moving/reorganization? What is the logical connection between this

Re: [PATCH v2 1/8] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-15 Thread Aleksandar Markovic
On Monday, March 16, 2020, Aleksandar Markovic wrote: > > > On Monday, March 16, 2020, Philippe Mathieu-Daudé > wrote: > >> Move out x86-specific structures from generic machine code. >> >> > Philippe, > > I a kind of have hard time understanding what i

Re: [EXTERNAL][PATCH 0/7] via-ide: fixes and improvements

2020-03-13 Thread Aleksandar Markovic
> From: Mark Cave-Ayland > This patchset effectively updates the VIA IDE PCI device to follow the > behaviour in the datasheet in two ways: fixing some PCI configuration > space register defaults and behaviours, and always using legacy IRQ 14/15 > routing, and once applied allows all our known

Re: [PATCH v3 1/4] scripts/simplebench: add simplebench.py

2020-03-02 Thread Aleksandar Markovic
--- - - - > > backup-1 backup-2 mirror > > ssd -> ssd 0.43 +-0.004.48 +-0.064.38 +-0.02 > > ssd -> hdd 10.60 +-0.08 10.69 +-0.18 10.57 +-0.05 > > ssd -> nbd 33.81 +-0.37 10.67 +-0.17 1

Re: [PATCH v3 3/4] scripts/simplebench: add example usage of simplebench

2020-02-28 Thread Aleksandar Markovic
) > And final call of simplebench API. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- In future, it would be perhaps useful to add option to output results in the format of csv (comma separated values) (or similar) - it would simplify import to other data presentation tools. In any case: Re

Re: [PATCH v3 4/4] MAINTAINERS: add simplebench

2020-02-28 Thread Aleksandar Markovic
On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy wrote: > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Aleksandar Markovic > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > inde

Re: [PATCH v3 2/4] scripts/simplebench: add qemu/bench_block_job.py

2020-02-28 Thread Aleksandar Markovic
On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy wrote: > > Add block-job benchmarking helper functions. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Aleksandar Markovic > scripts/simplebench/bench_block_job.py | 119 +

Re: [PATCH v3 1/4] scripts/simplebench: add simplebench.py

2020-02-28 Thread Aleksandar Markovic
g number, using something like this: s = ' {:.2f} +-{:.2f}'.format(result['average'], result['delta']) The resulting table would look like: -- - - ----- backup-1 backup-2 mirror ssd -> ssd 0.43 +-0.004.48 +-0

Re: [PATCH RESEND v2 07/32] hw/mips: Use memory_region_init_rom() with read-only regions

2020-02-26 Thread Aleksandar Markovic
On Monday, February 24, 2020, Philippe Mathieu-Daudé wrote: > This commit was produced with the Coccinelle script > scripts/coccinelle/memory-region-housekeeping.cocci. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Aleksandar Markovic Will be applied to the

Re: [PATCH v2] configure: Avoid compiling system tools on user build by default

2020-02-17 Thread Aleksandar Markovic
11:00 AM Pon, 17.02.2020. Philippe Mathieu-Daudé је написао/ла: > > From: Philippe Mathieu-Daudé > > User-mode does not need the sytem tools. system > Do not build them by > default if user specified --disable-system. specifies > > This disables building the following binary on a user-only

Re: [PATCH] configure: Avoid compiling system tools on user build by default

2020-02-16 Thread Aleksandar Markovic
5:23 PM Sub, 15.02.2020. Philippe Mathieu-Daudé је написао/ла: > > User-mode does not need the sytem tools. Do not build them by > default if user specified --disable-system. > > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 11 ++- > 1 file changed, 10 insertions(+), 1

Re: Can we retire Python 2 now?

2019-12-21 Thread Aleksandar Markovic
On Saturday, December 21, 2019, Paolo Bonzini wrote: > On 20/12/19 17:29, Markus Armbruster wrote: > > Python 2 EOL is only a few days away[*]. We made configure bitch about > > it in commit e5abf59eae "Deprecate Python 2 support", 2019-07-01. Any > > objections to retiring it now, i.e. in

Re: [PATCH for-5.0 v2 0/3] benchmark util

2019-11-27 Thread Aleksandar Markovic
On Tue, Nov 26, 2019 at 4:49 PM Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > Here is simple benchmarking utility, to generate performance > comparison tables, like the following: > > -- - - - > backup-1 backup-2 mirror

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-19 Thread Aleksandar Markovic
On Tue, Nov 19, 2019 at 10:14 PM Aleksandar Markovic wrote: > > On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: > > > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > > > Merge remote-tracking branch > > 'remotes

Re: [PULL for-4.2-rc2 0/2] Tracing patches

2019-11-19 Thread Aleksandar Markovic
On Tue, Nov 19, 2019 at 9:46 PM Stefan Hajnoczi wrote: > > The following changes since commit f086f22d6c068ba151b0f6e81e75a64f130df712: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-fixes-20191118.0' > into staging (2019-11-18 21:35:48 +) > > are available in the Git

Re: [RFC v5 026/126] python: add commit-per-subsystem.py

2019-11-11 Thread Aleksandar Markovic
e close to the top of the file on script usage? Or "--help" option? If you would like to be the script maintainer, please change the MAINTAINERS too. Reviewed-by: Aleksandar Markovic > > CC: Gerd Hoffmann > CC: "Gonglei (Arei)" > CC: Eduardo Habkost > CC: Igor Mammedo

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Aleksandar Markovic
09.09.2019. 18.32, "Aleksandar Markovic" је написао/ла: > > > 09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > > > Co-developed-by: Mark Cave-Ayland > > Signed-off-by: Mark Cave-Ayland > > Signed-off-by: Laurent Vivier > > Revie

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-09 Thread Aleksandar Markovic
09.09.2019. 18.03, "Laurent Vivier" је написао/ла: > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > Reviewed-by: Hervé Poussineau > --- Laurent, hi! I am not sure how "Co-developed-by:" fits in our workflow. There was some recent talk

Re: [Qemu-block] [Qemu-devel] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

2019-05-27 Thread Aleksandar Markovic
On May 27, 2019 3:32 PM, "Aleksandar Markovic" wrote: > > > On May 26, 2019 1:07 AM, "Laurent Vivier" wrote: > > > > If you want to test the machine, it doesn't yet boot a MacROM, but you can > > boot a linux kernel from the command line. >

Re: [Qemu-block] [Qemu-devel] [PATCH v7 10/10] hw/m68k: define Macintosh Quadra 800

2019-05-27 Thread Aleksandar Markovic
On May 26, 2019 1:07 AM, "Laurent Vivier" wrote: > > If you want to test the machine, it doesn't yet boot a MacROM, but you can > boot a linux kernel from the command line. > > You can install your own disk using debian-installer with: > > ./qemu-system-m68k \ > -M q800 \ > -serial