VirtIO specification?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
lowed to
> fail.)
>
> Signed-off-by: John Snow
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
John Snow writes:
> There is a bug in this version,
> see: https://github.com/pylint-dev/pylint/issues/9751
>
> Signed-off-by: John Snow
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
/machine/machine.py:345:52: E0606: Possibly using variable 'sock' before
> assignment (possibly-used-before-assignment)
> qemu/utils/qemu_ga_client.py:168:4: R1711: Useless return at end of function
> or method (useless-return)
>
> Signed-off-by: John Snow
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Fabiano Rosas writes:
> Alex Bennée writes:
>
>> Juan Quintela writes:
>>
>>> From: Fabiano Rosas
>>>
>>> Add a smoke test that migrates to a file and gives it to the
>>> script. It should catch the most annoying errors such as changes in
addest);
> +#ifndef _WIN32
> +qtest_add_func("/migration/analyze-script", test_analyze_script);
> +#endif
> qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plain);
> qtest_add_func("/migration/precopy/unix/xbzrle",
> test_precopy_unix_xbzrle);
> /*
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 66795cfcd2..d6022ebd64 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -357,6 +357,8 @@ foreach dir : target_dirs
> test_deps += [qsd]
>endif
>
> + qtest_env.set('PYTHON', python.full_path())
> +
>foreach test : target_qtests
> # Executables are shared across targets, declare them only the first
> time we
> # encounter them
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
nitor or stderr), and in
>> a uniform format.
>> Use error_printf() & friends to print additional information.
>
> This commit changes fprintfs that report warnings and errors to the
> appropriate report functions.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Sig
le that are used for tracing
> into tracepoints.
>
> Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
le that are used for tracing
> into tracepoints.
>
> Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
s file that are used for tracing
> into trace events. Errors or warnings are converted to error_report and
> warn_report calls.
>
> Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
s file that are used for tracing
> into trace events. DPRINTFs that report guest errors are logged with
> LOG_GUEST_ERROR.
>
> Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
s file that are used for tracing
> into trace events. DPRINTFs that report guest errors are logged with
> LOG_GUEST_ERROR.#
>
> Signed-off-by: Manos Pitsidianakis
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
}
> -/*
> - * We need to zero'ify the space that is not copied
> - * from file
> - */
> -if (file_size < mem_size) {
> - res = address_space_set(as ? as :
> &address_space_memory,
> -addr + file_size, 0,
> -mem_size - file_size,
> -MEMTXATTRS_UNSPECIFIED);
> -if (res != MEMTX_OK) {
> -goto fail;
> -}
> -}
> }
> }
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Alex Bennée writes:
> A lot of our vhost-user stubs are large chunks of boilerplate that do
> (mostly) the same thing. This series continues the cleanups by
> splitting the vhost-user-base and vhost-user-generic implementations.
> After adding a new vq_size property the rng, gpio a
Philippe Mathieu-Daudé writes:
> On 4/1/24 22:09, Alex Bennée wrote:
>> Lets keep a cleaner split between the base class and the derived
>> vhost-user-device which we can use for generic vhost-user stubs. This
>> includes an update to introduce the vq_size property so the nu
Lets keep a cleaner split between the base class and the derived
vhost-user-device which we can use for generic vhost-user stubs. This
includes an update to introduce the vq_size property so the number of
entries in a virtq can be defined.
Signed-off-by: Alex Bennée
---
v5
- s/parent
esolve the error, remove the duplicate property from
vhost-user-input-pci.
Signed-off-by: Leo Yan
Reviewed-by: Manos Pitsidianakis
Message-Id: <20231120043721.50555-5-leo@linaro.org>
Signed-off-by: Alex Bennée
---
include/hw/virtio/virtio-input.h | 6 +-
hw/virtio/vhost-user-input-p
Message-Id: <20231120043721.50555-2-leo@linaro.org>
Signed-off-by: Alex Bennée
---
hw/virtio/vhost-user-base.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/hw/virtio/vhost-user-base.c b/hw/virtio/vhost-user-base.c
index 78cfa9a5bbc..a83167191ee 100644
--- a/hw/virtio
Now we can take advantage of our new base class and make
vhost-user-rng a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Signed-off-by: Alex Bennée
---
v5
- don't remove the i
Now the new base class supports config handling we can take advantage
and make vhost-user-gpio a much simpler boilerplate wrapper. Also as
this doesn't require any target specific hacks we only need to build
the stubs once.
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by:
v4
- dropped the F_TRANSPORT work for another series
- added vhost-user-sound
Alex Bennée (6):
virtio: split into vhost-user-base and vhost-user-device
hw/virtio: convert vhost-user-base to async shutdown
hw/virtio: derive vhost-user-rng from vhost-user-base
hw/virtio: derive vhost-user-
Now we can take advantage of the new base class and make
vhost-user-i2c a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
---
v7
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
---
v5
- split vhost-user-device out of the table
- sort the table alphabetically
- add sound and scmi devices
v6
- add note re vhost-user-device
v7
- fix patching description
---
docs
From: Leo Yan
This adds basic documentation for vhost-user-input.
Signed-off-by: Leo Yan
Message-Id: <20231120043721.50555-3-leo@linaro.org>
Signed-off-by: Alex Bennée
---
MAINTAINERS | 1 +
docs/system/device-emulation.rst | 1 +
docs/
-pci,chardev=vsnd,id=snd \
/path/to/disk
[AJB: imported from
https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch]
Signed-off-by: Alex Bennée
Signed-off-by: Manos Pitsidianakis
---
v7
- s/parent/parent_obj/
- add MAINTAINERS
- add
y: Leo Yan
Reviewed-by: Manos Pitsidianakis
Message-Id: <20231120043721.50555-4-leo@linaro.org>
Signed-off-by: Alex Bennée
---
MAINTAINERS | 2 +-
hw/{input => virtio}/vhost-user-input.c | 0
hw/input/meson.build| 1 -
hw
We are about to convert at least one stubs which was using the async
teardown so lets use it for all the cases.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost-user-base.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/virtio/vhost-user-base.c b/hw
"Michael S. Tsirkin" writes:
> On Tue, Nov 07, 2023 at 06:07:45PM +, Alex Bennée wrote:
>> A lot of our vhost-user stubs are large chunks of boilerplate that do
>> (mostly) the same thing. This series continues the cleanups by
>> splitting the vhost-u
"Michael S. Tsirkin" writes:
> On Mon, Nov 06, 2023 at 07:15:09PM +, Alex Bennée wrote:
>> A lot of our vhost-user stubs are large chunks of boilerplate that do
>> (mostly) the same thing. This series continues the cleanups by
>> splitting the vhost-u
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
---
v5
- split vhost-user-device out of the table
- sort the table alphabetically
- add sound and scmi devices
v6
- add note re vhost-user-device
v7
- fix patching description
---
docs
Lets keep a cleaner split between the base class and the derived
vhost-user-device which we can use for generic vhost-user stubs. This
includes an update to introduce the vq_size property so the number of
entries in a virtq can be defined.
Signed-off-by: Alex Bennée
---
v5
- s/parent
Now we can take advantage of the new base class and make
vhost-user-i2c a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
---
v7
Now the new base class supports config handling we can take advantage
and make vhost-user-gpio a much simpler boilerplate wrapper. Also as
this doesn't require any target specific hacks we only need to build
the stubs once.
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by:
Now we can take advantage of our new base class and make
vhost-user-rng a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Signed-off-by: Alex Bennée
---
v5
- don't remove the i
-pci,chardev=vsnd,id=snd \
/path/to/disk
[AJB: imported from
https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch]
Signed-off-by: Alex Bennée
Signed-off-by: Manos Pitsidianakis
---
v7
- s/parent/parent_obj/
- add MAINTAINERS
- add
We are about to convert at least one stubs which was using the async
teardown so lets use it for all the cases.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost-user-base.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/virtio/vhost-user-base.c b/hw
ilure)
v6
- re-base to current master
- make vhost-user-device abstract
- mention abstractness in docs
v5
- addressing comments and tags
- improved the docs
v4
- dropped the F_TRANSPORT work for another series
- added vhost-user-sound
Alex Bennée (6):
virtio: split into vhost-use
r
- make vhost-user-device abstract
- mention abstractness in docs
v5
- addressing comments and tags
- improved the docs
v4
- dropped the F_TRANSPORT work for another series
- added vhost-user-sound
Alex Bennée (6):
virtio: split into vhost-user-base and vhost-user-device
hw/virti
-pci,chardev=vsnd,id=snd \
/path/to/disk
[AJB: imported from
https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch]
Signed-off-by: Alex Bennée
Signed-off-by: Manos Pitsidianakis
---
v7
- s/parent/parent_obj/
- add MAINTAINERS
- add
Now we can take advantage of the new base class and make
vhost-user-i2c a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
---
v7
We are about to convert at least one stubs which was using the async
teardown so lets use it for all the cases.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost-user-base.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/virtio/vhost-user-base.c b/hw
Now the new base class supports config handling we can take advantage
and make vhost-user-gpio a much simpler boilerplate wrapper. Also as
this doesn't require any target specific hacks we only need to build
the stubs once.
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by:
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-7-alex.ben...@linaro.org>
---
v5
- split vhost-user-device out of the table
- sort the table alphabetically
- add sound and scmi devices
v6
- add n
Now we can take advantage of our new base class and make
vhost-user-rng a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Signed-off-by: Alex Bennée
---
v5
- don't remove the i
Lets keep a cleaner split between the base class and the derived
vhost-user-device which we can use for generic vhost-user stubs. This
includes an update to introduce the vq_size property so the number of
entries in a virtq can be defined.
Signed-off-by: Alex Bennée
---
v5
- s/parent
"Michael S. Tsirkin" writes:
> On Mon, Nov 06, 2023 at 07:15:10PM +, Alex Bennée wrote:
>> Lets keep a cleaner split between the base class and the derived
>> vhost-user-device which we can use for generic vhost-user stubs. This
>> includes an update to introd
"Michael S. Tsirkin" writes:
> On Mon, Nov 06, 2023 at 07:15:10PM +, Alex Bennée wrote:
>> Lets keep a cleaner split between the base class and the derived
>> vhost-user-device which we can use for generic vhost-user stubs. This
>> includes an update to introd
"Michael S. Tsirkin" writes:
> On Mon, Nov 06, 2023 at 05:30:39PM +, Alex Bennée wrote:
>> "Michael S. Tsirkin" writes:
>>
>> > On Thu, Oct 19, 2023 at 10:56:07AM +0100, Alex Bennée wrote:
>> >> Now the new base class supports config
Lets keep a cleaner split between the base class and the derived
vhost-user-device which we can use for generic vhost-user stubs. This
includes an update to introduce the vq_size property so the number of
entries in a virtq can be defined.
Signed-off-by: Alex Bennée
Message-Id
addressing comments and tags
- improved the docs
v4
- dropped the F_TRANSPORT work for another series
- added vhost-user-sound
Alex Bennée (5):
virtio: split into vhost-user-base and vhost-user-device
hw/virtio: derive vhost-user-rng from vhost-user-base
hw/virtio: derive vhost-user
land
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-5-alex.ben...@linaro.org>
---
include/hw/virtio/vhost-user-i2c.h | 14 +-
hw/virtio/vhost-user-i2c.c | 272 ++---
hw/virtio/meson.build | 5 +-
3
Now we can take advantage of our new base class and make
vhost-user-rng a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.
t;
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-4-alex.ben...@linaro.org>
---
include/hw/virtio/vhost-user-gpio.h | 23 +-
hw/virtio/vhost-user-gpio.c | 406 ++--
hw/virtio/meson.build
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-7-alex.ben...@linaro.org>
---
v5
- split vhost-user-device out of the table
- sort the table alphabetically
- add sound and scmi devices
v6
- add n
-pci,chardev=vsnd,id=snd \
/path/to/disk
[AJB: imported from
https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch]
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-6-alex.ben...@linaro.org>
---
include/hw/virtio/vhost-user
"Michael S. Tsirkin" writes:
> On Thu, Oct 19, 2023 at 10:56:05AM +0100, Alex Bennée wrote:
>> Lets keep a cleaner split between the base class and the derived
>> vhost-user-device which we can use for generic vhost-user stubs. This
>> includes an update to introd
"Michael S. Tsirkin" writes:
> On Thu, Oct 19, 2023 at 10:56:07AM +0100, Alex Bennée wrote:
>> Now the new base class supports config handling we can take advantage
>> and make vhost-user-gpio a much simpler boilerplate wrapper. Also as
>> this doesn't requi
Alex Bennée writes:
> A lot of our vhost-user stubs are large chunks of boilerplate that do
> (mostly) the same thing. This series continues the cleanups by
> splitting the vhost-user-base and vhost-user-generic implementations.
> After adding a new vq_size property the rng, gpio a
sort of overview document in our
manual for how Xen guests are supported under KVM?
>-append "loglvl=all -- console=hvc0 root=/dev/xvda1"
>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Viresh Kumar writes:
> On 19-10-23, 10:56, Alex Bennée wrote:
>> From: Manos Pitsidianakis
>>
>> Tested with rust-vmm vhost-user-sound daemon:
>>
>> RUST_LOG=trace cargo run --bin vhost-user-sound -- --socket
>> /tmp/snd.sock --backend null
&g
t;
Acked-by: Mark Cave-Ayland
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-4-alex.ben...@linaro.org>
---
include/hw/virtio/vhost-user-gpio.h | 23 +-
hw/virtio/vhost-user-gpio.c | 407 ++--
hw/virtio/meson.build
land
Acked-by: Viresh Kumar
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-5-alex.ben...@linaro.org>
---
include/hw/virtio/vhost-user-i2c.h | 14 +-
hw/virtio/vhost-user-i2c.c | 272 ++---
hw/virtio/meson.build | 5 +-
3
Lets keep a cleaner split between the base class and the derived
vhost-user-device which we can use for generic vhost-user stubs. This
includes an update to introduce the vq_size property so the number of
entries in a virtq can be defined.
Signed-off-by: Alex Bennée
Message-Id
-pci,chardev=vsnd,id=snd \
/path/to/disk
[AJB: imported from
https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch]
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-6-alex.ben...@linaro.org>
---
include/hw/virtio/vhost-user
Now we can take advantage of our new base class and make
vhost-user-rng a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Acked-by: Mark Cave-Ayland
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.
her series
- added vhost-user-sound
Alex Bennée (5):
virtio: split into vhost-user-base and vhost-user-device
hw/virtio: derive vhost-user-rng from vhost-user-base
hw/virtio: derive vhost-user-gpio from vhost-user-base
hw/virtio: derive vhost-user-i2c from vhost-user-base
docs/system: a
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
Message-Id: <20231009095937.195728-7-alex.ben...@linaro.org>
---
v5
- split vhost-user-device out of the table
- sort the table alphabetically
- add sound and scmi devices
---
docs/
Manos Pitsidianakis writes:
> On Mon, 09 Oct 2023 12:59, Alex Bennée wrote:
>>diff --git a/hw/virtio/meson.build b/hw/virtio/meson.build
>>index 51c3f97c2d..d0b963199c 100644
>>--- a/hw/virtio/meson.build
>>+++ b/hw/virtio/meson.build
>>@@ -18,8 +18,15 @@ if
Signed-off-by: Alex Bennée
Acked-by: Mark Cave-Ayland
---
v2
- use new vhost-user-base
- move build to common code
v3
- fix inadvertent double link
v4
- merge conflict
- update includes
---
include/hw/virtio/vhost-user-gpio.h | 23 +-
hw/virtio/vhost-user-gpio.c
and
Signed-off-by: Alex Bennée
---
v2
- new derivation layout
- move directly to softmmu_virtio_ss
v3
- use vqsize
---
include/hw/virtio/vhost-user-rng.h | 11 +-
hw/virtio/vhost-user-rng.c | 278 +++--
hw/virtio/meson.build | 11 +-
3 files
-pci,chardev=vsnd,id=snd \
/path/to/disk
[AJB: imported from
https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch]
Signed-off-by: Alex Bennée
---
v1
- import and test
---
include/hw/virtio/vhost-user-snd.h | 26 +++
hw/virtio/vhost
and
Signed-off-by: Alex Bennée
---
v2
- update to new inheritance scheme
- move build to common code
v3
- fix merge conflict in meson
- style updates, remove duplicate includes
v4
- use vqsize
---
include/hw/virtio/vhost-user-i2c.h | 14 +-
hw/virtio/vhost-user-i2c.c
Lets keep a cleaner split between the base class and the derived
vhost-user-device which we can use for generic vhost-user stubs. This
includes an update to introduce the vq_size property so the number of
entries in a virtq can be defined.
Signed-off-by: Alex Bennée
---
v1
- merge and re-base
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
---
v2
- make clear vhost-user-device for expert use
---
docs/system/devices/vhost-user-rng.rst | 2 ++
docs/system/devices/vhost-user.rst | 41 ++
2 files changed, 43
for F_TRANSPORT are a bit more
invasive and still need a bit of debugging but I wanted to get this
stuff merged now.
Alex Bennée (5):
virtio: split into vhost-user-base and vhost-user-device
hw/virtio: derive vhost-user-rng from vhost-user-base
hw/virtio: derive vhost-user-gpio from vhost-user-b
^
>
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14:
> note: previous declaration is here
> extern char *optarg;/* getopt(3) external
> variables */
My same raised eyebrows are how exactly getopt.h is getting included b
>
> case TARGET_SYS_EXIT:
> case TARGET_SYS_EXIT_EXTENDED:
> +{
> +uint32_t ret;
> +
I suspect this could just as well be an int with an explicit cast for ret = arg1
because the consumers are all expecting int anyway.
Otherwise:
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14:
> note: previous declaration is here
> extern char *optarg;/* getopt(3) external
> variables */
I'm going to assume the getopt.h is somehow swept up by osdep.h?
Anyway:
A
Matias Ezequiel Vara Larsen writes:
> On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote:
>> In theory we shouldn't need to repeat so much boilerplate to support
>> vhost-user backends. This provides a generic vhost-user-base QOM
>> object and a derived vhost
Albert Esteve writes:
> Sorry to bring up this post, it's been a while since you posted.
> But I have been testing the patch the last couple of days.
>
> On Mon, Jul 10, 2023 at 9:58 PM Michael S. Tsirkin wrote:
>
> On Mon, Jul 10, 2023 at 04:35:12PM +0100, Alex Bennée
se file as CD-ROM image on the default bus of the emulated machine
> +(which is IDE1 master on x86, so you cannot use ``-hdc`` and ``-cdrom``
> +at the same time there). On systems that support it, you can use the
> +host CD-ROM by using ``/dev/cdrom`` as filename.
> ERST
>
> DEF("blockdev", HAS_ARG, QEMU_OPTION_blockdev,
Otherwise:
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Make it clear the vhost-user-device is intended for expert use only.
Signed-off-by: Alex Bennée
---
v2
- make clear vhost-user-device for expert use
---
docs/system/devices/vhost-user-rng.rst | 2 ++
docs/system/devices/vhost-user.rst | 41 ++
2 files changed, 43
Now we can take advantage of the new base class and make
vhost-user-i2c a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Signed-off-by: Alex Bennée
---
v2
- update to new inheritance scheme
- move bui
This will be useful if we end up having to consider initialising the
virtqs at a seperate time.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost.c | 60 ---
1 file changed, 41 insertions(+), 19 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio
Instead of requiring all the information up front allow the
vhost_dev_init to complete and then see what information we have from
the backend.
This does change the order around somewhat.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost-user-device.c | 45 +--
1
)
which the back-end can advertise which allows a probe message to be
sent to get all the details QEMU needs to know in one message.
Signed-off-by: Alex Bennée
---
Initial RFC for discussion. I intend to prototype this work with QEMU
and one of the rust-vmm vhost-user daemons.
---
docs/interop/vhost
id, VIRTIO_ID_RNG),
DEFINE_PROP_UINT32("num_vqs", VHostUserDevice, num_vqs, 1),
DEFINE_PROP_END_OF_LIST(),
};
And so far the API for doing that isn't super clear.
Signed-off-by: Alex Bennée
---
include/hw/qdev-core.h | 9 +
1 file changed, 9 insertions(+)
diff -
Now we can take advantage of our new base class and make
vhost-user-rng a much simpler boilerplate wrapper. Also as this
doesn't require any target specific hacks we only need to build the
stubs once.
Signed-off-by: Alex Bennée
---
v2
- new derivation layout
- move direct
In preparation for getting the details of the VirtIO device directly
from the vhost-user daemon we should connect once we have validated
the chardev. We will actually move the connection in the next patch to
keep the changes small and bisectable.
Signed-off-by: Alex Bennée
---
hw/virtio/vhost
to:
-device vhost-user-gpio-pci
Signed-off-by: Alex Bennée
---
include/hw/virtio/vhost-user-device.h | 1 +
hw/virtio/vhost-user-device.c | 58 ++-
2 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/include/hw/virtio/vhost-user-device.h
b/include
objects.
Signed-off-by: Alex Bennée
---
include/hw/virtio/vhost-user-blk.h | 1 -
include/hw/virtio/vhost.h | 9 +
backends/vhost-user.c | 1 -
hw/block/vhost-user-blk.c | 7 +--
hw/scsi/vhost-scsi.c | 2 --
hw/scsi/vhost-user-scsi.c
These are useful functions for when you want proper inheritance of
functionality across realize/unrealize calls.
Signed-off-by: Alex Bennée
---
include/hw/qdev-core.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
Fixes: 544f0278af (virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX)
Signed-off-by: Alex Bennée
---
hw/display/vhost-user-gpu.c| 4 ++--
hw/net/virtio-net.c| 4 ++--
hw/virtio/vhost-user-fs.c | 4 ++--
hw/virtio/vhost-user-gpio.c| 2 +-
hw/virtio/vhost-vsock-common.c | 4
Signed-off-by: Alex Bennée
---
include/hw/virtio/virtio.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 0492d26900..0671989383 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -276,6 +276,13
Signed-off-by: Alex Bennée
---
include/hw/virtio/virtio.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 0671989383..631490bda4 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -219,6 +219,12
Now the new base class supports config handling we can take advantage
and make vhost-user-gpio a much simpler boilerplate wrapper. Also as
this doesn't require any target specific hacks we only need to build
the stubs once.
Signed-off-by: Alex Bennée
---
v2
- use new vhost-user-base
-
Lets document some more of the core VirtIODevice structure.
Signed-off-by: Alex Bennée
---
include/hw/virtio/virtio.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 631490bda4..c8f72850bc 100644
--- a/include/hw/virtio
Now we have detected and validated the protocol support lets do the
probe. The empty state indicates no probe took place.
Signed-off-by: Alex Bennée
---
include/hw/virtio/vhost.h | 12 +++
hw/virtio/vhost-user.c| 73 +++
hw/virtio/vhost.c | 2
r protocol. This should provide a baseline implementation
from which the other vhost-user stub can specialise.
Signed-off-by: Alex Bennée
---
v2
- split into vub and vud
---
include/hw/virtio/vhost-user-device.h | 45
hw/virtio/vhost-user-device.c | 324 ++
This is all pretty much boilerplate.
Signed-off-by: Alex Bennée
Tested-by: Erik Schilling
---
hw/virtio/vhost-user-device-pci.c | 71 +++
hw/virtio/meson.build | 1 +
2 files changed, 72 insertions(+)
create mode 100644 hw/virtio/vhost-user-device
1 - 100 of 516 matches
Mail list logo
