[PATCH v2 2/6] tests/qemu-iotests: add case of writing compressed data to multiple clusters

2019-10-02 Thread Andrey Shinkevich
Add the test case to the iotest #214 that checks possibility of writing compressed data to more than one cluster. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/214 | 9 + tests/qemu-iotests/214.out | 6 ++ 2 files changed, 15 insertions(+) diff --git a/tests/qemu

[PATCH v2 3/6] qemu-nbd: add compression flag support

2019-10-02 Thread Andrey Shinkevich
Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- blockdev-nbd.c | 8 ++-- include/block/nbd.h | 11 +-- nbd/server.c| 14 ++ qemu-nbd.c | 30 ++ qemu-nbd.texi | 2 ++ 5 files changed, 53

[PATCH v2 6/6] tests/qemu-iotests: add case for block-stream compress

2019-10-02 Thread Andrey Shinkevich
Add a test case to the iotest #030 that checks 'compress' option for a block-stream job. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/030 | 49 +- tests/qemu-iotests/030.out | 4 ++-- 2 files changed, 50 insertions(+), 3 deletions

[PATCH v2 5/6] block-stream: add compress option

2019-10-02 Thread Andrey Shinkevich
Allow data compression during block-stream job for backup backing chain. Signed-off-by: Anton Nefedov Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- block/stream.c| 19 +-- blockdev.c

[PATCH v2 1/6] qcow2: Allow writing compressed data to multiple clusters

2019-10-02 Thread Andrey Shinkevich
. For unaligned requests, we use a workaround that writes the data without compression. Suggested-by: Pavel Butsykin Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/qcow2.c | 113 +++--- 1 file changed, 85 insertions

[PATCH v2 4/6] block: support compressed write for copy-on-read

2019-10-02 Thread Andrey Shinkevich
Support the data compression during block-stream job over a backup backing chain implemented in the following patch 'block-stream: add compress option'. Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- block/io.c | 21

[PATCH v2 0/6] qcow2: advanced compression options

2019-10-02 Thread Andrey Shinkevich
the boolean ones (suggested by Eric). Andrey Shinkevich (6): qcow2: Allow writing compressed data to multiple clusters tests/qemu-iotests: add case of writing compressed data to multiple clusters qemu-nbd: add compression flag support block: support compressed write for copy-on-read block

[PATCH 5/6] block-stream: add compress option

2019-10-01 Thread Andrey Shinkevich
Signed-off-by: Anton Nefedov Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- block/stream.c| 19 +-- blockdev.c| 14 +- hmp-commands.hx | 4 ++-- include/block

[PATCH 2/6] tests/qemu-iotests: add case of writing compressed data to multiple clusters.

2019-10-01 Thread Andrey Shinkevich
Add the test case to the iotest #214 that checks possibility of writing compressed data to more than one cluster. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/214 | 9 + tests/qemu-iotests/214.out | 6 ++ 2 files changed, 15 insertions(+) diff --git a/tests/qemu

[PATCH 3/6] block: support compressed write for copy-on-read

2019-10-01 Thread Andrey Shinkevich
Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- block/io.c | 21 - block/trace-events | 2 +- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index f8c3596..a7cd24f 100644

[PATCH 4/6] qemu-nbd: add compression flag support

2019-10-01 Thread Andrey Shinkevich
Signed-off-by: Denis V. Lunev Signed-off-by: Andrey Shinkevich --- blockdev-nbd.c | 2 +- include/block/nbd.h | 7 ++- nbd/server.c| 8 +++- qemu-nbd.c | 18 -- qemu-nbd.texi | 2 ++ 5 files changed, 32 insertions(+), 5 deletions(-) diff

[PATCH 1/6] qcow2: multiple clusters write compressed

2019-10-01 Thread Andrey Shinkevich
. For unaligned requests, we use a workaround that writes the data without compression. Suggested-by: Pavel Butsykin Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/qcow2.c | 113 +++--- 1 file changed, 85 insertions

[PATCH 6/6] tests/qemu-iotests: add case for block-stream compress

2019-10-01 Thread Andrey Shinkevich
Add a test case to the iotest #030 that checks 'compress' option for a block-stream job. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/030 | 49 +- tests/qemu-iotests/030.out | 4 ++-- 2 files changed, 50 insertions(+), 3 deletions

[PATCH 0/6] qcow2: advanced compression options

2019-10-01 Thread Andrey Shinkevich
New enhancements of writing compressed data to QCOW2 image. Based on: message ID <20190916175324.18478-1-vsement...@virtuozzo.com> https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg00751.html Andrey Shinkevich (6): qcow2: multiple clusters write compressed test

Re: [Qemu-block] [PATCH v4 5/7] iotests: Test driver whitelisting in 093

2019-09-18 Thread Andrey Shinkevich
On 18/09/2019 09:29, Max Reitz wrote: > On 17.09.19 16:25, Andrey Shinkevich wrote: >> >> >> On 17/09/2019 12:20, Max Reitz wrote: >>> null-aio may not be whitelisted. Skip all test cases that require it. >>> >>> (And skip the whole test if null-c

Re: [Qemu-block] [PATCH v4 7/7] iotests: Cache supported_formats()

2019-09-17 Thread Andrey Shinkevich
_only] = \ > +format_message.splitlines()[line].split(":")[1].split() > + > +return supported_formats.formats[read_only] > > def skip_if_unsupported(required_formats=[], read_only=False): > '''Skip Test Decorator > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH v4 6/7] iotests: Test driver whitelisting in 136

2019-09-17 Thread Andrey Shinkevich
sTestCoroutine(BlockDeviceStatsTestCase): > -test_img = "null-co://" > +test_driver = "null-co" > > if __name__ == '__main__': > +if 'null-co' not in iotests.supported_formats(): > +iotests.notrun('null-co driver support missing') > iotests.main(supported_fmts=["raw"]) > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH v4 5/7] iotests: Test driver whitelisting in 093

2019-09-17 Thread Andrey Shinkevich
"null-co" > > class ThrottleTestGroupNames(iotests.QMPTestCase): > max_drives = 3 > @@ -425,4 +429,6 @@ class ThrottleTestRemovableMedia(iotests.QMPTestCase): > > > if __name__ == '__main__': > +if 'null-co' not in iotests.supported_formats(): > +iotests.notrun('null-co driver support missing') > iotests.main(supported_fmts=["raw"]) > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH v4 4/7] iotests: Let skip_if_unsupported accept a function

2019-09-17 Thread Andrey Shinkevich
ist(set(fmts) - set(supported_formats(read_only))) > if usf_list: > test_case.case_skip('{}: formats {} are not > whitelisted'.format( > test_case, usf_list)) > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsupported()

2019-09-17 Thread Andrey Shinkevich
test_case, usf_list)) > else: > -return func(*args, **kwargs) > +return func(test_case, *args, **kwargs) > return func_wrapper > return skip_test_decorator > > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH v4 1/7] iotests: Prefer null-co over null-aio

2019-09-17 Thread Andrey Shinkevich
## > - opts = {'driver': 'null-aio', 'node-name': 'root', 'size': 1024} > +opts = {'driver': 'null-co', 'node-name': 'root', 'size': 1024} > > result = self.vm.qmp('blockdev-add', conv_keys = False, **opts) > self.assert_qmp(result, 'return', {}) > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PULL 4/9] block: workaround for unaligned byte range in fallocate()

2019-09-06 Thread Andrey Shinkevich
Many thanks Andrey On 05/09/2019 21:21, Eric Blake wrote: > From: Andrey Shinkevich > > Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' > and use better error handling for file systems that do not support > fallocate() for an unaligned byte range. All

Re: [Qemu-block] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

2019-09-04 Thread Andrey Shinkevich
On 04/09/2019 16:44, Kevin Wolf wrote: > Am 04.09.2019 um 11:11 hat Andrey Shinkevich geschrieben: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind with the switch '-valgrind'. >> Let's allow the common.rc ba

[Qemu-block] [PATCH v8 4/6] iotests: Valgrind fails with nonexistent directory

2019-09-04 Thread Andrey Shinkevich
The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/051

[Qemu-block] [PATCH v8 1/6] iotests: allow Valgrind checking all QEMU processes

2019-09-04 Thread Andrey Shinkevich
ing killed, the shell report refers to the text of the command in _qemu_io_wrapper(), which was modified with this patch. So, the benchmark output for the tests 039, 061 and 137 is to be changed also. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039.out | 30 +++ tests/qe

[Qemu-block] [PATCH v8 6/6] iotests: extend sleeping time under Valgrind

2019-09-04 Thread Andrey Shinkevich
To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time in the test 247. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1

[Qemu-block] [PATCH v8 2/6] iotests: exclude killed processes from running under Valgrind

2019-09-04 Thread Andrey Shinkevich
under the Valgrind until a new version with the bug fix is released because checking for the memory issues is covered by other test cases. Suggested-by: John Snow Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/039 | 5 + tests/qemu-iotests/061

[Qemu-block] [PATCH v8 3/6] iotests: Add casenotrun report to bash tests

2019-09-04 Thread Andrey Shinkevich
The new function _casenotrun() is to be invoked if a test case cannot be run for some reason. The user will be notified by a message passed to the function. It is the caller's responsibility to make skipped a particular test. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed

[Qemu-block] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

2019-09-04 Thread Andrey Shinkevich
ail-andrey.shinkev...@virtuozzo.com> <1560276131-683243-1-git-send-email-andrey.shinkev...@virtuozzo.com> <1566834628-485525-1-git-send-email-andrey.shinkev...@virtuozzo.com> Andrey Shinkevich (6): iotests: allow Valgrind checking all QEMU processes iotests: exclude killed proc

[Qemu-block] [PATCH v8 5/6] iotests: extended timeout under Valgrind

2019-09-04 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- tests

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

2019-09-03 Thread Andrey Shinkevich
On 03/09/2019 17:28, Kevin Wolf wrote: > Am 03.09.2019 um 16:22 hat Andrey Shinkevich geschrieben: >> >> >> On 03/09/2019 13:02, Kevin Wolf wrote: >>> Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: >>>> In the current implementat

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

2019-09-03 Thread Andrey Shinkevich
On 03/09/2019 13:02, Kevin Wolf wrote: > Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind with the switch '-valgrind'. >> Let's allow the common.rc ba

Re: [Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

2019-09-03 Thread Andrey Shinkevich
On 03/09/2019 13:02, Kevin Wolf wrote: > Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind with the switch '-valgrind'. >> Let's allow the common.rc ba

[Qemu-block] [PATCH v7 1/6] iotests: allow Valgrind checking all QEMU processes

2019-09-01 Thread Andrey Shinkevich
ing killed, the shell report refers to the text of the command in _qemu_io_wrapper(), which was modified with this patch. So, the benchmark output for the tests 039, 061 and 137 is to be changed also. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039.out | 30 +++ tests/qe

[Qemu-block] [PATCH v7 5/6] iotests: extended timeout under Valgrind

2019-09-01 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- tests

[Qemu-block] [PATCH v7 4/6] iotests: Valgrind fails with nonexistent directory

2019-09-01 Thread Andrey Shinkevich
The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/051

[Qemu-block] [PATCH v7 6/6] iotests: extend sleeping time under Valgrind

2019-09-01 Thread Andrey Shinkevich
To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time in the test 247. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1

[Qemu-block] [PATCH v7 3/6] iotests: Add casenotrun report to bash tests

2019-09-01 Thread Andrey Shinkevich
The new function _casenotrun() is to be invoked if a test case cannot be run for some reason. The user will be notified by a message passed to the function. It is the caller's responsibility to make skipped a particular test. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed

[Qemu-block] [PATCH v7 2/6] iotests: exclude killed processes from running under Valgrind

2019-09-01 Thread Andrey Shinkevich
under the Valgrind until a new version with the bug fix is released because checking for the memory issues is covered by other test cases. Suggested-by: John Snow Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/039 | 5 + tests/qemu-iotests/061

[Qemu-block] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

2019-09-01 Thread Andrey Shinkevich
uozzo.com> <1566834628-485525-1-git-send-email-andrey.shinkev...@virtuozzo.com> Andrey Shinkevich (6): iotests: allow Valgrind checking all QEMU processes iotests: exclude killed processes from running under Valgrind iotests: Add casenotrun report to bash tests iotests: Valgrind fail

Re: [Qemu-block] [Qemu-devel] [PATCH v6 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-29 Thread Andrey Shinkevich
/www.tldp.org/LDP/abs/html/parameter-substitution.html >> >> And it seems to work, but I'm not sure if this works with BSD or OSX's >> sh. I see Eric comment on that compatibility a lot, so maybe I'll let >> him chime in. > > It's quite portable; POSIX requires it, and autoconf relies on it. > -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH v5 6/6] iotests: extend sleeping time under Valgrind

2019-08-28 Thread Andrey Shinkevich
On 27/08/2019 22:42, John Snow wrote: > > > On 8/23/19 11:27 AM, Vladimir Sementsov-Ogievskiy wrote: >> 16.08.2019 4:01, John Snow wrote: >>> >>> >>> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>>> To synchronize the time when QE

Re: [Qemu-block] [PATCH v5 4/6] iotests: Valgrind fails with nonexistent directory

2019-08-28 Thread Andrey Shinkevich
On 27/08/2019 22:45, John Snow wrote: > > > On 8/25/19 11:24 AM, Andrey Shinkevich wrote: >> >> >> On 16/08/2019 03:55, John Snow wrote: >>> >>> >>> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>>> The Valgrind uses the expor

Re: [Qemu-block] [PATCH v5 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-28 Thread Andrey Shinkevich
On 27/08/2019 22:56, John Snow wrote: > > > On 8/25/19 11:26 AM, Andrey Shinkevich wrote: >> >> >> On 16/08/2019 01:49, John Snow wrote: >>> >>> >>> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>>> With the '-valgrind' opti

Re: [Qemu-block] [PATCH v2] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
On 27/08/2019 17:30, Eric Blake wrote: > On 8/27/19 9:04 AM, Andrey Shinkevich wrote: >> >> >> On 27/08/2019 16:55, Eric Blake wrote: >>> On 8/27/19 8:52 AM, Andrey Shinkevich wrote: >>>> Revert the commit 118f99442d 'block/io.c: fix for the allocation f

Re: [Qemu-block] [PATCH v2] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
On 27/08/2019 16:55, Eric Blake wrote: > On 8/27/19 8:52 AM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and use better error handling for file systems that do not support >> fallocate() for an unaligned byte rang

Re: [Qemu-block] [PATCH v2] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
On 27/08/2019 16:55, Eric Blake wrote: > On 8/27/19 8:52 AM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and use better error handling for file systems that do not support >> fallocate() for an unaligned byte rang

[Qemu-block] [PATCH v2] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
Signed-off-by: Andrey Shinkevich Reviewed-by: Eric Blake --- block/file-posix.c | 7 +++ block/io.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index fbeb006..b00259f 100644 --- a/block/file-posix.c +++ b/block/file

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
On 23/08/2019 00:09, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > > s/make/use/ > >> fall

[Qemu-block] [PATCH v6 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-26 Thread Andrey Shinkevich
ell report refers to the text of the command in _qemu_io_wrapper(), which was modified with this patch. So, the benchmark output for the tests 039, 061 and 137 is to be changed also. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039.out | 30 ++-- tests/qemu-iotests/061.o

[Qemu-block] [PATCH v6 3/6] iotests: Add casenotrun report to bash tests

2019-08-26 Thread Andrey Shinkevich
The new function _casenotrun() is to be invoked if a test case cannot be run for some reason. The user will be notified by a message passed to the function. It is the caller's responsibility to make skipped a particular test. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed

[Qemu-block] [PATCH v6 5/6] iotests: extended timeout under Valgrind

2019-08-26 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- tests

[Qemu-block] [PATCH v6 4/6] iotests: Valgrind fails with nonexistent directory

2019-08-26 Thread Andrey Shinkevich
The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich Reviewed-by: John Snow --- tests/qemu-iotests/051

[Qemu-block] [PATCH v6 6/6] iotests: extend sleeping time under Valgrind

2019-08-26 Thread Andrey Shinkevich
To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time in the test 247. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Qemu-block] [PATCH v6 0/6] Allow Valgrind checking all QEMU processes

2019-08-26 Thread Andrey Shinkevich
y.shinkev...@virtuozzo.com> Andrey Shinkevich (6): iotests: allow Valgrind checking all QEMU processes iotests: exclude killed processes from running under Valgrind iotests: Add casenotrun report to bash tests iotests: Valgrind fails with nonexistent directory iotests: extended timeout under Valgri

[Qemu-block] [PATCH v6 2/6] iotests: exclude killed processes from running under Valgrind

2019-08-26 Thread Andrey Shinkevich
under the Valgrind until a new version with the bug fix is released because checking for the memory issues is covered by other test cases. Suggested-by: John Snow Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039 | 5 + tests/qemu-iotests/061 | 2 ++ tests/qemu

Re: [Qemu-block] [PATCH v5 1/6] iotests: allow Valgrind checking all QEMU processes

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 01:49, John Snow wrote: > > > On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >> With the '-valgrind' option, let all the QEMU processes be run under >> the Valgrind tool. The Valgrind own parameters may be set with its >> environment variable VALGRIND_

Re: [Qemu-block] [PATCH v5 4/6] iotests: Valgrind fails with nonexistent directory

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 03:55, John Snow wrote: > > > On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >> The Valgrind uses the exported variable TMPDIR and fails if the >> directory does not exist. Let us exclude such a test case from >> being run under the V

Re: [Qemu-block] [PATCH v5 3/6] iotests: Add casenotrun report to bash tests

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 23:33, Cleber Rosa wrote: > On Thu, Aug 15, 2019 at 08:44:11PM -0400, John Snow wrote: >> >> >> On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >>> The new function _casenotrun() is to be invoked if a test case cannot >>> be run for some reason.

Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 23:05, Cleber Rosa wrote: > On Fri, Jul 19, 2019 at 07:30:10PM +0300, Andrey Shinkevich wrote: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind, which is a useful tool for >> finding memory usag

Re: [Qemu-block] [PATCH v5 6/6] iotests: extend sleeping time under Valgrind

2019-08-25 Thread Andrey Shinkevich
On 16/08/2019 04:01, John Snow wrote: > > > On 7/19/19 12:30 PM, Andrey Shinkevich wrote: >> To synchronize the time when QEMU is running longer under the Valgrind, >> increase the sleeping time in the test 247. >> >> Signed-off-by: Andrey Shinkevich >> Re

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-23 Thread Andrey Shinkevich
On 23/08/2019 00:09, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > > s/make/use/ > >> fall

[Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-22 Thread Andrey Shinkevich
Blake Signed-off-by: Andrey Shinkevich --- Discussed in email thread with the message ID <1554474244-553661-1-git-send-email-andrey.shinkev...@virtuozzo.com> block/file-posix.c | 7 +++ block/io.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/bloc

Re: [Qemu-block] [Qemu-devel] [PATCH v3 3/8] iotests: Allow skipping test cases

2019-08-21 Thread Andrey Shinkevich
gt; +out_first_line, out_rest = out.split('\n', 1) > +out = out_first_line.replace('s', '.') + '\n' + out_rest > + > + sys.stderr.write(out) > > def execute_test(test_function=None, >supported_fmts=[], supported_oses=['linux'], > Reviewed-by: Andrey Shinkevich -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH] iotests: Add more "skip_if_unsupported" statements to the python tests

2019-08-21 Thread Andrey Shinkevich
fies that we can't change the children of a block > # device during a reopen operation in a way that would create > # cycles in the node graph > +@iotests.skip_if_unsupported(['blkverify']) > def test_graph_cycles(self): > opts = [] > > @@ -534,6 +535,7 @@ class TestBlockdevReopen(iotests.QMPTestCase): > self.assert_qmp(result, 'return', {}) > > # Misc reopen tests with different block drivers > +@iotests.skip_if_unsupported(['quorum']) > def test_misc_drivers(self): > > ## quorum ## > -- With the best regards, Andrey Shinkevich

Re: [Qemu-block] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

2019-08-13 Thread Andrey Shinkevich
On 13/08/2019 15:05, Paolo Bonzini wrote: > On 13/08/19 14:02, Andrey Shinkevich wrote: >> PINGING... > > I thought I had already said I queued the series? > > Paolo > Thank you Paolo. I am clear now. Andrey >> On 30/07/2019 19:01, Andrey Shinkevich wrote

Re: [Qemu-block] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

2019-08-13 Thread Andrey Shinkevich
PINGING... On 30/07/2019 19:01, Andrey Shinkevich wrote: > Running unit tests under the Valgrind may help to detect QEMU memory issues > (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the > unit test code itself. Let's eliminate the detected memory issues to ease &

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver

2019-08-13 Thread Andrey Shinkevich
On 13/08/2019 11:46, Thomas Huth wrote: > On 7/30/19 3:23 PM, Andrey Shinkevich wrote: >> >> >> On 30/07/2019 15:59, Thomas Huth wrote: >>> On 30/07/2019 14.52, Thomas Huth wrote: >>>> On 29/07/2019 14.46, Andrey Shinkevich wrote: >>>>&

Re: [Qemu-block] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes

2019-08-06 Thread Andrey Shinkevich
PINGING... On 19/07/2019 19:30, Andrey Shinkevich wrote: > In the current implementation of the QEMU bash iotests, only qemu-io > processes may be run under the Valgrind, which is a useful tool for > finding memory usage issues. Let's allow the common.rc bash script > runing

Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call

2019-07-31 Thread Andrey Shinkevich
On 31/07/2019 15:43, Christian Borntraeger wrote: > > > On 31.07.19 14:28, Christian Borntraeger wrote: >> >> >> On 31.07.19 14:04, Andrey Shinkevich wrote: >>> On 31/07/2019 10:24, Christian Borntraeger wrote: >>>> >>>> >>

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call

2019-07-31 Thread Andrey Shinkevich
On 31/07/2019 15:32, Paolo Bonzini wrote: > On 31/07/19 11:05, Christophe de Dinechin wrote: >> >> Christian Borntraeger writes: >> >>> On 30.07.19 18:44, Philippe Mathieu-Daudé wrote: >>>> On 7/30/19 6:01 PM, Andrey Shinkevich wrote: >>>>&

Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call

2019-07-31 Thread Andrey Shinkevich
On 31/07/2019 10:24, Christian Borntraeger wrote: > > > On 30.07.19 21:20, Paolo Bonzini wrote: >> On 30/07/19 18:01, Andrey Shinkevich wrote: >>> Not the whole structure is initialized before passing it to the KVM. >>> Reduce the number of Valgrind repor

[Qemu-block] [PATCH 2/3] tests: Fix uninitialized byte in test_visitor_in_fuzz

2019-07-30 Thread Andrey Shinkevich
One byte in the local buffer stays uninitialized, at least with the first iteration, because of the double decrement in the test_visitor_in_fuzz(). This is what Valgrind does not like and not critical for the test itself. So, reduce the number of the memory issues reports. Signed-off-by: Andrey

[Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call

2019-07-30 Thread Andrey Shinkevich
Not the whole structure is initialized before passing it to the KVM. Reduce the number of Valgrind reports. Signed-off-by: Andrey Shinkevich --- target/i386/kvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index dbbb137..ed57e31 100644

[Qemu-block] [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length

2019-07-30 Thread Andrey Shinkevich
ThrottleState::cfg of the static variable 'ts' is reassigned with the local one in the do_test_accounting() and then is passed to the throttle_account() with uninitialized member LeakyBucket::burst_length. Signed-off-by: Andrey Shinkevich --- tests/test-throttle.c | 2 ++ 1 file changed, 2

[Qemu-block] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

2019-07-30 Thread Andrey Shinkevich
Running unit tests under the Valgrind may help to detect QEMU memory issues (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the unit test code itself. Let's eliminate the detected memory issues to ease locating critical ones. Andrey Shinkevich (3): test-throttle: Fix

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver

2019-07-30 Thread Andrey Shinkevich
On 30/07/2019 15:59, Thomas Huth wrote: > On 30/07/2019 14.52, Thomas Huth wrote: >> On 29/07/2019 14.46, Andrey Shinkevich wrote: >>> This patch is to reduce the number of Valgrind report messages about >>> using uninitialized memory with the null-co driver. It help

[Qemu-block] [PATCH] tests: Set read-zeroes on for null-co driver

2019-07-29 Thread Andrey Shinkevich
This patch is to reduce the number of Valgrind report messages about using uninitialized memory with the null-co driver. It helps to filter real memory issues and is the same work done for the iotests with the commit ID a6862418fec4072. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich

Re: [Qemu-block] [PATCH v2] Fixes: add read-zeroes to 051.out

2019-07-25 Thread Andrey Shinkevich
On 25/07/2019 17:25, Kevin Wolf wrote: > Am 25.07.2019 um 14:00 hat Andrey Shinkevich geschrieben: >> The patch "iotests: Set read-zeroes on in null block driver for Valgrind" >> with the commit ID a6862418fec4072 needs the change in 051.out when >> comp

[Qemu-block] [PATCH v2] Fixes: add read-zeroes to 051.out

2019-07-25 Thread Andrey Shinkevich
The patch "iotests: Set read-zeroes on in null block driver for Valgrind" with the commit ID a6862418fec4072 needs the change in 051.out when compared against on the s390 system. Reported-by: Christian Borntraeger Signed-off-by: Andrey Shinkevich Tested-by: Christian Borntraeger

[Qemu-block] [PATCH] Fixes: a6862418fec4072 iotests change in 051.out

2019-07-24 Thread Andrey Shinkevich
The patch "iotests: Set read-zeroes on in null block driver for Valgrind" needs the change in 051.out when compared against on the s390 system. Reported-by: Christian Borntraeger Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/051.out | 10 +- 1 file changed, 5 insert

Re: [Qemu-block] [Qemu-devel] [PULL 01/13] iotests: Set read-zeroes on in null block driver for Valgrind

2019-07-24 Thread Andrey Shinkevich
On 24/07/2019 11:05, Kevin Wolf wrote: > Am 24.07.2019 um 09:57 hat Andrey Shinkevich geschrieben: >> >> >> On 24/07/2019 10:38, Kevin Wolf wrote: >>> Am 24.07.2019 um 09:30 hat Andrey Shinkevich geschrieben: >>>> >>>>

Re: [Qemu-block] [Qemu-devel] [PULL 01/13] iotests: Set read-zeroes on in null block driver for Valgrind

2019-07-24 Thread Andrey Shinkevich
On 24/07/2019 10:38, Kevin Wolf wrote: > Am 24.07.2019 um 09:30 hat Andrey Shinkevich geschrieben: >> >> >> On 24/07/2019 10:18, Christian Borntraeger wrote: >>> >>> On 19.07.19 15:43, Kevin Wolf wrote: >>>> From: Andrey Shinkevich >>

Re: [Qemu-block] [Qemu-devel] [PULL 01/13] iotests: Set read-zeroes on in null block driver for Valgrind

2019-07-24 Thread Andrey Shinkevich
On 24/07/2019 10:33, Christian Borntraeger wrote: > > > On 24.07.19 09:30, Andrey Shinkevich wrote: >> >> >> On 24/07/2019 10:18, Christian Borntraeger wrote: >>> >>> On 19.07.19 15:43, Kevin Wolf wrote: >>>> From: Andrey Shinkevich &g

Re: [Qemu-block] [Qemu-devel] [PULL 01/13] iotests: Set read-zeroes on in null block driver for Valgrind

2019-07-24 Thread Andrey Shinkevich
On 24/07/2019 10:18, Christian Borntraeger wrote: > > On 19.07.19 15:43, Kevin Wolf wrote: >> From: Andrey Shinkevich >> >> The Valgrind tool reports about the uninitialised buffer 'buf' >> instantiated on the stack of the function guess_disk_lchs(). >> Pas

Re: [Qemu-block] [PATCH for-4.1 v2] nbd: Initialize reply on failure

2019-07-22 Thread Andrey Shinkevich
non-NULL reply, so there is a dead condtional to also be cleaned > up. > > Reported-by: Thomas Huth > Reported-by: Andrey Shinkevich > Signed-off-by: Eric Blake > --- > block/nbd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/blo

[Qemu-block] [PATCH v5 5/6] iotests: extended timeout under Valgrind

2019-07-19 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/028 | 6

[Qemu-block] [PATCH v5 3/6] iotests: Add casenotrun report to bash tests

2019-07-19 Thread Andrey Shinkevich
The new function _casenotrun() is to be invoked if a test case cannot be run for some reason. The user will be notified by a message passed to the function. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/common.rc | 7 +++ 1 file changed, 7 insertions

[Qemu-block] [PATCH v5 4/6] iotests: Valgrind fails with nonexistent directory

2019-07-19 Thread Andrey Shinkevich
The Valgrind uses the exported variable TMPDIR and fails if the directory does not exist. Let us exclude such a test case from being run under the Valgrind and notify the user of it. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/051 | 4 1 file changed

[Qemu-block] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes

2019-07-19 Thread Andrey Shinkevich
ch 7/7 was added to introduce the Valgrind error suppression file into the QEMU project. Discussed in the email thread with the message ID: <1560276131-683243-1-git-send-email-andrey.shinkev...@virtuozzo.com> Andrey Shinkevich (6): iotests: allow Valgrind checking all QEMU processe

[Qemu-block] [PATCH v5 6/6] iotests: extend sleeping time under Valgrind

2019-07-19 Thread Andrey Shinkevich
To synchronize the time when QEMU is running longer under the Valgrind, increase the sleeping time in the test 247. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/247 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Qemu-block] [PATCH v5 1/6] iotests: allow Valgrind checking all QEMU processes

2019-07-19 Thread Andrey Shinkevich
be changed also. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039.out | 30 --- tests/qemu-iotests/061.out | 12 ++-- tests/qemu-iotests/137.out | 6 +--- tests/qemu-iotests/common.rc | 69 4 files changed, 59

[Qemu-block] [PATCH v5 2/6] iotests: exclude killed processes from running under Valgrind

2019-07-19 Thread Andrey Shinkevich
of it because checking for the memory issues is covered by other test cases. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/039 | 5 + tests/qemu-iotests/061 | 2 ++ tests/qemu-iotests/137 | 1 + 3 files changed, 8 insertions(+) diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039

Re: [Qemu-block] [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized

2019-07-19 Thread Andrey Shinkevich
On 19/07/2019 17:44, Eric Blake wrote: > On 7/19/19 9:34 AM, Eric Blake wrote: >> On 7/19/19 4:40 AM, Andrey Shinkevich wrote: >>> In case nbd_co_receive_one_chunk() fails in >>> nbd_reply_chunk_iter_receive(), 'NBDReply reply' parameter is used in >>> the

Re: [Qemu-block] [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized

2019-07-19 Thread Andrey Shinkevich
On 19/07/2019 18:15, Eric Blake wrote: > On 7/19/19 10:00 AM, Andrey Shinkevich wrote: >> >> >> On 19/07/2019 17:44, Eric Blake wrote: >>> On 7/19/19 9:34 AM, Eric Blake wrote: >>>> On 7/19/19 4:40 AM, Andrey Shinkevich wrote: >

Re: [Qemu-block] [PATCH] nbd: Initialize reply on failure

2019-07-19 Thread Andrey Shinkevich
than chasing down which callers need to > pre-initialize reply, it's easier to guarantee that reply will always > be set by nbd_co_receive_one_chunk() even on failure. > > Reported-by: Thomas Huth > Reported-by: Andrey Shinkevich > Signed-off-by: Eric Blake > --- > >

Re: [Qemu-block] [PATCH v4 7/7] block/nbd: NBDReply is used being uninitialized

2019-07-19 Thread Andrey Shinkevich
On 19/07/2019 17:34, Eric Blake wrote: > On 7/19/19 4:40 AM, Andrey Shinkevich wrote: >> In case nbd_co_receive_one_chunk() fails in >> nbd_reply_chunk_iter_receive(), 'NBDReply reply' parameter is used in >> the check nbd_reply_is_simple() without being initialized. T

Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: Set read-zeroes on in null block driver for Valgrind

2019-07-19 Thread Andrey Shinkevich
On 19/07/2019 03:14, John Snow wrote: > > > On 7/15/19 12:06 PM, Andrey Shinkevich wrote: >> The Valgrind tool reports about the uninitialised buffer 'buf' >> instantiated on the stack of the function guess_disk_lchs(). >> Pass 'read-zeroes=on' to the null block driv

[Qemu-block] [PATCH v4 0/7] Allow Valgrind checking all QEMU processes

2019-07-19 Thread Andrey Shinkevich
v2: 01: The patch 2/7 of v1 was merged into the patch 1/7, suggested by Daniel. 02: Another patch 7/7 was added to introduce the Valgrind error suppression file into the QEMU project. Discussed in the email thread with the message ID: <1560276131-683243-1-git-send-email-andrey.shin

[Qemu-block] [PATCH v4 5/7] iotests: extended timeout under Valgrind

2019-07-19 Thread Andrey Shinkevich
As the iotests run longer under the Valgrind, the QEMU_COMM_TIMEOUT is to be increased in the test cases 028, 183 and 192 when running under the Valgrind. Suggested-by: Roman Kagan Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/028 | 6

  1   2   3   4   >