Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] Introduce a Python module structure

2019-02-18 Thread Caio Carrara
use code > * have a proper place for the module's own unittests > * apply a more consistent style > * generate documentation > > Signed-off-by: Cleber Rosa Reviewed-by: Caio Carrara > --- > configure | 1 + > scrip

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Caio Carrara
On Tue, Nov 27, 2018 at 03:02:03PM -0500, Cleber Rosa wrote: > > > On 11/27/18 2:00 PM, Caio Carrara wrote: > > Hi, Cleber. > > > > On Tue, Nov 27, 2018 at 05:50:34AM -0500, Cleber Rosa wrote: > >> This is a simple move of Python code that wraps common Q

Re: [Qemu-block] [RFC PATCH] Introduce Python module structure

2018-11-27 Thread Caio Carrara
6 +26,13 @@ import shutil > import multiprocessing > import traceback > > +THIS_DIR = os.path.dirname(os.path.abspath(__file__)) > +TOP_DIR = os.path.dirname(os.path.dirname(THIS_DIR)) > +PYTHON_MODULE_PATH = os.path.join(TOP_DIR, 'python') > +sys.path.append(PYTHON_MODULE_PATH) > + > +from qemu import QEMUMachine, kvm_available > + > SSH_KEY = open(os.path.join(os.path.dirname(__file__), > "..", "keys", "id_rsa")).read() > SSH_PUB_KEY = open(os.path.join(os.path.dirname(__file__), > -- > 2.19.1 > Thanks, -- Caio Carrara Software Engineer, Virt Team - Red Hat ccarr...@redhat.com