Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff -
is no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (2):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Modularize
On 08/11/2016 09:29 PM, Fam Zheng wrote:
> On Thu, 08/11 12:03, Colin Lord wrote:
>> On 08/10/2016 11:23 PM, Fam Zheng wrote:
>>> On Wed, 08/10 21:06, Max Reitz wrote:
>>>> On 10.08.2016 21:04, Colin Lord wrote:
>>>>> On 08/10/2016 02:37 PM, Max Reitz
ackage depends on libbz2, while the
main QEMU package needn't to. With this patch, we (temporarily) change
the case so that the main QEMU depends on libbz2 again.
Signed-off-by: Marc Marí <mar...@redhat.com>
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Stefan Hajnoczi &l
;
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
Makefile| 7 +++
scripts/modules/module_block.py | 108
2 files changed, 115 insertions(+)
create mode 100644 scripts
On 08/10/2016 11:23 PM, Fam Zheng wrote:
> On Wed, 08/10 21:06, Max Reitz wrote:
>> On 10.08.2016 21:04, Colin Lord wrote:
>>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>>> On 08.08.2016 20:07, Colin Lord wrote:
>>>>> From: Marc Mari <mar...@r
On 08/10/2016 03:24 PM, Colin Lord wrote:
> On 08/10/2016 03:04 PM, Colin Lord wrote:
>> On 08/10/2016 02:37 PM, Max Reitz wrote:
>>> On 08.08.2016 20:07, Colin Lord wrote:
>>>> From: Marc Mari <mar...@redhat.com>
>>>>
>>>> Ex
On 08/10/2016 03:04 PM, Colin Lord wrote:
> On 08/10/2016 02:37 PM, Max Reitz wrote:
>> On 08.08.2016 20:07, Colin Lord wrote:
>>> From: Marc Mari <mar...@redhat.com>
>>>
>>> Extend the current module interface to allow for block drivers to be
>>
On 08/10/2016 03:04 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> Modularizes the nfs block driver so that it gets dynamically loaded.
>>
>> Signed-off-by: Colin Lord <cl...@redhat.com>
>> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com
On 08/10/2016 02:37 PM, Max Reitz wrote:
> On 08.08.2016 20:07, Colin Lord wrote:
>> From: Marc Mari <mar...@redhat.com>
>>
>> Extend the current module interface to allow for block drivers to be
>> loaded dynamically on request. The only block drivers that
mation is located in a new structure found
in module_block.h
Signed-off-by: Marc Marí <mar...@redhat.com>
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
Makefile | 3 ---
bl
;
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
Makefile| 7 +++
scripts/modules/module_block.py | 108
2 files changed, 115 insertions(+)
create mode 100644 scripts
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff -
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
---
block/
in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (2):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Modularize nfs block driver
On 08/08/2016 11:18 AM, Stefan Hajnoczi wrote:
> On Tue, Aug 02, 2016 at 10:12:14AM -0400, Colin Lord wrote:
>> diff --git a/vl.c b/vl.c
>> index e7c2c62..1a5f807 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -506,6 +506,41 @@ static QemuOptsList qemu_fw_cfg_opts = {
On 08/02/2016 10:12 AM, Colin Lord wrote:
> I'm sending one more version of this series. v5 didn't seem to need any
> huge makeovers, but I found a small bug in it so I'm hoping it hasn't
> been committed yet. In v5, if a user explicitly specified the driver to
> use, eg dr
Modularizes the nfs block driver so that it gets dynamically loaded.
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
--- a/block/Makefile.objs
+++
pattern of format-probe.c
- Renamed crypto probe file to be crypto-probe.c, luks is no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (3
;
Signed-off-by: Colin Lord <cl...@redhat.com>
---
Makefile| 7 +++
scripts/modules/module_block.py | 108
2 files changed, 115 insertions(+)
create mode 100644 scripts/modules/module_block.py
diff --git a/Makefile b/Make
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
---
block/
in module_block.h
Signed-off-by: Marc Marí <mar...@redhat.com>
Signed-off-by: Colin Lord <cl...@redhat.com>
---
Makefile | 3 ---
block.c | 62 +--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
u
Removes some superfluous lines from the Makefile which should have been
removed as part of the patch series to add dynamic loading for block
driver modules.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Makefile b/Makefile
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 5
On 07/23/2016 02:21 PM, Max Reitz wrote:
> On 20.07.2016 16:30, Colin Lord wrote:
>> Here's v5 of the modularization series. Since it seems the concensus is
>> that modularizing the format drivers is unnecessary, this series no
>> longer modularizes those and is thus muc
in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (1):
blockdev: prepare iSCSI block driver for dynamic loading
Marc Mari (2):
blockdev: Add dynamic
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
---
block/
;
Signed-off-by: Colin Lord <cl...@redhat.com>
---
Makefile| 7 +++
scripts/modules/module_block.py | 102
2 files changed, 109 insertions(+)
create mode 100644 scripts/modules/module_block.py
diff --git a/Makefile b/Make
On 07/19/2016 06:54 AM, Paolo Bonzini wrote:
>
>
> On 14/07/2016 21:02, Colin Lord wrote:
>> Here's v4 of the modularization series. Things that have changed since
>> v3 include:
>>
>> - Fix indentation of the generated header file module_block.h
>> -
On 07/18/2016 12:28 PM, Max Reitz wrote:
> On 14.07.2016 21:03, Colin Lord wrote:
>> Modifies the bochs probe to return the format name as well as the
>> score as the final step of separating the probe function from the
>> driver. This keeps the probe completely inde
This commit finalizes the separation of the block driver and probe
function by removing the .bdrv_probe field from all BlockDrivers.
Probing is now accomplished solely by iterating over the array of probe
function pointers in the format_probes array.
Signed-off-by: Colin Lord <cl...@redhat.
This puts the bdrv_probe_device functions into their own files to
facilitate the modularization of the block drivers.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 1 +
block/host_cdrom-p
This commit finalizes the separation of the BlockDriver from its
device probing function. Now the accesses to these functions in block.c
occur through the protocol_probes array, and each function returns a
score and protocol name with which to find the corresponding driver.
Signed-off-by: Colin
Completes the separation of the vmdk probe from the vmdk driver. The
vmdk probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-b
Completes the separation of the qcow2 probe from the qcow2 driver. The
qcow2 probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
Re
Isolates vpc probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/vpc-probe.c | 9 +
block/vpc.c | 8 +---
include/block/probe.h |
Completes the separation of the luks probe from the crypto driver. The
luks probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-b
Completes the separation of the parallels probe from the parallels
driver. The parallels probe now returns the format in addition to the
score, allowing correlation of the score and driver without the probe
function being part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.
Completes the separation of the cloop probe from the cloop driver. The
cloop probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
Re
Isolate raw probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 1 +
block/raw-probe.c | 10 ++
block/raw_bsd.c | 9 +
include/block/probe.h |
Completes the separation of the qcow probe from the qcow driver. The
qcow probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-b
Isolates vhdx probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/vhdx-probe.c| 21 +
block/vhdx.c | 20 +---
i
allows the score to be correlated to the
driver without the probe function needing to be part of the driver.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block.c | 20
block/bochs-probe.c | 25 -
block/bochs.c | 1 -
i
Completes the separation of the raw probe from the raw driver. The
raw probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-b
Isolates qcow2 probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/qcow2-probe.c | 16
block/qcow2.c | 13 +
include/block/
This puts the bochs probe function into its own separate file as part of
the process of modularizing block drivers. Having the probe functions
separate from the rest of the driver allows us to probe without having
to potentially unnecessarily load the driver.
Signed-off-by: Colin Lord <
;
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
Makefile| 7 +++
scripts/modules/module_block.py | 122
2 files changed, 129 insertions(+)
create mode 100644 scripts/modul
Isolate qed probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/qed-probe.c | 18 ++
block/qed.c | 15 +--
include/b
Isolates cloop probing function as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/cloop-probe.c | 17 +
block/cloop.c | 16 +
Isolates qcow probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/qcow-probe.c| 16
block/qcow.c | 31 ++
.
All the necessary module information is located in a new structure found in
module_block.h
Signed-off-by: Marc Marí <mar...@redhat.com>
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
blo
Isolates vmdk probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/vmdk-probe.c| 60 +++
block/vmdk.c
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
---
block/
Isolates the luks probe function as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/crypto-probe.c | 23 +++
block/crypto.c
Isolate parallels probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 1 +
block/parallels-probe.c | 21 +
block/parallels.
in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (30):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Move bochs probe
Isolate dmg probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
---
block/Makefile.objs | 2 +-
block/dmg-probe.c | 17 +
block/dmg.c | 16 +---
include/b
On 07/12/2016 05:17 PM, John Snow wrote:
>
>
> On 07/11/2016 03:50 PM, Colin Lord wrote:
>> Adds a new iotest for testing that the format probing functions work as
>> expected. This is done by booting up a vm with a disk image without
>> specifying the image format.
/probe-iotests/tests/qemu-iotests/sample_images
Colin Lord (3):
iotests: Add dmg format option
iotests: Add python functions for using sample images
iotests: Test format probes
tests/qemu-iotests/158| 53 +++
tests/qemu-iotests/158.out| 5
Adds option to test the dmg format.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
tests/qemu-iotests/common | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index d60ea2c..dc937c7 100644
--- a/tests/qemu-iotests/common
This adds a python equivalent of the _use_sample_img and _rm_sample_img
testing functions.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
tests/qemu-iotests/iotests.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-i
of
the given format, and one check is done against a raw image. This is to
ensure that a probe correctly returns a high score when the format is
matched, and does not return a high score when the format should not be
matched, as would be the case with raw images.
Signed-off-by: Colin Lord <
On 07/06/2016 04:24 AM, Kevin Wolf wrote:
> Am 05.07.2016 um 22:50 hat John Snow geschrieben:
>>
>>
>> On 07/05/2016 11:49 AM, Daniel P. Berrange wrote:
>>> On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote:
>>>> This puts the bochs probe f
On 07/06/2016 11:59 AM, Max Reitz wrote:
> On 05.07.2016 17:24, Colin Lord wrote:
>> Modifies the bochs probe to return the format name as well as the
>> score as the final step of separating the probe function from the
>> driver. This keeps the probe completely inde
On 07/06/2016 09:17 AM, Max Reitz wrote:
> On 05.07.2016 17:24, Colin Lord wrote:
>> From: Marc Mari <mar...@redhat.com>
>>
>> To simplify the addition of new block modules, add a script that generates
>> module_block.h automatically from the modules' sourc
Completes the separation of the qcow2 probe from the qcow2 driver. The
qcow2 probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
This commit finalizes the separation of the BlockDriver from its
device probing function. Now the accesses to these functions in block.c
occur through the protocol_probes array, and each function returns a
score and protocol name with which to find the corresponding driver.
Signed-off-by: Colin
Completes the separation of the vpc probe from the vpc driver. The
vpc probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
Completes the separation of the qcow probe from the qcow driver. The
qcow probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
Completes the separation of the parallels probe from the parallels
driver. The parallels probe now returns the format in addition to the
score, allowing correlation of the score and driver without the probe
function being part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.
Completes the separation of the qed probe from the qed driver. The
qed probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
Completes the separation of the vhdx probe from the vhdx driver. The
vhdx probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
This commit finalizes the separation of the block driver and probe
function by removing the .bdrv_probe field from all BlockDrivers.
Probing is now accomplished solely by iterating over the array of probe
function pointers in the format_probes array.
Signed-off-by: Colin Lord <cl...@redhat.
Completes the separation of the vdi probe from the vdi driver. The
vdi probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
Completes the separation of the raw probe from the raw driver. The
raw probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
Isolates vpc probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 2 +-
block/probe/vpc.c | 9 +
block/vpc.c | 8 +---
include/block/probe.h | 1 +
4 files changed, 12 insertions(+), 8 deletions(-)
Completes the separation of the cloop probe from the cloop driver. The
cloop probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
allows the score to be correlated to the
driver without the probe function needing to be part of the driver.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block.c | 19 +++
block/bochs.c | 1 -
block/probe/bochs.c | 25 -
i
This puts the bochs probe function into its own separate file as part of
the process of modularizing block drivers. Having the probe functions
separate from the rest of the driver allows us to probe without having
to potentially unnecessarily load the driver.
Signed-off-by: Colin Lord <
Isolate raw probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 1 +
block/probe/raw.c | 10 ++
block/raw_bsd.c | 9 +
include/block/probe.h | 1 +
4 files changed, 13 insertions(+), 8 del
Completes the separation of the luks probe from the crypto driver. The
luks probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
b
Isolates vhdx probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 2 +-
block/probe/vhdx.c| 21 +
block/vhdx.c | 20 +---
include/block/probe.h | 1 +
4 files chang
Isolates qcow probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 2 +-
block/probe/qcow.c | 16
block/qcow.c| 31 ++-
include/block/driver/qcow.
curl5.245
spice 5.289
gnutls 5.400
gtk 8.782
vte 9.764
rbd 44.315
Colin Lord (30):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Move bochs probe into separate file
blockdev: Move
.
All the necessary module information is located in a new structure found in
module_block.h
Signed-off-by: Marc Marí <mar...@redhat.com>
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block.c | 110 ++
include/qemu/module.h | 3
Isolate parallels probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 1 +
block/parallels.c| 43 ++--
block/probe/parallels.c
;
Signed-off-by: Colin Lord <cl...@redhat.com>
---
Makefile| 7 +++
scripts/modules/module_block.py | 122
2 files changed, 129 insertions(+)
create mode 100644 scripts/modules/module_block.py
diff --git a/Makefile b/Make
Isolates qcow2 probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 2 +-
block/probe/qcow2.c | 16
block/qcow2.c | 13 +
include/block/probe.h | 1 +
4 files changed, 19 insertions(
Isolates vdi probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs| 2 +-
block/probe/vdi.c | 26 +
block/vdi.c| 69 ++
include/block/
Isolate dmg probe as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 2 +-
block/dmg.c | 16 +---
block/probe/dmg.c | 17 +
include/block/probe.h | 1 +
4 files changed, 20 insertions(
Isolates cloop probing function as part of the modularization process.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/Makefile.objs | 2 +-
block/cloop.c | 16 +---
block/probe/cloop.c | 17 +
include/block/probe.h | 1 +
4 files chang
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/iscsi.c | 36
vl.c
On 06/22/2016 09:22 PM, Fam Zheng wrote:
> On Wed, 06/22 17:35, Colin Lord wrote:
>> This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
>> struct out of block/iscsi.c in order to allow it to be dynamically
>> loaded. Drivers that perform init operations o
.
That hopefully explains some of the issues, and why I'm submitting this
with the duplicated loops still intact. If there are other ideas for
dealing with this my ears are open, but this is what I have for now.
Colin Lord (1):
blockdev: prepare iSCSI block driver for dynamic loading
Marc Mari (2
into the main binary.
Signed-off-by: Colin Lord <cl...@redhat.com>
---
block/iscsi.c | 36
vl.c | 36
2 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 7e78ade..6
edhat.com>
Signed-off-by: Colin Lord <cl...@redhat.com>
---
.gitignore | 1 +
Makefile| 8 +++
scripts/modules/module_block.py | 134
3 files changed, 143 insertions(+)
create mode 1006
On 06/21/2016 05:32 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 20, 2016 at 11:32:38AM -0400, Colin Lord wrote:
>> On 06/17/2016 05:54 AM, Stefan Hajnoczi wrote:
>>> On Wed, Jun 15, 2016 at 02:40:53PM -0400, Colin Lord wrote:
>>>> 1) Denis Lunev suggested havin
On 06/17/2016 05:54 AM, Stefan Hajnoczi wrote:
> On Wed, Jun 15, 2016 at 02:40:53PM -0400, Colin Lord wrote:
>> 1) Denis Lunev suggested having block_module_load_one return the
>> loaded driver to reduce duplicated for loops in many of the functions
>> in block.
On 06/16/2016 10:05 AM, Paolo Bonzini wrote:
>
>
> On 16/06/2016 16:00, Colin Lord wrote:
>>>>> The only block drivers that can be converted into modules are the drivers
>>>>> that don't perform any init operation except for registering themselves.
&g
On 06/15/2016 06:50 PM, Paolo Bonzini wrote:
>
>
> On 15/06/2016 20:40, Colin Lord wrote:
>>
>> The only block drivers that can be converted into modules are the drivers
>> that don't perform any init operation except for registering themselves. This
>>
1 - 100 of 108 matches
Mail list logo
