On 02/08/2018 06:55 PM, Eric Blake wrote:
On 02/08/2018 09:28 AM, Edgar Kaziakhmedov wrote:
We've got a potential problem. Unless you have out-of-band
communication of the maximum NBD_CMD_WRITE_ZEROES sizing (or if the
NBD protocol is enhanced to advertise that as an additional piece
On 02/08/2018 05:54 PM, Eric Blake wrote:
On 02/08/2018 07:23 AM, Edgar Kaziakhmedov wrote:
Upstream NBD protocol implementation supports an efficient zero out
mechanism over the wire, along with the ability to check whether a
client allows using a hole.
Accordingly, since PWRITE_ZERO
(aligned).
Moreover, such change will decrease the number of PWRITE_ZERO NBD commands
in comparison with the current 32M limit. The benefits of
the larger constraint can be examined in a block mirroring over NBD.
Signed-off-by: Edgar Kaziakhmedov <edgar.kaziakhme...@virtuozzo.com>
---
block
On 02/02/2018 05:15 PM, Eric Blake wrote:
On 02/02/2018 08:06 AM, Edgar Kaziakhmedov wrote:
However, it would be nice to remove can_write_zeroes_with_unmap from
BlockDriverInfo, and make bdrv_can_write_zeroes_with_unmap just return
!!(bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP).
On 01/26/2018 05:28 PM, Eric Blake wrote:
On 01/26/2018 06:39 AM, Edgar Kaziakhmedov wrote:
PIng
So, let me know if I need to make any changes in patch
On 1/18/18 1:09 PM, Paolo Bonzini wrote:
On 18/01/2018 12:51, Edgar Kaziakhmedov wrote:
+static int nbd_get_info(BlockDriverState *bs
PIng
So, let me know if I need to make any changes in patch
On 1/18/18 1:09 PM, Paolo Bonzini wrote:
On 18/01/2018 12:51, Edgar Kaziakhmedov wrote:
+static int nbd_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
+{
+if (bs->supported_zero_flags & BDRV_REQ_MAY_UNMAP) {
+
-by: Edgar Kaziakhmedov <edgar.kaziakhme...@virtuozzo.com>
---
block/nbd.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/block/nbd.c b/block/nbd.c
index 8b8ba56cdd..94220f6d14 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -566,6 +566,14 @@ static void nbd_refresh_filename(BlockDrive
Since bdrv_co_preadv does all neccessary checks including
reading after the end of the backing file, avoid duplication
of verification before bdrv_co_preadv call.
Signed-off-by: Edgar Kaziakhmedov <edgar.kaziakhme...@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy &l
